Re: RFR: 8273929: Remove GzipRandomAccess in heap dump test

2021-10-04 Thread Chris Plummer
On Sun, 26 Sep 2021 08:07:46 GMT, Lin Zang wrote: >> test/lib/jdk/test/lib/hprof/parser/Reader.java line 99: >> >>> 97: // Possible gziped file, try decompress it and get the >>> stack trace. >>> 98: in.close(); >>> 99: String deCompressedFile = "

Re: RFR: 8273929: Remove GzipRandomAccess in heap dump test

2021-10-04 Thread Chris Plummer
On Fri, 17 Sep 2021 08:24:54 GMT, Lin Zang wrote: > The class `GzipRandomAccess` is used to parse heap dump file generated from > `jcmd`/`jmap` tools when testing. > It has the limitation that only gzip file which has "blocksize" header field > could be sucessfully parsed. > We think this class

Re: RFR: 8274687: JDWP can deadlock VM if Java thread waits in blockOnDebuggerSuspend

2021-10-04 Thread Chris Plummer
On Mon, 4 Oct 2021 14:07:18 GMT, Richard Reingruber wrote: > This change fixes the deadlock described in the JBS-bug by: > > * Releasing `handlerLock` before waiting on `threadLock` in > `blockOnDebuggerSuspend()` > > * Notifying on `threadLock` after resuming all threads in > `threadControl_

Re: RFR: 8273152: Refactor CDS FileMapHeader loading code [v4]

2021-10-04 Thread Ioi Lam
On Mon, 4 Oct 2021 17:50:27 GMT, Yumin Qi wrote: >> Please review, >> Refactor fundamental CDS FileMapHeader code for reliable reading of basic >> info from shared archive. >> With the change, it makes it possible to read an archive generated by >> different version of hotspot. Also it is p

Re: RFR: 8274670: Improve version string handling in SA [v2]

2021-10-04 Thread Chris Plummer
On Mon, 4 Oct 2021 13:02:37 GMT, Yasumasa Suenaga wrote: >> Use >> [java.lang.Runtime.Version](https://docs.oracle.com/en/java/javase/17/docs/api/java.base/java/lang/Runtime.Version.html) >> to check the version of debugee. >> >> Currently `checkVMVersion()` in `sun.jvm.hotspot.runtime.VM` has

Re: RFR: 8274716: JDWP Spec: the description for the Dispose command confuses suspend with resume.

2021-10-04 Thread Chris Plummer
On Mon, 4 Oct 2021 13:44:44 GMT, Richard Reingruber wrote: > The following sentence in the JDWP Specification describing the Dispose > command confuses resume with suspend [1]: > > All threads suspended by the thread-level **resume** command or the VM-level > **resume** command are resumed

Re: RFR: 8273152: Refactor CDS FileMapHeader loading code [v4]

2021-10-04 Thread Yumin Qi
> Please review, > Refactor fundamental CDS FileMapHeader code for reliable reading of basic > info from shared archive. > With the change, it makes it possible to read an archive generated by > different version of hotspot. Also it is possible to automatically generate a > CDS archive If th

Re: RFR: 8273152: Refactor CDS FileMapHeader loading code [v3]

2021-10-04 Thread Yumin Qi
> Please review, > Refactor fundamental CDS FileMapHeader code for reliable reading of basic > info from shared archive. > With the change, it makes it possible to read an archive generated by > different version of hotspot. Also it is possible to automatically generate a > CDS archive If th

Re: RFR: 8274716: JDWP Spec: the description for the Dispose command confuses suspend with resume.

2021-10-04 Thread Richard Reingruber
On Mon, 4 Oct 2021 14:22:50 GMT, Alan Bateman wrote: > > > It looks like this typo goes all the way back to JDK 1.2 but was not noticed. Thanks for reviewing. JDK 1.2 is surely long ago. Nevertheless not too many will have read that sentence since then I reckon ;) - PR: https://

RFR: 8274687: JDWP can deadlock VM if Java thread waits in blockOnDebuggerSuspend

2021-10-04 Thread Richard Reingruber
This change fixes the deadlock described in the JBS-bug by: * Releasing `handlerLock` before waiting on `threadLock` in `blockOnDebuggerSuspend()` * Notifying on `threadLock` after resuming all threads in `threadControl_reset()` The PR has 3 commits: The first commit delays the cleanup action

Re: RFR: 8274716: JDWP Spec: the description for the Dispose command confuses suspend with resume.

2021-10-04 Thread Alan Bateman
On Mon, 4 Oct 2021 13:44:44 GMT, Richard Reingruber wrote: > The following sentence in the JDWP Specification describing the Dispose > command confuses resume with suspend [1]: > > All threads suspended by the thread-level **resume** command or the VM-level > **resume** command are resumed

RFR: 8274716: JDWP Spec: the description for the Dispose command confuses suspend with resume.

2021-10-04 Thread Richard Reingruber
The following sentence in the JDWP Specification describing the Dispose command confuses resume with suspend [1]: All threads suspended by the thread-level **resume** command or the VM-level **resume** command are resumed as many times as necessary for them to run. It should be changed to

Re: RFR: 8274670: Improve version string handling in SA [v2]

2021-10-04 Thread Yasumasa Suenaga
> Use > [java.lang.Runtime.Version](https://docs.oracle.com/en/java/javase/17/docs/api/java.base/java/lang/Runtime.Version.html) > to check the version of debugee. > > Currently `checkVMVersion()` in `sun.jvm.hotspot.runtime.VM` has following > code to check the version of debugee. > > >

Re: RFR: 8274670: Improve version string handling in SA [v2]

2021-10-04 Thread Yasumasa Suenaga
On Mon, 4 Oct 2021 12:07:02 GMT, Andrey Turbanov wrote: >> Yasumasa Suenaga has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Remove toString() calls > > src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/runtime/VMVersionMismatchExcepti

Re: RFR: 8274670: Improve version string handling in SA

2021-10-04 Thread Andrey Turbanov
On Sun, 3 Oct 2021 13:08:58 GMT, Yasumasa Suenaga wrote: > Use > [java.lang.Runtime.Version](https://docs.oracle.com/en/java/javase/17/docs/api/java.base/java/lang/Runtime.Version.html) > to check the version of debugee. > > Currently `checkVMVersion()` in `sun.jvm.hotspot.runtime.VM` has foll