Re: RFR: 8274687: JDWP deadlocks if some Java thread reaches wait in blockOnDebuggerSuspend [v4]

2021-10-12 Thread Chris Plummer
On Tue, 12 Oct 2021 08:03:22 GMT, Richard Reingruber wrote: >> This change fixes deadlocks described in the JBS-bug by: >> >> * Releasing `handlerLock` before waiting on `threadLock` in >> `blockOnDebuggerSuspend()` >> >> * Notifying on `threadLock` in `threadControl_reset()` >> >> Also the a

RFR: 8275185: Remove dead code and clean up jvmstat LocalVmManager

2021-10-12 Thread Ioi Lam
LocalVmManager and PerfDataFile have APIs that are supposed to look for VMs owned by a specific user. No one uses these APIs, and they don't work anyway. The current code is very confusing to look at. Since we're likely to change code in this area for further container support, it's better to cl

Re: RFR: 8275075: Remove unnecessary conversion to String in jdk.hotspot.agent

2021-10-12 Thread Andrey Turbanov
On Tue, 12 Oct 2021 05:37:53 GMT, Chris Plummer wrote: >> Cleanup unnecessary toString() calls when conversion will happen implicitly >> anyway > > src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/ui/classbrowser/HTMLGenerator.java > line 1012: > >> 1010: tmpBuf.append(Long.toHexSt

Integrated: 8268764: Use Long.hashCode() instead of int-cast where applicable

2021-10-12 Thread Сергей Цыпанов
On Tue, 15 Jun 2021 12:15:11 GMT, Сергей Цыпанов wrote: > In some JDK classes there's still the following hashCode() implementation: > > long objNum; > > public int hashCode() { > return (int) objNum; > } > > This outdated expression should be replaced with Long.hashCode(long) as it > > -

Integrated: 8271514: support JFR use of new ThreadsList::Iterator

2021-10-12 Thread Daniel D . Daugherty
On Fri, 30 Jul 2021 20:20:48 GMT, Daniel D. Daugherty wrote: > A trivial fix to support JFR use of new ThreadsList::Iterator. > > This fix was tested with Mach5 Tier[1-3]. This pull request has now been integrated. Changeset: 8657f776 Author:Daniel D. Daugherty URL: https://git.op

Re: RFR: 8271514: support JFR use of new ThreadsList::Iterator [v2]

2021-10-12 Thread Daniel D . Daugherty
On Wed, 4 Aug 2021 22:57:40 GMT, Serguei Spitsyn wrote: >> Daniel D. Daugherty has updated the pull request with a new target base due >> to a merge or a rebase. The incremental webrev excludes the unrelated >> changes brought in by the merge/rebase. The pull request contains three >> addition

Re: RFR: 8272992: Replace usages of Collections.sort with List.sort call in jdk.* modules [v4]

2021-10-12 Thread Pavel Rappo
On Sat, 25 Sep 2021 11:23:18 GMT, Andrey Turbanov wrote: >> Collections.sort is just a wrapper, so it is better to use an instance >> method directly. >> Affected modules: jdk.javadoc, jdk.jcmd, jdk.jconsole > > Andrey Turbanov has updated the pull request incrementally with one > additional co

Re: RFR: 8272992: Replace usages of Collections.sort with List.sort call in jdk.* modules [v4]

2021-10-12 Thread Pavel Rappo
On Sat, 25 Sep 2021 11:23:18 GMT, Andrey Turbanov wrote: >> Collections.sort is just a wrapper, so it is better to use an instance >> method directly. >> Affected modules: jdk.javadoc, jdk.jcmd, jdk.jconsole > > Andrey Turbanov has updated the pull request incrementally with one > additional co

Re: RFR: 8271514: support JFR use of new ThreadsList::Iterator [v5]

2021-10-12 Thread Markus Grönlund
On Mon, 11 Oct 2021 22:19:59 GMT, Daniel D. Daugherty wrote: >> A trivial fix to support JFR use of new ThreadsList::Iterator. >> >> This fix was tested with Mach5 Tier[1-3]. > > Daniel D. Daugherty has updated the pull request with a new target base due > to a merge or a rebase. The pull requ

Re: RFR: 8274687: JDWP deadlocks if some Java thread reaches wait in blockOnDebuggerSuspend [v4]

2021-10-12 Thread Richard Reingruber
On Tue, 12 Oct 2021 05:59:28 GMT, Chris Plummer wrote: >> Richard Reingruber has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Improve @summary section of test. > > test/jdk/com/sun/jdi/ResumeAfterThreadResumeCallTest.java line 31: > >> 2

Re: RFR: 8274687: JDWP deadlocks if some Java thread reaches wait in blockOnDebuggerSuspend [v4]

2021-10-12 Thread Richard Reingruber
> This change fixes deadlocks described in the JBS-bug by: > > * Releasing `handlerLock` before waiting on `threadLock` in > `blockOnDebuggerSuspend()` > > * Notifying on `threadLock` in `threadControl_reset()` > > Also the actions in handleAppResumeBreakpoint() are moved/deferred until > doPen

Re: RFR: 8274687: JDWP deadlocks if some Java thread reaches wait in blockOnDebuggerSuspend [v3]

2021-10-12 Thread Richard Reingruber
> This change fixes deadlocks described in the JBS-bug by: > > * Releasing `handlerLock` before waiting on `threadLock` in > `blockOnDebuggerSuspend()` > > * Notifying on `threadLock` in `threadControl_reset()` > > Also the actions in handleAppResumeBreakpoint() are moved/deferred until > doPen

Re: RFR: 8268764: Use Long.hashCode() instead of int-cast where applicable [v4]

2021-10-12 Thread Sergey Bylokhov
On Thu, 1 Jul 2021 12:19:53 GMT, Сергей Цыпанов wrote: >> In some JDK classes there's still the following hashCode() implementation: >> >> long objNum; >> >> public int hashCode() { >> return (int) objNum; >> } >> >> This outdated expression should be replaced with Long.hashCode(long) as i

Re: RFR: 8274687: JDWP deadlocks if some Java thread reaches wait in blockOnDebuggerSuspend [v2]

2021-10-12 Thread Richard Reingruber
> This change fixes deadlocks described in the JBS-bug by: > > * Releasing `handlerLock` before waiting on `threadLock` in > `blockOnDebuggerSuspend()` > > * Notifying on `threadLock` in `threadControl_reset()` > > Also the actions in handleAppResumeBreakpoint() are moved/deferred until > doPen