Re: RFR: 8249004: Reduce ThreadsListHandle overhead in relation to direct handshakes [v6]

2021-10-29 Thread Daniel D . Daugherty
On Sun, 17 Oct 2021 12:52:15 GMT, David Holmes wrote: >> On rereading all of these comments and the current baseline code, I have >> to clarify one thing: >> >> There is a minor change in behavior caused by switching from a >> `ThreadsListHandle::includes()` check to a `JavaThread::is_exiting()`

Re: RFR: 8249004: Reduce ThreadsListHandle overhead in relation to direct handshakes [v6]

2021-10-29 Thread Daniel D . Daugherty
On Sun, 17 Oct 2021 12:45:59 GMT, David Holmes wrote: >> I modeled the new check after the existing: >> >> >> bool Thread::is_JavaThread_protected(const JavaThread* p) { >> >> >> which is also a static function. > > While the name is somewhat ungainly - and unnecessarily detailed given > `is

Integrated: 8274621: NullPointerException because listenAddress[0] is null

2021-10-29 Thread Alex Menkov
On Tue, 5 Oct 2021 22:34:38 GMT, Alex Menkov wrote: > The change fixes ProcessTools.startProcess "warmup predicate" synchronization > issue. > Initially the predicate was called only for STDOUT; > From jdk8 it's called for STDERR too (but ProcessTools javadoc was not > updated). > The fix keeps

Integrated: 8271356: Modify jdb to treat an empty command as a repeat of the previous command

2021-10-29 Thread Jakob Cornell
On Sat, 28 Aug 2021 05:48:47 GMT, Jakob Cornell wrote: > This has been under discussion on and off for the past month or so on > serviceability-dev, and I think a CSR request is required, so this may be a > work in progress. > > Notes on the patch: > > - The `list` command previously marked a

Re: RFR: 8276139: TestJpsHostName.java not reliable, better to expand HostIdentifierCreate.java test

2021-10-29 Thread Jie Fu
On Fri, 29 Oct 2021 11:29:32 GMT, Kevin Walls wrote: > Remove a specific test which invokes jps on a fictional process, and can > timeout and fail. > Instead, add to the patterns used in > open/test/jdk/sun/jvmstat/monitor/HostIdentifier/HostIdentifierCreate.java > which will perform the same

Re: RFR: 8276139: TestJpsHostName.java not reliable, better to expand HostIdentifierCreate.java test

2021-10-29 Thread Jie Fu
On Fri, 29 Oct 2021 11:29:32 GMT, Kevin Walls wrote: > Remove a specific test which invokes jps on a fictional process, and can > timeout and fail. > Instead, add to the patterns used in > open/test/jdk/sun/jvmstat/monitor/HostIdentifier/HostIdentifierCreate.java > which will perform the same

Re: RFR: 8276139: TestJpsHostName.java not reliable, better to expand HostIdentifierCreate.java test

2021-10-29 Thread Kevin Walls
On Fri, 29 Oct 2021 11:29:32 GMT, Kevin Walls wrote: > Remove a specific test which invokes jps on a fictional process, and can > timeout and fail. > Instead, add to the patterns used in > open/test/jdk/sun/jvmstat/monitor/HostIdentifier/HostIdentifierCreate.java > which will perform the same

Re: RFR: 8276139: TestJpsHostName.java not reliable, better to expand HostIdentifierCreate.java test

2021-10-29 Thread Jie Fu
On Fri, 29 Oct 2021 11:29:32 GMT, Kevin Walls wrote: > Remove a specific test which invokes jps on a fictional process, and can > timeout and fail. > Instead, add to the patterns used in > open/test/jdk/sun/jvmstat/monitor/HostIdentifier/HostIdentifierCreate.java > which will perform the same

RFR: 8276139: TestJpsHostName.java not reliable, better to expand HostIdentifierCreate.java test

2021-10-29 Thread Kevin Walls
Remove a specific test which invokes jps on a fictional process, and can timeout and fail. Instead, add to the patterns used in open/test/jdk/sun/jvmstat/monitor/HostIdentifier/HostIdentifierCreate.java which will perform the same test, that we can create a HostIdentifier using numeric values.