Re: RFR: 8269556: sun/tools/jhsdb/JShellHeapDumpTest.java fails with RuntimeException 'JShellToolProvider' missing from stdout/stderr [v3]

2021-12-10 Thread Serguei Spitsyn
On Fri, 10 Dec 2021 21:12:45 GMT, Chris Plummer wrote: >> The test searches for "JShellToolProvider" in the main thread's stack trace, >> which is pulled from an SA heap dump. Typically the main thread is blocked >> in Object.wait(), so SA can determine its stack trace. However, the wait has

Re: RFR: 8269556: sun/tools/jhsdb/JShellHeapDumpTest.java fails with RuntimeException 'JShellToolProvider' missing from stdout/stderr [v3]

2021-12-10 Thread Alex Menkov
On Fri, 10 Dec 2021 21:12:45 GMT, Chris Plummer wrote: >> The test searches for "JShellToolProvider" in the main thread's stack trace, >> which is pulled from an SA heap dump. Typically the main thread is blocked >> in Object.wait(), so SA can determine its stack trace. However, the wait has

Re: RFR: 8269556: sun/tools/jhsdb/JShellHeapDumpTest.java fails with RuntimeException 'JShellToolProvider' missing from stdout/stderr [v2]

2021-12-10 Thread Chris Plummer
On Fri, 10 Dec 2021 21:05:38 GMT, Alex Menkov wrote: >> Chris Plummer has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Renamed isRetry to allowRetry. > > test/jdk/sun/tools/jhsdb/JShellHeapDumpTest.java line 112: > >> 110:

Re: RFR: 8269556: sun/tools/jhsdb/JShellHeapDumpTest.java fails with RuntimeException 'JShellToolProvider' missing from stdout/stderr [v2]

2021-12-10 Thread Alex Menkov
On Fri, 10 Dec 2021 20:30:41 GMT, Chris Plummer wrote: >> The test searches for "JShellToolProvider" in the main thread's stack trace, >> which is pulled from an SA heap dump. Typically the main thread is blocked >> in Object.wait(), so SA can determine its stack trace. However, the wait has

Re: RFR: 8269556: sun/tools/jhsdb/JShellHeapDumpTest.java fails with RuntimeException 'JShellToolProvider' missing from stdout/stderr [v3]

2021-12-10 Thread Chris Plummer
> The test searches for "JShellToolProvider" in the main thread's stack trace, > which is pulled from an SA heap dump. Typically the main thread is blocked in > Object.wait(), so SA can determine its stack trace. However, the wait has a > 100ms timeout, so the thread does periodically wake up

Re: RFR: 8269556: sun/tools/jhsdb/JShellHeapDumpTest.java fails with RuntimeException 'JShellToolProvider' missing from stdout/stderr [v2]

2021-12-10 Thread Chris Plummer
On Fri, 10 Dec 2021 12:22:22 GMT, Serguei Spitsyn wrote: > Hi Chris, > It looks good in general. I feel the parameter 'retry' is a little bit > confusing. It is possible to rename it to some to 'retriedOnce'. Another > approach would be to name it 'allowRetry' and revert the meaning of boolean

Re: RFR: 8269556: sun/tools/jhsdb/JShellHeapDumpTest.java fails with RuntimeException 'JShellToolProvider' missing from stdout/stderr [v2]

2021-12-10 Thread Chris Plummer
> The test searches for "JShellToolProvider" in the main thread's stack trace, > which is pulled from an SA heap dump. Typically the main thread is blocked in > Object.wait(), so SA can determine its stack trace. However, the wait has a > 100ms timeout, so the thread does periodically wake up

Re: RFR: 8277481: Obsolete seldom used CDS flags [v2]

2021-12-10 Thread Harold Seigel
On Fri, 10 Dec 2021 19:37:31 GMT, Calvin Cheung wrote: >> Harold Seigel has updated the pull request incrementally with one additional >> commit since the last revision: >> >> fix print_debug() message > > src/jdk.hotspot.agent/share/native/libsaproc/ps_core_common.c line 303: > >> 301:

Re: RFR: 8277481: Obsolete seldom used CDS flags [v2]

2021-12-10 Thread Harold Seigel
> Please review this change to obsolete deprecated CDS options UseSharedSpaces, > RequireSharedSpaces, DynamicDumpSharedSpaces, and DumpSharedSpaces. The > change was tested by running Mach5 tiers 1-2 on Linux, Mac OS, and Windows > and Mach5 tiers 3-5 on Linux x64 and Windows x64. > > The

Re: RFR: 8277481: Obsolete seldom used CDS flags

2021-12-10 Thread Calvin Cheung
On Fri, 10 Dec 2021 15:01:29 GMT, Harold Seigel wrote: > Please review this change to obsolete deprecated CDS options UseSharedSpaces, > RequireSharedSpaces, DynamicDumpSharedSpaces, and DumpSharedSpaces. The > change was tested by running Mach5 tiers 1-2 on Linux, Mac OS, and Windows > and

Re: RFR: 8277481: Obsolete seldom used CDS flags

2021-12-10 Thread Ioi Lam
On Fri, 10 Dec 2021 15:01:29 GMT, Harold Seigel wrote: > Please review this change to obsolete deprecated CDS options UseSharedSpaces, > RequireSharedSpaces, DynamicDumpSharedSpaces, and DumpSharedSpaces. The > change was tested by running Mach5 tiers 1-2 on Linux, Mac OS, and Windows > and

Integrated: Merge jdk18

2021-12-10 Thread Jesper Wilhelmsson
On Fri, 10 Dec 2021 17:51:31 GMT, Jesper Wilhelmsson wrote: > Forwardport JDK 18 -> JDK 19 This pull request has now been integrated. Changeset: 61736f81 Author:Jesper Wilhelmsson URL: https://git.openjdk.java.net/jdk/commit/61736f81fb4a20375c83d59e2b37a00aafb11107 Stats: 1142

RFR: Merge jdk18

2021-12-10 Thread Jesper Wilhelmsson
Forwardport JDK 18 -> JDK 19 - Commit messages: - Merge - 8277621: ARM32: multiple fastdebug failures with "bad AD file" after JDK-8276162 - 8278538: Test langtools/jdk/javadoc/tool/CheckManPageOptions.java fails after the manpage was updated - 8273179: Update nroff pages in

RFR: 8277481: Obsolete seldom used CDS flags

2021-12-10 Thread Harold Seigel
Please review this change to obsolete deprecated CDS options UseSharedSpaces, RequireSharedSpaces, DynamicDumpSharedSpaces, and DumpSharedSpaces. The change was tested by running Mach5 tiers 1-2 on Linux, Mac OS, and Windows and Mach5 tiers 3-5 on Linux x64 and Windows x64. The use of

Re: RFR: 8269556: sun/tools/jhsdb/JShellHeapDumpTest.java fails with RuntimeException 'JShellToolProvider' missing from stdout/stderr

2021-12-10 Thread Serguei Spitsyn
On Fri, 10 Dec 2021 07:00:10 GMT, Chris Plummer wrote: > The test searches for "JShellToolProvider" in the main thread's stack trace, > which is pulled from an SA heap dump. Typically the main thread is blocked in > Object.wait(), so SA can determine its stack trace. However, the wait has a >

Re: RFR: 8269556: sun/tools/jhsdb/JShellHeapDumpTest.java fails with RuntimeException 'JShellToolProvider' missing from stdout/stderr

2021-12-10 Thread Kevin Walls
On Fri, 10 Dec 2021 07:00:10 GMT, Chris Plummer wrote: > The test searches for "JShellToolProvider" in the main thread's stack trace, > which is pulled from an SA heap dump. Typically the main thread is blocked in > Object.wait(), so SA can determine its stack trace. However, the wait has a >