Re: RFR: 8275775: Add jcmd VM.classes to print details of all classes [v2]

2022-01-17 Thread David Holmes
On Tue, 18 Jan 2022 02:50:06 GMT, Yi Yang wrote: >> Add VM.classes to print details of all classes, output looks like: >> >> 1. jcmd VM.classes >> >> KlassAddr Size State Flags LoaderName ClassName >> 0x000800c0b400 62 inited W bootstrap >> java.lang.invoke.LambdaForm$MH/0x000800c0b400

Re: RFR: 8279124: VirtualMachineImpl should check signal handler has installed before sending SIGQUIT

2022-01-17 Thread Thomas Stuefe
On Mon, 17 Jan 2022 09:00:25 GMT, Kevin Walls wrote: > > I propose a simpler and more robust way to fix it though > > Great, this is the kind of thing I was heading towards with the conversation > in the bug text. Although not sure why I could not reproduce the problem, > with various differen

Re: RFR: 8279124: VirtualMachineImpl should check signal handler has installed before sending SIGQUIT

2022-01-17 Thread Kevin Walls
On Mon, 17 Jan 2022 08:10:57 GMT, Thomas Stuefe wrote: > I propose a simpler and more robust way to fix it though Great, this is the kind of thing I was heading towards with the conversation in the bug text. Although not sure why I could not reproduce the problem, with various different JDK v

Re: RFR: 8280035: Use Class.isInstance instead of Class.isAssignableFrom where applicable

2022-01-17 Thread Erik Gahlin
On Thu, 13 Jan 2022 08:39:04 GMT, Andrey Turbanov wrote: >> Method `Class.isAssignableFrom` is often used in form of: >> >> if (clazz.isAssignableFrom(obj.getClass())) { >> Such condition could be simplified to more shorter and performarnt code >> >> if (clazz.isInstance(obj)) { >>

Re: RFR: 8279124: VirtualMachineImpl should check signal handler has installed before sending SIGQUIT

2022-01-17 Thread Thomas Stuefe
On Mon, 10 Jan 2022 05:19:26 GMT, Xin Liu wrote: > There is a handshake protocol between attach and HotSpot. Linux > VirtualMachineImpl sends SIGQUIT(3) if the AttachListener has not been > initialized. It expects "Signal Dispatcher" to handle SIGBREAK(same as > SIGQUIT) and create AttachListe