On Fri, 6 May 2022 09:40:37 GMT, Jaroslav Bachorik
wrote:
>> A gist of the fix is to allow relaxed special handling of code blob lookup
>> when done for ASGCT.
>>
>> Currently, a guarantee will fail when we happen to hit a zombie method which
>> is still on stack. While this would indicate
On Fri, 6 May 2022 14:20:30 GMT, Jaroslav Bachorik
wrote:
>> Functionally this looks good now - thanks.
>>
>> The only concern is the overhead added to `find_blob` to account for this
>> very special case. Can you do some benchmarking of this?
>>
>> Thanks.
>
> Hi @dholmes-ora , thanks for
On Fri, 6 May 2022 09:40:37 GMT, Jaroslav Bachorik
wrote:
>> A gist of the fix is to allow relaxed special handling of code blob lookup
>> when done for ASGCT.
>>
>> Currently, a guarantee will fail when we happen to hit a zombie method which
>> is still on stack. While this would indicate
On Fri, 29 Apr 2022 21:39:20 GMT, Alex Menkov wrote:
> The test counts calls of intercepted JNI functions, but doesn't completely
> filter out calls from other threads.
> Function isThreadExpected is used only for ExceptionOccurred function and the
> function checks only some known JFR/Graal
On Fri, 6 May 2022 20:48:29 GMT, Alex Menkov wrote:
>> The test counts calls of intercepted JNI functions, but doesn't completely
>> filter out calls from other threads.
>> Function isThreadExpected is used only for ExceptionOccurred function and
>> the function checks only some known
On Fri, 6 May 2022 09:40:37 GMT, Jaroslav Bachorik
wrote:
>> A gist of the fix is to allow relaxed special handling of code blob lookup
>> when done for ASGCT.
>>
>> Currently, a guarantee will fail when we happen to hit a zombie method which
>> is still on stack. While this would indicate
On Fri, 6 May 2022 09:40:37 GMT, Jaroslav Bachorik
wrote:
>> A gist of the fix is to allow relaxed special handling of code blob lookup
>> when done for ASGCT.
>>
>> Currently, a guarantee will fail when we happen to hit a zombie method which
>> is still on stack. While this would indicate
On Fri, 6 May 2022 20:17:53 GMT, Dean Long wrote:
>> Jaroslav Bachorik has refreshed the contents of this pull request, and
>> previous commits have been removed. The incremental views will show
>> differences compared to the previous content of the PR. The pull request
>> contains one new
> The test counts calls of intercepted JNI functions, but doesn't completely
> filter out calls from other threads.
> Function isThreadExpected is used only for ExceptionOccurred function and the
> function checks only some known JFR/Graal threads.
>
> The change:
> - updates the test to count
On Fri, 6 May 2022 09:40:37 GMT, Jaroslav Bachorik
wrote:
>> A gist of the fix is to allow relaxed special handling of code blob lookup
>> when done for ASGCT.
>>
>> Currently, a guarantee will fail when we happen to hit a zombie method which
>> is still on stack. While this would indicate
On Fri, 6 May 2022 10:08:09 GMT, David Holmes wrote:
>> Jaroslav Bachorik has refreshed the contents of this pull request, and
>> previous commits have been removed. The incremental views will show
>> differences compared to the previous content of the PR. The pull request
>> contains one new
On Fri, 6 May 2022 09:40:37 GMT, Jaroslav Bachorik
wrote:
>> A gist of the fix is to allow relaxed special handling of code blob lookup
>> when done for ASGCT.
>>
>> Currently, a guarantee will fail when we happen to hit a zombie method which
>> is still on stack. While this would indicate
On Fri, 6 May 2022 06:48:46 GMT, Alan Bateman wrote:
>> This is the implementation of JEP 425: Virtual Threads (Preview).
>>
>> We will refresh this PR periodically to pick up changes and fixes from the
>> loom repo.
>>
>> Most of the new mechanisms in the HotSpot VM are disabled by default
> A gist of the fix is to allow relaxed special handling of code blob lookup
> when done for ASGCT.
>
> Currently, a guarantee will fail when we happen to hit a zombie method which
> is still on stack. While this would indicate a serious error for the normal
> execution flow, in case of ASGCT
On Fri, 6 May 2022 01:18:21 GMT, David Holmes wrote:
>> I will have to do check/cast in `CodeCache::find_blob()` as that may get
>> called from any thread, not just Java threads.
>> I would assume that having this flag defined at Thread level is a lesser of
>> the evils - or am I wrong here?
>
> A gist of the fix is to allow relaxed special handling of code blob lookup
> when done for ASGCT.
>
> Currently, a guarantee will fail when we happen to hit a zombie method which
> is still on stack. While this would indicate a serious error for the normal
> execution flow, in case of ASGCT
On Fri, 6 May 2022 01:30:35 GMT, David Holmes wrote:
>> Ok, moved it a bit around - now the bool field is after an int field which
>> should make things slightly better, I guess.
>
> At the start of JavaThread we have:
>
> private:
> bool _on_thread_list;// Is set
On Thu, 5 May 2022 18:54:49 GMT, Alan Bateman wrote:
> We mailed porters-dev in Sep 2021 to give a heads up that this feature would
> require porting work so it shouldn't be a surprise. We have been open to
> including other ports with the initial integration but it was never a goal to
> have
> This is the implementation of JEP 425: Virtual Threads (Preview).
>
> We will refresh this PR periodically to pick up changes and fixes from the
> loom repo.
>
> Most of the new mechanisms in the HotSpot VM are disabled by default and
> require running with `--enable-preview` to enable.
>
>
19 matches
Mail list logo
