Re: RFR: 8286212: Cgroup v1 initialization causes NPE on some systems [v3]

2022-05-18 Thread Ioi Lam
On Wed, 18 May 2022 18:14:52 GMT, Severin Gehwolf wrote: >> Please review this change to the cgroup v1 subsystem which makes it more >> resilient on some of the stranger systems. Unfortunately, I wasn't able to >> re-create a similar system as the reporter. The idea of using the longest >> sub

Re: RFR: 8286983: Add mention of "Preview Feature" for new loom related jdb and debug agent options

2022-05-18 Thread Leonid Mesnik
On Thu, 19 May 2022 00:10:15 GMT, Chris Plummer wrote: > As part of the loom integration, jdb added -trackvthreads and the debug agent > added "enumeratevthreads". The help text for these options should call out > that they are Preview Features. Marked as reviewed by lmesnik (Reviewer). -

Re: RFR: 8286983: Add mention of "Preview Feature" for new loom related jdb and debug agent options

2022-05-18 Thread Alex Menkov
On Thu, 19 May 2022 00:10:15 GMT, Chris Plummer wrote: > As part of the loom integration, jdb added -trackvthreads and the debug agent > added "enumeratevthreads". The help text for these options should call out > that they are Preview Features. Marked as reviewed by amenkov (Reviewer). -

RFR: 8286983: Add mention of "Preview Feature" for new loom related jdb and debug agent options

2022-05-18 Thread Chris Plummer
As part of the loom integration, jdb added -trackvthreads and the debug agent added "enumeratevthreads". The help text for these options should call out that they are Preview Features. - Commit messages: - Add mention of "Preview Feature" for new vthread related debugging options.

Re: RFR: 8284209: Replace remaining usages of 'a the' in source code

2022-05-18 Thread Jonathan Gibbons
On Wed, 18 May 2022 14:46:42 GMT, Alexey Ivanov wrote: > Replaces usages of articles that follow each other in all combinations: > a/the, an?/an?, the/the… > > It's the last issue in the series, and it still touches different areas of > the code. javac and javadoc changes look OK test/langto

Integrated: 8281268: Resolve duplication of test ClassTransformer class

2022-05-18 Thread Alex Menkov
On Fri, 13 May 2022 22:50:11 GMT, Alex Menkov wrote: > The fix deletes ClassTransformer class from jdi, switches all the test to > jdk.test.lib copy. This pull request has now been integrated. Changeset: a6177092 Author:Alex Menkov URL: https://git.openjdk.java.net/jdk/commit/a6177

Re: RFR: 8286212: Cgroup v1 initialization causes NPE on some systems [v2]

2022-05-18 Thread Severin Gehwolf
On Wed, 18 May 2022 18:09:54 GMT, Severin Gehwolf wrote: >> src/hotspot/os/linux/cgroupV1Subsystem_linux.cpp line 92: >> >>> 90: } >>> 91: ss.print_raw(_root, last_matching_slash_pos); >>> 92: _path = os::strdup(ss.base()); >> >> Do you mean `Find the longest commo

Re: RFR: 8286212: Cgroup v1 initialization causes NPE on some systems [v2]

2022-05-18 Thread Severin Gehwolf
On Tue, 17 May 2022 06:18:25 GMT, Ioi Lam wrote: >> Severin Gehwolf has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Use stringStream to simplify controller path assembly > > src/hotspot/os/linux/cgroupV1Subsystem_linux.cpp line 92: > >>

Re: RFR: 8286212: Cgroup v1 initialization causes NPE on some systems [v3]

2022-05-18 Thread Severin Gehwolf
> Please review this change to the cgroup v1 subsystem which makes it more > resilient on some of the stranger systems. Unfortunately, I wasn't able to > re-create a similar system as the reporter. The idea of using the longest > substring match for the cgroupv1 file paths was based on the fact

Re: RFR: 8284209: Replace remaining usages of 'a the' in source code

2022-05-18 Thread Iris Clark
On Wed, 18 May 2022 14:46:42 GMT, Alexey Ivanov wrote: > Replaces usages of articles that follow each other in all combinations: > a/the, an?/an?, the/the… > > It's the last issue in the series, and it still touches different areas of > the code. Marked as reviewed by iris (Reviewer). --

Re: RFR: 8284191: Replace usages of 'a the' in hotspot and java.base

2022-05-18 Thread Iris Clark
On Wed, 18 May 2022 13:27:24 GMT, Alexey Ivanov wrote: > Replaces usages of articles that follow each other in all combinations: > a/the, an?/an?, the/the… > > Also, I fixed a couple of spelling mistakes. Marked as reviewed by iris (Reviewer). - PR: https://git.openjdk.java.net/j

Re: RFR: 8284191: Replace usages of 'a the' in hotspot and java.base

2022-05-18 Thread Naoto Sato
On Wed, 18 May 2022 13:27:24 GMT, Alexey Ivanov wrote: > Replaces usages of articles that follow each other in all combinations: > a/the, an?/an?, the/the… > > Also, I fixed a couple of spelling mistakes. LGTM for i18n changes. - Marked as reviewed by naoto (Reviewer). PR: https

Re: RFR: 8284209: Replace remaining usages of 'a the' in source code

2022-05-18 Thread Daniel Fuchs
On Wed, 18 May 2022 14:46:42 GMT, Alexey Ivanov wrote: > Replaces usages of articles that follow each other in all combinations: > a/the, an?/an?, the/the… > > It's the last issue in the series, and it still touches different areas of > the code. Logging/JNDI OK - Marked as revi

Re: RFR: 8284209: Replace remaining usages of 'a the' in source code

2022-05-18 Thread Bradford Wetmore
On Wed, 18 May 2022 14:46:42 GMT, Alexey Ivanov wrote: > Replaces usages of articles that follow each other in all combinations: > a/the, an?/an?, the/the… > > It's the last issue in the series, and it still touches different areas of > the code. Looked at -java.security.jgss. LGTM --

Re: RFR: 8284191: Replace usages of 'a the' in hotspot and java.base

2022-05-18 Thread Bradford Wetmore
On Wed, 18 May 2022 13:27:24 GMT, Alexey Ivanov wrote: > Replaces usages of articles that follow each other in all combinations: > a/the, an?/an?, the/the… > > Also, I fixed a couple of spelling mistakes. Looked at - java.base/.../sun/security - jdk.crypto.* - test/*/com/sun/crypto/provider

Re: RFR: 8284209: Replace remaining usages of 'a the' in source code

2022-05-18 Thread Lance Andersen
On Wed, 18 May 2022 14:46:42 GMT, Alexey Ivanov wrote: > Replaces usages of articles that follow each other in all combinations: > a/the, an?/an?, the/the… > > It's the last issue in the series, and it still touches different areas of > the code. Marked as reviewed by lancea (Reviewer).

RFR: 8284209: Replace remaining usages of 'a the' in source code

2022-05-18 Thread Alexey Ivanov
Replaces usages of articles that follow each other in all combinations: a/the, an?/an?, the/the… It's the last issue in the series, and it still touches different areas of the code. - Commit messages: - 8284209: Replace remaining usages of 'the a' in source code - 8284209: Replac

Re: RFR: 8284191: Replace usages of 'a the' in hotspot and java.base

2022-05-18 Thread Lance Andersen
On Wed, 18 May 2022 13:27:24 GMT, Alexey Ivanov wrote: > Replaces usages of articles that follow each other in all combinations: > a/the, an?/an?, the/the… > > Also, I fixed a couple of spelling mistakes. Marked as reviewed by lancea (Reviewer). - PR: https://git.openjdk.java.net

RFR: 8284191: Replace usages of 'a the' in hotspot and java.base

2022-05-18 Thread Alexey Ivanov
Replaces usages of articles that follow each other in all combinations: a/the, an?/an?, the/the… Also, I fixed a couple of spelling mistakes. - Commit messages: - 8284191: Replace usages of 'the an' in hotspot and java.base - 8284191: Replace usages of 'the an' in hotspot and java