Integrated: 8287008: Improve tests for thread dumps in JSON format

2022-05-23 Thread Alan Bateman
On Thu, 19 May 2022 09:38:06 GMT, Alan Bateman wrote: > This change is mostly test infrastructure and improvements to the testing of > thread dumps in JSON format. It also tweaks the thread dump format so that > the process identifier and thread identifiers are a type string rather than > numb

RFR: 8286490: JvmtiEventControllerPrivate::set_event_callbacks CLEARING_MASK computation is incorrect

2022-05-23 Thread Serguei Spitsyn
It was a typo when the original CLEARING_MASK was initially introduced: // Mask to clear normal event bits. const jlong CLEARING_MASK = (1L >> (TOTAL_MIN_EVENT_TYPE_VAL - TOTAL_MIN_EVENT_TYPE_VAL)) - 1L; // Avoid cleaning extension event bits. jlong enabled_bits = CLEARING_MASK & env->en

Re: RFR: 8287008: Improve tests for thread dumps in JSON format [v5]

2022-05-23 Thread Chris Plummer
On Mon, 23 May 2022 19:33:31 GMT, Alan Bateman wrote: >> This change is mostly test infrastructure and improvements to the testing of >> thread dumps in JSON format. It also tweaks the thread dump format so that >> the process identifier and thread identifiers are a type string rather than >>

Re: RFR: 8284209: Replace remaining usages of 'a the' in source code [v2]

2022-05-23 Thread Alexey Ivanov
> Replaces usages of articles that follow each other in all combinations: > a/the, an?/an?, the/the… > > It's the last issue in the series, and it still touches different areas of > the code. Alexey Ivanov has updated the pull request with a new target base due to a merge or a rebase. The pull

Re: RFR: 8284191: Replace usages of 'a the' in hotspot and java.base [v3]

2022-05-23 Thread Alexey Ivanov
> Replaces usages of articles that follow each other in all combinations: > a/the, an?/an?, the/the… > > Also, I fixed a couple of spelling mistakes. Alexey Ivanov has updated the pull request incrementally with one additional commit since the last revision: Update copyright to 2022 ---

Re: RFR: 8287008: Improve tests for thread dumps in JSON format [v5]

2022-05-23 Thread Alan Bateman
> This change is mostly test infrastructure and improvements to the testing of > thread dumps in JSON format. It also tweaks the thread dump format so that > the process identifier and thread identifiers are a type string rather than > number. > > The tests for thread dumps added by JEP 425 are

Re: RFR: 8286212: Cgroup v1 initialization causes NPE on some systems [v3]

2022-05-23 Thread Severin Gehwolf
On Mon, 23 May 2022 09:24:19 GMT, Severin Gehwolf wrote: >> Also, I think the current PR could produce the wrong answer, if systemd is >> indeed running inside the container, and we have: >> >> >> "/user.slice/user-1000.slice/session-50.scope",// root_path >> "/user.slice/user-1000.slice/s

Re: RFR: 8286983: Add mention of "Preview Feature" for new loom related jdb and debug agent options [v2]

2022-05-23 Thread Alan Bateman
On Mon, 23 May 2022 02:52:38 GMT, David Holmes wrote: >> I was really trying to emphasize that the flag is preview, and therefore may >> change or go away. If I change as you suggest, the reader could imply that >> as long as virtual threads support is in place, then the flag will be also >>

Re: Concurrent heap monitoring

2022-05-23 Thread Chris Plummer
Adding hotspot-gc-dev. On 5/21/22 12:49 AM, Volker Simonis wrote: This sounds very interesting. Does this feature work with every GC or  does the implementation depend on specific GCs (and if the latter, which GCs does your prototype currently support). Kemper, William schrieb am Fr., 20. Ma

Re: RFR: 8287008: Improve tests for thread dumps in JSON format [v3]

2022-05-23 Thread Chris Plummer
On Mon, 23 May 2022 07:52:58 GMT, Alan Bateman wrote: >> test/jdk/com/sun/management/HotSpotDiagnosticMXBean/DumpThreads.java line >> 115: >> >>> 113: >>> 114: // find the thread container that corresponds to the >>> executor >>> 115: String name = Objects.toId

Re: RFR: 8287008: Improve tests for thread dumps in JSON format [v4]

2022-05-23 Thread Alan Bateman
On Mon, 23 May 2022 16:44:12 GMT, Chris Plummer wrote: >> Alan Bateman has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Use string rater than number for process/thread identifiers > > test/lib/jdk/test/lib/threaddump/ThreadDump.java line

Re: RFR: 8287008: Improve tests for thread dumps in JSON format [v3]

2022-05-23 Thread Chris Plummer
On Mon, 23 May 2022 07:53:09 GMT, Alan Bateman wrote: >> test/lib/jdk/test/lib/threaddump/ThreadDump.java line 179: >> >>> 177: return this; >>> 178: if (name().startsWith(name + "/")) >>> 179: return this; >> >> It's not clear to me why this is here.

Re: RFR: 8287008: Improve tests for thread dumps in JSON format [v4]

2022-05-23 Thread Chris Plummer
On Mon, 23 May 2022 08:30:51 GMT, Alan Bateman wrote: >> This change is mostly test infrastructure and improvements to the testing of >> thread dumps in JSON format. It also tweaks the thread dump format so that >> the process identifier and thread identifiers are a type string rather than >>

Integrated: 8285739: disable EscapeBarrier deopt for virtual threads

2022-05-23 Thread Leonid Mesnik
On Mon, 9 May 2022 01:36:39 GMT, Leonid Mesnik wrote: > The fix disables EscapeBarrier and EscapeAnalysis when certain JVMTI > capabilities are enabled and --enable-preview. > > It restores the same behavior as it was before > https://bugs.openjdk.java.net/browse/JDK-8227745 "Enable Escape Ana

Integrated: 8287103: java/lang/management/ThreadMXBean/VirtualThreadDeadlocks.java fails with Xcomp

2022-05-23 Thread Leonid Mesnik
On Fri, 20 May 2022 22:27:29 GMT, Leonid Mesnik wrote: > Sync improved in test This pull request has now been integrated. Changeset: 110d9064 Author:Leonid Mesnik URL: https://git.openjdk.java.net/jdk/commit/110d906432761482acd2899be1314e075bc21bec Stats: 7 lines in 1 file chang

Re: RFR: 8285739: disable EscapeBarrier deopt for virtual threads [v2]

2022-05-23 Thread Leonid Mesnik
On Mon, 23 May 2022 10:20:39 GMT, Richard Reingruber wrote: > Could it be that you mean > [JDK-8264699](https://bugs.openjdk.java.net/browse/JDK-8264699)? > Yes, you are right. > I'm ok with this version of your fix. I'd suggest to change title/synopsis of > the bug report to better match it t

Re: RFR: 8287103: java/lang/management/ThreadMXBean/VirtualThreadDeadlocks.java fails with Xcomp [v2]

2022-05-23 Thread Kevin Walls
On Sat, 21 May 2022 16:34:32 GMT, Leonid Mesnik wrote: >> Sync improved in test > > Leonid Mesnik has updated the pull request incrementally with one additional > commit since the last revision: > > fix Looks good! - Marked as reviewed by kevinw (Committer). PR: https://git.op

Re: RFR: 8287135: Calculation of jmm_GetMemoryUsage is wrong

2022-05-23 Thread Yi Yang
On Mon, 23 May 2022 09:58:46 GMT, David Holmes wrote: > Sorry but I can't agree with this change as presented. By definition the > total non-heap memory is the sum of all pools which identify as non-heap as > per the specification: > > "The non-heap memory consists of one or more memory pools.

Re: RFR: 8244681: Add a warning for possibly lossy conversion in compound assignments [v10]

2022-05-23 Thread Adam Sotona
> Please review this patch adding new lint option, **lossy-conversions**, to > javac to warn about type casts in compound assignments with possible lossy > conversions. > > The new lint warning is shown if the type of the right-hand operand of a > compound assignment is not assignment compatibl

Re: RFR: 8244681: Add a warning for possibly lossy conversion in compound assignments [v9]

2022-05-23 Thread Adam Sotona
> Please review this patch adding new lint option, **lossy-conversions**, to > javac to warn about type casts in compound assignments with possible lossy > conversions. > > The new lint warning is shown if the type of the right-hand operand of a > compound assignment is not assignment compatibl

Re: RFR: 8285739: disable EA when both JVMTI and Preview are enabled [v2]

2022-05-23 Thread Richard Reingruber
On Sat, 21 May 2022 16:09:17 GMT, Leonid Mesnik wrote: > > Hi Leonid, if EscapeAnalysis is not disabled, then local objects cannot be > > read per JVMTI if they are scalarized in compiled frames on the heap, > > right? This would be a problem I'd think. Thanks, Richard. > > Yes, the fix restor

Re: RFR: 8287135: Calculation of jmm_GetMemoryUsage is wrong

2022-05-23 Thread David Holmes
On Mon, 23 May 2022 07:28:41 GMT, Yi Yang wrote: > It seems that calculation of > MemoryMXBean.getNonHeapMemoryUsage(jmm_GetMemoryUsage) is wrong. > > Currently, NonHeapUsage = CodeCache + Metaspace + CompressedClassSpace > > ==> CodeHeap 'non-nmethods' 1532544 (Used) > ==> CodeHeap 'profiled

Re: RFR: 8286212: Cgroup v1 initialization causes NPE on some systems [v3]

2022-05-23 Thread Severin Gehwolf
On Thu, 19 May 2022 20:18:50 GMT, Ioi Lam wrote: >> I am wondering if the problem is this: >> >> We have systemd running on the host, and a different copy of systemd that >> runs inside the container. >> >> - They both set up `/user.slice/user-1000.slice/session-??.scope` within >> their own

Re: RFR: 8287008: Improve tests for thread dumps in JSON format [v4]

2022-05-23 Thread Alan Bateman
On Mon, 23 May 2022 08:30:51 GMT, Alan Bateman wrote: >> This change is mostly test infrastructure and improvements to the testing of >> thread dumps in JSON format. It also tweaks the thread dump format so that >> the process identifier and thread identifiers are a type string rather than >>

Re: RFR: 8287008: Improve tests for thread dumps in JSON format [v4]

2022-05-23 Thread Alan Bateman
> This change is mostly test infrastructure and improvements to the testing of > thread dumps in JSON format. It also tweaks the thread dump format so that > the process identifier and thread identifiers are a type string rather than > number. > > The tests for thread dumps added by JEP 425 are

Re: RFR: 8287008: Improve tests for thread dumps in JSON format [v3]

2022-05-23 Thread Alan Bateman
On Mon, 23 May 2022 06:09:58 GMT, Chris Plummer wrote: >> Alan Bateman has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Remove spurious colon > > test/jdk/com/sun/management/HotSpotDiagnosticMXBean/DumpThreads.java line 115: > >> 113: >

RFR: 8287135: Calculation of jmm_GetMemoryUsage is wrong

2022-05-23 Thread Yi Yang
It seems that calculation of MemoryMXBean.getNonHeapMemoryUsage(jmm_GetMemoryUsage) is wrong. Currently, NonHeapUsage = CodeCache + Metaspace + CompressedClassSpace ==> CodeHeap 'non-nmethods' 1532544 (Used) ==> CodeHeap 'profiled nmethods' 0 ==> CodeHeap 'non-profiled nmethods' 13952 ==> Metasp