Integrated: 8264396: Use the blessed modifier order in jdk.internal.jvmstat

On Mon, 29 Mar 2021 21:00:20 GMT, Alex Blewitt wrote: > 8264396: Use the blessed modifier order in jdk.internal.jvmstat This pull request has now been integrated. Changeset: f43d14a2 Author: Alex Blewitt Committer: Kevin Walls URL: https://git.openjdk.java.net/jdk/commit/f43d1

Re: RFR: 8264396: Use the blessed modifier order in jdk.internal.jvmstat [v2]

On Wed, 31 Mar 2021 09:24:46 GMT, Alex Blewitt wrote: >> Looks fine to me as well. > > Going to upstream this patch into opendjk/panama-foreign Sorry, closed the wrong PR. This one should be good to go 🙄 - PR: https://git.openjdk.java.net/jdk/pull/3252

Re: RFR: 8264396: Use the blessed modifier order in jdk.internal.jvmstat [v2]

On Wed, 31 Mar 2021 06:07:57 GMT, Aleksey Shipilev wrote: >> Alex Blewitt has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Updated copyright dates > > Looks fine to me as well. Going to upstream this pat

Withdrawn: 8264396: Use the blessed modifier order in jdk.internal.jvmstat

On Mon, 29 Mar 2021 21:00:20 GMT, Alex Blewitt wrote: > 8264396: Use the blessed modifier order in jdk.internal.jvmstat This pull request has been closed without being integrated. - PR: https://git.openjdk.java.net/jdk/pull/3252

Re: RFR: 8264396: Use the blessed modifier order in jdk.internal.jvmstat [v2]

> 8264396: Use the blessed modifier order in jdk.internal.jvmstat Alex Blewitt has updated the pull request incrementally with one additional commit since the last revision: Updated copyright dates - Changes: - all: https://git.openjdk.java.net/jdk/pull/3252/files -

RFR: 8263854: Use the blessed modifier in jdk.internal.jvmstat

8263854: Use the blessed modifier in jdk.internal.jvmstat - Commit messages: - 8263854: Use the blessed modifier in jdk.internal.jvmstat Changes: https://git.openjdk.java.net/jdk/pull/3252/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=3252&range=00 Issue: https://bu

Integrated: 8264087: Use the blessed modifier order in jdk.jconsole

On Tue, 23 Mar 2021 21:43:47 GMT, Alex Blewitt wrote: > 8264087: Use the blessed modifier order in jdk.jconsole This pull request has now been integrated. Changeset: 59ed1fa2 Author: Alex Blewitt Committer: Claes Redestad URL: https://git.openjdk.java.net/jdk/commit/59ed1fa2 St

Re: RFR: 8264087: Use the blessed modifier order in jdk.jconsole

On Tue, 23 Mar 2021 21:43:47 GMT, Alex Blewitt wrote: > 8264087: Use the blessed modifier order in jdk.jconsole Is anyone able to review this change? The only change in 31 lines are modifier orders. - PR: https://git.openjdk.java.net/jdk/pull/3164

RFR: 8264087: Use the blessed modifier order in jdk.jconsole

8264087: Use the blessed modifier order in jdk.jconsole - Commit messages: - 8264087: Use the blessed modifier order in jdk.jconsole Changes: https://git.openjdk.java.net/jdk/pull/3164/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=3164&range=00 Issue: https://bugs.o

Integrated: 8263855: Use the blessed modifier order in java.management/naming

On Thu, 18 Mar 2021 18:26:20 GMT, Alex Blewitt wrote: > As with #2993 changing the order of `final static` to `static final` for the > `java.management`, `java.management.rmi` and `java.naming` modules. This pull request has now been integrated. Changeset: 5262d95b Author: Alex B

Re: RFR: 8263855: Use the blessed modifier order in java.management/naming [v2]

> As with #2993 changing the order of `final static` to `static final` for the > `java.management`, `java.management.rmi` and `java.naming` modules. Alex Blewitt has updated the pull request incrementally with one additional commit since the last revision: Added more replacements of

Re: RFR: 8263855: Use the blessed modifier order in java.management/naming

On Fri, 19 Mar 2021 13:28:12 GMT, Claes Redestad wrote: >> Thanks @cl4es -- do I need to update the git commit message as well, or is >> updating the title of the PR sufficient? I recall you suggesting not to do >> amend/rebases previously. > > No, the git commit messages here doesn't matter, t

Re: RFR: 8263855: Use the blessed modifier order in java.management/naming

On Fri, 19 Mar 2021 11:01:45 GMT, Claes Redestad wrote: >> @cl4es would you mind creating a parent task of something like "Source code >> cleanups" and then another sub task for this change please? > > Created the subtask https://bugs.openjdk.java.net/browse/JDK-8263855 for this > along with an

Re: RFR: 8263855: Use the blessed modifier order in java.management/naming

On Thu, 18 Mar 2021 19:33:59 GMT, Alex Blewitt wrote: >> As with #2993 changing the order of `final static` to `static final` for the >> `java.management`, `java.management.rmi` and `java.naming` modules. > > Would someone mind creating a bug for me? In addition, if it would

RFR: 8263855: Use the blessed modifier order in java.management/naming

As with #2993 changing the order of `final static` to `static final` for the `java.management`, `java.management.rmi` and `java.naming` modules. - Commit messages: - Use the blessed modifier order in java.management/naming Changes: https://git.openjdk.java.net/jdk/pull/3078/files

Re: RFR: 8263855: Use the blessed modifier order in java.management/naming

On Thu, 18 Mar 2021 18:26:20 GMT, Alex Blewitt wrote: > As with #2993 changing the order of `final static` to `static final` for the > `java.management`, `java.management.rmi` and `java.naming` modules. Would someone mind creating a bug for me? In addition, if it would help, we could