Re: RFR: 8284209: Replace remaining usages of 'a the' in source code

On Wed, 18 May 2022 14:46:42 GMT, Alexey Ivanov wrote: > Replaces usages of articles that follow each other in all combinations: > a/the, an?/an?, the/the… > > It's the last issue in the series, and it still touches different areas of > the code. Looked at -java.security.jgss. LGTM --

Re: RFR: 8284191: Replace usages of 'a the' in hotspot and java.base

On Wed, 18 May 2022 13:27:24 GMT, Alexey Ivanov wrote: > Replaces usages of articles that follow each other in all combinations: > a/the, an?/an?, the/the… > > Also, I fixed a couple of spelling mistakes. Looked at - java.base/.../sun/security - jdk.crypto.* - test/*/com/sun/crypto/provider

Re: RFR: JDK-8285676: Add missing @param tags for type parameters on classes and interfaces

On Tue, 26 Apr 2022 22:24:26 GMT, Joe Darcy wrote: > To enable more complete doclint checking (courtesy @jonathan-gibbons), please > review this PR to add type-level @param tags where they are missing. > > To the maintainers of java.util.concurrent, those changes could be separated > out in an

Re: RFR: 8282657: Code cleanup: removing double semicolons at the end of lines

On Fri, 28 Jan 2022 14:39:31 GMT, Matteo Baccan wrote: > Hi > > I have reviewed the code for removing double semicolons at the end of lines > > all the best > matteo LGTM also. Similar suggestion for updating copyrights. - Marked as reviewed by wetmore (Reviewer). PR: https:/

Re: RFR: 8252999: Cleanup: replace .equals("") with .isEmpty() within all codebase

On Fri, 11 Sep 2020 07:15:26 GMT, Dmitriy Dumanskiy wrote: >> 1) This is un-necessary churn. >> 2) I can't even be sure I am finding the ones in my area because there's so >> much here >> 3) The ones I can find have no need of whatever performance improvement this >> might bring. >> I think th

hg: jdk8/tl/jdk: 8027526: CheckTipsAndVersions.java failing occasionally

Changeset: f731d096530f Author:wetmore Date: 2013-10-30 16:49 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/f731d096530f 8027526: CheckTipsAndVersions.java failing occasionally Reviewed-by: mullan, mchung ! test/java/security/Signature/SignatureGetAlgorithm.java

hg: jdk8/tl/corba: 8026762: jdk8-tl builds windows builds failing in corba - javac: no source files

Changeset: 1a71d800b032 Author:wetmore Date: 2013-10-16 23:31 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/corba/rev/1a71d800b032 8026762: jdk8-tl builds windows builds failing in corba - javac: no source files Reviewed-by: katleman, dholmes ! makefiles/BuildCorba.gmk

hg: jdk8/tl/jdk: 8026762: jdk8-tl builds windows builds failing in corba - javac: no source files

Changeset: a45acc8de0f3 Author:wetmore Date: 2013-10-16 23:32 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/a45acc8de0f3 8026762: jdk8-tl builds windows builds failing in corba - javac: no source files Reviewed-by: katleman, dholmes ! makefiles/GenerateClasses.gmk

hg: jdk8/tl/jdk: 8025694: Rename getStrongSecureRandom based on feedback; ...

Changeset: a6ac824b463d Author:wetmore Date: 2013-10-02 09:38 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/a6ac824b463d 8025694: Rename getStrongSecureRandom based on feedback 8014838: getStrongSecureRandom() should require at least one implementation Reviewed-by: mullan, d

hg: jdk8/tl/jdk: 8023075: JDK-5049299 has broken old make in jdk8

Changeset: f8af3499c1fb Author:wetmore Date: 2013-08-14 19:19 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/f8af3499c1fb 8023075: JDK-5049299 has broken old make in jdk8 Reviewed-by: katleman ! make/java/java/Makefile

hg: jdk8/tl/jdk: 8019341: Update CookieHttpsClientTest to use the newer framework.

Changeset: 11c15607e43f Author:wetmore Date: 2013-07-05 18:22 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/11c15607e43f 8019341: Update CookieHttpsClientTest to use the newer framework. Reviewed-by: xuelei, smarks, michaelm ! test/sun/security/ssl/sun/net/www/protocol/htt

hg: jdk8/tl/jdk: 8014620: Signature.getAlgorithm return null in special case

Changeset: 116050227ee9 Author:youdwei Date: 2013-06-17 17:36 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/116050227ee9 8014620: Signature.getAlgorithm return null in special case Reviewed-by: wetmore ! src/share/classes/java/security/Signature.java + test/java/security/Si

hg: jdk8/tl/jdk: 8012530: test/sun/security/provider/SecureRandom/StrongSeedReader.java failing

Changeset: b600d637ef77 Author:wetmore Date: 2013-04-25 17:10 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/b600d637ef77 8012530: test/sun/security/provider/SecureRandom/StrongSeedReader.java failing Reviewed-by: wetmore Contributed-by: alan.bate...@oracle.com ! test/sun/se

hg: jdk8/tl/jdk: 8009925: Back out AEAD CipherSuites temporarily

Changeset: 6379415d8fca Author:wetmore Date: 2013-03-12 15:31 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/6379415d8fca 8009925: Back out AEAD CipherSuites temporarily Reviewed-by: valeriep ! src/share/classes/com/sun/crypto/provider/TlsKeyMaterialGenerator.java ! src/shar

hg: jdk8/tl/jdk: 8001419: Build the JCE portion of JDK-8000970

Changeset: 13b46e8eda33 Author:ohrstrom Date: 2012-10-23 15:51 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/13b46e8eda33 8001419: Build the JCE portion of JDK-8000970 Summary: Original code done by Fredrik Ohrstrom, separated/pushed by wetmore Reviewed-by: wetmore ! src/sh

hg: jdk8/tl/jdk: 7197071: Makefiles for various security providers aren't including the default manifest

Changeset: 940c8cc5a5c4 Author:wetmore Date: 2012-10-23 12:36 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/940c8cc5a5c4 7197071: Makefiles for various security providers aren't including the default manifest Reviewed-by: valeriep, mullan, katleman ! make/com/oracle/securi

hg: jdk8/tl/jdk: 7177556: Put TestProviderLeak.java on the ProblemList until test can be reworked

Changeset: 8e5635ded425 Author:wetmore Date: 2012-06-15 17:42 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/8e5635ded425 7177556: Put TestProviderLeak.java on the ProblemList until test can be reworked Reviewed-by: khazra ! test/ProblemList.txt

hg: jdk8/tl/jdk: 7167362: SecureRandom.init should be converted, amendment to 7084245

Changeset: 6438f1277df6 Author:wetmore Date: 2012-05-09 16:33 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/6438f1277df6 7167362: SecureRandom.init should be converted, amendment to 7084245 Reviewed-by: sherman ! src/share/classes/sun/security/provider/SecureRandom.java

hg: jdk8/tl/jdk: 7157903: JSSE client sockets are very slow

Changeset: 10480cf00dcd Author:wetmore Date: 2012-04-11 17:12 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/10480cf00dcd 7157903: JSSE client sockets are very slow Reviewed-by: xuelei ! src/share/classes/sun/security/ssl/AppOutputStream.java ! src/share/classes/sun/security

hg: jdk8/tl/jdk: 7142172: Custom TrustManagers that return null for getAcceptedIssuers will NPE

Changeset: 7a7dcbbd610f Author:wetmore Date: 2012-03-30 15:43 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/7a7dcbbd610f 7142172: Custom TrustManagers that return null for getAcceptedIssuers will NPE Reviewed-by: xuelei ! src/share/classes/sun/security/ssl/SSLContextImpl.ja

hg: jdk8/tl/jdk: 7142509: Cipher.doFinal(ByteBuffer, ByteBuffer) fails to process when in.remaining() == 0

Changeset: b16cbeb0d213 Author:wetmore Date: 2012-02-10 19:07 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/b16cbeb0d213 7142509: Cipher.doFinal(ByteBuffer,ByteBuffer) fails to process when in.remaining() == 0 Reviewed-by: valeriep ! src/share/classes/javax/crypto/CipherSp

hg: jdk8/tl/jdk: 7141910: Incorrect copyright dates on new test cases.

Changeset: 55a82eba1986 Author:wetmore Date: 2012-02-01 16:00 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/55a82eba1986 7141910: Incorrect copyright dates on new test cases. Reviewed-by: mullan ! test/sun/security/ssl/com/sun/net/ssl/internal/ssl/EngineArgs/DebugReportsOn

hg: jdk8/tl/jdk: 7126889: Incorrect SSLEngine debug output

Changeset: 5ee30ab905db Author:wetmore Date: 2012-01-26 17:16 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/5ee30ab905db 7126889: Incorrect SSLEngine debug output Reviewed-by: xuelei ! src/share/classes/sun/security/ssl/EngineArgs.java ! src/share/classes/sun/security/ssl/S

hg: jdk8/tl/jdk: 7053252: New regression test does not compile on windows-amd64

Changeset: b60e88ef5d8d Author:wetmore Date: 2011-10-31 16:23 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/b60e88ef5d8d 7053252: New regression test does not compile on windows-amd64 Reviewed-by: valeriep ! test/ProblemList.txt ! test/sun/security/pkcs11/Provider/Absolute.

hg: jdk8/tl/jdk: 7105780: Add SSLSocket client/SSLEngine server to templates directory

Changeset: 8681362a2f04 Author:wetmore Date: 2011-10-31 11:54 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/8681362a2f04 7105780: Add SSLSocket client/SSLEngine server to templates directory Reviewed-by: xuelei + test/sun/security/ssl/templates/SSLSocketSSLEngineTemplate.ja

hg: jdk8/tl/jdk: 7031830: bad_record_mac failure on TLSv1.2 enabled connection with SSLEngine

Changeset: 8640b7185be1 Author:wetmore Date: 2011-10-18 11:58 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/8640b7185be1 7031830: bad_record_mac failure on TLSv1.2 enabled connection with SSLEngine Reviewed-by: xuelei, weijun, asaha ! src/share/classes/sun/security/ssl/Ciph

hg: jdk7/tl/jdk: 7042097: JDK 7's Unlimited Cryptographic Policy bundle text files must be updated.

Changeset: c79a089ae13b Author:wetmore Date: 2011-05-31 12:45 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/c79a089ae13b 7042097: JDK 7's Unlimited Cryptographic Policy bundle text files must be updated. Reviewed-by: valeriep ! make/javax/crypto/Makefile

hg: jdk7/tl/jdk: 7031343: Provide API changes to support future GCM AEAD ciphers

Changeset: 13af7c12c62a Author:wetmore Date: 2011-04-13 11:59 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/13af7c12c62a 7031343: Provide API changes to support future GCM AEAD ciphers Reviewed-by: valeriep, xuelei + src/share/classes/javax/crypto/AEADBadTagException.java !

hg: jdk7/tl/jdk: 6626257: Update SWAN-specific webcaching to Oracle environment in the regression tests.

Changeset: 65b6fe866a6f Author:wetmore Date: 2011-04-13 16:12 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/65b6fe866a6f 6626257: Update SWAN-specific webcaching to Oracle environment in the regression tests. Reviewed-by: valeriep ! test/sun/net/InetAddress/nameservice/dns

hg: jdk7/tl/jdk: 6914617: JCE framework code signing certificate is expiring at the end of 2010.

Changeset: 29e88b0c0894 Author:wetmore Date: 2011-04-13 11:36 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/29e88b0c0894 6914617: JCE framework code signing certificate is expiring at the end of 2010. Reviewed-by: valeriep, weijun, mullan ! make/javax/crypto/Defs-jce.gmk

hg: jdk7/tl/jdk: 6844879: Source distribution should be more robustly built without the security source distribution

Changeset: 0f0d6b8f98cc Author:wetmore Date: 2011-02-23 22:54 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/0f0d6b8f98cc 6844879: Source distribution should be more robustly built without the security source distribution Reviewed-by: ohair ! make/common/shared/Defs-java.gm

hg: jdk7/tl/jdk: 6945604: wrong error message in CardImpl.java

Changeset: d8ad2da3ecf3 Author:wetmore Date: 2010-04-20 14:24 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/d8ad2da3ecf3 6945604: wrong error message in CardImpl.java Reviewed-by: mullan ! src/share/classes/sun/security/smartcardio/CardImpl.java

hg: jdk7/tl/jdk: 6923976: TestProviderLeak.java is using too small of an initial heap under newer Hotspot (b79+)

Changeset: 7136683a33d2 Author:wetmore Date: 2010-02-05 17:05 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/7136683a33d2 6923976: TestProviderLeak.java is using too small of an initial heap under newer Hotspot (b79+) Reviewed-by: ohair ! test/com/sun/crypto/provider/KeyFac

hg: jdk7/tl: 6872177: JCE framework and provider builds broken following -target 7 changes

Changeset: d8b49b53d8cf Author:wetmore Date: 2009-08-14 17:29 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/rev/d8b49b53d8cf 6872177: JCE framework and provider builds broken following -target 7 changes Reviewed-by: ohair ! make/Defs-internal.gmk

hg: jdk7/tl/jdk: 2 new changesets

Changeset: 8c0c96a3f9f6 Author:wetmore Date: 2009-08-13 12:36 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/8c0c96a3f9f6 6870335: Provider numbers need to be bumped to 1.7 Reviewed-by: mullan ! src/share/classes/com/sun/security/sasl/Provider.java ! src/share/classes/sun/se

hg: jdk7/tl/jdk: 6867657: Many JSN tests do not run under cygwin

Changeset: 2aa570c01c69 Author:wetmore Date: 2009-08-06 17:56 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/2aa570c01c69 6867657: Many JSN tests do not run under cygwin Reviewed-by: ohair ! test/java/net/Authenticator/B4933582.sh ! test/java/net/DatagramSocket/SetDatagramSo

hg: jdk7/tl/jdk: 6778613: Update javax.crypto.Cipher.getMaxAllowedKeyLength to point to proper Appendix after doc reorg

Changeset: 4e0e690373fc Author:wetmore Date: 2008-12-02 14:53 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/4e0e690373fc 6778613: Update javax.crypto.Cipher.getMaxAllowedKeyLength to point to proper Appendix after doc reorg Reviewed-by: mullan ! src/share/classes/javax/cry

hg: jdk7/tl/jdk: 7 new changesets

Changeset: 486b917ed417 Author:mullan Date: 2008-10-07 13:41 -0400 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/486b917ed417 6752764: PIT B37: CertPath/CertPathValidatorTest/KeyParamsInheritanceTest failed Summary: fix regression introduced by 6465942 Reviewed-by: vinnie ! src/s

hg: jdk7/tl/jdk: 10 new changesets

Changeset: c7fae5013939 Author:michaelm Date: 2008-09-19 13:32 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/c7fae5013939 6750364: Error in test for 6744329 Reviewed-by: chegar ! test/com/sun/net/httpserver/bugs/B6744329.java Changeset: e57447118235 Author:michaelm Dat

hg: jdk7/tl/jdk: 9 new changesets

Changeset: eb342082e2b6 Author:jccollet Date: 2008-09-04 15:26 +0200 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/eb342082e2b6 6692802: HttpCookie needs to support HttpOnly attribute Summary: Added HttpOnly tag support to HttpCookie class. Reviewed-by: chegar, michaelm ! src/sha

hg: jdk7/tl/jdk: 6 new changesets

Changeset: a4ff2fe5b5d9 Author:weijun Date: 2008-08-06 08:11 +0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/a4ff2fe5b5d9 6731685: CertificateFactory.generateCertificates throws IOException on PKCS7 cert chain Reviewed-by: mullan ! src/share/classes/sun/security/util/DerInde

hg: jdk7/tl/jdk: 13 new changesets

Changeset: 571a6e4bbb91 Author:jccollet Date: 2008-07-01 13:29 +0200 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/571a6e4bbb91 6713809: FTP fails from multi-homed system Summary: Binds the data socket to the same address as the control socket Reviewed-by: michaelm ! src/share/cl

hg: jdk7/tl/jdk: 6 new changesets

Changeset: 2f21c9f8136a Author:mullan Date: 2008-06-17 10:34 -0400 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/2f21c9f8136a 6673277: Thread unsafe lazy initialization code in sun.security.provider.certpath.*Checker classes Summary: make supportedExts variable non-static Reviewe

hg: jdk7/tl/jdk: 9 new changesets

Changeset: e8201036fc65 Author:xuelei Date: 2008-06-04 09:56 +0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/e8201036fc65 6690018: RSAClientKeyExchange NullPointerException Summary: checking certificate key length for RSA_EXPORT key exchange Reviewed-by: wetmore, mullan ! src

hg: jdk7/tl/jdk: 7 new changesets

Changeset: ca48d7cc3579 Author:chegar Date: 2008-05-15 10:26 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/ca48d7cc3579 6670408: testcase panics 1.5.0_12&_14 JVM when java.net.PlainSocketImpl trying to throw an exception Summary: Replace select with poll Reviewed-by: alanb,

hg: jdk7/tl/jdk: 2 new changesets

Changeset: d95a6a4ea502 Author:chegar Date: 2008-05-02 21:33 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/d95a6a4ea502 6687919: REGRESSION : Classloader can handle any resource which is not included in classpath Reviewed-by: jccollet, alanb ! src/share/classes/sun/misc/UR

hg: jdk7/tl/jdk: 19 new changesets

Changeset: ad75c4b21d63 Author:weijun Date: 2008-04-10 19:58 +0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/ad75c4b21d63 6675606: javax.security.auth.login.Configuration does not recognize path with spaces Reviewed-by: chegar, xuelei ! src/share/classes/com/sun/security/aut

hg: jdk7/tl/jdk: 14 new changesets

Changeset: a8d6215fa863 Author:weijun Date: 2008-03-20 11:57 +0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/a8d6215fa863 6670362: HTTP/SPNEGO should work across realms Reviewed-by: valeriep ! src/share/classes/sun/net/www/protocol/http/NegotiatorImpl.java Changeset: 74bc85c

hg: jdk7/tl/jdk: 32 new changesets

Changeset: e1b99dfabb04 Author:chegar Date: 2008-03-04 17:09 + URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/e1b99dfabb04 6638560: APPCRASH in "SPNEGO_HTTP_AUTH/PROXY_FALLBACK" test case with 64 bit JDK on Win2008 x64, VinVista x64 Summary: Remove incorrect free from native c