Integrated: 8283728: jdk.hotspot.agent: Wrong location for RISCV64ThreadContext.java

2022-03-28 Thread Christoph Langer
On Sun, 27 Mar 2022 08:59:40 GMT, Christoph Langer wrote: > Fix risv64 -> riscv64 This pull request has now been integrated. Changeset: f4eaa16c Author:Christoph Langer URL: https://git.openjdk.java.net/jdk/commit/f4eaa16c0fe0659376325cec1c912a13ef0f1be8 Stats: 0 line

Re: RFR: 8283728: jdk.hotspot.agent: Wrong location for RISCV64ThreadContext.java

2022-03-28 Thread Christoph Langer
On Sun, 27 Mar 2022 08:59:40 GMT, Christoph Langer wrote: > Fix risv64 -> riscv64 Interestingly, the thing compiles as the package name inside of RISCV64ThreadContext.java is correct and the compiler doesn't bother about the path. Only my Eclipse IDE complained. Thanks for

RFR: 8283728: jdk.hotspot.agent: Wrong location for RISCV64ThreadContext.java

2022-03-27 Thread Christoph Langer
Fix risv64 -> riscv64 - Commit messages: - JDK-8283728 Changes: https://git.openjdk.java.net/jdk/pull/7977/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=7977&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8283728 Stats: 0 lines in 1 file changed: 0 ins;

Re: RFR: 8267666: Add option to jcmd GC.heap_dump to use existing file [v4]

2021-07-06 Thread Christoph Langer
On Sun, 6 Jun 2021 08:50:22 GMT, Anton Kozlov wrote: >> Anton Kozlov has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Fix windows flags (although complied fine) > > Thanks for the comments! Indeed, the change is about the "overwrite" opti

Re: RFR: 8267666: Add option to jcmd GC.heap_dump to use existing file [v4]

2021-06-08 Thread Christoph Langer
On Wed, 2 Jun 2021 20:57:02 GMT, Anton Kozlov wrote: >> Please review a small change that adds an option to GC.heap_dump to use an >> existing file. >> >> The option is necessary if the target file is a predefined file-like object, >> like a named pipe. This opens up a lot of possibilities to

Re: RFR: 8267666: Add option to jcmd GC.heap_dump to use existing file [v4]

2021-06-06 Thread Christoph Langer
On Sun, 6 Jun 2021 08:50:22 GMT, Anton Kozlov wrote: > Thanks for the comments! Indeed, the change is about the "overwrite" option > only. The CSR describes why the option is necessary, and sockets and pipes > are just examples. I have rephrased CSR to be more explicit about the option, > but

Re: RFR: 8267666: Add option to jcmd GC.heap_dump to use existing file [v4]

2021-06-05 Thread Christoph Langer
On Wed, 2 Jun 2021 20:57:02 GMT, Anton Kozlov wrote: >> Please review a small change that adds an option to GC.heap_dump to use an >> existing file. >> >> The option is necessary if the target file is a predefined file-like object, >> like a named pipe. This opens up a lot of possibilities to

Re: RFR: 8267666: Add option to jcmd GC.heap_dump to use existing file [v3]

2021-06-05 Thread Christoph Langer
On Wed, 2 Jun 2021 20:49:10 GMT, Anton Kozlov wrote: > SInce JDK-8263066 suggests more enhancements, it may be worth keeping it to > track the remaining ones. No, the issue we're trying to solve with JDK-8263066 is basically the same as with JDK-8267666, so we'll close it. There's also JDK-820

Re: RFR: 8252837: Cleanup SAP Copyright file headers

2020-09-07 Thread Christoph Langer
e.com) on > [nio-dev](mailto:nio-...@openjdk.java.net):_ > Looks good to me - and trivial. > > Thanks, > David > > On 7/09/2020 2:22 pm, Christoph Langer wrote: Thanks, David! - PR: https://git.openjdk.java.net/jdk/pull/36

Integrated: 8252837: Cleanup SAP Copyright file headers

2020-09-07 Thread Christoph Langer
On Mon, 7 Sep 2020 04:14:06 GMT, Christoph Langer wrote: > The format for SAP copyrights in OpenJDK headers should be like: > Copyright (c) SAP SE. All rights reserved. > or > Copyright (c) , SAP SE. All rights reserved. > > There should not be a comma character (&

Re: RFR: 8252837: Cleanup SAP Copyright file headers

2020-09-07 Thread Christoph Langer
On Mon, 7 Sep 2020 07:27:39 GMT, Christoph Langer wrote: >> Marked as reviewed by dholmes (Reviewer). > >> _Mailing list message from [David Holmes](mailto:david.hol...@oracle.com) on >> [nio-dev](mailto:nio-...@openjdk.java.net):_ >> Looks good to me - and trivi

RFR: 8252837: Cleanup SAP Copyright file headers

2020-09-06 Thread Christoph Langer
The format for SAP copyrights in OpenJDK headers should be like: Copyright (c) SAP SE. All rights reserved. or Copyright (c) , SAP SE. All rights reserved. There should not be a comma character (",") before "SAP SE". This is inconsistent in some files which calls for some cleanup. Please revie