Re: RFR (S) 8025238: nsk/jvmti/scenarios/bcinstr/BI04/bi04t002 crashed with SIGSEGV

On 10/3/2013 7:01 PM, Daniel D. Daugherty wrote: On 10/3/13 4:56 PM, Coleen Phillmore wrote: Thanks Dan - On 10/3/2013 4:07 PM, Daniel D. Daugherty wrote: > http://cr.openjdk.java.net/~coleenp/8025238/ src/share/vm/classfile/javaClasses.cpp 1804 if (method == NULL) { 1

Re: RFR (S) 8025238: nsk/jvmti/scenarios/bcinstr/BI04/bi04t002 crashed with SIGSEGV

On 10/3/2013 3:29 PM, Staffan Larsen wrote: Looks good! (Obviously I would think so for the testcase :-) ) Thanks for the testcase! Coleen Thanks for fixing, /Staffan On 3 okt 2013, at 20:02, Coleen Phillimore wrote: Summary: Redefined class in stack trace may not be found by method_idn

Re: RFR (S) 8025238: nsk/jvmti/scenarios/bcinstr/BI04/bi04t002 crashed with SIGSEGV

Thanks Serguei! Coleen On 10/3/2013 3:50 PM, serguei.spit...@oracle.com wrote: Coleen, The fix looks good. It is nice you've come up with this. Thanks, Serguei On 10/3/13 11:02 AM, Coleen Phillimore wrote: Summary: Redefined class in stack trace may not be found by method_idnum so handle nul

Re: RFR (S) 8025238: nsk/jvmti/scenarios/bcinstr/BI04/bi04t002 crashed with SIGSEGV

Thanks Dan - On 10/3/2013 4:07 PM, Daniel D. Daugherty wrote: > http://cr.openjdk.java.net/~coleenp/8025238/ src/share/vm/classfile/javaClasses.cpp 1804 if (method == NULL) { 1805 // leave name and fileName null 1806 java_lang_StackTraceElement::set_lineNumber(element(), -1);

Re: RFR (S) 8025238: nsk/jvmti/scenarios/bcinstr/BI04/bi04t002 crashed with SIGSEGV

Thanks Dan - On 10/3/2013 4:28 PM, Daniel D. Daugherty wrote: > open webrev at http://cr.openjdk.java.net/~coleenp/8025238_jdk test/java/lang/instrument/RedefineMethodInBacktrace.sh No comments. test/java/lang/instrument/RedefineMethodInBacktraceApp.java line 78: t.setDaemon(t

Re: Review Request (S) 8017230: Internal Error (jvmtiRedefineClasses.cpp:1662): guarantee(false) failed: insert_space_at() failed

It took me a while to remember why this change is the way it is. Why do you clear the pending exception at line 1601? thanks, Coleen On 9/12/2013 3:21 PM, serguei.spit...@oracle.com wrote: On 9/11/13 8:54 PM, David Holmes wrote: Hi Dmitry, It seems odd that you install the new_method even i

Re: Review Request (S) 8017230: Internal Error (jvmtiRedefineClasses.cpp:1662): guarantee(false) failed: insert_space_at() failed

I see the answer to my question in the mail that hasn't come out yet. The error handling in this code relies on boolean returns in order to throw a JVMTI_ERROR code. Maybe a comment to this effect would be good above CLEAR_PENDING_EXCEPTION. I don't need to rereview this.understand that

Re: Review Request (S) 8024345: 'assert(_value != NULL) failed: resolving NULL _value' from VM_RedefineClasses::set_new_constant_pool

This looks good too. Thanks for catching the smaller_cp case. Coleen On 9/12/2013 8:19 PM, serguei.spit...@oracle.com wrote: The update open webrev: http://cr.openjdk.java.net/~sspitsyn/webrevs/2013/hotspot/8024345-JVMTI-MEM.2/ Thanks, Serguei On 9/12/13 5:13 PM, serguei.spit...@oracle

Re: Review Request (S) 8024346: ~CautiouslyPreserveExceptionMark - assert(!_thread->has_pending_exception()) failed: unexpected exception generated

This looks good. Coleen On 9/12/2013 8:21 PM, serguei.spit...@oracle.com wrote: The updated open webrev: http://cr.openjdk.java.net/~sspitsyn/webrevs/2013/hotspot/8024346-JVMTI-MEM.2/ Thanks, Serguei On 9/12/13 1:03 PM, serguei.spit...@oracle.com wrote: On 9/11/13 9:09 PM, David Holmes wr

Re: RFR S: 7127792 Add the ability to change an existing PeriodicTask's execution interval

Rickard, Are David and Marcus sufficient to push this. I briefly looked at it a few times and have to admit not knowing anything about this code without further study. Dan and Karen probably know more.Keith might too, so I've cc'd him. Sorry I can't be more helpful but if you need a

Re: Review request: 7197350: NPG: jvmtiHeapReferenceCallback receives incorrect reference_kind for system class roots

This looks good. Coleen On 9/10/2012 12:39 PM, Stefan Karlsson wrote: http://cr.openjdk.java.net/~stefank/7197350/webrev/ 7197350 : NPG: jvmtiHeapReferenceCallback receives incorrect reference_kind for system class roots Summary: Fi