[8u] RFR(S) 8044107 : Add Diagnostic Command to list all ClassLoaders

Hi! Please review this very simple serviceability backport to 8u. The only difference between the JDK 9 changeset and the JDK 8 changeset is that the ClassLoaderDataGraph::cld_do function was already backported to JDK 8 in the fix for 8049421 [0]. So the changes for adding classLoaderData.hpp

[8u] RFR(S) 8031304 : Add dcmd to print all loaded dynamic libraries

Hi! Please review this straightforward serviceability backport to JDK 8. No real changes to product code. I just moved the import statements in the DynLibDcmdTest.java test case to below the copyright header. bug report: https://bugs.openjdk.java.net/browse/JDK-8031304 JDK 9 review thread: h

Re: [8u] RFR(S) 8059036: Implement Diagnostic Commands for heap and finalizerinfo

Hi! Any love out there for my review request? Cheers, -Buck On 2017/12/15 14:42, David Buck wrote: Hi! May I please get a review of the following very simple backport of this serviceability improvement to JDK 8? The two hotspot jtreg test cases needed to be modified slightly because of

[8u] RFR(S) 8059036: Implement Diagnostic Commands for heap and finalizerinfo

Hi! May I please get a review of the following very simple backport of this serviceability improvement to JDK 8? The two hotspot jtreg test cases needed to be modified slightly because of the lack of dcmd-specific test support in JDK 8's HS code base. The only non-test difference from the JD

Re: [10] RFR 8181647: jhsdb jstack could not output thread name

Hi! Sharath Ballal has identified another minor formatting issue on line 984 of vmStructs.cpp. I have corrected it and uploaded a new webrev: http://cr.openjdk.java.net/~dbuck/8181647.2/ I have run the changes through JPRT (default and "hotspot" test sets) and see no sign of regression. We

RFR 8133666: OperatingSystemMXBean reports abnormally high machine CPU consumption on Linux

Hi! Please review my fix for this JMX issue. bug: https://bugs.openjdk.java.net/browse/JDK-8133666 webrev: http://cr.openjdk.java.net/~dbuck/8133666/ Once approved, I will push this fix into: http://hg.openjdk.java.net/jdk9/hs-rt Cheers, -Buck

RFR 8060169: Update the Crash Reporting URL in the Java crash log

Hi! Please approve this very simple update to the URL written in the crash log (hs_err_pid.log) file. BUGURL: https://bugs.openjdk.java.net/browse/JDK-8060169 WEBREV: http://cr.openjdk.java.net/~dbuck/8060169/webrev.000/ Cheers, -Buck

hg: jdk8/tl/jdk: 7042126: (alt-rt) HashMap.clone implementation should be re-examined

Changeset: 3f766f58c48a Author:dbuck Date: 2013-01-31 10:55 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/3f766f58c48a 7042126: (alt-rt) HashMap.clone implementation should be re-examined Summary: Test case for cr7042126. Issue only found in OracleJDK, but test case is vali

Re: cr7154822 : Request for code review

version of the script locally (solaris/SPARC). Rerunning on JPRT just to make sure all platforms are OK. (I'm a sucker for testing.) Cheers, -Buck On 3/30/2012 12:36 PM, Daniel D. Daugherty wrote: On 3/29/12 9:04 PM, David Buck wrote: Hi! I would like to submit a new version of the fi

Re: cr7154822 : Request for code review

the feedback. Cheers, -Buck On 3/30/2012 3:20 AM, Staffan Larsen wrote: On 29 mar 2012, at 17:11, David Buck wrote: Hi! If the limit is the same for all platforms, then the fix could be improved to check that each line is smaller than the limit before to send it to the target JVM, and prope

Re: cr7154822 : Request for code review

his value into the client is just asking for trouble. Ideally, jcmd should be inter-operable with multiple versions of the JVM. Thanks for all the feedback. Will rebuild / re-test and get a new version out ASAP. Cheers, -Buck On 03/29/12 23:29, Daniel D. Daugherty wrote: Resending... with Dav

Re: cr7154822 : Request for code review

" > if [ "$status" != 0 ]; then > echo "jcmd command returned non-zero exit code (status=$status). Failed." Thanks. will change. > line 54: please redirect output of 'grep' here to /dev/null or the > appropriate bit bucket... Thanks, will change as wel

Re: cr7154822 : Request for code review

ge like: "line 84: Line too long" would improve the user experience. A few comments on the code: src/share/classes/sun/tools/jcmd/JCmd.java Copyright years should be "2011, 2012" instead of "2012" test/sun/tools/jcmd/dcmd-big-script.txt The empty line at the end of the

cr7154822 : Request for code review

Hi! Please review my fix for the following bug : [ Bug ID: 7154822 forward port fix for Bug 13645891 to JDK8 jcmd (1024 byte file size limit issue) ] http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7154822 The issue is there is an arbitrary limit in the size of a script file you pass to t

Re: Code Review Request : 7011591 JDWP socket transport should restart interrupted system calls (EINTR)

Hi Alan! After looking at the code, I think that not-honoring the timeout would be a bug. I will fix this and resubmit my review request. (I also have other changes to make based on Dmitry Samersoff's comment, so this may take a bit longer before the new version is submitted. Thanks for the

Re: Code Review Request : 7011591 JDWP socket transport should restart interrupted system calls (EINTR)

ecommended to call getsockopt() and read the SO_ERROR to determine whether connect was successful or not. -Dmitry On 2011-08-04 16:02, David Buck wrote: Hi! I would like to request that my fix for 7011591 be reviewed for push into JDK8 (and JDK7u if possible). CR: 7011591 JDWP socket transport