On 5/26/15 10:16 AM, Dmitry Samersoff wrote:
Hi Everybody,
http://cr.openjdk.java.net/~dsamersoff/JDK-8059036/webrev.09/
Please review updated webrev -
printFinalizationQueue now returns and array of Map.Entry
Hi Dmitry,
I looked at the jdk_webrev. Everything looks great except the spacing
f (r instanceof FinalReference) {
sun.misc.VM.addFinalRefCount(-1);
}
return r;
}
return null;
}
Peter
-Dmitry
On 2015-05-16 01:59, Derek White wrote:
Hi Dmitry, Peter,
I should read my email more frequently - I missed Dmitry's last webrev
his use is correct.
While looking over this Reference code I found 3-6 really simple things
that need cleaning up that have been there for years, so I'm not a big
cheerleader for more complicated things here :-)
- Derek
On 5/15/15 6:46 PM, Derek White wrote:
Hi Peter,
Some comments below..
Hi Peter,
Some comments below...
On 5/14/15 3:50 AM, Peter Levart wrote:
Hi Derek,
On 05/13/2015 10:34 PM, Derek White wrote:
Hi Peter,
I don't have smoking gun evidence that your change introduces a bug,
but I have some concerns...
I did have a concern too, ...
On 5/12/15 6:
8: "} else {"
- Check for consistent line spacing.
- Derek
-Dmitry
On 2015-05-07 00:51, Derek White wrote:
Hi Dmitry, Staffan,
Lots of good comments here.
On the topic of what list should be printed out, I think we should focus
on objects waiting to be finalized - e.g. the con
y be thrown out and re-written, but that's another issue :-)
- Derek
Regards, Peter
On 05/12/2015 07:10 PM, Dmitry Samersoff wrote:
Everybody,
Updated version:
http://cr.openjdk.java.net/~dsamersoff/JDK-8059036/webrev.03/
Now it iterates over queue and output result sorted by number of in
ject with a finalize() method.
The sorting suggestion is a nice touch.
- Derek White, GC team
On 5/5/15 10:40 AM, Peter Levart wrote:
Hi Dmitry, Staffan,
On 05/05/2015 12:38 PM, Staffan Larsen wrote:
Dmitry,
I think this should be reviewed on hotspot-gc and core-libs-dev as
well consid
