Re: RFR(S): 8152989: serviceability/tmtools/jstat/GcCauseTest02.java fails with OOME

2016-04-07 Thread Dmitry Fazunenko
Per, On 07.04.2016 14:55, Per Liden wrote: On 2016-04-07 13:24, Dmitry Fazunenko wrote: Hi Per, The fix looks good, but a couple of suggestions regarding: Thanks Dima! GcCapacityTest.java.frames.html 1) -Xmx128 --> -Xmx128m Ah, thanks for catching that! 2) Remove @ignore 8149

Re: RFR(S): 8152989: serviceability/tmtools/jstat/GcCauseTest02.java fails with OOME

2016-04-07 Thread Dmitry Fazunenko
Hi Per, The fix looks good, but a couple of suggestions regarding: GcCapacityTest.java.frames.html 1) -Xmx128 --> -Xmx128m 2) Remove @ignore 8149778 Adding -Xmx should fix 8149778 as well. Thanks, Dima On 06.04.2016 12:32, Per Liden wrote: Summary: This patch updates the tests in servic

Re: Fwd: Re: RFR: 8062536: [TESTBUG] Conflicting GC combinations in jdk tests

2014-11-10 Thread Dmitry Fazunenko
On 10.11.2014 20:28, Bengt Rutisson wrote: On 2014-11-08 09:11, Dmitry Fazunenko wrote: Hi Mandy, On 08.11.2014 02:41, Mandy Chung wrote: On 11/7/14 3:34 AM, Evgeniya Stepanova wrote: http://cr.openjdk.java.net/~eistepan/8062536/webrev.02/ What are the valid values ofvm.gc? It's

Re: Fwd: Re: RFR: 8062536: [TESTBUG] Conflicting GC combinations in jdk tests

2014-11-08 Thread Dmitry Fazunenko
Hi Mandy, On 08.11.2014 02:41, Mandy Chung wrote: On 11/7/14 3:34 AM, Evgeniya Stepanova wrote: http://cr.openjdk.java.net/~eistepan/8062536/webrev.02/ What are the valid values ofvm.gc? It's a bit awk for null as a valid value and I would imagine "*" wildcard may be a better value? vm.g

Re: Fwd: Re: RFR: 8062536: [TESTBUG] Conflicting GC combinations in jdk tests

2014-11-06 Thread Dmitry Fazunenko
Hi Katja, You are right, there will be no conflict, because test ignores any external VM flags. So, adding @requires seems unnecessary here, but... Ignoring external options is bad thing, such "selfish" tests are not applicable for other areas, like GC, compiler, RT. @requires will allow t

Re: RFR: JDK-8055845 - Add trace event for promoted objects

2014-08-27 Thread Dmitry Fazunenko
be a separate webrev as they will be located in a separate repository. Regards, Staffan On 08/27/2014 04:08 AM, Dmitry Fazunenko wrote: Hi Staffan, Thanks for submitting RFE and implementing it! This event seems to be used widely. So it's very important to design it correctly. May I ask you

Re: RFR: JDK-8055845 - Add trace event for promoted objects

2014-08-27 Thread Dmitry Fazunenko
Hi Staffan, Thanks for submitting RFE and implementing it! This event seems to be used widely. So it's very important to design it correctly. May I ask you to provide some extra information: - format of event (this could be included in the CR description) - regression tests for that event wil