Re: RFR: 8241080: Consolidate signature parsing code in serviceability tools

2020-09-08 Thread Egor Ushakov
hat centralizes the signature processing in serviceability tools to make it capable of being easily extensible in the future. > > Testing: Mach5 tier1-tier3 tests successfully passed. > > [1] http://cr.openjdk.java.net/~dtitov/8241080/webrev.01 > [2] https://bugs.openjdk.java.net/browse/JDK-8241080 > > Thank you, > Daniil > > > > > > -- Egor Ushakov Software Developer JetBrains http://www.jetbrains.com The Drive to Develop

RFR: 8241958: Slow ClassLoaderReferenceImpl.findType

2020-04-03 Thread Egor Ushakov
adds extra check in classesBySignature before comparing signatures of all visible classes. bugid https://bugs.openjdk.java.net/browse/JDK-8241958 cr http://cr.openjdk.java.net/~eushakov/8241958/webrev.00/ Thanks! -- Egor Ushakov Software Developer JetBrains http://www.jetbrains.com The Drive to

invokeMethod's result gced immediately

2020-03-12 Thread Egor Ushakov
().zoo() to evaluate successfully. Is there a way to automatically disable collection for newly created objects from jdi? Maybe there's a bug about this? Thanks! -- Egor Ushakov Software Developer JetBrains http://www.jetbrains.com The Drive to Develop

Re: Slow class loading when running JVM in debug mode

2019-07-04 Thread Egor Ushakov
option and jcmd command. Chris On 6/21/19 3:06 AM, Egor Ushakov wrote: Will have a look, thanks for advices! On 21-Jun-19 00:42, Chris Plummer wrote: With respect to the specific issue brought up in https://youtrack.jetbrains.com/issue/JBR-1611: "If we look into the code, we'l

Re: Slow class loading when running JVM in debug mode

2019-06-21 Thread Egor Ushakov
r runtime behavior. Regards, Volker Egor Ushakov <mailto:egor.usha...@jetbrains.com>> schrieb am Do. 20. Juni 2019 um 11:36: Hi everyone! we have detected that a process started with the debug agent (even when debugger is not actually attached) may run significantly

Re: RFR: 8221503: vmTestbase/nsk/jdb/eval/eval001/eval001.java failes with: com.sun.jdi.InvalidTypeException: Can't assign double[][][] to double[][][]

2019-06-20 Thread Egor Ushakov
Hi David, any news on https://bugs.openjdk.java.net/browse/JDK-8212117? I do not see any activity on this :( Thanks, Egor On 09-Apr-19 15:53, David Holmes wrote: On 9/04/2019 7:36 pm, Egor Ushakov wrote: Hi David, you're right! The fix for JDK-8212117 should help here as well. After

Slow class loading when running JVM in debug mode

2019-06-20 Thread Egor Ushakov
a difference. Is that something well known? Should we file a bug? Thanks, Egor -- Egor Ushakov Software Developer JetBrains http://www.jetbrains.com The Drive to Develop

Re: RFR: 8221503: vmTestbase/nsk/jdb/eval/eval001/eval001.java failes with: com.sun.jdi.InvalidTypeException: Can't assign double[][][] to double[][][]

2019-04-09 Thread Egor Ushakov
Egor, I want to re-emphasise that once JDK-8212117 is fixed then this bug should also be fixed. On 5/04/2019 8:30 pm, Egor Ushakov wrote: Hi David, thanks for your comments! I'm not sure how findComponentType worked in the current state: Type findComponentType(String signatu

Re: RFR: 8221503: vmTestbase/nsk/jdb/eval/eval001/eval001.java failes with: com.sun.jdi.InvalidTypeException: Can't assign double[][][] to double[][][]

2019-04-05 Thread Egor Ushakov
wrote: Hi Egor, This doesn't seem right to me sorry ... On 2/04/2019 7:42 pm, Egor Ushakov wrote: Please review the fix this test started to fail after the fix of https://bugs.openjdk.java.net/browse/JDK-8146986 previously any call to ClassLoaderReference.visibleClasses as a

RFR: 8221503: vmTestbase/nsk/jdb/eval/eval001/eval001.java failes with: com.sun.jdi.InvalidTypeException: Can't assign double[][][] to double[][][]

2019-04-02 Thread Egor Ushakov
://bugs.openjdk.java.net/browse/JDK-8221503 cr http://cr.openjdk.java.net/~eushakov/8221503/webrev.00/ Thanks! <http://cr.openjdk.java.net/~eushakov/8221503/webrev.00/> -- Egor Ushakov Software Developer JetBrains http://www.jetbrains.com The Drive to Develop

Re: RFR: 8146986: JDI: Signature lookups for unprepared classes can take a long time

2019-03-23 Thread Egor Ushakov
/vmTestbase/nsk/jdi Thanks, Serguei On 3/22/19 11:51, Egor Ushakov wrote: Thanks for your comments, some jdi test were really failing :( As we switched from TreeSet to HashSet we have to explicitly set signature now. Please review the updated fix: http://cr.openjdk.java.net/~eushakov

Re: RFR: 8146986: JDI: Signature lookups for unprepared classes can take a long time

2019-03-22 Thread Egor Ushakov
new timeouts are observed. Thanks, Serguei On 3/21/19 10:19, Egor Ushakov wrote: > Hi all, please review the fix > > it disables caching for types when signature is not provided as > described in the bug (this is one of the proposed solutions in

RFR: 8146986: JDI: Signature lookups for unprepared classes can take a long time

2019-03-21 Thread Egor Ushakov
Hi all, please review the fix it disables caching for types when signature is not provided as described in the bug (this is one of the proposed solutions in the bug). https://bugs.openjdk.java.net/browse/JDK-8146986 http://cr.openjdk.java.net/~eushakov/8146986/webrev.00/ Thanks! -- Egor

Re: Is it possible to resurrect sa-jdi?

2018-09-05 Thread Egor Ushakov
teman wrote: On 05/09/2018 11:25, Egor Ushakov wrote: Hi, suddenly at Jetbrains we realized that sa pid attach may be useful. Unfortunately sun.jvm.hotspot.jdi* was removed in jdk 9. We would like to resurrect sa-jdi in our jdk fork. As I can see the agent is still there, so it should be feasibl

Is it possible to resurrect sa-jdi?

2018-09-05 Thread Egor Ushakov
that direction or is it a dead end? Thanks! -- Egor Ushakov Software Developer JetBrains http://www.jetbrains.com The Drive to Develop

Re: Connection refused when attaching to java 9 process

2018-08-29 Thread Egor Ushakov
I was connecting from java 8 to java 9, it seems that in this configuration it is not possible any more On 29-Aug-18 13:50, Egor Ushakov wrote: this one I was able to overcome specifying the "hostname=127.0.0.1": >jdb -connect com.sun.jdi.SocketAttach:port=50327,hostname=127.0

Re: Connection refused when attaching to java 9 process

2018-08-29 Thread Egor Ushakov
ConnectException: Connection refused: connect     at java.net.DualStackPlainSocketImpl.connect0(Native Method)     at java.net.DualStackPlainSocketImpl.socketConnect(DualStackPlainSocketImpl.java:79) On 29-Aug-18 13:02, Egor Ushakov wrote: Hi, First, I'm aware about changes in j

Connection refused when attaching to java 9 process

2018-08-29 Thread Egor Ushakov
ion refused: connect     at java.net.DualStackPlainSocketImpl.connect0(Native Method)     at java.net.DualStackPlainSocketImpl.socketConnect(DualStackPlainSocketImpl.java:79) ... Is it possible to connect in this configuration? Thanks! -- Egor Ushakov Software Developer JetBrains http://www.jetbrains.com The Drive to Develop

Re: SA Debug attach to another jvm version possible?

2018-08-21 Thread Egor Ushakov
o:rednaxel...@gmail.com] *Sent:* Tuesday, August 21, 2018 4:18 PM *To:* Egor Ushakov *Cc:* Sharath Ballal; David Holmes; serviceability-dev@openjdk.java.net serviceability-dev@openjdk.java.net *Subject:* Re: SA Debug attach to another jvm version possible? You're probably looking for /jdk.hot

Re: SA Debug attach to another jvm version possible?

2018-08-21 Thread Egor Ushakov
arath -Original Message- From: David Holmes Sent: Tuesday, August 21, 2018 7:47 AM To: Sharath Ballal; Egor Ushakov; serviceability-dev@openjdk.java.net serviceability-dev@openjdk.java.net Subject: Re: SA Debug attach to another jvm version possible? Hi Sharath, On 21/08/2018 3:07 AM, Sharath B

SA Debug attach to another jvm version possible?

2018-08-20 Thread Egor Ushakov
)     at sun.jvm.hotspot.runtime.VM.(VM.java:294)     at sun.jvm.hotspot.runtime.VM.initialize(VM.java:370)     at sun.jvm.hotspot.HotSpotAgent.setupVM(HotSpotAgent.java:431)     ... 13 more Thanks! -- Egor Ushakov Software Developer JetBrains http://www.jetbrains.com The Drive to Develop

Re: Issues debugging java 9 from jdk 8

2018-02-13 Thread Egor Ushakov
the following code:     public boolean canGetModuleInfo() {     validateVM();     return versionInfo().jdwpMajor >= 9;     } Given that, your changes look correct. I'm not an 8u reviewer. You'll need to get the official ok from someone on the 8u list. thanks, Chris On 2/5/18

Issues debugging java 9 from jdk 8

2018-02-05 Thread Egor Ushakov
#x27;ve attached the patch just in case. -- Egor Ushakov Software Developer JetBrains http://www.jetbrains.com The Drive to Develop Index: src/share/classes/com/sun/tools/jdi/VirtualMachineImpl.java IDEA additional info: Subsystem: com.intellij.openapi.diff.imp

Re: RFR: 8194143: remove unneeded casts in LocationImpl and MirrorImpl classes

2018-01-22 Thread Egor Ushakov
Serguei, here is the fixed webrev, sorry for the delay, it took forever to clone the repo. http://cr.openjdk.java.net/~avu/JDK-8194143/webrev.00/ Thanks, Egor On 17-Jan-18 20:37, serguei.spit...@oracle.com wrote: On 1/17/18 09:32, Egor Ushakov wrote: Is the link http://cr.openjdk.java.net

Re: RFR: 8194143: remove unneeded casts in LocationImpl and MirrorImpl classes

2018-01-18 Thread Egor Ushakov
Hi Serguei, I do not see jdk11 repo on http://hg.openjdk.java.net, do I need to use http://hg.openjdk.java.net/jdk/hs? Thanks, Egor On 17-Jan-18 20:37, serguei.spit...@oracle.com wrote: On 1/17/18 09:32, Egor Ushakov wrote: Is the link http://cr.openjdk.java.net/~avu/egor.ushakov/cast_fix

Re: RFR: 8194143: remove unneeded casts in LocationImpl and MirrorImpl classes

2018-01-17 Thread Egor Ushakov
, Serguei Thanks, Serguei On 1/17/18 02:24, David Holmes wrote: Hi Egor, On 17/01/2018 7:15 PM, Egor Ushakov wrote: Hello, Please review and push the fix. This is a formal letter after the discussion on the alias. Bug:https://bugs.openjdk.java.net/browse/JDK-8194143 Webrev:http

Re: RFR: 8194143: remove unneeded casts in LocationImpl and MirrorImpl classes

2018-01-17 Thread Egor Ushakov
, Both webrevs below are from Daniil Titov on the JVMTI bug: JDK-8153629. Also, I expect new webrev is based on the JDK 11 jdk/hs repository and with 2018 copyright comments updated. Thanks, Serguei On 1/17/18 02:24, David Holmes wrote: Hi Egor, On 17/01/2018 7:15 PM, Egor Ushakov wrote

Re: RFR: 8194143: remove unneeded casts in LocationImpl and MirrorImpl classes

2018-01-17 Thread Egor Ushakov
Thanks, Serguei. We have tested this with JTreg tests already. On 17-Jan-18 12:35, serguei.spit...@oracle.com wrote: Thanks, Egor! I'll sponsor the push. Do I have to run the JDI tests, or already tested it with the JTreg JDI tests? Thanks, Serguei On 1/17/18 01:15, Egor Ushakov

RFR: 8194143: remove unneeded casts in LocationImpl and MirrorImpl classes

2018-01-17 Thread Egor Ushakov
Hello, Please review and push the fix. This is a formal letter after the discussion on the alias. Bug:https://bugs.openjdk.java.net/browse/JDK-8194143 Webrev:http://cr.openjdk.java.net/~avu/egor.ushakov/cast_fix/ -- Egor Ushakov Software Developer JetBrains http://www.jetbrains.com The Drive

Re: RFR: cleanup - removed unneeded casts in jdi

2018-01-15 Thread Egor Ushakov
of interfaces and classes this stuff doesn't really seem to be that amenable to supporting alternative implementations of the interfaces. Cheers, David Best regards Christoph -Original Message- From: David Holmes [mailto:david.hol...@oracle.com] Sent: Dienstag, 2. Janu

Re: RFR: cleanup - removed unneeded casts in jdi

2017-12-25 Thread Egor Ushakov
   remove unneeded casts in LocationImpl and MirrorImpl classes On 12/22/17 13:06, David Holmes wrote: Hi Egor, On 23/12/2017 1:32 AM, Egor Ushakov wrote: Hi all, could you please review and sponsor this small cleanup removing unneeded casts in jdi LocationImpl and MirrorImpl. They were

RFR: cleanup - removed unneeded casts in jdi

2017-12-22 Thread Egor Ushakov
do not have rights to create JDK bug report directly, please create it if it is needed for the procedure. Thanks! -- Egor Ushakov Software Developer JetBrains http://www.jetbrains.com The Drive to Develop

Re: Fwd: Re: [PATCH] 6822627: NPE at ReferenceTypeImpl.constantPool

2016-09-02 Thread Egor Ushakov
good for me. -Dmitry On 2016-09-01 20:01, serguei.spit...@oracle.com wrote: I hope, we got a review from Dmitry. Dmitry, please, confirm. Thanks, Serguei On 9/1/16 10:00, serguei.spit...@oracle.com wrote: On 9/1/16 08:41, Egor Ushakov wrote: I've found how to fix this! Add @modules se

Re: [PATCH] 6822627: NPE at ReferenceTypeImpl.constantPool

2016-07-20 Thread Egor Ushakov
ed-by: egor.usha...@jetbrains.com and push it to the jdk9/hs. I hope, somebody will correct me if it is not right. Please, let me know if it works for you. Thanks, Serguei On 7/20/16 02:10, Egor Ushakov wrote: Serguei, thanks for the review! Please sponsor the fix, I do not know how to pr

Re: [PATCH] 6822627: NPE at ReferenceTypeImpl.constantPool

2016-07-20 Thread Egor Ushakov
76 } 77 println("ConstantPoolInfoGC: passed"); But I leave it up to you.No need to see another webrev.I can sponsor your fix, if needed. Thanks, Serguei On 7/19/16 00:07, Egor Ushakov wrote: Hi Serguei, here's a new webrev with a test included: http:/

Re: [PATCH] 6822627: NPE at ReferenceTypeImpl.constantPool

2016-07-19 Thread Egor Ushakov
ilure mode? We have a rule to provide a test coverage for the fixes. Thanks, Serguei On 7/15/16 00:03, Egor Ushakov wrote: Thanks for your comments! I totally agree that the code there requires major refactoring. In the fix I tried not to make it worse and fix the NPE. On 14.07.2016 20:06, M

Re: [PATCH] 6822627: NPE at ReferenceTypeImpl.constantPool

2016-07-15 Thread Egor Ushakov
deeper fix is necessary to be truly correct. For comparison, much of the similar code implementing reflection has been changed to use volatile. But that's a big job, for the serviceability team. On Thu, Jul 14, 2016 at 2:33 AM, Egor Ushakov mailto:egor.usha...@jetbrains.com>> wrot

[PATCH] 6822627: NPE at ReferenceTypeImpl.constantPool

2016-07-14 Thread Egor Ushakov
check for that. I've added it to the check inside getConstantPoolInfo to request the bytes again in this case. BUGURL: https://bugs.openjdk.java.net/browse/JDK-6822627 WEBREV: http://cr.openjdk.java.net/~avu/JDK-6822627/webrev.00/ Thanks! -- Egor Ushakov Software Developer JetBrains http://ww

Re: Long standing groovy step into issue

2014-01-30 Thread Egor Ushakov
you tried this with? There was a bug fix for invokedynamic and line numbers that may or may not be relevant in jdk8-b115: https://bugs.openjdk.java.net/browse/JDK-8026508 /Staffan On 30 jan 2014, at 11:33, Egor Ushakov wrote: Hi guys! there is a long standing issue (on groovy) https://ji

Long standing groovy step into issue

2014-01-30 Thread Egor Ushakov
Hi guys! there is a long standing issue (on groovy) https://jira.codehaus.org/browse/GROOVY-4063, that does not allow to do correct step into: java debugger just skips the user code together with the code in stepping filters. If breakpoint is set in user code it stops where expected. Could som