Re: RFR: 8287496: Alternative virtual thread implementation that maps to OS thread

2022-05-31 Thread ExE Boss
On Sun, 29 May 2022 14:46:39 GMT, Alan Bateman wrote: > This patch adds an alternative virtual thread implementation where each > virtual thread is backed by an OS thread. It doesn't scale but it can be used > by ports that don't have continuations support in the VM. Aside from > scalability,

Re: RFR: 8284161: Implementation of Virtual Threads (Preview) [v5]

2022-04-21 Thread ExE Boss
On Thu, 21 Apr 2022 11:35:57 GMT, Alan Bateman wrote: >> This is the implementation of JEP 425: Virtual Threads (Preview); TBD which >> JDK version to target. >> >> We will refresh this PR periodically to pick up changes and fixes from the >> loom repo. >> >> Most of the new mechanisms in the

Re: RFR: 8284161: Implementation of Virtual Threads (Preview) [v4]

2022-04-18 Thread ExE Boss
On Sun, 17 Apr 2022 16:03:30 GMT, Alan Bateman wrote: >> This is the implementation of JEP 425: Virtual Threads (Preview); TBD which >> JDK version to target. >> >> We will refresh this PR periodically to pick up changes and fixes from the >> loom repo. >> >> Most of the new mechanisms in the

Re: RFR: 8284161: Implementation of Virtual Threads (Preview) [v2]

2022-04-16 Thread ExE Boss
On Wed, 13 Apr 2022 14:21:20 GMT, Alan Bateman wrote: >> This is the implementation of JEP 425: Virtual Threads (Preview); TBD which >> JDK version to target. >> >> We will refresh this PR periodically to pick up changes and fixes from the >> loom repo. >> >> Most of the new mechanisms in the

Re: RFR: 8280035: Use Class.isInstance instead of Class.isAssignableFrom where applicable

2022-04-15 Thread ExE Boss
On Mon, 21 Feb 2022 12:16:53 GMT, Andrey Turbanov wrote: >> I've stared at the javadoc for Class.isAssignableFrom and Class.isInstance >> and if a non-null instance is used to get a non-null class they are PROBABLY >> the same but it is far from clear. The implementations of both are at least

Re: RFR: 8284161: Implementation of Virtual Threads (Preview)

2022-04-13 Thread ExE Boss
On Tue, 12 Apr 2022 19:09:32 GMT, Daniel Jeliński wrote: >> This is the implementation of JEP 425: Virtual Threads (Preview); TBD which >> JDK version to target. >> >> We will refresh this PR periodically to pick up changes and fixes from the >> loom repo. >> >> Most of the new mechanisms in

Re: RFR: 8284161: Implementation of Virtual Threads (Preview)

2022-04-13 Thread ExE Boss
On Wed, 13 Apr 2022 09:49:04 GMT, Daniel Fuchs wrote: >>> Not sure if that even matters - but there will be a slight change of >>> behaviour here if `InternalLock.CAN_USE_INTERNAL_LOCK` is ever `false`. >>> Instead of synchronizing on `in`, the `BufferedReader` will synchronize on >>> `this`.

Re: RFR: 8284161: Implementation of Virtual Threads (Preview)

2022-04-11 Thread ExE Boss
On Mon, 11 Apr 2022 07:12:09 GMT, Alan Bateman wrote: >> src/java.base/share/classes/jdk/internal/misc/StructureViolationExceptions.java >> line 81: >> >>> 79: Constructor ctor; >>> 80: try { >>> 81: Class exClass = >>> Class.forName("jdk.incubator.concurrent.Struct

Re: RFR: 8284161: Implementation of Virtual Threads (Preview)

2022-04-09 Thread ExE Boss
On Fri, 8 Apr 2022 13:43:39 GMT, Alan Bateman wrote: > This is the implementation of JEP 425: Virtual Threads (Preview); TBD which > JDK version to target. > > We will refresh this PR periodically to pick up changes and fixes from the > loom repo. > > Most of the new mechanisms in the HotSpot

Re: RFR: 8280035: Use Class.isInstance instead of Class.isAssignableFrom where applicable

2022-03-21 Thread ExE Boss
On Mon, 21 Feb 2022 12:16:53 GMT, Andrey Turbanov wrote: > Method `isAssignableFrom` is opposite: it brings unnecessary complexity in > the code. And it's easy to confuse orders of parameters. Even JBS confirms > that: Maybe we should add `Class::isSubclassOf(Class that)` that performs `that.