Re: RFR (XS): 8173936 [TESTBUG] test/serviceability/jvmti/ModuleAwareAgents/ClassFileLoadHook/MAAClassFileLoadHook.java needs to be re-examined

2017-10-17 Thread George Triantafillou
Hi Serguei, This looks good. -George On 10/17/2017 1:35 AM, serguei.spit...@oracle.com wrote: Please, review a fix for the test bug: https://bugs.openjdk.java.net/browse/JDK-8173936 Webrev: http://cr.openjdk.java.net/~sspitsyn/webrevs/2017/hotspot/8173936-MAA-cflh.1/ Summary:   This test e

Re: RFR 8149790: NegativeArraySizeException with hprof

2017-08-15 Thread George Triantafillou
Thanks Christian. -George On 8/15/2017 4:28 PM, Christian Tornqvist wrote: Hi George, This looks good. Thanks, Christian On Aug 14, 2017, at 11:31 AM, George Triantafillou <mailto:george.triantafil...@oracle.com>> wrote: Please review this change to fix NegativeArraySizeExcep

Re: RFR 8149790: NegativeArraySizeException with hprof

2017-08-14 Thread George Triantafillou
Hi Lois, Thanks for the review. I'll update the copyrights. -George On 8/14/2017 4:08 PM, Lois Foltan wrote: George, I think this looks good. Copyright needs updating in FileReadBuffer.java, MappedReadBuffer.java & ReadBuffer.java. Thanks, Lois On 8/14/2017 11:31 A

RFR 8149790: NegativeArraySizeException with hprof

2017-08-14 Thread George Triantafillou
Please review this change to fix NegativeArraySizeException test failures with hprof: JBS: https://bugs.openjdk.java.net/browse/JDK-8149790 webrev: http://cr.openjdk.java.net/~gtriantafill/8149790-webrev/webrev/index.html

Re: RFR 8160833: ClassesByName2Test.java and RedefineCrossEvent.java failing with jtreg tip

2016-08-03 Thread George Triantafillou
Hi David, Thanks for your review. On 8/2/2016 9:49 PM, David Holmes wrote: Hi George, On 3/08/2016 4:49 AM, George Triantafillou wrote: Please review this small change to fix test failures in two JDI tests: There's only one test changed in the webrev ?? RedefineCrossEvent.java simply

Re: RFR 8160833: ClassesByName2Test.java and RedefineCrossEvent.java failing with jtreg tip

2016-08-03 Thread George Triantafillou
Thanks Dan! -George On 8/2/2016 3:50 PM, Daniel D. Daugherty wrote: Adding serviceability-dev@... alias since these are JDI tests... Dan On 8/2/16 12:49 PM, George Triantafillou wrote: Please review this small change to fix test failures in two JDI tests: JBS: https

Re: hg: hsx/hotspot-rt/hotspot: 8028160: [TESTBUG] Exclude failing (runtime) jtreg tests using @ignore

2013-12-02 Thread George Triantafillou
Thanks Harold for pushing the fix. Thanks also to my reviewers for your time. -George On 11/26/2013 6:11 PM, harold.sei...@oracle.com wrote: Changeset: e567d5afd4dd Author:hseigel Date: 2013-11-26 16:03 -0500 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/e567d5afd4