B/c @modules affect all actions, such location can confuse people into thinking
that it affects only the next one (or all the following).
— Igor
> On May 2, 2020, at 8:46 AM, Alan Bateman wrote:
>
> On 02/05/2020 16:39, Igor Ignatyev wrote:
>> Hi Alan,
>>
>> it looks good, but could you ple
Thanks Chris. I can’t help but wonder if we should move all tests from
serviceability/logging to runtime then.
— Igor
> On Apr 24, 2020, at 3:53 PM, Chris Plummer wrote:
>
> Adding hotspot-runtime-dev since logging is owned by runtime, not
> serviceability.
>
> Chris
>
>> On 4/24/20 3:41
Thanks Chris! Would you consider this trivial or should I wait for another
review?
— Igor
> On Apr 9, 2020, at 8:35 PM, Chris Plummer wrote:
>
>
> Hi Igor,
>
> The changes looks good.
>
> thanks,
>
> Chris
>
>> On 4/9/20 4:13 PM, Igor Ignatyev wrote:
>> Hi Chris,
>>
>> I looked what tra
LGTM
— Igor
> On Apr 5, 2020, at 11:49 PM, Chris Plummer wrote:
>
> [Sorry about the resend. Subject wasn't quite right the first time.]
>
> Hello,
>
> Please help review the following:
>
> https://bugs.openjdk.java.net/browse/JDK-8242168
> http://cr.openjdk.java.net/~cjplummer/8242168/webr
Reviewed.
— Igor
> On Mar 18, 2020, at 3:18 PM, Leonid Mesnik wrote:
>
>
>
>
> On 3/18/20 2:30 PM, Igor Ignatyev wrote:
>>> I need more time to get grasp of Wicket and your changes in it; will come
>>> back to you after I understand them.
>> ok, now when I believe that I have enough unde
> On Mar 16, 2020, at 11:43 AM, "serguei.spit...@oracle.com"
> wrote:
>
>
>> On 3/16/20 11:26, Chris Plummer wrote:
>> I had to make another change. TestMutuallyExclusivePlatformPredicates.java
>> failed when I ran tier 3. I had fixed it a long while back due to
>> Platform.shouldSAAttach(
rather like this :
> } catch (InterruptedException e) {
>Thread.currentThread().interrupt();
>return false; // assume not signed
> }
— Igor
> On Feb 11, 2020, at 6:15 PM, Chris Plummer wrote:
>
>
> Like this?
>
> } catch (InterruptedException e) {
> Thread.curren
LGTM
— Igor
>> On Dec 20, 2019, at 4:42 PM, Daniil Titov wrote:
> Please a review a changeset below that removes
> vmTestbase/nsk/jvmti/scenarios/hotswap/HS102/hs102t002/TestDescription.java
> and runtime/appcds/cacheObject/RedefineClassTest.java tests from
> test/hotspot/jtreg/ProblemList-g
Hi Per,
> On Sep 26, 2019, at 2:32 PM, Per Liden wrote:
>
> Hi Igor,
>
> I don't think it belongs in the problem list, for two reasons:
>
> 1) The test doesn't fail because of a bug. It fails because ZGC doesn't
> currently support that use case. In other words, the test shouldn't be
> test
