Re: RFR: 8283903: GetContainerCpuLoad does not return the correct result in share mode [v2]

2022-03-29 Thread Jie Fu
On Wed, 30 Mar 2022 02:08:16 GMT, xpbob wrote: >> ``` >>long hostTicks = getHostTotalCpuTicks0(); >> int totalCPUs = getHostOnlineCpuCount0(); >> int containerCPUs = getAvailableProcessors(); >> // scale the total host load t

Re: RFR: 8283903: GetContainerCpuLoad does not return the correct result in share mode

2022-03-29 Thread Jie Fu
On Wed, 30 Mar 2022 02:44:52 GMT, xpbob wrote: > GetHostTotalCpuTicks0 is correct > (GetHostTotalCpuTicks0() * containerCPUs) will overflowed Okay. It makes sense for this case. Maybe, there is no way to prevent the overflow of `hostTicks ` returned by `getHostTotalCpuTicks0()`. So the change

Re: RFR: 8283903: GetContainerCpuLoad does not return the correct result in share mode

2022-03-29 Thread Jie Fu
On Wed, 30 Mar 2022 02:29:47 GMT, xpbob wrote: > In share mode, the process runs for a long time and the number of physical > machine cores is large, making it easier to reappear. So if we run long enough, the `getHostTotalCpuTicks0()` may return overflowed `hostTicks`, right? -

Re: RFR: 8283903: GetContainerCpuLoad does not return the correct result in share mode

2022-03-29 Thread Jie Fu
On Wed, 30 Mar 2022 01:46:20 GMT, xpbob wrote: > ``` >long hostTicks = getHostTotalCpuTicks0(); > int totalCPUs = getHostOnlineCpuCount0(); > int containerCPUs = getAvailableProcessors(); > // scale the total host load to the

Re: RFR: 8283728: jdk.hotspot.agent: Wrong location for RISCV64ThreadContext.java

2022-03-27 Thread Jie Fu
On Sun, 27 Mar 2022 08:59:40 GMT, Christoph Langer wrote: > Fix risv64 -> riscv64 Looks reasonable to me. - Marked as reviewed by jiefu (Reviewer). PR: https://git.openjdk.java.net/jdk/pull/7977

Re: RFR: 8283279: [Testbug] Improve TestGetSwapSpaceSize [v2]

2022-03-23 Thread Jie Fu
On Wed, 23 Mar 2022 09:27:07 GMT, Severin Gehwolf wrote: >> Please review this container test improvement. The test in question only >> makes sense iff the total swap space size as reported by the container aware >> OperatingSystemMXBean is `0`. If that's not the case, then something else >> m

Re: RFR: 8283279: [Testbug] Improve TestGetSwapSpaceSize

2022-03-22 Thread Jie Fu
On Thu, 17 Mar 2022 13:40:53 GMT, Severin Gehwolf wrote: > Please review this container test improvement. The test in question only > makes sense iff the total swap space size as reported by the container aware > OperatingSystemMXBean is `0`. If that's not the case, then something else > might

Re: RFR: 8276139: TestJpsHostName.java not reliable, better to expand HostIdentifierCreate.java test

2021-10-29 Thread Jie Fu
On Fri, 29 Oct 2021 11:29:32 GMT, Kevin Walls wrote: > Remove a specific test which invokes jps on a fictional process, and can > timeout and fail. > Instead, add to the patterns used in > open/test/jdk/sun/jvmstat/monitor/HostIdentifier/HostIdentifierCreate.java > which will perform the same

Re: RFR: 8276139: TestJpsHostName.java not reliable, better to expand HostIdentifierCreate.java test

2021-10-29 Thread Jie Fu
On Fri, 29 Oct 2021 11:29:32 GMT, Kevin Walls wrote: > Remove a specific test which invokes jps on a fictional process, and can > timeout and fail. > Instead, add to the patterns used in > open/test/jdk/sun/jvmstat/monitor/HostIdentifier/HostIdentifierCreate.java > which will perform the same

Re: RFR: 8276139: TestJpsHostName.java not reliable, better to expand HostIdentifierCreate.java test

2021-10-29 Thread Jie Fu
On Fri, 29 Oct 2021 11:29:32 GMT, Kevin Walls wrote: > Remove a specific test which invokes jps on a fictional process, and can > timeout and fail. > Instead, add to the patterns used in > open/test/jdk/sun/jvmstat/monitor/HostIdentifier/HostIdentifierCreate.java > which will perform the same

Re: [jdk17] RFR: 8067223: [TESTBUG] Rename Whitebox API package [v2]

2021-08-01 Thread Jie Fu
On Sat, 31 Jul 2021 20:42:10 GMT, Igor Ignatyev wrote: >> Hi all, >> >> could you please review this big tedious and trivial(-ish) patch which moves >> `sun.hotspot.WhiteBox` and related classes to `jdk.test.whitebox` package? >> >> the majority of the patch is the following substitutions: >>

Re: RFR: 8270901: Typo PHASE_CPP in CompilerPhaseType [v2]

2021-07-28 Thread Jie Fu
On Wed, 28 Jul 2021 08:06:56 GMT, Yi Yang wrote: >> Should be PHASE_CCP instead of PHASE_CPP, it also affects dumped ideal graph >> XML. > > Yi Yang has updated the pull request incrementally with one additional commit > since the last revision: > > update copyright year For hotspot changes

Re: RFR: 8270901: Typo PHASE_CPP in CompilerPhaseType

2021-07-28 Thread Jie Fu
On Wed, 28 Jul 2021 07:19:08 GMT, Yi Yang wrote: > Should be PHASE_CCP instead of PHASE_CPP, it also affects dumped ideal graph > XML. Looks good to me. The copyright year should also be updated. Thanks. - Marked as reviewed by jiefu (Reviewer). PR: https://git.openjdk.java.net/

Re: RFR: 8269851: OperatingSystemMXBean getProcessCpuLoad reports incorrect process cpu usage in containers [v8]

2021-07-27 Thread Jie Fu
On Wed, 14 Jul 2021 04:00:39 GMT, xpbob wrote: >> …ocess cpu usage in containers > > xpbob has updated the pull request incrementally with one additional commit > since the last revision: > > Add comments Will sponsor it tomorrow if there is no objection. Thanks. - PR: https:

Re: RFR: 8270814: ProblemList the failing serviceability/jvmti/HeapMonitor/MyPackage/HeapMonitor* tests

2021-07-15 Thread Jie Fu
On Fri, 16 Jul 2021 06:02:05 GMT, David Holmes wrote: > Two tests have started failing regularly in our CI testing, and also in GHA, > so I'm ProblemListing them until the issue can be resolved. > > Thanks, > David Marked as reviewed by jiefu (Reviewer). - PR: https://git.openjdk

Re: RFR: 8260878: com/sun/jdi/JdbOptions.java fails without jfr

2021-02-02 Thread Jie Fu
On Tue, 2 Feb 2021 20:46:08 GMT, Alex Menkov wrote: >> Hi all, >> >> com/sun/jdi/JdbOptions.java fails in our ci/cd when jfr is disabled. >> It would be better to fix it. >> >> Thanks. >> Best regards, >> Jie > > Marked as reviewed by amenkov (Reviewer). Thanks @alexmenkov and @plummercj . --

Integrated: 8260878: com/sun/jdi/JdbOptions.java fails without jfr

2021-02-02 Thread Jie Fu
On Tue, 2 Feb 2021 03:43:29 GMT, Jie Fu wrote: > Hi all, > > com/sun/jdi/JdbOptions.java fails in our ci/cd when jfr is disabled. > It would be better to fix it. > > Thanks. > Best regards, > Jie This pull request has now been integrated. Changeset: a47befc

Re: RFR: 8260878: com/sun/jdi/JdbOptions.java fails without jfr

2021-02-01 Thread Jie Fu
On Tue, 2 Feb 2021 04:09:24 GMT, Chris Plummer wrote: >> Hi all, >> >> com/sun/jdi/JdbOptions.java fails in our ci/cd when jfr is disabled. >> It would be better to fix it. >> >> Thanks. >> Best regards, >> Jie > > test/jdk/com/sun/jdi/JdbOptions.java line 99: > >> 97: test("-connect",

RFR: 8260878: com/sun/jdi/JdbOptions.java fails without jfr

2021-02-01 Thread Jie Fu
Hi all, com/sun/jdi/JdbOptions.java fails in our ci/cd when jfr is disabled. It would be better to fix it. Thanks. Best regards, Jie - Commit messages: - 8260878: com/sun/jdi/JdbOptions.java fails without jfr Changes: https://git.openjdk.java.net/jdk/pull/2346/files Webrev: https