Re: RFR JDK-8005120

2013-01-17 Thread John Zavgren
.openjdk.java.net/~jzavgren/8005120/webrev.07/ <http://cr.openjdk.java.net/%7Ejzavgren/8005120/webrev.07/> Thank you! John Zavgren john.zavg...@oracle.com On 12/20/2012 05:47 PM, John Zavgren wrote: Greetings: I modified my changes so that windows knows the definition of the POSIX data

Re: RFR JDK-8005120

2013-01-08 Thread John Zavgren
On 12/28/2012 10:49 AM, John Zavgren wrote: Please consider the following webrev for JDK-8005120. http://cr.openjdk.java.net/~mullan/webrevs/jzavgren/8005120/webrev.06/ (I apologize for overlooking an error in the windows code that I created in my previous release. ) Thanks! John Zavgren

Re: RFR JDK-8005120

2012-12-28 Thread John Zavgren
Greetings: I modified windows source code files so they pass size_t for buffer sizes and socklen_t for address structures. http://cr.openjdk.java.net/~mullan/webrevs/jzavgren/8005120/webrev.03/ Please let me know what you think. Thanks! On 12/26/2012 02:56 PM, John Zavgren wrote

Re: RFR JDK-8005120

2012-12-26 Thread John Zavgren
Greetings: I modified the windows code so that it uses socklen_t to specify the lengths of data structures, parameter lengths, etc. instead of ints (which can be negative.) http://cr.openjdk.java.net/~mullan/webrevs/jzavgren/8005120/webrev.02/ Thanks! John Zavgren On 12/20/2012 05:47 PM

Re: RFR JDK-8005120

2012-12-20 Thread John Zavgren
1/ Thanks! John Zavgren On 20/12/2012 13:49, John Zavgren wrote: > Greetings: > > I agree that the "correct" way to fix this problem is to use POSIX data > types, e.g., socklen_t. However, when I switch to the doctrinaire data type, > the build fails on windows machin

Re: RFR JDK-8005120

2012-12-20 Thread John Zavgren
r-sign] >> ../../../../src/share/transport/socket/sysSocket.h:41:5: note: expected >> 'uint32_t *' but argument is of type 'int *' >> >> Do you see these in your build? >> >> -Chris. >> >> On 12/19/2012 03:42 PM, Alan Bateman wrote: >