ote:
>
> Hi Karen,
>
> Thank you for sorting this out!
>
>
> On 2/21/18 09:55, Karen Kinnear wrote:
>> Dan,
>>
>> Thank you for all the background digging. This is really helpful.
>>
>> Serguei - do you know what tests exist for this behavior?
&
;mailto:serguei.spit...@oracle.com> wrote:
>>>> Hi Karen and David,
>>>>
>>>>
>>>> On 2/20/18 19:52, David Holmes wrote:
>>>>> Hi Karen,
>>>>>
>>>>> On 21/02/2018 1:54 AM, Karen Kinnear wrote:
>
Folks,
As part of the Valhalla EG discussions for JVMTI changes for nestmates (thank
you Serguei and David),
IBM brought up a request that we update the JVMTI documentation to reflect that
we allow addition
of private methods.
Is there a reason we do not document this? I’m inviting those who we
Just a note - unified logging belongs to runtime.
thanks,
Karen
> On Dec 6, 2017, at 1:33 AM, David Holmes wrote:
>
> On 1/12/2017 11:15 AM, Man Cao wrote:
>> Thanks David for the quick response!
>> Yes, I understand completely removing defaultStream and tty is probably
>> infeasible.
>> If de
Jiangli,
Thank you so much for picking up this bug fix, I very much appreciate that.
I agree with not quitting the vm on agent attach.
I actually think we also want the agent attach to succeed - see below.
> On Jul 7, 2016, at 9:56 PM, Ioi Lam wrote:
>
> (Adding serviceability-dev@openjdk.java.
Vote: yes
> On Jul 7, 2016, at 7:48 PM, Daniel D. Daugherty
> wrote:
>
> I hereby nominate Staffan Larsen to Serviceability Group Lead [1].
>
> Staffan is a Reviewer in the jdk9 and jdk8u Projects, a member of the
> Serviceability team, and has so far committed > 145 changesets. He is the
> Ser
Markus,
It would be helpful if you could find a place to record a comment about the
JfrStream_lock - that the rank needs to
be between safe point and JfrBuffer_lock. That way, should we do cleanup in
this area we will know the constraints.
thanks,
Karen
> On Feb 24, 2016, at 2:30 PM, Ka
Markus,
See below.
> On Feb 23, 2016, at 11:58 PM, David Holmes wrote:
>
> Hi Markus,
>
> On 23/02/2016 8:00 PM, Markus Gronlund wrote:
>> Thanks for taking a look David,
>>
>> I have verified the new lock rankings by running Kitchensink and by code
>> inspection.
>>
>> The original intent w
Dan,
I did not do a complete review - I have been following the conversation and you
all seem to have this completely
in hand so I didn't jump in. Yell if need more.
thanks,
Karen
On Sep 2, 2015, at 3:27 PM, Daniel D. Daugherty wrote:
> On 9/2/15 12:50 PM, Karen Kinnear wrote
Dan,
Can you possibly change the two "in a parallel" to "in parallel" ?
thanks,
Karen
On Sep 2, 2015, at 1:06 PM, Tom Benson wrote:
> Looks good to me!
> Tnx,
> Tom
>
> On 9/2/2015 12:40 PM, Daniel D. Daugherty wrote:
>> Just for the record, here are the comment context diffs:
>>
>> $ diff -c
\
> ma -> bind(skip_sample);\
> } \
> } while(0)
>
> It's not all that hard to port to additional architectures, but we'll have to
> think about
Jeremy,
Did I follow this correctly - that your approach modifies the compilers and
interpreters and Tony's modifies the
common allocation code?
Given that the number of compilers and interpreters and interpreter platforms
keeps expanding - I'd like to
add a vote to have heap allocation profili
So I am in agreement on the CLD* - sorry for the earlier suggestion.
thanks,
Karen
On Feb 11, 2015, at 3:04 AM, Staffan Larsen wrote:
> This version looks good to me!
>
> Small comments inline.
>
>> On 11 feb 2015, at 04:13, Chris Plummer wrote:
>>
>> Hi Staffan,
>>
>> Thanks for your feedb
u clarify what you mean by "address of the j.l.ClassLoader class". Is
> that the Klass* for the ClassLoader subclass, or the actual address of the
> ClassLoader instance in the heap, which can change.
>
> Chris
>
> On 2/6/15 1:21 PM, Karen Kinnear wrote:
>> Chris,
&
Chris,
So I was curious - I was thinking you would printing the hex address of the
j.l.ClassLoader class rather than the cld so that if folks were to look
at a heap dump later it might be meaningful to them. Is it unlikely that they
would ever want to correlate those?
On Feb 6, 2015, at 3:15 P
Chris,
I filed JDK-8068830 to capture the request I had to print the super types of
a given class - so you don't have to deal with that as part of this exercise.
thanks,
Karen
On Jan 9, 2015, at 12:53 PM, Karen Kinnear wrote:
> Thanks Frederic for suggesting two different dcmds - th
AM, Frederic Parain wrote:
>
>
> On 01/08/2015 10:29 PM, Chris Plummer wrote:
>> Hi Karen,
>>
>> Comments inline.
>>
>> On 1/8/15 8:07 AM, Karen Kinnear wrote:
>>> Chris,
>>>
>>> Thank you for doing this. I had a couple of qu
---
>1: 945 117736 java.lang.Object/0x12345600
>2: 442 50352 java.util.List/0x12345605
>3: 499 25288 java.util.AbstractList/0x12345607
>
>
>
> /Staffan
>
>> On 9 jan 2015, at 09:53,
Chris,
Thank you for doing this. I had a couple of questions/comments.
I like your idea of being able to start with a specific class to show all
subclasses of.
I think the way I read the code this shows the superclass hierarchy, not the
superinterfaces. With the addition
of default methods in
Dan,
Code looks good. This makes sense to me. Thank you for the detailed comments
and testing.
thanks,
Karen
p.s. sorry - you would think getting three copies of the review request would
mean
I would not completely overlook this in my emails :-)
On Feb 21, 2014, at 10:40 PM, Daniel D. Daugher
o believe we do not plan to backport.
thank you for the detailed walk-through,
Karen
On Feb 10, 2014, at 1:55 PM, Daniel D. Daugherty wrote:
> On 2/9/14 8:37 PM, David Holmes wrote:
>> trimming content ...
>>
>> On 8/02/2014 9:45 AM, Daniel D. Daugherty wrote:
>>> O
Dan,
Greatly impressed. Very subtle. Thanks to you and David and Dice and Serguei
for a lot of blood, sweat and tears.
Apologies that I haven't been following all the details, so a couple of
questions.
1. I like the new fix. I totally appreciate the massive documentation in the
bug, it really
Changeset: 379f11bc04fc
Author:acorn
Date: 2013-12-03 11:13 -0800
URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/379f11bc04fc
8028438: static superclass method masks default methods
Reviewed-by: hseigel, lfoltan, coleenp
! src/share/vm/classfile/defaultMethods.cpp
! src
Changeset: 7a58803b5069
Author:acorn
Date: 2013-12-03 08:36 -0800
URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/7a58803b5069
8026066: ICCE for invokeinterface static
Reviewed-by: coleenp, lfoltan, hseigel
! src/share/vm/interpreter/linkResolver.cpp
! src/share/vm/inter
Changeset: fce21ac5968d
Author:acorn
Date: 2013-11-13 07:31 -0800
URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/fce21ac5968d
8027229: ICCE expected for >=2 maximally specific default methods.
Summary: Need to process defaults for interfaces for invokespecial
Reviewed-by
Changeset: fdd464c8d62e
Author:acorn
Date: 2013-10-30 09:11 -0700
URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/fdd464c8d62e
8027304: Lambda: inheriting abstract + 1 default -> default, not ICCE
Reviewed-by: hseigel, zgu
! src/share/vm/classfile/defaultMethods.cpp
Cha
Changeset: e39b138b2518
Author:acorn
Date: 2013-10-19 18:32 -0400
URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/e39b138b2518
8026893: Push 8026365 to TL early and add test
Reviewed-by: dcubed, kamg
! src/share/vm/classfile/verifier.cpp
! test/TEST.groups
+ test/runtime/802636
Changeset: 2f8728d92483
Author:acorn
Date: 2013-10-14 21:52 -0400
URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/2f8728d92483
8026299: invokespecial gets ICCE when it should get AME.
Reviewed-by: ccheung, coleenp
! src/share/vm/interpreter/linkResolver.cpp
! src/share/v
Changeset: d25557d03ec0
Author:acorn
Date: 2013-10-09 17:57 -0400
URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/d25557d03ec0
8026185: nsk/jvmit/GetMethodDeclaringClass/declcls001 failed
Summary: Missed initialization. Thanks Coleen.
Reviewed-by: coleenp, minqi
! src/sh
Changeset: c72075c2883e
Author:acorn
Date: 2013-10-08 16:58 -0400
URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/c72075c2883e
8026022: Verifier: allow anon classes to invokespecial host class/intf methods.
Reviewed-by: coleenp, bharadwaj
! src/share/vm/classfile/verifie
Changeset: ac9cb1d5a202
Author:acorn
Date: 2013-10-07 12:20 -0400
URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/ac9cb1d5a202
8009130: Lambda: Fix access controls, loader constraints.
Summary: New default methods list with inherited superinterface methods
Reviewed-by: mi
Changeset: 36b97be47bde
Author:acorn
Date: 2013-10-01 08:10 -0400
URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/36b97be47bde
8011311: Private interface methods. Default conflicts:ICCE. no
erased_super_default.
Reviewed-by: coleenp, bharadwaj, minqi
! src/share/vm/clas
Changeset: 42863137168c
Author:acorn
Date: 2013-09-16 17:57 -0400
URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/42863137168c
8024647: Default method resolution with private superclass method
Reviewed-by: kamg, minqi
! src/share/vm/classfile/defaultMethods.cpp
Changese
Changeset: 3a1df0dce3e5
Author:acorn
Date: 2013-08-30 15:15 -0400
URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/3a1df0dce3e5
8023872: Verification error in generated lambda classes
Summary: skip verification for generated lambda classes
Reviewed-by: kamg, dholmes
! src
Changeset: 915cc4f3fb15
Author:acorn
Date: 2013-08-28 08:15 -0400
URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/915cc4f3fb15
8020489: VM crash when non-existent interface called by invokespecial
Reviewed-by: kamg, coleenp
! src/share/vm/classfile/defaultMethods.cpp
Changeset: 91b93f523ec6
Author:acorn
Date: 2013-08-26 11:35 -0400
URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/91b93f523ec6
8012294: remove generic handling for default methods
Reviewed-by: kamg, coleenp
! src/share/vm/classfile/classFileParser.cpp
! src/share/vm/clas
Looks good.
thanks,
Karen
On Aug 21, 2013, at 7:11 AM, Markus Grönlund wrote:
> Greetings,
>
> Kindly asking for reviews for the following:
>
> Bugid: http://bugs.sun.com/view_bug.do?bug_id=8023457
>
> Webrev: http://cr.openjdk.java.net/~mgronlun/8023457/webrev01/
>
> Thanks
> Markus
Code looks good.
thanks,
Karen
On Jul 25, 2013, at 11:21 AM, Erik Gahlin wrote:
> Hello,
>
> Could you be so kind and review this small change. The fix is targeted for
> jdk7u40, and the hook is needed to have a leak free event tracing
> implementation.
>
> http://cr.openjdk.java.net/~egahli
Code looks good. Thank you for the assertions and comments.
Cleanly done, as usual for your changes Rickard.
thanks,
Karen
On Jul 17, 2013, at 8:22 AM, Rickard Bäckman wrote:
> Sorry everyone, wrong bugnr in the topic.
> It should be 8020701.
>
> /R
>
> On Jul 17, 2013, at 1:58 PM, Rickard Bä
Markus,
Looks good.
(Ok, I miss the comment about j.l.Thread :-)
ship it!
Karen
On Jul 16, 2013, at 11:48 AM, Markus Grönlund wrote:
> Greetings,
>
> Kindly asking for reviews for the following change in hsx24:
>
> Bugid: http://bugs.sun.com/view_bug.do?bug_id=8020547
>
> Webrev: http://c
Changeset: 50257d6f5aaa
Author:acorn
Date: 2013-07-09 14:02 -0400
URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/50257d6f5aaa
8013635: VM should no longer create bridges for generic signatures.
Summary: Requires: 8013789: Compiler bridges, 8015402: metafactory
Reviewed-b
Changeset: d9b08d62b95e
Author:acorn
Date: 2013-05-02 10:58 -0400
URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/d9b08d62b95e
8010783: assert(s->refcount() != 0) failed: for create_overpasses
Reviewed-by: kvn, dcubed
! src/share/vm/classfile/bytecodeAssembler.cpp
Chang
Staffan,
Code looks good. Many thanks for fixing this - sorry we missed this when
adding the default method handling.
thanks,
Karen
On May 2, 2013, at 1:39 PM, serguei.spit...@oracle.com wrote:
> On 5/2/13 8:26 AM, Staffan Larsen wrote:
>>
>> On 2 maj 2013, at 16:33, Robert Field wrote:
>>
>
Frederic,
Code looks good - actually it looks very clean. Ship it.
Couple of minor comments that don't require re-review:
1. nmtDCmd.hpp/cpp - copyrights 2012 -> 2012, 2013
2. jmm.h
line 213: "True is" -> "True if"
3. diagnosticFramework.hpp
Thank you for the comments!
line 298 "rational
Markus,
Looks good.
Minor comments:
1. systemDictionary.cpp
Does the post_class_load_event internal logic want to be #ifdef
INCLUDE_TRACE/#endif
so it builds with embedded?
2. tracestream.hpp
print_val (both)
- don't you need a ResourceMark rm to use as_C_string() and
name_and_sig_as_C_st
Changeset: cd3089a56438
Author:acorn
Date: 2013-03-27 14:10 -0400
URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/cd3089a56438
8009731: Confusing error message for loader constraint violation
Summary: Fix text, overwritten type and holder for resolved method
Reviewed-by:
Changeset: d254a5f9b93f
Author:acorn
Date: 2013-03-27 13:40 -0400
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/d254a5f9b93f
8010846: Update the corresponding test in test/vm/verifier/TestStaticIF.java
Summary: Remove test flag -XX:-UseSplitVerifier, not supported classfile 52
Rev
Coleen,
Looks good.
thanks,
Karen
On Mar 26, 2013, at 6:11 PM, Coleen Phillimore wrote:
> Summary: Neglected to copy the annotations in clone_with_new_data when they
> were moved to ConstMethod.
>
> open webrev at http://cr.openjdk.java.net/~coleenp/8009531/
> bug link at http://bugs.sun.com/
Changeset: 2c7663baeb67
Author:acorn
Date: 2013-03-20 11:43 -0400
URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/2c7663baeb67
8010017: lambda: reflection get(Declared)Methods support for default methods.
Summary: Don't expose vm generated overpass (bridges to default met
Code looks good. I did not study the details (again) for the monitor owner, but
my memory is that there are other cases in which the monitor owner can be
temporarily null, so this is will help there also.
thanks,
Karen
On Feb 26, 2013, at 6:54 PM, Daniel D. Daugherty wrote:
> Greetings,
>
> I h
Thanks for the explanation. The guarantee should let us know we are
in that situation.
thanks,
Karen
On Feb 20, 2013, at 1:48 PM, Daniel D. Daugherty wrote:
> Karen,
>
> Thanks for the review!
>
>
> On 2/20/13 11:39 AM, Karen Kinnear wrote:
>> Thank you for fixing
Thank you for fixing this Ron and to both you and Dan for figuring out a way to
simulate this problem
to test the fix.
So what does happen with the UseOSErrorReporting option?
If we know the answer, perhaps the comment could not state that we have to
figure this out later?
On Feb 20, 2013, at
Changeset: 3a531d40ad93
Author:acorn
Date: 2013-02-14 14:33 -0500
URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/3a531d40ad93
8007736: VerifyError for static method in interface
Reviewed-by: dholmes, acorn
Contributed-by: bharadwaj.yadava...@oracle.com
! src/share/vm/cl
Changeset: 4f520ce7ba3f
Author:acorn
Date: 2013-02-13 16:09 -0500
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/4f520ce7ba3f
8007888: jdk fix default method: VerifyError: Illegal use of nonvirtual
Summary: Recognize VM generated method in old verifier. With 8004967
Reviewed-by: co
Thank you Dan - this is much better and sets a good model for the rest of us.
thanks,
Karen
On Feb 6, 2013, at 9:05 AM, Daniel D. Daugherty wrote:
> Adding other alias and people back onto the thread...
>
> Thanks for the re-review!
>
>
> On 2/6/13 6:41 AM, Coleen Phillimore wrote:
>>
>> Thi
New versions look great. Thank you.
For jdk8 only - is redefineclasses in the MINIMALVM? I missed your reply.
If so, I was assuming that the additional tracing would also be conditional
in the builds. I believe in addition to ifdef's there is a list of files not
included
in MINIMALVM, but I didn'
Dan,
All 3 versions of the code looks good. Thank you for enabling the printing for
product since
this type of problem is so hard to duplicate.
A small note, I think it would have been easier for the internal code logic
for the CPCE::check_no_old_or_obsolete_entries to reverse the true/false,
bu
Changeset: 815957d0203e
Author:acorn
Date: 2013-01-28 10:55 -0500
URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/815957d0203e
8004967: Default method cause VerifyError: Illegal use of nonvirtual
Summary: Recognize VM generated method in old verifier
Reviewed-by: acorn, c
Changeset: 16fb9f942703
Author:acorn
Date: 2013-01-25 15:06 -0500
URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/16fb9f942703
6479360: PrintClassHistogram improvements
Summary: jcmd GC.class_stats (UnlockDiagnosticVMOptions)
Reviewed-by: coleenp, hseigel, sla, acorn
Con
Changeset: 7df93f7c14a5
Author:brutisso
Date: 2013-01-16 12:46 +0100
URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/7df93f7c14a5
8006242: G1: WorkerDataArray::verify() too strict for double calculations
Summary: Also reviewed by vita...@gmail.com.
Reviewed-by: johnc, mge
Changeset: e51c9860cf66
Author:jmasa
Date: 2012-12-03 15:09 -0800
URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/e51c9860cf66
8005082: NPG: Add specialized Metachunk sizes for reflection and anonymous
classloaders
Reviewed-by: johnc, coleenp
! src/share/vm/classfile/cl
Mikael,
I like the assertion that you added.
I believe that this field isn't used by SA - so if you could double-check that
in SA - if that is the case, please
just remove it from vmStructs before checking in.
thanks,
Karen
On Dec 28, 2012, at 5:24 PM, Mikael Vidstedt wrote:
>
> Please review
Changeset: aefb345d3f5e
Author:acorn
Date: 2013-01-10 17:38 -0500
URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/aefb345d3f5e
7199207: NPG: Crash in PlaceholderTable::verify after StackOverflow
Summary: Reduce scope of placeholder table entries to improve cleanup
Reviewe
Frederic,
Finally getting to a code review. I like the design and the code looks very
clean.
I had a couple of questions please:
1. in the EFP and diagnosticCommand.hpp, why do GC.run and GC. run_finalization
not need any special Java permissions?
Is this backward compatibility with existing w
Changeset: adc176e95bf2
Author:acorn
Date: 2013-01-09 11:39 -0500
URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/adc176e95bf2
8005689: InterfaceAccessFlagsTest failures in Lambda-JDK tests
Summary: Fix verifier for new interface access flags
Reviewed-by: acorn, kvn
Contr
Sounds like time to file a separate bug to track that issue down (particularly
the bsd issue)
and move on with this one.
Thank you so much Dan for the history and details,
Karen
On Dec 19, 2012, at 11:30 AM, Daniel D. Daugherty wrote:
> Adding the other aliases back in...
>
> Harold,
>
> This
Looks good. Thank you.
thanks,
Karen
On May 23, 2012, at 3:50 PM, Daniel D. Daugherty wrote:
> Greetings,
>
> This is a JDK code review request for a pair of Full Debug Symbols
> gobjcopy work arounds on Solaris. The gobjcopy utility on Solaris 10
> corrupts the SUNW_* sections on objects. This
Changeset: df84b4a3ebcb
Author:rbackman
Date: 2012-05-24 13:37 +0200
URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/df84b4a3ebcb
7171422: Change 7161732 breaks SA on Windows
Reviewed-by: dholmes, sla
! src/os_cpu/windows_x86/vm/vmStructs_windows_x86.hpp
Dan,
Code looks good.
Thank you for the work-around.
So is this HDR_FLAGS workaround also needed in all the other jdk repositories?
And I assume the windows/makefiles/defs.make change is because you determined
that the failing tests actually pre-dated the zipped debuginfo. Did you find
the ro
Dan,
Code looks good. Thank you for figuring out this work-around.
thanks,
Karen
On May 17, 2012, at 10:14 AM, Daniel D. Daugherty wrote:
> Greetings,
>
> This is a code review request for the following P1 bug:
>
>7168520 1/3 No jdk8 TL Nightly linux builds due to broken link in
>
t;
> So, unless I missed some code, it is safe to use getDescriptor()
> without null check.
>
> Fred
>
> On 4/13/12 3:54 PM, Karen Kinnear wrote:
>> Frederic,
>>
>> Looks good. And I like the refactoring.
>>
>> A question - does the Descriptor
Frederic,
Looks good. And I like the refactoring.
A question - does the Descriptor field have the same potential for being null?
e.g.
in MBeanFeatureInfo.java new line 160 - do you need to check getDescriptor() ==
null as well?
in MBeanConstructorinfo.java line 197, do you need the alternative
Summary - code change looks good.
thanks,
Karen
On Apr 12, 2012, at 10:03 AM, Karen Kinnear wrote:
> Dmitry,
>
> I hear your point, there is a comment in the VM Initialization Event that "In
> the case of VM start-up
> failure, this event will not be sent".
>
>
Dmitry,
I hear your point, there is a comment in the VM Initialization Event that "In
the case of VM start-up
failure, this event will not be sent".
That said, the goal of the VM initialization event is to inform the agent that
it is free
to call any JNI or JMVTI function. Many agents want to b
Changeset: 1139f6b1cbd4
Author:jcoomes
Date: 2012-03-20 19:36 -0700
URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/1139f6b1cbd4
7154724: jdk7u4 test properties missing from jprt.properties
Reviewed-by: brutisso
! make/jprt.properties
Changeset: 0e9e3cecdc81
Author:
Changeset: ee138854b3a6
Author:kvn
Date: 2012-03-12 10:46 -0700
URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/ee138854b3a6
7147744: CTW: assert(false) failed: infinite EA connection graph build
Summary: rewrote Connection graph construction code in EA to reduce time spe
Looks good.
thanks,
Karen
On Mar 27, 2012, at 9:12 AM, Frederic Parain wrote:
> CR:
> http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7087969
>
> The fix is very simple, converting ticks into milliseconds
> before using them to create the notification. This fix
> makes the notification consi
Looks good Rickard - thanks for the fixes.
Karen
On Mar 14, 2012, at 5:25 AM, Rickard Bäckman wrote:
> Hi,
>
> I would like to get reviews for CR 7145419, where we have a test that
> sometimes fails when getting events from background threads. The test should
> ignore those events.
>
> Webre
Looks good. Thanks Dmitry.
Karen
On Feb 28, 2012, at 6:54 AM, Dmitry Samersoff wrote:
> Hi Everyone,
>
> Please review:
>
> http://cr.openjdk.java.net/~dsamersoff/7149181/webrev.01/
>
> Disable test until hotspot and jdk changes meet together.
>
> -Dmitry
>
> --
> Dmitry Samersoff
> Java H
Looks good. Thank you.
And I will deal with the early event work when we add more events in terms of
exactly how early we need to initialize the tracing subsystem.
thanks,
Karen
On Feb 15, 2012, at 6:38 AM, Nils Loodin wrote:
> Thank you all for suggesting even more improvements!
>
> Updated t
Frederic, Nils,
Just fix the copyright then.
responses inline ...
On Feb 14, 2012, at 1:27 PM, Frederic Parain wrote:
>
>
> On 14/02/2012 18:55, Karen Kinnear wrote:
>> Thank you Nils :-)
>>
>> I had a question on the DCmdArgument - I think I am
>&
Thank you Nils :-)
I had a question on the DCmdArgument - I think I am not
reading
this correctly:
Couple of questions please:
1) What is this doing?
if (idx == len) {
143
// only accept missing unit if the value is 0
144
if (_value._time != 0) {
145
THROW_MSG(vmS
Changeset: b2cd0ee8f778
Author:acorn
Date: 2012-01-30 23:27 -0500
URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/b2cd0ee8f778
7114376: Make system dictionary hashtable bucket array size configurable
Summary: 7u4 new experimental flag -XX:PredictedClassLoadedCount=#
Revie
Thanks Rickard.
My guess is that if it works with all version of jar which you've tested, then
it will
be easier going forward to maintain the file consistently, and it causes no
harm.
thanks,
Karen
On Jan 26, 2012, at 7:03 AM, Rickard Bäckman wrote:
> On 01/26/2012 12:53 PM, Karen
Code change looks good.
I assume you want to put this fix back to JDK8 as well.
thank you for the quick fix!
Karen
On Jan 26, 2012, at 4:44 AM, Rickard Bäckman wrote:
> Hi,
>
> We have a problem with some versions of jar reporting errors when trying to
> run jar cf com/test com/test/foo
>
>
Frederic,
Code looks good.
A couple of minor comments/questions:
1) diagnosticCommand.cpp HeapDumpDCmd::execute
- There is a comment in attachListener under dump_heap that would
be helpful to have here as well: // Request a full GC before heap dump if
live_objects ...
2) I wonder if it
Dan,
Thank you for the quick fix - I echo Coleen's sentiments of wondering how
you managed to find the problem(s).
On Dec 21, 2011, at 5:41 PM, Daniel D. Daugherty wrote:
> Karen,
>
> Thanks for the quick review! Replies in-lined below...
>
>
> On 12/21/11 2:47
Dan,
All versions of hotspot changes look good.
For the JDK and test side:
1) minor: JPLISAgent.c - new lines 1210-1212 might just be an } else {
2) new lines 1311-1312
Why do you break if an error occurred?
If there is a reason to stop freeing memory, would that also apply if
you al
Keith,
Looks good. Only mismatch I found is the one David already caught.
In jvmti.xsl - line 1044 - what is #8482 for?
thanks for doing this,
Karen
On May 5, 2011, at 8:42 AM, Keith McGuigan wrote:
On May 4, 2011, at 11:18 PM, David Holmes wrote:
Hi Keith,
Keith McGuigan said the followi
Thank you very much. It is safer to err on the side of paranoia.
thanks,
Karen
On 04/28/11 10:38, Daniel D. Daugherty wrote:
On 4/28/2011 8:06 AM, Karen Kinnear wrote:
Sorry, I didn't know you were going to redo this. I too have memories
of os::free of null having issues. And I also
Sorry, I didn't know you were going to redo this. I too have memories
of os::free of null having issues. And I also have memories of code checking
tools complaining about calls to os::free of null.
So, if you could either go back to the way it was, or only call
os::free if it is not null I would
Code looks good. And thank you for freeing memory :-)
thanks,
Karen
On Apr 27, 2011, at 3:46 PM, Daniel D. Daugherty wrote:
Greetings,
I have a fix for a bug in JVM/TI DynamicCodeGenerated event posting:
7039447 2/1 java profiling is broken in build 139 (garbage in
function n
Changeset: 7dc5384467e0
Author:coleenp
Date: 2011-02-12 10:28 -0500
URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/hotspot/rev/7dc5384467e0
7022659: errorHandler doesn't compile without precompiled headers
Summary: add proper includes in errorHandler.hpp
Reviewed-by: phh, kamg
! s
Changeset: 5d8f5a6dced7
Author:iveresov
Date: 2011-03-04 15:14 -0800
URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/hotspot/rev/5d8f5a6dced7
7020403: Add AdvancedCompilationPolicy for tiered
Summary: This implements adaptive tiered compilation policy.
Reviewed-by: kvn, never
! src
Changeset: 70b50ac7e2af
Author:cl
Date: 2011-03-10 17:10 -0800
URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/hotspot/rev/70b50ac7e2af
Added tag jdk7-b133 for changeset 1b3a350709e4
! .hgtags
Changeset: 447e6faab4a8
Author:trims
Date: 2011-03-11 11:18 -0800
URL: ht
Dan,
Approved.
Looks very tricky to track down.
Only minor suggestion - line 1361 warning: if ret_code == OS_ERR, it
might be nice to
print %s and strerror(errno) rather than %d and ret_code. Not a big
deal.
thanks,
Karen
On Feb 15, 2011, at 7:49 PM, Daniel D. Daugherty wrote:
I need a
Currently to maintain the proper ordering of load and unload events,
when you post
a compiled_method_load event, if there are pending
compiled_method_unload events,
then we "lock" the nmethod to ensure that the nmethod is not flushed
or unloaded while posting the event. What if we did that until
Changeset: 4e22405d98d6
Author:iveresov
Date: 2010-10-19 11:14 -0700
URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/hotspot/rev/4e22405d98d6
6989669: Coops: -Xshare:dump causes crash
Summary: Temporarily fix to disable compressed oops with CDS
Reviewed-by: dholmes, twisti, kvn, nev
Changeset: fa83ab460c54
Author:acorn
Date: 2010-10-22 15:59 -0400
URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/hotspot/rev/fa83ab460c54
6988353: refactor contended sync subsystem
Summary: reduce complexity by factoring synchronizer.cpp
Reviewed-by: dholmes, never, coleenp
- src/
Changeset: 75588558f1bf
Author:never
Date: 2010-10-07 21:40 -0700
URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/hotspot/rev/75588558f1bf
6980792: Crash "exception happened outside interpreter, nmethods and vtable
stubs (1)"
Reviewed-by: kvn
! src/cpu/sparc/vm/stubGenerator_sparc
1 - 100 of 128 matches
Mail list logo
