Re: RFR(XXS): 8156226: DiagnosticCommandImpl::invoke throws NoSuchMethodException even if the method actually exists but parameters are wrong

2016-06-10 Thread Kirill Zhaldybin
he way the previous variant is. Not sure what a zero-length array might produce either - for both you would want the representation of an "empty" signature. David best regards, -- daniel On 09/06/16 13:09, Kirill Zhaldybin wrote: Mandy, Thank you for reviewing the fix! I added signat

Re: RFR(XXS): 8156226: DiagnosticCommandImpl::invoke throws NoSuchMethodException even if the method actually exists but parameters are wrong

2016-06-09 Thread Kirill Zhaldybin
David, Thank you for reviewing the fix! Regards, Kirill On 09.06.2016 04:10, David Holmes wrote: On 9/06/2016 10:33 AM, David Holmes wrote: Hi Kirill, On 9/06/2016 4:26 AM, Kirill Zhaldybin wrote: Dear all, After discussion with Mandy Chung, Daniel Fuchs and Frederic Parain we decided to

Re: RFR(XXS): 8156226: DiagnosticCommandImpl::invoke throws NoSuchMethodException even if the method actually exists but parameters are wrong

2016-06-09 Thread Kirill Zhaldybin
: On Jun 8, 2016, at 11:26 AM, Kirill Zhaldybin wrote: Dear all, After discussion with Mandy Chung, Daniel Fuchs and Frederic Parain we decided to provide separate error message for the case if method exists but signature or parametes are wrong but throw the same NoSuchMethodError exception

Re: RFR(XXS): 8156226: DiagnosticCommandImpl::invoke throws NoSuchMethodException even if the method actually exists but parameters are wrong

2016-06-08 Thread Kirill Zhaldybin
WebRev: http://cr.openjdk.java.net/~kzhaldyb/webrevs/JDK-8156226/webrev.04/ CR: https://bugs.openjdk.java.net/browse/JDK-8156226 Thank you. Regards, Kirill On 06.05.2016 20:16, Kirill Zhaldybin wrote: Dear all, Could you please review this small fix for 8156226? A case when a method exists

Re: RFR(XXS): 8156226: DiagnosticCommandImpl::invoke throws NoSuchMethodException even if the method actually exists but parameters are wrong

2016-05-06 Thread Kirill Zhaldybin
Alexander, Thank you for reviewing the fix. On 06.05.2016 20:24, Alexander Kulyakhtin wrote: Is there a specification of what shall be thrown, or the justification of the changes done? One can think that the currently thrown NoSuchMethodException is correct since  methods, which differ in sign

RFR(XXS): 8156226: DiagnosticCommandImpl::invoke throws NoSuchMethodException even if the method actually exists but parameters are wrong

2016-05-06 Thread Kirill Zhaldybin
Dear all, Could you please review this small fix for 8156226? A case when a method exists but parameters' signature is wrong now causes new ReflectionException(new IllegalArgumentException()) thrown instead of new ReflectionException(new NoSuchMethodException()). WebRev: http://cr.openjdk.ja