PM, Konstantin Shefov wrote:
Hello
Please review a test bug fix.
The test fails because Cygwin PID returned by "$!" and Windows PID
returned by "tasklist" are not the same.
Need to use cygwin "ps".
Bug: https://bugs.openjdk.java.net/browse/JDK-8150070
Webrev: http:
Kindly reminder
Please, review
Thanks
-Konstantin
On 02/18/2016 07:07 PM, Konstantin Shefov wrote:
Hello
Please review a test bug fix.
The test fails because Cygwin PID returned by "$!" and Windows PID
returned by "tasklist" are not the same.
Need to use cygw
Alexander,
Direct backport form JDK 9 does not work on JDK 8, JDK 9 tests just hang
on JDK 8 because of some JDK9-specific changes have been done there.
As for JDK 9 tests, they pass without error, although they use tasklist
to search for Cygwin PID. Perhaps they do not fail because when I
Yes, it is a fix for JDK 8u only.
-Konstantin
On 02/19/2016 05:47 PM, Alexander Kulyakhtin wrote:
Hi Konstantin,
(not a reviewer)
Could you, please, explain your fix a bit more, if possible?
Since the comment to the CR says "Cannot be reproduced with JDK 9.", is this
fix for JDK 8 only?
Hello
Please review a test bug fix.
The test fails because Cygwin PID returned by "$!" and Windows PID
returned by "tasklist" are not the same.
Need to use cygwin "ps".
Bug: https://bugs.openjdk.java.net/browse/JDK-8150070
Webrev: http://cr.openjdk.java.net/~kshefov/8150070/webrev
Thanks
Changeset: f22742d5daa3
Author:kshefov
Date: 2013-10-21 13:31 +0400
URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/f22742d5daa3
8026871: NASHORN TEST: Enable possibility to test Nashorn use of JavaFX canvas.
Reviewed-by: jlaskey, sundar
! make/build.xml
!
