Re: Removal of SA javascript support

2019-12-10 Thread Krystal Mok
Hi Yasumasa, That's a very nice idea. Basically what you're asking for is exposing the Command interface [1] so that plugins can implement it and get dynamically loaded / registered into CLHSDB / HSDB, right? [1]:

Re: Removal of SA javascript support

2019-12-10 Thread Krystal Mok
eone used JS interface of SA :) Quick prototyping + > debugger interactive scripting were the goals of JS interface! As you > mentioned, given the current state of SA JS interface, it has to be removed > :( > > Thanks > > -Sundar > On 11/12/19 8:56 am, Krystal Mo

Re: Removal of SA javascript support

2019-12-10 Thread Krystal Mok
Hi Chris, Thanks for the proposal. I used to be one of the few heavy users of jsload / jseval in CLHSDB back in the JDK6 to JDK8 era. The way I used to use it is to quickly prototype new functionality in JS and later bake it into Java code, and also for exploring heap dumps beneath the existing

Re: A Bug about the JVM Attach mechanism

2019-06-20 Thread Krystal Mok
(Speaking on behalf of my own experience) Yes Alan, you're right on. I'm fairly sure that's the symptom that Nijiaben is asking about here. - Kris On Wed, Jun 19, 2019 at 11:54 PM Alan Bateman wrote: > On 20/06/2019 05:10, nijiaben wrote: > > : > > I know this mechanism, can we provide means

Re: SA Debug attach to another jvm version possible?

2018-08-21 Thread Krystal Mok
You're probably looking for /jdk.hotspot.agent.jmod ? - Kris On Tue, Aug 21, 2018 at 3:18 AM, Egor Ushakov wrote: > Thank you all! It is much better now. > > Related question: documentation for java 10 https://docs.oracle.com/javase > /10/docs/specs/jpda/conninv.html#sa-pid-attaching-connector

Re: SA Debug attach to another jvm version possible?

2018-08-20 Thread Krystal Mok
Hi guys, It's been some time since I last juggled with SA, but IIRC when I wanted to take shortcuts of using SA between minor version mismatches, I used to just run the SA tool with the matching version of sa-jdi.jar with the target process. i.e. if I wanted to run an SA tool from a JDK8u162

Re: RFR(XS): 8043264: hsdis library not picked up correctly on expected paths

2014-05-17 Thread Krystal Mok
Hi Serguei, Thank you very much! Best regards, Kris On Friday, May 16, 2014, serguei.spit...@oracle.com serguei.spit...@oracle.com wrote: Kris, I've submitted the jprt job: 2014-05-17-060826.sspitsyn.hotspot Thanks, Serguei On 5/16/14 3:38 PM, Krystal Mok wrote: Thank you

Re: RFR(XS): 8043264: hsdis library not picked up correctly on expected paths

2014-05-16 Thread Krystal Mok
Thank you, Staffan! Best regards, Kris On Thu, May 15, 2014 at 11:46 PM, Staffan Larsen staffan.lar...@oracle.comwrote: On 15 maj 2014, at 22:19, Krystal Mok rednaxel...@gmail.com wrote: Hi everyone, May I have a couple of review for this small patch, please? *Bug*: https

Re: RFR(XS): 8043264: hsdis library not picked up correctly on expected paths

2014-05-16 Thread Krystal Mok
Thank you, Serguei! BTW, Could you or Staffan sponsor this change and help me push it? Best regards, Kris On Fri, May 16, 2014 at 3:20 PM, serguei.spit...@oracle.com serguei.spit...@oracle.com wrote: On 5/15/14 1:19 PM, Krystal Mok wrote: Hi everyone, May I have a couple of review

RFR(XS): 8043264: hsdis library not picked up correctly on expected paths

2014-05-15 Thread Krystal Mok
Hi everyone, May I have a couple of review for this small patch, please? *Bug*: https://bugs.openjdk.java.net/browse/JDK-8043264 *Patch*: (against jdk9/hs) diff -r 466b58fa837b src/share/vm/compiler/disassembler.cpp --- a/src/share/vm/compiler/disassembler.cpp Thu May 15 11:35:26 2014 -0700

Re: Compute sizes of classes loaded in perm gen

2014-03-20 Thread Krystal Mok
of classes loaded in perm gen. As I've understood, this is possible only by using Serviceability Agent? - Sergei On 20.03.2014 00:12, Krystal Mok wrote: Hi Sergei, jmap -permstat, or PermStat itself is an utility based on the Serviceability Agent. For your reference, I've written

Re: Compute sizes of classes loaded in perm gen

2014-03-19 Thread Krystal Mok
Hi Sergei, Are you using PermStat in the context of Serviceability Agent? In other words, is the agent you're writing a Serviceability Agent, or something else, like a Java agent as in java.lang.instrument, or a JVMTI agent? SA uses different means to connect to the target VM from the other types

Re: Compute sizes of classes loaded in perm gen

2014-03-19 Thread Krystal Mok
clear to me how can I write my own custom Serviceability Agent. By the way, is it possible to compute sizes of classes loaded in perm gen only by using Java Agent and JVMTI agent? - Sergei 19.03.2014, 17:39, Krystal Mok rednaxel...@gmail.com: Hi Sergei, Are you using PermStat in the context

Re: RR(XS): JDK-7050685 jsdbproc64.sh has a typo in the package name

2013-11-26 Thread Krystal Mok
Hi all, I thought this was familiar...I reported the bug back in June 2011 to serviceability-dev, and Dan opened 7050685 for it. http://mail.openjdk.java.net/pipermail/serviceability-dev/2011-May/004056.html Nice to see the fix finally goes in. Thank you. - Kris On Tue, Nov 26, 2013 at 3:47

Re: RFR: 8011888: sa.js: TypeError: [object JSAdapter] has no such function __has__

2013-08-12 Thread Krystal Mok
Hi Peter, Looks good to me. Thank you! I'd like to mention again that the getHandle - getAddress change has been purposed by Yunda, which I mentioned in [1], too. Best regards, Kris (kmo) On Monday, August 12, 2013, A. Sundararajan wrote: Looks good -Sundar On Monday 12 August 2013 06:21

Re: RR(XS): JDK-8021771 warning: stat64 is deprecated - when building on OSX 10.7.5

2013-08-07 Thread Krystal Mok
. Moreover for this particular case we don't need stat64 because the code deals with pid file and it doubtly grows over 2GB. Great. I'm good with the fix then. Thanks again for the info :-) - Kris -Dmitry On 2013-08-07 06:31, Krystal Mok wrote: Hi Dmitry, Thanks for taking care

Re: RR(XS): JDK-8021771 warning: stat64 is deprecated - when building on OSX 10.7.5

2013-08-06 Thread Krystal Mok
Hi Dmitry, Thanks for taking care of this patch. Has it been confirmed that all BSD variants are good to use stat instead of stat64? Regards, Kris (kmo) On Wed, Aug 7, 2013 at 3:30 AM, Dmitry Samersoff dmitry.samers...@oracle.com wrote: Hi Everyone, Please review. stat64 replaced with

Re: About bug fix of 8010278

2013-07-31 Thread Krystal Mok
Hi Kevin, Just noticed this one. I wonder if the suggested sa.js fix is similar to the one I purposed here: http://mail.openjdk.java.net/pipermail/serviceability-dev/2013-July/010831.html Regards, Kris On Fri, Jul 26, 2013 at 5:20 PM, Kevin Walls kevin.wa...@oracle.com wrote: Hi Yumin,

Re: SA: Various fixes to sa.js to make it work in JDK8

2013-07-31 Thread Krystal Mok
out of the box again. Thanks, Kris On Mon, Jul 29, 2013 at 3:53 PM, Krystal Mok rednaxel...@gmail.com wrote: Hi all, Could I have a couple of reviews for this patch, please? https://gist.github.com/rednaxelafx/6102608 Switching the JavaScript engine from Rhino to Nashorn

Re: SA: Various fixes to sa.js to make it work in JDK8

2013-07-30 Thread Krystal Mok
. Now, I'm with the nashorn team. Thanks -Sundar On Monday 29 July 2013 01:23 PM, Krystal Mok wrote: Hi all, Could I have a couple of reviews for this patch, please? https://gist.github.com/**rednaxelafx/6102608https://gist.github.com/rednaxelafx/6102608 Switching the JavaScript engine

SA: Various fixes to sa.js to make it work in JDK8

2013-07-29 Thread Krystal Mok
Hi all, Could I have a couple of reviews for this patch, please? https://gist.github.com/rednaxelafx/6102608 Switching the JavaScript engine from Rhino to Nashorn and the No PermGen project caused a few issues that stopped sa.js from working. This is a patch that tries to fix the issues that

Re: CR 8005604: HPROF should report the actual instance size

2012-12-29 Thread Krystal Mok
Hi Aleksey, It's good to see that this problem is being addressed. I wonder what's the history of making HPROF calculate the instance size on its own... A nitpick: even though the proposed patch should work just right, but I think it's better to access the size_helper through

Re: RFR: 8000489: older builds of hsdis don't work anymore after 6879063

2012-10-24 Thread Krystal Mok
Hi Yumin, minor typos: s/instrurctions/instructions/ By the way, I tried to use a build of hsdis plugin after 6879063 in an earlier JDK build (e.g. JDK8b59) and it was working strangely. A rough look at the output looks like it's missing some newlines, I didn't go into the details. Could you

Re: Request for review (XS): Wrong filter predicate of visible locals in SA JSJavaFrame

2012-05-08 Thread Krystal Mok
/23/12 9:05 PM, Krystal Mok wrote: Hi all, Could I get a review for this patch, please? Regards, Kris On Thu, Apr 19, 2012 at 3:55 PM, Krystal Mok rednaxel...@gmail.comwrote: Thanks, Staffan :-) - Kris On Thu, Apr 19, 2012 at 3:53 PM, Staffan Larsen staffan.lar...@oracle.com

Re: Request for review (XS): Wrong filter predicate of visible locals in SA JSJavaFrame

2012-04-23 Thread Krystal Mok
Hi all, Could I get a review for this patch, please? Regards, Kris On Thu, Apr 19, 2012 at 3:55 PM, Krystal Mok rednaxel...@gmail.com wrote: Thanks, Staffan :-) - Kris On Thu, Apr 19, 2012 at 3:53 PM, Staffan Larsen staffan.lar...@oracle.com wrote: Hi Kris, This fix looks good

Re: Removing BugSpot

2012-04-16 Thread Krystal Mok
Hi Staffan, There are quite a few tools depending on BugSpotAgent for attaching. At least all tools that inherit from sun.jvm.hotspot.tools.Tool do. Removing the BugSpot frontend shouldn't affect those tools, or would it? Regards, Kris On Sat, Apr 14, 2012 at 6:32 PM, Staffan Larsen

Re: Removing BugSpot

2012-04-16 Thread Krystal Mok
Hi Staffan, Alright, then I'm ok with this :-) Thanks, Kris On Mon, Apr 16, 2012 at 4:22 PM, Staffan Larsen staffan.lar...@oracle.comwrote: Hi Krystal, Those tools can all use HotSpotAgent instead without any loss of functionality. Regards, /Staffan On 16 apr 2012, at 10:21, Krystal

Re: 7153375 jmap -histo should output a unique identifier with each line

2012-03-22 Thread Krystal Mok
Hi Shinji, This patch should work better after the work on Permanent Generation removal is integrated into mainstream. For now, though, it's not guaranteed to work: Klasses are subject to GC, which could move around from time to time. You're using hashCode() from the Klass, whichi ultimately

Re: 7153375 jmap -histo should output a unique identifier with each line

2012-03-22 Thread Krystal Mok
Oops, missed the link in the last mail: [1]: http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/file/a142c661f6b1/agent/src/share/classes/sun/jvm/hotspot/debugger/linux/LinuxAddress.java On Thu, Mar 22, 2012 at 4:50 PM, Krystal Mok rednaxel...@gmail.com wrote: Hi Shinji, This patch should

Re: SA frontends

2012-02-23 Thread Krystal Mok
it by jhat or VisualVM. Same thing here? Thanks for the feedback, /Staffan -Sundar Krystal Mok wrote: Hi Staffan, There's at least another frontend, the SA Plugin for Visual VM. I think it only uses the BugSpotAgent for attaching/detaching, otherwise it doesn't use stuff from

Re: RFR: 6988220: java.lang.ObjectName use of String.intern() causes major performance issues at scale

2012-02-23 Thread Krystal Mok
Hi Keith, Another problem with using 'intern()' is that when you intern a string you're placing it into the permgen, and space there is at a premium. (no perm gen project will hopefully fix this soon). Actually that's fixed already, in 6962931 and a couple of related fixes later. - Kris On

Re: SA frontends

2012-02-22 Thread Krystal Mok
Hi Staffan, There's at least another frontend, the SA Plugin for Visual VM. I think it only uses the BugSpotAgent for attaching/detaching, otherwise it doesn't use stuff from BugSpot. Other tools, e.g. jstack -m, jstack -F, jmap -F, etc., are not exactly SA frontends, but use the SA to implement

Re: Request for Review (XS): 7143760 Memory leak in GarbageCollectionNotifications

2012-02-12 Thread Krystal Mok
Hi all, Tto follow up with what David mentioned: If sendNotification generates an exception then the serviceThread will terminate. Is that the desired behaviour? Other event processing can't terminate the service thread. I did a simple test to see what would happen in 7u2 when someone throws

Re: Review Request: 7009098: SA cannot open core file larger than 2GB

2012-02-08 Thread Krystal Mok
Hi Poonam, Could the synopsis include the fact that this only affects Linux/x86 32-bit? I got a bit confused when I first read the synopsis, because I've been using SA to open core files around 4GB~5GB on Linux/x64 routinely, and it worked. Regards, Kris Mok On Thu, Feb 9, 2012 at 12:41 PM,

Re: Pls review 7124880 (XS)

2011-12-19 Thread Krystal Mok
Hi Paul, I've used 7117389 and added a few manageable flags in globals_ext.hpp in my local experiment builds, and they all seem to work fine (jinfo -flag can correctly query and set the new flags; didn't try JConsole). Does 7124880 change any behaviors of the manageable flags? Or is it just for

Re: Pls review 7124880 (XS)

2011-12-19 Thread Krystal Mok
Got it. Thank you very much :-) Regards, Kris Mok On Tue, Dec 20, 2011 at 8:43 AM, Paul Hohensee paul.hohen...@oracle.comwrote: On 12/19/11 7:34 PM, Krystal Mok wrote: Hi Paul, I've used 7117389 and added a few manageable flags in globals_ext.hpp in my local experiment builds

Re: Enabling non product flags like Verbose in GC Code

2011-08-25 Thread Krystal Mok
reason to protect some of these more useful messages with a product flag rather than with a develop flag. I recall Krystal Mok also mentioning something similar. Perhaps the community can work on what are the kinds of messages one might want to see in production (under control of a suitable

Re: Number of CMS collections and the JMM GC counters

2011-07-28 Thread Krystal Mok
29, 2011 at 8:29 AM, Y. S. Ramakrishna y.s.ramakris...@oracle.com wrote: Hi Kevin -- thanks for jumping on this! More inline below ... On 07/28/11 09:33, Krystal Mok wrote: Hi Kevin, Thank you for taking care of this, and it's good to see the problem is verified. I think whether

Wrong package name in jsdbproc64.sh

2011-05-04 Thread Krystal Mok
Hi all, There seem to be a typo in Serviceability Agent's JSDB launcher script, jsdbproc64.sh. The class name sun.jvm.hotspot.tools.soql.JSDB is incorrectly written as sun.jvm.hotspot.tools.JSDB in this script. This script also contains a few extra Carriage Return characters at the end of lines,