Re: RFR: 8178287: AsyncGetCallTrace fails to traverse valid Java stacks [v4]

2021-08-23 Thread Marcus Hirt
On Mon, 23 Aug 2021 10:57:54 GMT, David Holmes wrote: >> @dcubed-ojdk , @dholmes-ora would you be willing/able to take a look at this >> change, pretty please? > > Sorry @jbachorik but frames and code-blobs are not an area I know. > > David @dholmes-ora, do you know anyone who could be the pr

Re: RFR: 8178287: AsyncGetCallTrace fails to traverse valid Java stacks [v4]

2021-08-18 Thread Marcus Hirt
On Mon, 19 Jul 2021 09:25:59 GMT, Ludovic Henry wrote: >> When the signal sent for AsyncGetCallTrace or JFR would land on a runtime >> stub (like arraycopy), a vtable stub, or the prolog of a compiled method, >> it wouldn't be able to detect the sender (caller) frame for multiple >> reasons.

Re: RFR: 8178287: AsyncGetCallTrace fails to traverse valid Java stacks [v3]

2021-08-17 Thread Marcus Hirt
On Wed, 30 Jun 2021 09:17:42 GMT, Serguei Spitsyn wrote: >> Ludovic Henry has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Fix comments > > Hi Ludovic, > You need two reviews including one (R)eviewer before integration of your fix. > Than

Re: Proposal: Always-on Statistical History

2018-11-15 Thread Marcus Hirt
Hi all, I'm with Roger on this one. This is an aggregation mechanism. If we want such an aggregation mechanism, we should probably build one into one of the already available serviceability technologies (JMX and/or JFR). If we feel the need to introduce a generic one that can source data from m

Re: Proposal: Always-on Statistical History

2018-11-15 Thread Marcus Hirt
JDK Flight Recorder is free, open sourced and part of OpenJDK 11+. Kind regards, Marcus From: serviceability-dev on behalf of Simon Roberts Date: Thursday, 15 November 2018 at 18:10 To: Cc: Subject: Re: Proposal: Always-on Statistical History I don't begin to claim to know the poli