Re: RFR: 8243290: Improve diagnostic messages for class verification and redefinition failures

NULL, will the call to st->print_cr() at line 142 - 143, fail? Thanks, Harold On 6/9/2020 10:46 AM, Poonam Parhar wrote: Hello, Please review this simple change for improving diagnostics around class verification and linking failures: Bug: https://bugs.openjdk.java.net/browse/JDK-824329

Re: RFR: 8243290: Improve diagnostic messages for class verification and redefinition failures

both files. Coleen On 6/9/20 10:46 AM, Poonam Parhar wrote: Hello, Please review this simple change for improving diagnostics around class verification and linking failures: Bug: https://bugs.openjdk.java.net/browse/JDK-8243290 Webrev: http://cr.openjdk.java.net/~poonam/8243290/webrev.00

Re: RFR: 8243290: Improve diagnostic messages for class verification and redefinition failures

Thanks Serguei! regards, Poonam On 6/9/20 10:56 AM, serguei.spit...@oracle.com wrote: Hi Poonam, Thank you for taking care about this! It looks good besides the comment from Harold and Coleen about ex_msg can be equal to NULL. Thanks, Serguei On 6/9/20 07:46, Poonam Parhar wrote: Hello

RFR: 8243290: Improve diagnostic messages for class verification and redefinition failures

Hello, Please review this simple change for improving diagnostics around class verification and linking failures: Bug: https://bugs.openjdk.java.net/browse/JDK-8243290 Webrev: http://cr.openjdk.java.net/~poonam/8243290/webrev.00/ Problem: During the class redefinition process, if a class veri

Re: Discussion about fixing deprecation in jdk.hotspot.agent

Hello Coleen, Does the removal of this code only impact the 'reattach' functionality, and it does not affect any commands available in 'clhsdb' once it is attached to a core file? If that's true, then I think it should be okay to remove this code. Thanks, Poonam On 3/31/20 5:34 AM, coleen.p

Re: RFR (S) 8239055: Wrong implementation of VMState.hasListener

Hello Fairoz, The change looks good to me as well. Thanks, Poonam On 2/18/20 12:26 PM, serguei.spit...@oracle.com wrote: Hi Fairoz, Looks good. Thanks, Serguei On 2/13/20 9:13 PM, Fairoz Matte wrote: Hi, Please review a tiny change to correct the VMState.hasListener implementation. J

RFR 8229420: [Redo] jstat reports incorrect values for OU for CMS GC

Hello, The fix for JDK-8215523 had to be backed out with '8227178: Backout of 8215523' because it had caused timeout failures for some of the CMS tests. Changeset of JDK-8215523: http://hg.openjdk.java.net/jdk/jdk/rev/734e58d8477b Those f

Re: RFR 8215523: jstat reports incorrect values for OU for CMS GC

Hello Severin, On 8/12/19 1:22 AM, Severin Gehwolf wrote: Hi, On Sun, 2019-08-11 at 07:25 -0700, Poonam Parhar wrote: Hello, The fix for this bug had to be backed out with '8227178: Backout of 8215523' because it had caused timeout failures for some of the CMS tests. Those fa

Re: RFR 8215523: jstat reports incorrect values for OU for CMS GC

se review the updated webrev: http://cr.openjdk.java.net/~poonam/8215523/webrev.02/ Thanks, Poonam On 7/2/19 6:42 AM, Poonam Parhar wrote: Hi Aleksey, Thomas, It wasn't meant to be non-public. I have opened it. Thanks, Poonam On 7/2/19 3:36 AM, Thomas Schatzl wrote: Hi, On Tue, 2019-07

RFR 8227178: Backout of 8215523

Hello, Please review the changeset that reverses the changes done with JDK-8215523 . JDK-8227178 : Backout of 8215523 webrev: http://cr.openjdk.java.net/~poonam/8227178/webrev.00/ The fix for

Re: RFR 8215523: jstat reports incorrect values for OU for CMS GC

Hi Aleksey, Thomas, It wasn't meant to be non-public. I have opened it. Thanks, Poonam On 7/2/19 3:36 AM, Thomas Schatzl wrote: Hi, On Tue, 2019-07-02 at 10:10 +0200, Aleksey Shipilev wrote: Hi, On 6/21/19 10:30 PM, Poonam Parhar wrote: On 6/21/19 12:21 PM, Poonam Parhar wrote:

Re: RFR 8215523: jstat reports incorrect values for OU for CMS GC

Hello Severin, Thanks for catching that. Yes, I meant jstat. I will correct that. regards, Poonam On 6/28/19 9:32 AM, Severin Gehwolf wrote: Hi Poonam, One nit caught my eye: On Fri, 2019-06-21 at 13:30 -0700, Poonam Parhar wrote: Please review the changes for the fix of: Bug 8215523

Re: RFR 8215523: jstat reports incorrect values for OU for CMS GC

21/19 5:59 PM, serguei.spit...@oracle.com wrote: Hi Poonam, The fix looks Okay from the Serviceability point of view. Thanks, Serguei On 6/21/19 13:30, Poonam Parhar wrote: Updating the subject line with the updated bug synopsis. And also, much thanks to Thomas Schatzl for his remarkable he

Re: RFR 8215523: jstat reports incorrect values for OU for CMS GC

Updating the subject line with the updated bug synopsis. And also, much thanks to Thomas Schatzl for his remarkable help in tweaking and refining this fix. regards, Poonam On 6/21/19 12:21 PM, Poonam Parhar wrote: Hello, Please review the changes for the fix of: Bug 8215523 <ht

RFR 8215523: Request for clarification in unexpected OU decrease with CMS GC

Hello, Please review the changes for the fix of: Bug 8215523 : jstat reports incorrect values for OU for CMS GC Webrev: http://cr.openjdk.java.net/~poonam/8215523/webrev.00/ Problem: With CMS, at certain points, 'OU' (Old usage) values reporte

Re: SA side fix for 8150689

Hello Yasumasa, It seems to be a good fix to have in SA. Please file a bug and send in your review request. Thanks, Poonam On 11/29/18 6:29 AM, Yasumasa Suenaga wrote: Hi all, Does someone work for adapting SA to the 8150689? 8150689 fixed not to show incorrect lock information in thread du

Re: [12] RFR (S) 8205534: Remove SymbolTable dependency from serviceability agent

Hello Coleen, The changes look good to me. One minor thing that I noticed though: At Line 94 in file src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/classfile/ClassLoaderData.java The comment above the function find() is removed. Is that intentional? Thanks, Poonam On 6/22/18 2:40 PM, c

Re: RFR: SA: MacOS X: 8184042: several serviceability/sa tests timed out on MacOS X

Hello Jini, I don't know much about the mach exceptions either. I read through your wiki page and looked at the relevant gdb and lldb code to understand how it works. A few points regarding the changes for this CR: File: src/jdk.hotspot.agent/macosx/native/libsaproc/MacosxDebuggerLocal.m 1.

RE: [10] RFR for JDK-8169961: Memory leak after debugging session

I think it cannot be removed. Thanks, Poonam > -Original Message- > From: Shafi Ahmad > Sent: Thursday, July 13, 2017 1:45 AM > To: serviceability-dev@openjdk.java.net > Cc: Poonam Parhar (poonam.ba...@oracle.com) > Subject: [10] RFR for JDK-8169961: Memory leak aft

RE: [10] RFR 8181647: jhsdb jstack could not output thread name

Hello Chihiro, The updated webrev looks good! Thanks, Poonam > -Original Message- > From: chihiro ito > Sent: Wednesday, July 05, 2017 12:58 PM > To: Poonam Parhar; Yasumasa Suenaga > Cc: serviceability-dev@openjdk.java.net > Subject: Re: [10] RFR 8181647: jhsdb jstac

RE: [10] RFR 8181647: jhsdb jstack could not output thread name

Hello Chihiro, The changes in the following webrev look good to me: http://cr.openjdk.java.net/~dbuck/8181647.0/ A few minor suggestions though: - src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/oops/OopUtilities.java Lines 354 - 370: Extra whitespace in the if conditions can be removed: if

RE: RFR(10): JDK-8178536: OOM ERRORS + SERVICE-THREAD TAKES A PROCESSOR TO 100%

Thanks Dan! I will incorporate your suggestions. Regards, Poonam > -Original Message- > From: Daniel D. Daugherty > Sent: Friday, June 16, 2017 10:13 AM > To: Poonam Parhar; Mandy Chung > Cc: serviceability-dev; hotspot-runtime-...@openjdk.java.net > Subject: Re: RF

Re: RFR(10): JDK-8178536: OOM ERRORS + SERVICE-THREAD TAKES A PROCESSOR TO 100%

On 6/14/2017 3:14 PM, Mandy Chung wrote: On Jun 14, 2017, at 12:58 PM, Poonam Parhar <mailto:poonam.ba...@oracle.com>> wrote: [Poonam] yes, that could also be another way. But for this bug, I would like to keep the changes in sync with how the exceptions in the Java code called

RE: RFR(10): JDK-8178536: OOM ERRORS + SERVICE-THREAD TAKES A PROCESSOR TO 100%

Hello Mandy,   Thanks for taking a look at the changes. My comments inlined below:   From: Mandy Chung Sent: Wednesday, June 14, 2017 10:18 AM To: Poonam Parhar Cc: hotspot-runtime-...@openjdk.java.net; serviceability-dev Subject: Re: RFR(10): JDK-8178536: OOM ERRORS + SERVICE-THREAD TAKES A

RFR(10): JDK-8178536: OOM ERRORS + SERVICE-THREAD TAKES A PROCESSOR TO 100%

Hello, Could I have reviews for the changes for the Bug HYPERLINK "https://bugs.openjdk.java.net/browse/JDK-8178536"; JDK-8178536: OOM ERRORS + SERVICE-THREAD TAKES A PROCESSOR TO 100%. Problem: If there are listeners installed for MemoryMXBean then in the event of an OOME, JVM internal threa

RE: [jdk10] RFR for 'JDK-8177721: Improve diagnostics in sun.management.Agent#startAgent()

Looks good to me too. Thanks, Poonam > -Original Message- > From: Daniel Fuchs > Sent: Wednesday, April 26, 2017 2:30 AM > To: Shafi Ahmad; Poonam Parhar; David Holmes; serviceability- > d...@openjdk.java.net; hotspot-runtime-...@openjdk.java.net > Subject: Re: [j

RE: [jdk10] RFR for 'JDK-8177721: Improve diagnostics in sun.management.Agent#startAgent()

Hello Shafi, You could do something like this: + public static void error(AgentConfigurationError e) { +String keyText = getText(e.getError()); +String params = e.getParams(); + +System.err.print(getText("agent.err.error") + ": " + keyText); + +if (params != null &