On Fri, 28 May 2021 10:49:32 GMT, Anton Kozlov wrote:
>> Please review a small change that adds an option to GC.heap_dump to use an
>> existing file.
>>
>> The option is necessary if the target file is a predefined file-like object,
>> like a named pipe. This opens up a lot of possibilities t
On Wed, 2 Jun 2021 20:57:02 GMT, Anton Kozlov wrote:
>> Please review a small change that adds an option to GC.heap_dump to use an
>> existing file.
>>
>> The option is necessary if the target file is a predefined file-like object,
>> like a named pipe. This opens up a lot of possibilities to
On Wed, 2 Jun 2021 20:57:02 GMT, Anton Kozlov wrote:
>> Please review a small change that adds an option to GC.heap_dump to use an
>> existing file.
>>
>> The option is necessary if the target file is a predefined file-like object,
>> like a named pipe. This opens up a lot of possibilities to
This change triggers a GC by System.gc() in the test case, so the created heap
dump is significantly smaller and the test runs much faster.
-
Commit messages:
- Improve performance of HeapDumpAllTest
Changes: https://git.openjdk.java.net/jdk/pull/5084/files
Webrev: https://webrevs
On Wed, 11 Aug 2021 19:19:51 GMT, Chris Plummer wrote:
> Is there a reason you don't want this change to also apply to HeapDumpTest?
Since the GC.heap_dump already does a GC it is not really needed. Of course
doing the gc in HeapDumpTest is a smaller change, so I'm open for that.
-
On Wed, 11 Aug 2021 13:05:06 GMT, Ralf Schmelter wrote:
> This change triggers a GC by System.gc() in the test case, so the created
> heap dump is significantly smaller and the test runs much faster.
This pull request has now been integrated.
Changeset: 73da66ff
Author: Ralf Schmelte
On Mon, 6 Sep 2021 08:03:22 GMT, Lin Zang wrote:
>> 8252842: Extend jmap to support parallel heap dump
>
> Lin Zang has updated the pull request incrementally with one additional
> commit since the last revision:
>
> fix build error
I will start reviewing this today.
-
PR: http
On Thu, 9 Sep 2021 20:07:25 GMT, Per Liden wrote:
>> JDK-8237354 introduced the concept of "foreground work" in WorkGang, as a
>> special case for use by the HeapDumper. I propose that we remove this code,
>> since this special use case can be solved without the need for the concept
>> of "for
On Mon, 6 Sep 2021 08:03:22 GMT, Lin Zang wrote:
>> 8252842: Extend jmap to support parallel heap dump
>
> Lin Zang has updated the pull request incrementally with one additional
> commit since the last revision:
>
> fix build error
The change seems OK so far, but I've found a few issues.
s
On Thu, 16 Sep 2021 09:35:20 GMT, Lin Zang wrote:
>> 8252842: Extend jmap to support parallel heap dump
>
> Lin Zang has refreshed the contents of this pull request, and previous
> commits have been removed. The incremental views will show differences
> compared to the previous content of the P
On Fri, 22 Oct 2021 06:21:37 GMT, Richard Reingruber wrote:
>> This change fixes deadlocks described in the JBS-bug by:
>>
>> * Releasing `handlerLock` before waiting on `threadLock` in
>> `blockOnDebuggerSuspend()`
>>
>> * Notifying on `threadLock` in `threadControl_reset()`
>>
>> Also the a
On Fri, 19 Feb 2021 14:36:00 GMT, Lin Zang wrote:
>> 8252842: Extend jmap to support parallel heap dump
>
> Lin Zang has updated the pull request incrementally with one additional
> commit since the last revision:
>
> fix build fail issue on windows
Hi,
I've benchmarked the code on my machi
On Mon, 22 Feb 2021 07:36:55 GMT, Lin Zang wrote:
>> Hi,
>>
>> I've benchmarked the code on my machine (128GB memory, 56 logical CPUs) with
>> an example creating a 32 GB heap dump. I only saw a 10 percent reduction in
>> time, both using uncompressed and compressed dumps. Have you seen better
On Tue, 23 Feb 2021 08:37:34 GMT, Lin Zang wrote:
>> Dear @ralf,
>> Really Thanks for benchmarking it!
>> It is a little surprise to me that "parallel=1" is 10~20 percent slower than
>> before. I believe this can be avoid with some revise in code. And I also
>> found a potential memory leak in
On Wed, 10 Mar 2021 09:41:21 GMT, Lin Zang wrote:
>> 8252842: Extend jmap to support parallel heap dump
>
> Lin Zang has updated the pull request incrementally with one additional
> commit since the last revision:
>
> reduce memory consumption and fix memory leak issue
src/hotspot/share/serv
On Thu, 18 Mar 2021 11:07:16 GMT, Lin Zang wrote:
>> Dear Ralf @schmelter-sap,
>> Sorry for late response, I got stuck in other work recently.
>> I have uploaded a new update that could help reduce memory consumption and
>> also fix the assertion issue.
>> I
On Wed, 12 May 2021 15:22:52 GMT, Richard Reingruber wrote:
>> src/hotspot/share/services/heapDumperCompression.cpp line 262:
>>
>>> 260: }
>>> 261:
>>> 262: void CompressionBackend::thread_loop() {
>>
>> You could simplify `CompressionBackend::thread_loop()` further:
>>
>>
>> void Compressi
r
> buffer is available, which will never happen.
>
> The fix is to take the buffer to write out of the queue in the iterating
> thread under lock protection and the do the unlocking.
Ralf Schmelter has updated the pull request with a new target base due to a
merge or a rebase.
On Thu, 22 Apr 2021 14:16:21 GMT, Ralf Schmelter wrote:
> This fixes a race condition in the CompressionBackend class of the heap dump
> code.
>
> The race happens when the thread iterating the heap wants to write the data
> it has collected. If the compression backend has work
19 matches
Mail list logo
