Re: RFR JDK-8225474: JDI connector accept fails "Address already in use" with concurrent listeners

Thanks Andrew! If you want more data points on failure modes, this and the linked issues might be a rich source: https://bugs.openjdk.java.net/browse/JDK-8184445 JShell is built on JDI and these various forms of intermittent attach failures have been a continual pain point. -Robert On 6/

Re: RFR JDK-8225474: JDI connector accept fails "Address already in use" with concurrent listeners

Thanks Andrew! Can I add my support for this.  I imagine this could be the cause of JShell failures in high-concurrency testing (JShell uses JDI, the failures are in connection). This is not a review, as I haven't been on the JPDA team for a LONG time. Just a request that this be prioritized

Re: JVMTI retransformation and addition of private methods

Rather than reverse engineer the spec from the hotspot implementation... Capabilities are the mechanism by which the level of functionality is defined.  Capabilities say what can be done, not what can't. The wording "The redefinition must not add, remove or rename fields or methods, change th

Re: RFR: 8189102: All tools should support -?, -h and --help

Thumbs up for JShell changes. -Robert > On Nov 28, 2017, at 3:16 AM, Lindenmaier, Goetz > wrote: > > Hi, > > I uploaded a new webrev: > http://cr.openjdk.java.net/~goetz/wr17/8189102-helpMessage/webrev.04/ > > This includes the changes > - to jshell requested by Robert > - to the test as

Re: RFR: 8189102: All tools should support -?, -h and --help

JShell changes — The code change is fine. The help change in the properties file is not consistent with the other items, note:--help-extra, -X Print help on… so this should be: —help, -h, -? Or, if there is a tool-wide standard, then the —help-extra entry should be chang

Re: CFV: New Serviceability Group Lead: Serguei Spitsyn

Vote: yes On April 4, 2017 10:15:12 AM Staffan Larsen wrote: Vote: yes On Tue, 4 Apr 2017 at 16:03 Tim Bell wrote: Vote: yes Tim On 04/04/17 06:46, Daniel D. Daugherty wrote: > I hereby nominate Serguei Spitsyn to Serviceability Group Lead

Re: CFV: New Serviceability Group Member: Staffan Larsen

Vote: yes Robert On 06/17/16 16:22, Daniel D. Daugherty wrote: I hereby nominate Staffan Larsen to Membership in the Serviceability Group. Staffan is a Reviewer in the jdk9 and jdk8u Projects, a member of the Serviceability team, and has so far committed > 145 changesets. He is the Serviceabi

hg: jdk8/tl/jdk: 8035777: Consistent Lambda construction

Changeset: 183a8c520b4a Author:rfield Date: 2014-02-28 10:43 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/183a8c520b4a 8035777: Consistent Lambda construction Reviewed-by: ahgross, briangoetz, dlsmith ! src/share/classes/java/lang/invoke/AbstractValidatingLambdaMetafactory

hg: jdk8/tl/jdk: 8032697: Issues with Lambda

Changeset: e385bd6f7338 Author:rfield Date: 2014-01-28 17:23 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/e385bd6f7338 8032697: Issues with Lambda Reviewed-by: ahgross, briangoetz, dlsmith, rfield Contributed-by: daniel.sm...@oracle.com ! src/share/classes/java/lang/invoke

hg: jdk8/tl/jdk: 8032711: Issue with Lambda in handling; ...

Changeset: c8d9cdc6445c Author:rfield Date: 2014-01-28 13:02 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/c8d9cdc6445c 8032711: Issue with Lambda in handling 8032704: Issues with lib perm in Lambda Reviewed-by: jrose, ahgross, briangoetz ! src/share/classes/java/lang/invok

hg: jdk8/tl/langtools: 8029558: java.lang.VerifyError: Bad return type when lambda's body is in parentheses

Changeset: 847cc0cccfa1 Author:rfield Date: 2013-12-11 11:56 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/847cc0cccfa1 8029558: java.lang.VerifyError: Bad return type when lambda's body is in parentheses Summary: properly type convert the body of a lambda expression

hg: jdk8/tl/langtools: 8028739: javac generates incorrect descriptor for MethodHandle::invoke

Changeset: 4fa835472e3c Author:rfield Date: 2013-11-22 17:07 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/4fa835472e3c 8028739: javac generates incorrect descriptor for MethodHandle::invoke Summary: introduce special handling for signature polymorphic methods Reviewed

hg: jdk8/tl/jdk: 8027803: test/sun/reflect/AnonymousNewInstance/ManyNewInstanceAnonTest.java fails

Changeset: c04e46dbfea8 Author:rfield Date: 2013-11-11 16:14 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/c04e46dbfea8 8027803: test/sun/reflect/AnonymousNewInstance/ManyNewInstanceAnonTest.java fails Summary: fix NPE in test infrastructure Reviewed-by: ksrini, jfranck, al

hg: jdk8/tl/jdk: 7194897: JSR 292: Cannot create more than 16 instances of an anonymous class; ...

Changeset: 51b002381b35 Author:rfield Date: 2013-11-04 10:12 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/51b002381b35 7194897: JSR 292: Cannot create more than 16 instances of an anonymous class 8027681: Lambda serialization fails once reflection proxy generation kicks in

hg: jdk8/tl/langtools: 8027220: DefaultMethodsTest: Change test to match spec

Changeset: 860f1d21763a Author:rfield Date: 2013-10-24 16:52 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/860f1d21763a 8027220: DefaultMethodsTest: Change test to match spec Reviewed-by: ksrini ! test/tools/javac/lambdaShapes/org/openjdk/tests/separate/TestHarness.ja

hg: jdk8/tl/jdk: 8025868: Several lang/LMBD JCK tests fail with java.lang.BootstrapMethodError

Changeset: d9d3705a992f Author:rfield Date: 2013-10-23 15:16 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/d9d3705a992f 8025868: Several lang/LMBD JCK tests fail with java.lang.BootstrapMethodError Summary: Wildcard marker interfaces can cause duplicate implemented interface

hg: jdk8/tl/jdk: 8027176: Remove redundant jdk/lambda/vm/DefaultMethodsTest.java

Changeset: 88acc99132e2 Author:rfield Date: 2013-10-23 11:36 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/88acc99132e2 8027176: Remove redundant jdk/lambda/vm/DefaultMethodsTest.java Reviewed-by: ksrini - test/jdk/lambda/vm/DefaultMethodsTest.java

hg: jdk8/tl/langtools: 8022720: Method refeerences - private method should be accessible (nested classes)

Changeset: 32ea6ccb7607 Author:rfield Date: 2013-10-23 10:28 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/32ea6ccb7607 8022720: Method refeerences - private method should be accessible (nested classes) Reviewed-by: jjg, ksrini ! src/share/classes/com/sun/tools/javac

hg: jdk8/tl/langtools: 8023668: Desugar serializable lambda bodies using more robust naming scheme

Changeset: 6cd16d8ed2b9 Author:rfield Date: 2013-10-22 16:53 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/6cd16d8ed2b9 8023668: Desugar serializable lambda bodies using more robust naming scheme Summary: lambda / bridged method-reference naming overhaul Reviewed-by: k

hg: jdk8/tl/jdk: 8025631: Enhance Lambda construction

Changeset: 71ecbde5e5e4 Author:rfield Date: 2013-10-20 18:07 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/71ecbde5e5e4 8025631: Enhance Lambda construction Reviewed-by: ksrini, ahgross ! src/share/classes/java/lang/invoke/InnerClassLambdaMetafactory.java - src/share/classe

hg: jdk8/tl/jdk: 8026213: Reflection support for private interface methods

Changeset: 4561460bf570 Author:rfield Date: 2013-10-11 15:21 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/4561460bf570 8026213: Reflection support for private interface methods Reviewed-by: forax, psandoz, dholmes, jfranck Contributed-by: karen.kinn...@oracle.com ! src/sha

hg: jdk8/tl/langtools: 8012557: Implement lambda methods on interfaces as private; ...

Changeset: 1ce8405af5fe Author:rfield Date: 2013-10-10 23:26 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/1ce8405af5fe 8012557: Implement lambda methods on interfaces as private 8016320: Method reference in subinterface of type I.super::foo produces exception at runt

hg: jdk8/tl/jdk: 8021186: jdk/lambda/vm/DefaultMethodsTest.java fails

Changeset: 7736abdf0805 Author:rfield Date: 2013-10-04 09:54 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/7736abdf0805 8021186: jdk/lambda/vm/DefaultMethodsTest.java fails Summary: remove DefaultMethodsTest from jdk/test/problemList.txt Reviewed-by: mduigou ! test/ProblemL

hg: jdk8/tl/jdk: 8020849: jdk/lambda/vm/DefaultMethodsTest.java

Changeset: 1b3616c4a836 Author:rfield Date: 2013-10-03 11:26 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/1b3616c4a836 8020849: jdk/lambda/vm/DefaultMethodsTest.java Summary: Bridge generation has been removed from the VM. Fix is to remove tests that no longer make sense.

hg: jdk8/tl/jdk: 8010433: Remove lambda metafactory work-around to JDK-8005119

Changeset: 8d8b809dd294 Author:rfield Date: 2013-10-03 10:23 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/8d8b809dd294 8010433: Remove lambda metafactory work-around to JDK-8005119 Summary: Restore invokespecial to lambda metafactory Reviewed-by: ksrini ! src/share/classes

hg: jdk8/tl/langtools: 8025548: langtools test tools/javac/lambda/methodReference/BridgeMethod.java incorrectly assumes no other methods generated in lambda class

Changeset: dee28dd47e12 Author:rfield Date: 2013-09-27 13:06 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/dee28dd47e12 8025548: langtools test tools/javac/lambda/methodReference/BridgeMethod.java incorrectly assumes no other methods generated in lambda class Reviewed

hg: jdk8/tl/jdk: 8024260: 10 closed/java/lang/invoke/* tests failing after overhaul to MethodHandleInfo

Changeset: f2487bb0c0d2 Author:rfield Date: 2013-09-06 00:43 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/f2487bb0c0d2 8024260: 10 closed/java/lang/invoke/* tests failing after overhaul to MethodHandleInfo Reviewed-by: vlivanov, briangoetz Contributed-by: john.r.r...@oracl

hg: jdk8/tl/jdk: 8024283: 10 nashorn tests fail with similar stack trace InternalError with cause being NoClassDefFoundError

Changeset: 9cc74675a854 Author:rfield Date: 2013-09-05 14:58 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/9cc74675a854 8024283: 10 nashorn tests fail with similar stack trace InternalError with cause being NoClassDefFoundError Summary: Fix pre-existing 292 bug tickled by c

hg: jdk8/tl/jdk: 8020816: Metafactory crashes on code with method reference; ...

Changeset: bd6fcc5eebb8 Author:rfield Date: 2013-09-04 19:47 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/bd6fcc5eebb8 8020816: Metafactory crashes on code with method reference 8021050: MethodHandleInfo throws exception when method handle is to a method with @CallerSensit

hg: jdk8/tl/jdk: 8008688: Make MethodHandleInfo public

Changeset: 4bdbd1fabea4 Author:rfield Date: 2013-09-03 21:42 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/4bdbd1fabea4 8008688: Make MethodHandleInfo public Summary: A major overhaul to MethodHandleInfo and method handles in general. Reviewed-by: vlivanov, twisti Contribute

hg: jdk8/tl/jdk: 8016761: Lambda metafactory - incorrect type conversion of constructor method handle

Changeset: 71059bca036a Author:rfield Date: 2013-06-26 07:50 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/71059bca036a 8016761: Lambda metafactory - incorrect type conversion of constructor method handle Reviewed-by: jrose ! src/share/classes/java/lang/invoke/InnerClassLa

hg: jdk8/tl/jdk: 8015402: Lambda metafactory should not attempt to determine bridge methods

Changeset: 989049977d04 Author:rfield Date: 2013-06-17 20:31 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/989049977d04 8015402: Lambda metafactory should not attempt to determine bridge methods Summary: paired with 8013789: Compiler should emit bridges in interfaces Reviewe

hg: jdk8/tl/langtools: 8013789: Compiler should emit bridges in interfaces

Changeset: 455be95bd1b5 Author:rfield Date: 2013-06-17 20:29 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/455be95bd1b5 8013789: Compiler should emit bridges in interfaces Summary: paired with 8015402: Lambda metafactory should not attempt to determine bridge methods

hg: jdk8/tl/langtools: 8012556: Implement lambda methods on interfaces as static; ...

Changeset: c09b7234cded Author:rfield Date: 2013-05-14 11:11 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/c09b7234cded 8012556: Implement lambda methods on interfaces as static 8006140: Javac NPE compiling Lambda expression on initialization expression of static fiel

Re: RFR: 8008453: JvmtiClassFileReconstituter does not recognize default methods

On 05/02/13 04:08, Staffan Larsen wrote: On 2 maj 2013, at 12:58, serguei.spit...@oracle.com wrote: If I understand correctly, the default methods are generated by the VM and have no presence in class file. Is that right? Yes, that is my understanding

hg: jdk8/tl/langtools: 8011591: BootstrapMethodError when capturing constructor ref to local classes

Changeset: 8e27e84de2e9 Author:rfield Date: 2013-05-01 08:46 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/8e27e84de2e9 8011591: BootstrapMethodError when capturing constructor ref to local classes Reviewed-by: mcimadamore ! src/share/classes/com/sun/tools/javac/comp/

hg: jdk8/tl/jdk: 8012028: Metafactory-generated lambda classes should be final; ...

Changeset: 06dfdfa8c3e6 Author:rfield Date: 2013-04-12 20:23 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/06dfdfa8c3e6 8012028: Metafactory-generated lambda classes should be final 8008941: isSynthetic() returns false for lambda instances Reviewed-by: mduigou ! src/share/c

hg: jdk8/tl/jdk: 8011805: Update sun.tools.java class file reading/writing support to include the new constant pool entries

Changeset: e2cd40d7567c Author:rfield Date: 2013-04-12 10:02 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/e2cd40d7567c 8011805: Update sun.tools.java class file reading/writing support to include the new constant pool entries Reviewed-by: mduigou, alanb ! src/share/classe

hg: jdk8/tl/langtools: 8010010: NPE generating serializedLambdaName for nested lambda

Changeset: fbbf5376e7e4 Author:rfield Date: 2013-03-14 22:54 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/fbbf5376e7e4 8010010: NPE generating serializedLambdaName for nested lambda Reviewed-by: mcimadamore ! src/share/classes/com/sun/tools/javac/comp/LambdaToMethod.

hg: jdk8/tl/langtools: 8009742: Bad lambda name for lambda in a static initializer or ctor

Changeset: d0ae21e3a382 Author:rfield Date: 2013-03-11 10:02 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/d0ae21e3a382 8009742: Bad lambda name for lambda in a static initializer or ctor Reviewed-by: mcimadamore ! src/share/classes/com/sun/tools/javac/comp/LambdaToMe

hg: jdk8/tl/langtools: 8009582: Method reference generic constructor gives: IllegalArgumentException: Invalid lambda deserialization

Changeset: a02c3ddc182b Author:rfield Date: 2013-03-07 08:26 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/a02c3ddc182b 8009582: Method reference generic constructor gives: IllegalArgumentException: Invalid lambda deserialization Reviewed-by: mcimadamore ! src/share/

hg: jdk8/tl/jdk: 8008770: SerializedLambda incorrect class loader for lambda deserializing class

Changeset: 5ebc62421717 Author:rfield Date: 2013-02-26 10:38 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/5ebc62421717 8008770: SerializedLambda incorrect class loader for lambda deserializing class Summary: current thread's context ClassLoader was used to load class by nam

hg: jdk8/tl/jdk: 8008356: Test LambdaSerialization.java failing

Changeset: 1da987f0311a Author:rfield Date: 2013-02-21 15:46 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/1da987f0311a 8008356: Test LambdaSerialization.java failing Summary: run in /othervm mode Reviewed-by: ksrini ! test/java/lang/invoke/lambda/LambdaSerialization.java

hg: jdk8/tl/langtools: 8008405: Now that metafactory is in place, add javac lambda serialization tests

Changeset: cd7340a84bb8 Author:rfield Date: 2013-02-21 14:43 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/cd7340a84bb8 8008405: Now that metafactory is in place, add javac lambda serialization tests Summary: Tests part of original langtools serialization review. Revie

hg: jdk8/tl/jdk: 8004970: Implement serialization in the lambda metafactory

Changeset: 7748ffdca16a Author:rfield Date: 2013-02-16 12:36 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/7748ffdca16a 8004970: Implement serialization in the lambda metafactory Reviewed-by: forax ! src/share/classes/java/lang/invoke/AbstractValidatingLambdaMetafactory.jav

hg: jdk8/tl/jdk: 8003881: Prevent lambda implementing inner classes from allowing the creation of new instances

Changeset: 896d4af2ebfd Author:rfield Date: 2012-12-06 21:55 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/896d4af2ebfd 8003881: Prevent lambda implementing inner classes from allowing the creation of new instances Summary: Lambda implementing inner classes now has private

hg: jdk8/tl/langtools: 8003639: convert lambda testng tests to jtreg and add them

Changeset: d898d9ee352f Author:rfield Date: 2012-11-20 09:58 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/d898d9ee352f 8003639: convert lambda testng tests to jtreg and add them Reviewed-by: mcimadamore + test/tools/javac/defaultMethodExecution/DefaultMethodRegressio

hg: jdk8/tl/langtools: 8003306: Compiler crash: calculation of inner class access modifier

Changeset: e6b1abdc11ca Author:rfield Date: 2012-11-13 08:06 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/e6b1abdc11ca 8003306: Compiler crash: calculation of inner class access modifier Summary: Fix binary sense lost in transition to hasTag Reviewed-by: mcimadamore

hg: jdk8/tl/langtools: 8000694: Add generation of lambda implementation code: invokedynamic call, lambda method, adaptor methods

Changeset: a65971893c50 Author:rfield Date: 2012-10-29 10:39 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/a65971893c50 8000694: Add generation of lambda implementation code: invokedynamic call, lambda method, adaptor methods Summary: Add lambda implementation code wi

hg: jdk8/tl/jdk: 8000806: Implement runtime lambda metafactory

Changeset: 6302932b7380 Author:rfield Date: 2012-10-25 17:34 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/6302932b7380 8000806: Implement runtime lambda metafactory Summary: Implement lambda invokedynamic bootstrap by generating at runtime an inner class that implements th

Re: Request for review (S): JDWP spec

On 4/14/11 1:01 PM, Alan Bateman wrote: ...I see in other command sets that have commands that require capabilities that it uses the phrase "Requires XXX capability" - just wondering if that might be better than "Only generated by VMs which support the XXX capability". +1

Re: Proposal to add Tomas Hurka as a member of the Serviceability Group

serguei spitsyn sundararajan a swamy venkataramanappa robert field Thanks - jjh [1] http://blogs.sun.com/mr/entry/cosmology