Thank you David and Serguei.
I have uploaded the webrev for my reference.
http://cr.openjdk.java.net/~shshahma/8165736/hotspot.01/
Regards,
Shafi
> -Original Message-
> From: Serguei Spitsyn
> Sent: Tuesday, April 03, 2018 12:03 AM
> To: David Holmes ; Shafi Ahmad
> ;
Hi,
Please review the backport of ' JDK-8165736: Error message should be shown when
JVMTI agent cannot be attached' to jdk8u-dev.
Please note that this is not a clean backport because we can't not backport
native jtreg tests as infrastructure of naive jtreg test has been available
since JDK 9.
Hi,
Could someone please review it.
Regards,
Shafi
> -Original Message-
> From: Shafi Ahmad
> Sent: Monday, January 29, 2018 6:02 PM
> To: serviceability-dev@openjdk.java.net
> Subject: [8u] RFR for 'JDK-8195088: [TEST_BUG] StartManagementAgent got
> unexpe
Hi,
Please review the trivial code change for the fix of 'JDK-8195088: [TEST_BUG]
StartManagementAgent got unexpected exception' to jdk8u-dev.
Summary:
This test case is expected to fail but the expected exception message is
different.
This fix
-if (!ex.getMessage().contains("Inval
: David Holmes ; Shafi Ahmad
Cc: serviceability-dev@openjdk.java.net
Subject: Re: [10] RFR for JDK-8170299: Debugger does not stop inside the low
memory notifications code [internal]
On 12/11/17 9:32 PM, David Holmes wrote:
Hi Shafi,
I missed the first round of reviews on this so hadn't
I will send the updated webrev after incorporating the review comment.
Regards,
Shafi
From: mandy chung
Sent: Tuesday, December 12, 2017 2:35 AM
To: Shafi Ahmad
Cc: serviceability-dev@openjdk.java.net
Subject: Re: [10] RFR for JDK-8170299: Debugger does not stop inside the low
cuted with the service
thread, which is a hidden thread.
shafi@shafi-ahmad:~/Java/jdk8/jdk8u-dev$ jdb -Xmx32m MemoryWarningSystem
Initializing jdb ...
> stop at MemoryWarningSystem$1:25
Deferring breakpoint MemoryWarningSystem$1:25.
It will be set after the class is loaded
Thank you David.
Regards,
Shafi
> -Original Message-
> From: David Holmes
> Sent: Thursday, November 02, 2017 11:55 AM
> To: Shafi Ahmad ; Daniel Fuchs
> ; serviceability-dev@openjdk.java.net
> Subject: Re: [8u] RFR for backport of JDK-8177721: Impr
Hi All,
May get the second review for this backport.
Regards,
Shafi
> -Original Message-
> From: Daniel Fuchs
> Sent: Wednesday, October 25, 2017 2:34 PM
> To: Shafi Ahmad ; serviceability-
> d...@openjdk.java.net
> Cc: David Holmes
> Subject: Re: [8u] RFR for ba
Hi Daniel,
Thank you for the review.
Regards,
Shafi
> -Original Message-
> From: Daniel Fuchs
> Sent: Wednesday, October 25, 2017 2:34 PM
> To: Shafi Ahmad ; serviceability-
> d...@openjdk.java.net
> Cc: David Holmes
> Subject: Re: [8u] RFR for backport of
Hi,
Please review the backport of "JDK-8177721: Improve diagnostics in
sun.management.Agent#startAgent()" to jdk8u-dev.
The backport is not clean as I got the below conflict.
shshahma@slc12kkg:/scratch/shshahma/Java/jdk8u-dev/jdk$ cat
src/share/classes/sun/management/Agent.java.rej
--- Agent.ja
om: mandy chung
Sent: Tuesday, September 12, 2017 2:19 AM
To: Shafi Ahmad ; serviceability-dev@openjdk.java.net
Cc: Poonam Parhar
Subject: Re: [10] RFR for JDK-8170299: Debugger does not stop inside the low
memory notifications code
On 9/4/17 3:11 AM, Shafi Ahmad wrote:
The method hasL
Gentle reminder.
Regards,
Shafi
From: Shafi Ahmad
Sent: Thursday, September 07, 2017 11:43 AM
To: Daniel Daugherty ;
serviceability-dev@openjdk.java.net
Subject: RE: [10] RFR for JDK-8170299: Debugger does not stop inside the low
memory notifications code
Hi Daniel,
Thank
perty:
-Djmx-registry.port=
test result: Failed. Execution failed: `main' threw exception:
java.lang.RuntimeException: Specify port with system property:
-Djmx-registry.port=
Regards,
Shafi
From: Daniel D. Daugherty
Sent: Tuesday, September 05, 2017 10:36 PM
To: S
17 4:11 AM, Shafi Ahmad wrote:
Hi,
Please review the fix for ‘JDK-8170299:
Debugger does not stop inside the low memory notifications
code’ to jdk10.
With the current implementation
Hi,
Please review the fix for 'JDK-8170299: Debugger does not stop inside the low
memory notifications code' to jdk10.
With the current implementation 'debugger does not stop inside the low memory
*notifications* code'
This is expected as the notification code is getting executed with t
Thank you Serguei.
Regards,
Shafi
> -Original Message-
> From: Serguei Spitsyn
> Sent: Thursday, August 24, 2017 12:49 AM
> To: Shafi Ahmad ; serviceability-
> d...@openjdk.java.net
> Cc: Langer, Christoph ; Daniel Daugherty
>
> Subject: Re: [8u] RFR for JDK-81
Hi,
Please review the backport of bug: "JDK-8169961: Memory leak after debugging
session" to jdk8u-dev
Please note that this is not a clean backport due to small conflict -
shshahma@slc12kkg:/scratch/shshahma/Java/jdk8u-dev-base/jdk$ cat
src/share/classes/com/sun/tools/jdi/TargetVM.java.rej
-
August 10, 2017 12:27 AM
> To: Daniel Daugherty ; Shafi Ahmad
> ; serviceability-dev@openjdk.java.net
> Cc: Roger Calnan
> Subject: Re: [10] RFR for JDK-8169961: Memory leak after debugging session
>
> On 8/9/17 08:27, Daniel D. Daugherty wrote:
> > On 8/9/17 3:05 AM, Shafi
May I get it reviewed by serviceability team.
Regards,
Shafi
> -Original Message-
> From: Shafi Ahmad
> Sent: Wednesday, July 26, 2017 8:26 AM
> To: serviceability-dev@openjdk.java.net
> Cc: Roger Calnan
> Subject: RE: [10] RFR for JDK-8169961: Memory leak after
May I get it reviewed by someone from serviceability group.
Webrev link: http://cr.openjdk.java.net/~shshahma/8169961/webrev.01/
This review thread:
http://mail.openjdk.java.net/pipermail/serviceability-dev/2017-July/021538.html
Regards,
Shafi
> -Original Message-
> From: Shafi
Hi,
> -Original Message-
> From: Langer, Christoph [mailto:christoph.lan...@sap.com]
> Sent: Monday, July 17, 2017 9:01 PM
> To: Poonam Parhar
> Cc: Shafi Ahmad ; serviceability-
> d...@openjdk.java.net
> Subject: RE: [10] RFR for JDK-8169961: Memory leak after debu
Hi Daniel,
> -Original Message-
> From: Langer, Christoph [mailto:christoph.lan...@sap.com]
> Sent: Monday, July 17, 2017 6:44 PM
> To: Shafi Ahmad ; Daniel Daugherty
>
> Cc: serviceability-dev@openjdk.java.net
> Subject: RE: [10] RFR for JDK-8169961: Memory leak af
Hi Daniel,
Thank you for the review.
> -Original Message-
> From: Daniel D. Daugherty
> Sent: Friday, July 14, 2017 6:46 AM
> To: Shafi Ahmad ; serviceability-
> d...@openjdk.java.net
> Subject: Re: [10] RFR for JDK-8169961: Memory leak after debugging session
>
Hi Daniel,
Thank you for the review.
> -Original Message-
> From: Daniel D. Daugherty
> Sent: Thursday, July 13, 2017 7:40 PM
> To: Shafi Ahmad ; serviceability-
> d...@openjdk.java.net
> Subject: Re: [10] RFR for JDK-8169961: Memory leak after debugging session
>
Hi Christoph,
Thank you for reviewing.
Regards,
Shafi
> -Original Message-
> From: Langer, Christoph [mailto:christoph.lan...@sap.com]
> Sent: Thursday, July 13, 2017 4:16 PM
> To: Shafi Ahmad
> Cc: serviceability-dev@openjdk.java.net
> Subject: RE: [10] RFR for J
Hi,
Please review the code change for the fix of bug 'JDK-8169961: Memory leak
after debugging session'
Summary:
1. It seems that the thread created for
com.sun.tools.jdi.TargetVM.EventController is never stopped and keeps a hard
reference to the VirtualMachineImpl. This leads to VirtualMach
> Sent: Thursday, April 27, 2017 2:35 AM
> To: Shafi Ahmad ; Poonam Parhar
> ; Daniel Fuchs ;
> serviceability-dev@openjdk.java.net; hotspot-runtime-
> d...@openjdk.java.net
> Subject: Re: [jdk10] RFR for 'JDK-8177721: Improve diagnostics in
> sun.management.Agent#startAgent()
>
uchs ; David Holmes
> ; Shafi Ahmad ;
> serviceability-dev@openjdk.java.net; hotspot-runtime-
> d...@openjdk.java.net
> Subject: RE: [jdk10] RFR for 'JDK-8177721: Improve diagnostics in
> sun.management.Agent#startAgent()
>
> Hello Shafi,
>
> You could do somethin
Hi,
Please review the trivial code change for the fix of 'JDK-8177721: Improve
diagnostics in sun.management.Agent#startAgent()' to jdk10.
Summary:
In method exportMBeanServer of
sun/management/jmxremote/ConnectorBootstrap.java, we wrap IOException in
AgentConfigurationError.
But in jdk/intern
Sending it to runtime alias too.
Please note that the changes in the test case are done only for testing
purpose. It will not be a part of final checkin.
Any way attached webrev don't have this change.
Regards,
Shafi
-Original Message-
From: Shafi Ahmad
Sent: Wednesday, Apr
31 matches
Mail list logo
