Thanks for all the reviews.
Marcus Larsson has kindly agreed to sponsor the patch.
Cheers,
Staffan
On 12/03/2014 01:21 AM, Thomas Schatzl wrote:
On Tue, 2014-12-02 at 10:50 -0800, Staffan Friberg wrote:
Hi,
As noted in the original thread [1] about this event we split up the
commit in 4
Hi,
As noted in the original thread [1] about this event we split up the
commit in 4 different steps. This is the first step that only adds the
event and methods to send them, but the usage will be added separately
for the 3 GCs using PLABs.
Bug (sub-task): https://bugs.openjdk.java.net/brow
arate review for
that later today and the others will follow later.
Cheers,
Staffan
On 11/19/2014 08:23 AM, Staffan Friberg wrote:
Hi,
Erik and Tomas asked me to separate the G1 changes which was pushed
separately in JDK-8064473.
Erik also had some further comments offline that I have taken
Rutisson wrote:
On 2014-11-06 14:00, Staffan Friberg wrote:
Good catch, fixed.
// Too large; allocate the object individually.
obj = sp->par_allocate(word_sz);
if (obj != NULL) {
gc_tracer()->report_promotion_outside_plab_event(old, word_sz, age,
false);
}
Please
h this.
Thanks,
Staffan
On 11/06/2014 12:01 PM, Bengt Rutisson wrote:
Hi Staffan,
On 2014-11-06 11:12, Staffan Friberg wrote:
Hi,
After further off list discussion it was decided to keep the
gc_tracer in par_promote as is.
I have uploaded a new webrev,
http://cr.openjdk.java.net/~sf
to Erik a bit about how to handle the gc_tracer in
par_promote. He'll get back to you with some thoughts on that.
Thanks,
Bengt
On 2014-09-06 00:20, Staffan Friberg wrote:
Hi,
I have uploaded a new webrev here,
cr.openjdk.java.net/~sfriberg/8055845/webrev.03
It contains several ch
Hi,
Uploaded a new webrev, with the changes from your comments here and from
Bengt's email.
http://cr.openjdk.java.net/~sfriberg/8055845/webrev.04
See inline for comments.
On 09/15/2014 05:57 AM, Thomas Schatzl wrote:
Hi,
On Fri, 2014-09-05 at 15:20 -0700, Staffan Friberg wrote:
H
14:57 +0200, Thomas Schatzl wrote:
Hi,
On Fri, 2014-09-05 at 15:20 -0700, Staffan Friberg wrote:
Hi,
I have uploaded a new webrev here,
cr.openjdk.java.net/~sfriberg/8055845/webrev.03
It contains several changes
- Split event into two events (PromoteObjectInNewPLAB,
PromoteObjectOutsid
send the events before we
realize that the allocation has failed, i.e. new_obj is NULL.
I talked to Erik a bit about how to handle the gc_tracer in
par_promote. He'll get back to you with some thoughts on that.
Thanks,
Bengt
On 2014-09-06 00:20, Staffan Friberg wrote:
Hi,
I have uplo
event has size information in bytes
rather than words
Thanks for offline comments and suggestions from Dmitry and Thomas.
Cheers,
Staffan
On 08/29/2014 03:32 PM, Staffan Friberg wrote:
Hi Erik,
On 08/28/2014 11:34 PM, Erik Helin wrote:
(it seems like we lost hotspot-gc-...@openjdk.java.net so
Hi Erik,
On 08/28/2014 11:34 PM, Erik Helin wrote:
(it seems like we lost hotspot-gc-...@openjdk.java.net somewhere in
this thread, I'm adding it back)
On 2014-08-28 23:15, Staffan Friberg wrote:
Hi Erik,
Thanks for the comments.
- Aren't the events for promotion to the tenured
:15 PM, Staffan Friberg wrote:
Hi Erik,
Thanks for the comments.
- Aren't the events for promotion to the tenured generation (SerialOld)
and the CMS generation missing?
The reason for leaving out these two, Serial completely and CMS
promotion, was due to that neither as far as I understand
Bengt Rutisson wrote:
Hi all,
Staffan sent me an updated webrev based on Erik's comments. I uploaded
it here:
http://cr.openjdk.java.net/~brutisso/8055845/webrev.01/
Thanks,
Bengt
On 2014-08-25 19:32, Staffan Friberg wrote:
Hi Erik,
No issue with naming the field class, since the e
nformation:
- format of event
(this could be included in the CR description)
- regression tests for that event will be also required
- please include hotspot-dev on CC
Thanks,
Dima
On 25.08.2014 20:28, Staffan Friberg wrote:
Hi,
Could I please get reviews for this RFE that adds a trace event
and/or a field name that better reflects what we really mean with age.
Otherwise trace.xml looks good!
Erik
Staffan Friberg skrev 25/08/14 18:28:
Hi,
Could I please get reviews for this RFE that adds a trace event for
aging and promotion for young collections in G1, CMS and Parallel GC.
It w
Hi,
Could I please get reviews for this RFE that adds a trace event for
aging and promotion for young collections in G1, CMS and Parallel GC.
It works similarly to allocation events, and generates the event on the
slow path when either a direct copy occurs or a new PLAB is request.
Since I'm
16 matches
Mail list logo
