RE: RFR: 8011888: sa.js: TypeError: [object JSAdapter] has no such function "__has__"

2013-08-23 Thread Yunda
Peter & Kris Thank both of you very much! Yunda From: serviceability-dev-boun...@openjdk.java.net [mailto:serviceability-dev-boun...@openjdk.java.net] On Behalf Of Peter Allwin Sent: Thursday, August 22, 2013 5:34 PM To: Krystal Mok Cc: serviceability-dev@openjdk.java.net; hot

RE: [PATCH] EnableTracing: output from multiple threads may be mixed together

2013-05-13 Thread Yunda
Rickard, Thank you very much for doing this! Regards, Yunda > -Original Message- > From: Rickard Bäckman [mailto:rickard.back...@oracle.com] > Sent: Tuesday, May 14, 2013 1:35 PM > To: 云达(Yunda) > Cc: David Holmes; serviceability-dev@openjdk.java.net; &g

RE: [PATCH] EnableTracing: output from multiple threads may be mixed together

2013-05-09 Thread Yunda
Thanks for looking at this, Rickard. David, do you like this option which is easier to read, too :) Regards, Yunda > -Original Message- > From: Rickard Bäckman [mailto:rickard.back...@oracle.com] > Sent: Thursday, May 09, 2013 4:53 PM > To: 云达(Yunda) > Cc: David Holmes;

RE: [PATCH] EnableTracing: output from multiple threads may be mixed together

2013-05-09 Thread Yunda
lse { + writeEventContent(); +} + } + + void writeEventContent() { TraceStream ts(*tty); ts.print(": ["); Regards, Yunda > -Original Message- > From: Rickard Bäckman [mailto:rickard.back...@oracle.com] > Sent: Wednesday, May 08, 2013 3:03 PM > To: David H

RE: [PATCH] EnableTracing: output from multiple threads may be mixed together

2013-05-07 Thread Yunda
} TraceStream ts(*tty); ts.print(": ["); ts.print("]\n"); +if (UseLockedTracing) { + ttyLocker::release_tty(holder); +} } }; Regards, Yunda > -Original Message- > From: David Holmes [mailto:david.hol...@oracle.com] >

RE: [PATCH] EnableTracing: output from multiple threads may be mixed together

2013-05-07 Thread Yunda
David, I've made a stupid mistake and please ignore it... Regards, Yunda > -Original Message- > From: 云达(Yunda) > Sent: Tuesday, May 07, 2013 5:44 PM > To: 'David Holmes' > Cc: hotspot-runtime-...@openjdk.java.net; > serviceability-dev@openj

RE: [PATCH] EnableTracing: output from multiple threads may be mixed together

2013-05-07 Thread Yunda
07 17:38:58 2013 +0800 @@ -132,6 +132,9 @@ void writeEvent(void) { ResourceMark rm; HandleMark hm; +if (UseLockedTracing) { + ttyLocker ttyl; +} TraceStream ts(*tty); ts.print(": ["); Regards, Yunda > -Original Message- > From: David Holmes

RE: [PATCH] EnableTracing: output from multiple threads may be mixed together

2013-05-02 Thread Yunda
Hi Kirk, Now I understand you. The situation you mentioned happens in the "gc.log" file. My fix won't affect it because EnableTracing doesn't change things already there. It just adds event records. At least I think so. Regards, Yunda ___

RE: [PATCH] EnableTracing: output from multiple threads may be mixed together

2013-05-02 Thread Yunda
Staffan, Thanks! Regards, Yunda From: Staffan Larsen [staffan.lar...@oracle.com] Sent: Thursday, May 02, 2013 20:57 To: 云达(Yunda) Cc: hotspot-runtime-...@openjdk.java.net; serviceability-dev@openjdk.java.net Subject: Re: [PATCH] EnableTracing: output

RE: [PATCH] EnableTracing: output from multiple threads may be mixed together

2013-05-02 Thread Yunda
Rickard, Thanks for the review! Regards, Yunda From: Rickard Bäckman [rickard.back...@oracle.com] Sent: Thursday, May 02, 2013 13:11 To: 云达(Yunda) Cc: hotspot-runtime-...@openjdk.java.net; serviceability-dev@openjdk.java.net Subject: Re: [PATCH

RE: [PATCH] EnableTracing: output from multiple threads may be mixed together

2013-05-02 Thread Yunda
Kirk, I'm not quite clear what "the other mixed up log files" means, since when using EnableTracing the output uses stdout by default. Regards, Yunda From: Kirk Pepperdine [k...@kodewerk.com] Sent: Thursday, May 02, 2013 21:05 To: Staffa

RE: [PATCH] EnableTracing: output from multiple threads may be mixed together

2013-05-01 Thread Yunda
Could anyone review this for me, please? Regards, Yunda From: 云达(Yunda) Sent: Friday, April 19, 2013 4:26 PM To: hotspot-runtime-...@openjdk.java.net; serviceability-dev@openjdk.java.net Subject: [PATCH] EnableTracing: output from multiple threads may be mixed together Hi all, I found that

RE: [PATCH]"classes" command of CLHSDB doesn't work

2013-05-01 Thread Yunda
Hi all, Could anyone give me some advice on the test code or just push this for me, please? Regards, Yunda From: 云达(Yunda) Sent: Wednesday, April 03, 2013 3:34 PM To: 'Coleen Phillimore' Cc: serviceability-dev@openjdk.java.net Subject: RE: [PATCH]"classes" command of

RE: Request for reviews (S): JDK-8011979: SA: Special-case Instance.printValueOn() for Java mirrors

2013-04-23 Thread Yunda
Kris, I applied your change and it’s useful when using CLHSDB. And I also think the code is good. Regards, Yunda From: serviceability-dev-boun...@openjdk.java.net [mailto:serviceability-dev-boun...@openjdk.java.net] On Behalf Of Krystal Mo Sent: Thursday, April 11, 2013 5:40 PM To

[PATCH] EnableTracing: output from multiple threads may be mixed together

2013-04-19 Thread Yunda
t;); I searched before sending this mail I didn't find anyone who covering this☺ Regards, Yunda This email (including any attachments) is confidential and may be legally privileged. If you received this email in error, please delete it immediately an

RE: [PATCH] EnableTracing prints exact class name

2013-04-18 Thread Yunda
David, Thanks. Sorry that I didn't see Marcus' changes that carefully. Regards, Yunda > -Original Message- > From: David Holmes [mailto:david.hol...@oracle.com] > Sent: Friday, April 19, 2013 12:12 PM > To: 云达(Yunda) > Cc: hotspot-runtime-...@openjdk.java.

[PATCH] EnableTracing prints exact class name

2013-04-18 Thread Yunda
ss = java.lang.ref.ReferenceQueue$Lock Regards, Yunda This email (including any attachments) is confidential and may be legally privileged. If you received this email in error, please delete it immediately and do not copy it or use it for any purpose or disclose its

RE: Why the type of GCId in gcTrace.hpp is uint?

2013-04-17 Thread Yunda
Jesper, Thanks and I'll have a look at it. Regards, Yunda > -Original Message- > From: Jesper Wilhelmsson [mailto:jesper.wilhelms...@oracle.com] > Sent: Wednesday, April 17, 2013 7:13 PM > To: 云达(Yunda) > Cc: hotspot-gc-dev openjdk.java.net (hotspot-gc-

RE: [PATCH]"classes" command of CLHSDB doesn't work

2013-04-03 Thread Yunda
test code(not sure about that and hope someone in Serviceability team could confirm). Regards, Yunda From: Coleen Phillimore [mailto:coleen.phillim...@oracle.com] Sent: Monday, April 01, 2013 10:54 PM To: 云达(Yunda) Cc: serviceability-dev@openjdk.java.net Subject: Re: [PATCH]"classes&quo

[PATCH]"classes" command of CLHSDB doesn't work

2013-04-01 Thread Yunda
ring()); 227 } else { 228 writeln("class not found: " + name); 229 } Regards, Yunda This email (including any attachments) is confidential and may be legally privileged. If you received this email in error, please delete it immediately

RE: [PATCH] typeToVtbl of BasicTypeDataBase should not be static

2013-03-19 Thread Yunda
Staffan, Thanks. I saw the changes have already been pushed. Regards, Yunda From: Staffan Larsen [mailto:staffan.lar...@oracle.com] Sent: Tuesday, March 19, 2013 9:03 PM To: 云达(Yunda) Cc: hotspot-runtime-...@openjdk.java.net; serviceability-dev@openjdk.java.net Subject: Re: [PATCH] typeToVtbl

RE: [PATCH] A small fix on "scanoops" command in CLHSDB

2013-03-19 Thread Yunda
cc'ing hotspot-runtime for an official Review, too. Regards, Yunda From: Staffan Larsen [mailto:staffan.lar...@oracle.com] Sent: Tuesday, March 05, 2013 9:21 PM To: 云达(Yunda) Cc: Krystal Mo; serviceability-dev@openjdk.java.net Subject: Re: [PATCH] A small fix on "scanoops" comma

RE: [PATCH] typeToVtbl of BasicTypeDataBase should not be static

2013-03-19 Thread Yunda
cc'ing hotspot-runtime for an official Review. Regards, Yunda From: Staffan Larsen [mailto:staffan.lar...@oracle.com] Sent: Tuesday, March 05, 2013 9:18 PM To: 云达(Yunda) Cc: serviceability-dev@openjdk.java.net Subject: Re: [PATCH] typeToVtbl of BasicTypeDataBase should not be static

RE: Why the type of GCId in gcTrace.hpp is uint?

2013-03-14 Thread Yunda
Jesper, Thanks. I think you should consider that in trace.xml the type of compileID is INTEGER and the type of javalangthread is JAVALANGTHREAD. Since they all have similar meanings( as an ID), could they be a same type? Regards, Yunda > -Original Message- > From: Jesper Wilhe

Why the type of GCId in gcTrace.hpp is uint?

2013-03-14 Thread Yunda
on/shared/gcTrace.hpp> the type is ULONG. Could someone tell me if there’s a special reason, or it’s just a mistake? Regards, Yunda This email (including any attachments) is confidential and may be legally privileged. If you received this email in error, p

RE: [PATCH] typeToVtbl of BasicTypeDataBase should not be static

2013-03-06 Thread Yunda
Staffan, Thanks! I think the issue here is quite clear, since the role of "typeToVtbl " filed of BasicTypeDataBase is similar to "typeToVtblMap" field of BasicVtblAccess and the latter is not static. Regards, Yunda From: Staffan Larsen [mailto:staffan.lar...@oracl

RE: [PATCH] A small fix on "scanoops" command in CLHSDB

2013-03-06 Thread Yunda
Staffan, Thanks for doing this, too☺ Regards, Yunda From: Staffan Larsen [mailto:staffan.lar...@oracle.com] Sent: Tuesday, March 05, 2013 9:21 PM To: 云达(Yunda) Cc: Krystal Mo; serviceability-dev@openjdk.java.net Subject: Re: [PATCH] A small fix on "scanoops" command in CLHSDB I ha

[PATCH] typeToVtbl of BasicTypeDataBase should not be static

2013-02-27 Thread Yunda
bl = new HashMap(); private Address vtblForType(Type type) { Address vtblAddr = (Address)typeToVtbl.get(type); After applying this patch, the problem I mentioned above disappeared. Regards, Yunda This email (including any attachments) is confidential and

RE: Oop.iterateFields() should support CompressedKlassPointers again

2013-02-25 Thread Yunda
Kris, Thanks a lot! Regards, Yunda From: serviceability-dev-boun...@openjdk.java.net [mailto:serviceability-dev-boun...@openjdk.java.net] On Behalf Of Krystal Mo Sent: Monday, February 25, 2013 7:19 PM To: serviceability-dev@openjdk.java.net Subject: Re: Oop.iterateFields() should support

Oop.iterateFields() should support CompressedKlassPointers again

2013-02-25 Thread Yunda
lassPointersEnabled()) { -throw new InternalError("unimplemented"); +visitor.doMetadata(compressedKlass, true); } else { visitor.doMetadata(klass, true); } Regards, Yunda This email (including any attachments) is confide