Re: RFR: 8284209: Replace remaining usages of 'a the' in source code

2022-05-18 Thread Jonathan Gibbons
On Wed, 18 May 2022 14:46:42 GMT, Alexey Ivanov wrote: > Replaces usages of articles that follow each other in all combinations: > a/the, an?/an?, the/the… > > It's the last issue in the series, and it still touches different areas of > the code. javac and javadoc changes look OK

Re: RFR: JDK-8285676: Add missing @param tags for type parameters on classes and interfaces

2022-04-26 Thread Jonathan Gibbons
On Tue, 26 Apr 2022 22:24:26 GMT, Joe Darcy wrote: > To enable more complete doclint checking (courtesy @jonathan-gibbons), please > review this PR to add type-level @param tags where they are missing. > > To the maintainers of java.util.concurrent, those changes could be sepa

Re: RFR: 8279918: Fix various doc typos [v2]

2022-01-14 Thread Jonathan Gibbons
On Thu, 13 Jan 2022 14:01:04 GMT, Pavel Rappo wrote: >> - Most of the typos are of a trivial kind: missing whitespace. >> - If any of the typos should be fixed in the upstream projects instead, >> please say so; I will drop those typos from the patch. >> - As I understand it, ` ` in

Re: RFR: 8279918: Fix various doc typos [v2]

2022-01-13 Thread Jonathan Gibbons
On Thu, 13 Jan 2022 11:40:20 GMT, Lance Andersen wrote: >> OK, so lines 264, 295, 329, 364, 431 are arguably wrong as well? >> Separating the [] completely looks quite rare. >> I'll leave it up to you. 8-) > > I think that can be a follow on clean up. The strange formatting of `long

Re: [jdk18] RFR: JDK-8273179: Update nroff pages in JDK 18 before RC

2021-12-09 Thread Jonathan Gibbons
On Fri, 10 Dec 2021 01:46:03 GMT, Jonathan Gibbons wrote: > Please review this semi-automatic update for the nroff man pages for JDK 18. > The changes update the version number, copyright year, and incorporate the > changes from the latest upstream files. hmmm, I thought we had t

Re: [jdk18] RFR: JDK-8273179: Update nroff pages in JDK 18 before RC

2021-12-09 Thread Jonathan Gibbons
On Fri, 10 Dec 2021 01:46:03 GMT, Jonathan Gibbons wrote: > Please review this semi-automatic update for the nroff man pages for JDK 18. > The changes update the version number, copyright year, and incorporate the > changes from the latest upstream files. Hi David, The copyr

[jdk18] Integrated: JDK-8273179: Update nroff pages in JDK 18 before RC

2021-12-09 Thread Jonathan Gibbons
On Fri, 10 Dec 2021 01:46:03 GMT, Jonathan Gibbons wrote: > Please review this semi-automatic update for the nroff man pages for JDK 18. > The changes update the version number, copyright year, and incorporate the > changes from the latest upstream files. This pull request has

[jdk18] RFR: JDK-8273179: Update nroff pages in JDK 18 before RC

2021-12-09 Thread Jonathan Gibbons
Please review this semi-automatic update for the nroff man pages for JDK 18. The changes update the version number, copyright year, and incorporate the changes from the latest upstream files. - Commit messages: - JDK-8273179: Update nroff pages in JDK 18 before RC Changes:

Re: RFR: 8272992: Replace usages of Collections.sort with List.sort call in jdk.* modules [v2]

2021-09-20 Thread Jonathan Gibbons
On Tue, 14 Sep 2021 07:46:12 GMT, Andrey Turbanov wrote: >> Collections.sort is just a wrapper, so it is better to use an instance >> method directly. > > Andrey Turbanov has updated the pull request incrementally with one > additional commit since the last revision: > > 8272992: Replace

[jdk17] Integrated: JDK-8270872: Final nroff manpage update for JDK 17

2021-08-05 Thread Jonathan Gibbons
On Thu, 5 Aug 2021 19:20:50 GMT, Jonathan Gibbons wrote: > Please review a semi-automatic update of the nroff man pages from the > upstream files. This pull request has now been integrated. Changeset: dfacda48 Author:Jonathan Gibbons URL: https://git.openjdk.java.net/jdk17/

Re: [jdk17] RFR: JDK-8270872: Final nroff manpage update for JDK 17

2021-08-05 Thread Jonathan Gibbons
On Thu, 5 Aug 2021 19:57:59 GMT, Naoto Sato wrote: >> Please review a semi-automatic update of the nroff man pages from the >> upstream files. > > src/jdk.hotspot.agent/share/man/jhsdb.1 line 1: > >> 1: .\" Copyright (c) 2019, 2020, Oracle and/or its affiliates. All rights >> reserved. > >

[jdk17] RFR: JDK-8270872: Final nroff manpage update for JDK 17

2021-08-05 Thread Jonathan Gibbons
Please review a semi-automatic update of the nroff man pages from the upstream files. - Commit messages: - JDK-8270872: Final nroff manpage update for JDK 17 Changes: https://git.openjdk.java.net/jdk17/pull/303/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk17=303=00

Integrated: JDK-8255262: Remove use of legacy custom @spec tag

2020-10-22 Thread Jonathan Gibbons
On Thu, 22 Oct 2020 17:16:23 GMT, Jonathan Gibbons wrote: > The change is (just) to remove legacy usages of a JDK-private custom tag. This pull request has now been integrated. Changeset: 0aa3c925 Author: Jonathan Gibbons URL: https://git.openjdk.java.net/jdk/commit/0aa3c925 St

RFR: JDK-8255262: Remove use of legacy custom @spec tag

2020-10-22 Thread Jonathan Gibbons
The change is (just) to remove legacy usages of a JDK-private custom tag. - Commit messages: - JDK-8255262: Remove use of legacy custom @spec tag Changes: https://git.openjdk.java.net/jdk/pull/814/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk=814=00 Issue:

Re: RFR: 8252999: Cleanup: replace .equals("") with .isEmpty() within all codebase

2020-09-10 Thread Jonathan Gibbons
On Thu, 10 Sep 2020 12:04:48 GMT, Dmitriy Dumanskiy wrote: > I have in mind dozens of improvements all over the code like this one. That sounds scary. Broad updates like these cause unnecessary churn in the codebase, and can make merging and back porting harder. Changes should be discussed

RFR: [15,docs] JDK-8248061,bad reference in @throws in HotSpotDiagnosticMXBean

2020-06-22 Thread Jonathan Gibbons
Please review a small change to fix an unresolved reference in `@throws IOException`. The problem is that the method signature uses a fully-qualified name for `java.io.IOException` instead of importing it. meaning that the `@throws` cannot resolve the name. Although this could be fixed by

RFR: [15,docs] JDK-8247958,minor HTML errors in com.sun.jdi

2020-06-19 Thread Jonathan Gibbons
Please review a couple of minor HTML errors (missing end tags) in a couple of classes.  These should be the last of the fixes for com.sun.jdi in this round of cleanup. -- Jon JBS: https://bugs.openjdk.java.net/browse/JDK-8247958 Patch inline: diff -r 086c7f077fc6

Re: RFR: JDK-8247784,Bad link causes invalid documentation

2020-06-18 Thread Jonathan Gibbons
resend, with correct subject line On 6/18/20 8:12 PM, Jonathan Gibbons wrote: Please review some changes to fix typos in some recent doc updates. In two places, ${docRoot} is used instead of {@docRoot} -- Jon JBS: https://bugs.openjdk.java.net/browse/JDK-8247784 Patch: diff -r

RFR: https://bugs.openjdk.java.net/browse/JDK-8247784

2020-06-18 Thread Jonathan Gibbons
Please review some changes to fix typos in some recent doc updates. In two places, ${docRoot} is used instead of {@docRoot} -- Jon JBS: https://bugs.openjdk.java.net/browse/JDK-8247784 Patch: diff -r c5904de55565 src/jdk.jdi/share/classes/com/sun/jdi/Type.java ---

Qu: JDK-8247901, Multiple conflicting @return for FlightRecorderMXBean

2020-06-18 Thread Jonathan Gibbons
I have filed JDK-8247901, to cover an issue detected by doclint, regarding two conflicting @return descriptions for a single method. I can make the fix, if you want, but I need confirmation of which one should be deleted and which should be retained.  I can make an informed guess (one of them

RFR: [15,docs] JDK-8247894,Invalid @see in java.management

2020-06-18 Thread Jonathan Gibbons
Please review a trivial fix for an invalid @see tag in java/lang/management/package.html. The presumed intent of the original is not a supported variant. The fix is to remove the `{@linkplain ...}` wrapper. -- Jon JBS: https://bugs.openjdk.java.net/browse/JDK-8247894 Patch inline: diff -r

Re: RFR: [small, docs] JDK-8240971 Fix CSS styles in some doc comments

2020-03-13 Thread Jonathan Gibbons
On 12 Mar 2020, at 20:50, Jonathan Gibbons wrote: Please review a simple fix regarding the non-standard use of some CSS in some doc comments. From the JBS Description: Recently, for the display of javadoc block tags, javadoc changed from using an inconsistent set of CSS class names

RFR: [small,docs] JDK-8240971 Fix CSS styles in some doc comments

2020-03-12 Thread Jonathan Gibbons
Please review a simple fix regarding the non-standard use of some CSS in some doc comments. From the JBS Description: Recently, for the display of javadoc block tags, javadoc changed from using an inconsistent set of CSS class names on the generated 'dt' elements to using a single new name

RFR XS,docs,13 JDK-8226593 Fix HTML in com/sun/jdi/doc-files/signature.html

2019-06-21 Thread Jonathan Gibbons
Please review a fix for an accessibility issue reported by Axe in src/jdk.jdi/share/classes/com/sun/jdi/doc-files/signature.html The issue is a conflict between an explicit `role="main">...``  specified in the file and the automatic `` added by javadoc.  The fix is just to remove the ``

RFR: XXS,docs JDK-8225324 Bad HTML in jdk.jfr module-info.java

2019-06-04 Thread Jonathan Gibbons
Please review a fix to remove an unnecessary trailing from the module-info file for jdk.jfr Patch below. -- Jon JBS: https://bugs.openjdk.java.net/browse/JDK-8225324 $ hg diff -R open diff -r e079a4cfad75 src/jdk.jfr/share/classes/module-info.java ---

RFR XS,docs JDK-8225309 HTML issues in jdk.jdi module

2019-06-04 Thread Jonathan Gibbons
Please review another small patch for the jdk.jdi module, to fix a missing heading in one file and to adjust a heading in another. No webrev; patch below. That being said, the file src/jdk.jdi/share/classes/com/sun/jdi/doc-files/signature.html barely warrants being its own file, but even

RFR: XXS,doc JDK-8225207: redundant in Instrumentation.java

2019-06-03 Thread Jonathan Gibbons
Please review a tiny delete-one-line change to fix the last HTML error in the java.instrument module. Note to all: should only be used at the *beginning* of a paragraph. It is not a terminator or separator. In the context of a javadoc comment, it should not be used before the set of block

RFR: docs/accessibility: JDK-8220251: fix headings in java.management

2019-05-30 Thread Jonathan Gibbons
Please review a conceptually simple fix to adjust the rank of the headings in the following files in 4 management-related modules: src/java.management.rmi/share/classes/javax/management/remote/rmi/package.html src/java.management/share/classes/java/lang/management/LockInfo.java

Re: Infinite loop in jdk/test/sun/management/windows/revokeall

2018-10-01 Thread Jonathan Gibbons
I'm guessing serviceability-dev is a better place for this message. -- Jon On 10/1/18 5:44 AM, Ladislav Jahoda wrote: Hello guys, the revokeall utility has an infinite loop in its revokeAll method. Please note in the loop (line #344 in revokeall.c): while (count > 0) { the condition (line

Re: RFR: 8189102: All tools should support -?, -h and --help

2017-11-19 Thread Jonathan Gibbons
We are already in a hybrid world of old-style and new-style options :-( All the new module-related options added in JDK 9 are "new style", following the guidelines of JEP 293. It does not make sense to add "--" to some of the older tools, that may be going away at some point, and while we

Re: RFR: 8189102: All tools should support -?, -h and --help

2017-11-17 Thread Jonathan Gibbons
Goetz, I understand why you might want to ensure that a basic set of help options is supported, but I don't understand why that justifies removing older options, like "-help" for many tools. In addition, I notice the CSR says: *Compatibility Risk Description:*

RFR: JDK-8186932: Fix accessibility issues in the java.management module

2017-08-29 Thread Jonathan Gibbons
Please review these relatively simple changes to fix accessibility issues in the java.management module. JBS: https://bugs.openjdk.java.net/browse/JDK-8186932 Webrev: http://cr.openjdk.java.net/~jjg/8186932/webrev.00/ API:

RFR: JDK-8185867: fix a11y and html issues in jdk.jdi docs

2017-08-04 Thread Jonathan Gibbons
Please review this fix for some of the docs for the jdk.jdi module. Most of the changes are relatively straightforward. The biggest change was to the introductory tables in the Type and Value classes. These were both conceptually "many tables in one", with embedded headers within the tables.

RFR: JDK-8185589: jdk.management API has accessibility issues

2017-07-31 Thread Jonathan Gibbons
Please review this reasonably simple doc fix for some tables in the jdk.management API documentation. JBS: https://bugs.openjdk.java.net/browse/JDK-8185589 Webrev: http://cr.openjdk.java.net/~jjg/8185589/webrev.00/ -- Jon

RFR: JDK-8185588: jdk.attach API has accessibility issues

2017-07-31 Thread Jonathan Gibbons
Please review this small doc fix for a table in the jdk.attach API documentation. JBS: https://bugs.openjdk.java.net/browse/JDK-8185588 Webrev: http://cr.openjdk.java.net/~jjg/8185588/webrev.00/ -- Jon

RFR: JDK-8185154: jdwp-protocol.html contains unescaped entities

2017-07-24 Thread Jonathan Gibbons
Please review a simple fix to escape use of the < character in HTML fragments in the JDWP spec. In each case, the < is simply replaced by . JBS: https://bugs.openjdk.java.net/browse/JDK-8185154 Webrev: http://cr.openjdk.java.net/~jjg/8185154/webrev.00/make/data/jdwp/jdwp.spec.sdiff.html --

RFR: 8179460: Fix unnecessary uses of {@docRoot} in serviceability APIs

2017-04-28 Thread Jonathan Gibbons
Please review the following simple changes to update use of {@docRoot} in doc comments now that we have a single docs bundle. Most instances in this review can be replaced with direct references using @see or {@link}. One use of {@docRoot} remains, but modified, to refer to an explicit anchor

Re: RFR(S): 8034960: Serviceability tests using @library failing with java.lang.NoClassDefFoundError

2014-03-25 Thread Jonathan Gibbons
On 03/25/2014 07:31 AM, Yekaterina Kantserova wrote: On 03/25/2014 02:53 PM, Alan Bateman wrote: On 25/03/2014 12:14, Staffan Larsen wrote: I’ve looked at a random sample of these changes and they look ok. Since some of the changes are in non-serviceability code I have also added core-libs

hg: jdk8/tl/langtools: 8028318: [doclint] doclint will reject existing user-written doc comments using custom tags that follow the recommended rules

2013-11-25 Thread jonathan . gibbons
Changeset: a78f51d6bd5e Author:jjg Date: 2013-11-25 17:42 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/a78f51d6bd5e 8028318: [doclint] doclint will reject existing user-written doc comments using custom tags that follow the recommended rules Reviewed-by: darcy !

hg: jdk8/tl/langtools: 2 new changesets

2013-10-22 Thread jonathan . gibbons
Changeset: 351d6808c1a5 Author:jjg Date: 2013-10-22 17:42 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/351d6808c1a5 8027119: Cleanup javadoc comments for taglet API Reviewed-by: mduigou ! src/share/classes/com/sun/javadoc/Tag.java Changeset: 41d3ffca22ff Author:

hg: jdk8/tl/langtools: 8025109: Better encapsulation for AnnotatedType

2013-10-20 Thread jonathan . gibbons
Changeset: e5d3cd43c85e Author:jjg Date: 2013-10-20 12:01 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/e5d3cd43c85e 8025109: Better encapsulation for AnnotatedType Reviewed-by: jjg Contributed-by: wdi...@gmail.com !

hg: jdk8/tl/langtools: 8026791: wrong type_path encoded for method_return on an inner class constructor

2013-10-20 Thread jonathan . gibbons
Changeset: ae4f5cb78ebd Author:jjg Date: 2013-10-20 12:46 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/ae4f5cb78ebd 8026791: wrong type_path encoded for method_return on an inner class constructor Reviewed-by: jjg Contributed-by: wdi...@gmail.com !

hg: jdk8/tl/langtools: 8026749: Missing LV table in lambda bodies

2013-10-18 Thread jonathan . gibbons
Changeset: 7de97abc4a5c Author:jjg Date: 2013-10-18 15:03 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/7de97abc4a5c 8026749: Missing LV table in lambda bodies Reviewed-by: vromero, jlahoda ! src/share/classes/com/sun/tools/javac/code/Flags.java !

hg: jdk8/tl/langtools: 8026704: Build failure with --enable-debug

2013-10-16 Thread jonathan . gibbons
Changeset: d7e155f874a7 Author:jjg Date: 2013-10-16 10:47 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/d7e155f874a7 8026704: Build failure with --enable-debug Reviewed-by: ksrini ! src/share/classes/com/sun/tools/javac/code/Flags.java !

hg: jdk8/tl/langtools: 8025998: Missing LV table in lambda bodies

2013-10-15 Thread jonathan . gibbons
Changeset: 09a414673570 Author:jjg Date: 2013-10-14 23:07 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/09a414673570 8025998: Missing LV table in lambda bodies Reviewed-by: vromero ! src/share/classes/com/sun/tools/javac/code/Flags.java !

hg: jdk8/tl/langtools: 8026564: import changes from type-annotations forest

2013-10-15 Thread jonathan . gibbons
Changeset: b0c086cd4520 Author:jjg Date: 2013-10-15 15:57 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/b0c086cd4520 8026564: import changes from type-annotations forest Reviewed-by: jjg Contributed-by: wdi...@gmail.com, steve.si...@oracle.com ! make/build.properties

hg: jdk8/tl/langtools: 8026368: doclint does not report empty tags when tag closed implicitly

2013-10-14 Thread jonathan . gibbons
Changeset: b024fe427d24 Author:jjg Date: 2013-10-14 12:38 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/b024fe427d24 8026368: doclint does not report empty tags when tag closed implicitly Reviewed-by: darcy ! src/share/classes/com/sun/tools/doclint/Checker.java !

hg: jdk8/tl/langtools: 8026371: tidy issues in langtools/src/**/*.html files

2013-10-14 Thread jonathan . gibbons
Changeset: b9e3b55a908c Author:jjg Date: 2013-10-14 16:28 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/b9e3b55a908c 8026371: tidy issues in langtools/src/**/*.html files Reviewed-by: darcy + src/share/classes/com/sun/javadoc/package-info.java -

hg: jdk8/tl/langtools: 8025693: recent javadoc changes cause com/sun/javadoc/testLinkOption/TestLinkOption.java to fail

2013-10-14 Thread jonathan . gibbons
Changeset: 7d266a2b31b2 Author:jjg Date: 2013-10-14 22:34 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/7d266a2b31b2 8025693: recent javadoc changes cause com/sun/javadoc/testLinkOption/TestLinkOption.java to fail Reviewed-by: darcy !

hg: jdk8/tl/langtools: 8026294: 8025633 breaks langtools/test/com/sun/javadoc/testRepeatedAnnotations/TestRepeatedAnnotations.java

2013-10-10 Thread jonathan . gibbons
Changeset: f068d235c4f7 Author:jjg Date: 2013-10-10 17:13 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/f068d235c4f7 8026294: 8025633 breaks langtools/test/com/sun/javadoc/testRepeatedAnnotations/TestRepeatedAnnotations.java Reviewed-by: darcy !

hg: jdk8/tl/langtools: 8022163: javac exits with 0 status and no messages on error to construct an ann-procesor

2013-10-04 Thread jonathan . gibbons
Changeset: 2fa6ced325cc Author:jjg Date: 2013-10-04 13:59 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/2fa6ced325cc 8022163: javac exits with 0 status and no messages on error to construct an ann-procesor Reviewed-by: darcy !

hg: jdk8/tl/langtools: 6525408: DiagnosticListener should receive MANDATORY_WARNING in standard compiler mode

2013-10-04 Thread jonathan . gibbons
Changeset: 515d54c1b063 Author:jjg Date: 2013-10-04 14:46 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/515d54c1b063 6525408: DiagnosticListener should receive MANDATORY_WARNING in standard compiler mode Reviewed-by: darcy !

hg: jdk8/tl/langtools: 8025970: Spurious characters in JavaCompiler

2013-10-04 Thread jonathan . gibbons
Changeset: 3e3c321710be Author:jjg Date: 2013-10-04 15:24 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/3e3c321710be 8025970: Spurious characters in JavaCompiler Reviewed-by: ksrini ! src/share/classes/com/sun/tools/javac/main/JavaCompiler.java

hg: jdk8/tl/langtools: 8025407: TypeAnnotations does not use Context

2013-09-25 Thread jonathan . gibbons
Changeset: 5043e7056be8 Author:jjg Date: 2013-09-25 11:07 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/5043e7056be8 8025407: TypeAnnotations does not use Context Reviewed-by: jfranck ! src/share/classes/com/sun/tools/javac/code/TypeAnnotations.java !

hg: jdk8/tl/langtools: 8025412: Add legal header and comments to test/tools/doclint/tidy/util/Main.java

2013-09-25 Thread jonathan . gibbons
Changeset: 3d61984b077c Author:jjg Date: 2013-09-25 14:04 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/3d61984b077c 8025412: Add legal header and comments to test/tools/doclint/tidy/util/Main.java Reviewed-by: bpatel ! test/tools/doclint/tidy/util/Main.java !

hg: jdk8/tl/langtools: 8025050: Doclint doesn't recognize dfn tag

2013-09-24 Thread jonathan . gibbons
Changeset: 96dcb66e6b0a Author:jjg Date: 2013-09-24 10:48 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/96dcb66e6b0a 8025050: Doclint doesn't recognize dfn tag Reviewed-by: bpatel ! src/share/classes/com/sun/tools/doclint/HtmlTag.java !

hg: jdk8/tl/langtools: 8002154: [doclint] doclint should check for issues which are errors in javadoc

2013-09-24 Thread jonathan . gibbons
Changeset: 3ae62331a56f Author:jjg Date: 2013-09-24 13:48 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/3ae62331a56f 8002154: [doclint] doclint should check for issues which are errors in javadoc Reviewed-by: bpatel !

hg: jdk8/tl/langtools: 8024609: sjavac assertion fails during call to BuildState.collectArtifacts

2013-09-19 Thread jonathan . gibbons
Changeset: 0cfd5baa7154 Author:ohrstrom Date: 2013-09-19 08:26 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/0cfd5baa7154 8024609: sjavac assertion fails during call to BuildState.collectArtifacts Reviewed-by: jjg !

hg: jdk8/tl/langtools: 8025110: TreeCopier does not correctly copy LabeledStatementTree

2013-09-19 Thread jonathan . gibbons
Changeset: 9a75bdb249a2 Author:jjg Date: 2013-09-19 19:18 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/9a75bdb249a2 8025110: TreeCopier does not correctly copy LabeledStatementTree Reviewed-by: jjg Contributed-by: Werner Dietl wdi...@gmail.com !

hg: jdk8/tl/langtools: 8024538: -Xdoclint + -Xprefer:source + incremental compilation == FAIL

2013-09-17 Thread jonathan . gibbons
Changeset: fdfbc5f0c4ed Author:jjg Date: 2013-09-17 14:17 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/fdfbc5f0c4ed 8024538: -Xdoclint + -Xprefer:source + incremental compilation == FAIL Reviewed-by: darcy ! src/share/classes/com/sun/tools/doclint/DocLint.java !

hg: jdk8/tl/langtools: 8019521: Enhanced rethrow disabled in lambdas

2013-09-09 Thread jonathan . gibbons
Changeset: 77d395862700 Author:jlahoda Date: 2013-09-09 23:13 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/77d395862700 8019521: Enhanced rethrow disabled in lambdas Summary: Fixing effectively final detection inside lambdas, small cleanup related to thrown types

hg: jdk8/tl/langtools: 8006972: jtreg test fails: test/tools/javac/processing/model/element/TestMissingElement/TestMissingElement.java

2013-09-09 Thread jonathan . gibbons
Changeset: 7439356a7dc5 Author:jjg Date: 2013-09-09 17:36 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/7439356a7dc5 8006972: jtreg test fails: test/tools/javac/processing/model/element/TestMissingElement/TestMissingElement.java Reviewed-by: darcy !

hg: jdk8/tl/langtools: 8024434: problem running javadoc tests in samevm mode on Windows

2013-09-06 Thread jonathan . gibbons
Changeset: 64328fe5e4a6 Author:jjg Date: 2013-09-06 15:31 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/64328fe5e4a6 8024434: problem running javadoc tests in samevm mode on Windows Reviewed-by: darcy !

hg: jdk8/tl/langtools: 8024288: javadoc generated-by comment should always be present

2013-09-04 Thread jonathan . gibbons
Changeset: 044721d4d359 Author:jjg Date: 2013-09-04 14:44 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/044721d4d359 8024288: javadoc generated-by comment should always be present Reviewed-by: bpatel !

hg: jdk8/tl/langtools: 8023700: Use non breaking space in various labels

2013-08-30 Thread jonathan . gibbons
Changeset: 240f424cc0d5 Author:jjg Date: 2013-08-30 11:48 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/240f424cc0d5 8023700: Use non breaking space in various labels Reviewed-by: bpatel !

hg: jdk8/tl/langtools: 8024093: Two *.rej files checked in to langtools/test directory

2013-08-30 Thread jonathan . gibbons
Changeset: 3dd40e5715fb Author:jjg Date: 2013-08-30 15:14 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/3dd40e5715fb 8024093: Two *.rej files checked in to langtools/test directory Reviewed-by: mchung - test/tools/javac/diags/examples/MrefStat.java.rej -

hg: jdk8/tl/langtools: 8008367: Sub-packages missing from Profiles javadoc

2013-08-30 Thread jonathan . gibbons
Changeset: f050c714b556 Author:jjg Date: 2013-08-30 16:27 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/f050c714b556 8008367: Sub-packages missing from Profiles javadoc Reviewed-by: bpatel ! src/share/classes/com/sun/tools/doclets/internal/toolkit/Configuration.java

hg: jdk8/tl/langtools: 8015663: Need to supply tests to provide javadoc for profiles support code coverage

2013-08-30 Thread jonathan . gibbons
Changeset: 7993cfab8610 Author:jjg Date: 2013-08-30 17:36 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/7993cfab8610 8015663: Need to supply tests to provide javadoc for profiles support code coverage Reviewed-by: jjg Contributed-by: evgeniya.stepan...@oracle.com !

hg: jdk8/tl/langtools: 8001669: javadoc internal DocletAbortException should set cause when appropriate

2013-08-29 Thread jonathan . gibbons
Changeset: 0e6577980181 Author:jjg Date: 2013-08-29 11:41 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/0e6577980181 8001669: javadoc internal DocletAbortException should set cause when appropriate Reviewed-by: darcy !

hg: jdk8/tl/langtools: 8023522: tools/javac/tree/TypeAnnotationsPretty.java test cases with @TA newline fail on windows only

2013-08-29 Thread jonathan . gibbons
Changeset: b0b25c1f6cbd Author:jjg Date: 2013-08-29 11:57 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/b0b25c1f6cbd 8023522: tools/javac/tree/TypeAnnotationsPretty.java test cases with @TA newline fail on windows only Reviewed-by: darcy !

hg: jdk8/tl/langtools: 8013384: Potential infinite loop in javadoc

2013-08-29 Thread jonathan . gibbons
Changeset: 9c0e192c0926 Author:jjg Date: 2013-08-29 12:03 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/9c0e192c0926 8013384: Potential infinite loop in javadoc Reviewed-by: darcy ! src/share/classes/com/sun/tools/javadoc/ClassDocImpl.java

hg: jdk8/tl/langtools: 8022744: javac -Xpkginfo command's documentation is sparse

2013-08-29 Thread jonathan . gibbons
Changeset: 96b6865eda94 Author:jjg Date: 2013-08-29 12:11 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/96b6865eda94 8022744: javac -Xpkginfo command's documentation is sparse Reviewed-by: darcy ! src/share/classes/com/sun/tools/javac/main/Option.java

hg: jdk8/tl/langtools: 8010310: [javadoc] Error processing sources with -private

2013-08-28 Thread jonathan . gibbons
Changeset: 189942cdf585 Author:jjg Date: 2013-08-28 15:40 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/189942cdf585 8010310: [javadoc] Error processing sources with -private Reviewed-by: vromero, mcimadamore ! src/share/classes/com/sun/tools/javac/code/Symbol.java !

hg: jdk8/tl/langtools: 8023701: Fix badly named test

2013-08-26 Thread jonathan . gibbons
Changeset: 60f156c653d3 Author:jjg Date: 2013-08-26 11:48 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/60f156c653d3 8023701: Fix badly named test Reviewed-by: bpatel - test/com/sun/javadoc/testNavagation/TestNavagation.java -

hg: jdk8/tl/langtools: 8023768: Use the unannotatedType in cyclicity checks.

2013-08-26 Thread jonathan . gibbons
Changeset: 7bf6313e1ced Author:jjg Date: 2013-08-26 15:55 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/7bf6313e1ced 8023768: Use the unannotatedType in cyclicity checks. Reviewed-by: jjg Contributed-by: wdi...@gmail.com !

hg: jdk8/tl/langtools: 8022173: Relax some warnings in doclint

2013-08-22 Thread jonathan . gibbons
Changeset: b77381d99056 Author:jjg Date: 2013-08-22 12:41 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/b77381d99056 8022173: Relax some warnings in doclint Reviewed-by: darcy ! src/share/classes/com/sun/tools/doclint/HtmlTag.java !

hg: jdk8/tl/langtools: 8023515: import type-annotations updates

2013-08-21 Thread jonathan . gibbons
Changeset: 7de231613e4a Author:jjg Date: 2013-08-21 16:13 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/7de231613e4a 8023515: import type-annotations updates Reviewed-by: jjg Contributed-by: wdi...@gmail.com ! src/share/classes/com/sun/source/tree/MethodTree.java !

hg: jdk8/tl/langtools: 8022287: javac.sym.Profiles uses a static Map when it should not

2013-08-21 Thread jonathan . gibbons
Changeset: 57e1266527dd Author:jjg Date: 2013-08-21 17:26 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/57e1266527dd 8022287: javac.sym.Profiles uses a static Map when it should not Reviewed-by: ksrini ! src/share/classes/com/sun/tools/javac/sym/Profiles.java +

hg: jdk8/tl/langtools: 8020663: Restructure some properties to facilitate better translation

2013-08-20 Thread jonathan . gibbons
Changeset: a76dc1b4c299 Author:jjg Date: 2013-08-20 14:46 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/a76dc1b4c299 8020663: Restructure some properties to facilitate better translation Reviewed-by: darcy !

hg: jdk8/tl/langtools: 8020556: doclint does not check type variables for @throws

2013-07-24 Thread jonathan . gibbons
Changeset: 2fbe77c38802 Author:jjg Date: 2013-07-24 17:35 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/2fbe77c38802 8020556: doclint does not check type variables for @throws Reviewed-by: mcimadamore ! src/share/classes/com/sun/source/util/DocTrees.java !

hg: jdk8/tl/langtools: 8021215: javac gives incorrect doclint warnings on normal package statements

2013-07-23 Thread jonathan . gibbons
Changeset: 129751018061 Author:jjg Date: 2013-07-23 16:06 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/129751018061 8021215: javac gives incorrect doclint warnings on normal package statements Reviewed-by: darcy ! src/share/classes/com/sun/tools/doclint/Checker.java

hg: jdk8/tl/langtools: 8014636: TestLiteralCodeInPre fails on windows

2013-07-17 Thread jonathan . gibbons
Changeset: 80e75aa6a707 Author:jjg Date: 2013-07-17 18:18 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/80e75aa6a707 8014636: TestLiteralCodeInPre fails on windows Reviewed-by: ksrini ! src/share/classes/com/sun/tools/doclets/formats/html/HtmlDocletWriter.java !

hg: jdk8/tl/langtools: 8020664: doclint gives incorrect warnings on normal package statements

2013-07-17 Thread jonathan . gibbons
Changeset: 1476d54fdc61 Author:jjg Date: 2013-07-17 19:16 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/1476d54fdc61 8020664: doclint gives incorrect warnings on normal package statements Reviewed-by: mcimadamore ! src/share/classes/com/sun/tools/doclint/DocLint.java

hg: jdk8/tl/langtools: 8020313: doclint doesn't reset HTML anchors correctly

2013-07-17 Thread jonathan . gibbons
Changeset: 1e533c1bfb01 Author:jjg Date: 2013-07-17 19:12 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/1e533c1bfb01 8020313: doclint doesn't reset HTML anchors correctly Reviewed-by: mcimadamore ! src/share/classes/com/sun/tools/doclint/Checker.java +

hg: jdk8/tl/langtools: 8020278: NPE in javadoc

2013-07-12 Thread jonathan . gibbons
Changeset: 37031963493e Author:jjg Date: 2013-07-12 13:11 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/37031963493e 8020278: NPE in javadoc Reviewed-by: mcimadamore, vromero ! src/share/classes/com/sun/tools/doclint/DocLint.java !

hg: jdk8/tl/langtools: 8015720: since tag isn't copied while generating JavaFX documentation

2013-06-27 Thread jonathan . gibbons
Changeset: 26437287529d Author:janvalenta Date: 2013-06-27 17:47 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/26437287529d 8015720: since tag isn't copied while generating JavaFX documentation Reviewed-by: jjg !

hg: jdk8/tl/langtools: 8014137: Update test/tools/javac/literals/UnderscoreLiterals to add testcases with min/max values

2013-06-26 Thread jonathan . gibbons
Changeset: 3b2e10524627 Author:jjg Date: 2013-06-26 18:03 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/3b2e10524627 8014137: Update test/tools/javac/literals/UnderscoreLiterals to add testcases with min/max values Reviewed-by: jjg, darcy Contributed-by:

hg: jdk8/tl/langtools: 8016193: Fix OAC issue in langtools docs

2013-06-07 Thread jonathan . gibbons
Changeset: fd31bf97340f Author:jjg Date: 2013-06-07 15:35 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/fd31bf97340f 8016193: Fix OAC issue in langtools docs Reviewed-by: darcy ! src/share/classes/com/sun/javadoc/Tag.java

hg: jdk8/tl/langtools: 8004643: Reduce javac space overhead introduced with compiler support for repeating annotations

2013-06-04 Thread jonathan . gibbons
Changeset: 8fb68f73d4b1 Author:jjg Date: 2013-06-04 14:17 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/8fb68f73d4b1 8004643: Reduce javac space overhead introduced with compiler support for repeating annotations Reviewed-by: mcimadamore, jfranck !

hg: jdk8/tl/langtools: 8013405: DocLint should support LI value=value

2013-06-03 Thread jonathan . gibbons
Changeset: 391f97e270c2 Author:jjg Date: 2013-06-03 16:22 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/391f97e270c2 8013405: DocLint should support LI value=value Reviewed-by: ksrini ! src/share/classes/com/sun/tools/doclint/Checker.java !

hg: jdk8/tl/langtools: 8006615: [doclint] move remaining messages into resource bundle

2013-06-03 Thread jonathan . gibbons
Changeset: 242bcad5be74 Author:jjg Date: 2013-06-03 17:09 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/242bcad5be74 8006615: [doclint] move remaining messages into resource bundle Reviewed-by: mcimadamore, vromero !

hg: jdk8/tl/langtools: 8015641: genstubs needs to cope with static interface methods

2013-05-29 Thread jonathan . gibbons
Changeset: d685b12b62a4 Author:jjg Date: 2013-05-29 15:34 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/d685b12b62a4 8015641: genstubs needs to cope with static interface methods Reviewed-by: ksrini ! make/tools/genstubs/GenStubs.java

hg: jdk8/tl/langtools: 6885876: add comments to javac/util/Convert.java

2013-05-17 Thread jonathan . gibbons
Changeset: 0928f2cfbf8e Author:jjg Date: 2013-05-17 13:48 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/0928f2cfbf8e 6885876: add comments to javac/util/Convert.java Reviewed-by: mduigou ! src/share/classes/com/sun/tools/javac/util/Convert.java

hg: jdk8/tl/langtools: 8006879: Detection of windows in sjavac fails.

2013-05-15 Thread jonathan . gibbons
Changeset: 445b8b5ae9f4 Author:jjg Date: 2013-05-15 10:39 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/445b8b5ae9f4 8006879: Detection of windows in sjavac fails. Reviewed-by: jjg Contributed-by: erik.joels...@oracle.com !

hg: jdk8/tl/langtools: 8014557: Mutable static field in HtmlDocletWriter

2013-05-14 Thread jonathan . gibbons
Changeset: 0384683c64be Author:jjg Date: 2013-05-14 13:55 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/0384683c64be 8014557: Mutable static field in HtmlDocletWriter Reviewed-by: ksrini ! src/share/classes/com/sun/tools/doclets/formats/html/HtmlDocletWriter.java

hg: jdk8/tl/langtools: 8013852: update reference impl for type-annotations

2013-05-14 Thread jonathan . gibbons
Changeset: ddb4a2bfcd82 Author:jjg Date: 2013-05-14 15:04 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/ddb4a2bfcd82 8013852: update reference impl for type-annotations Reviewed-by: jjg Contributed-by: wdi...@gmail.com, steve.si...@oracle.com, joel.fra...@oracle.com,

hg: jdk8/tl/langtools: 8013163: Convert 4 tools multicatch tests to jtreg format

2013-05-14 Thread jonathan . gibbons
Changeset: 53b389eb39c1 Author:sogoel Date: 2013-05-14 18:02 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/53b389eb39c1 8013163: Convert 4 tools multicatch tests to jtreg format Reviewed-by: jjg + test/tools/javac/multicatch/Pos11.java +

hg: jdk8/tl/langtools: 8014323: Add VariableTree.getNameExpression

2013-05-14 Thread jonathan . gibbons
Changeset: 529fb3ed5d2a Author:jjg Date: 2013-05-14 21:08 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/529fb3ed5d2a 8014323: Add VariableTree.getNameExpression Reviewed-by: darcy ! src/share/classes/com/sun/source/tree/VariableTree.java !

hg: jdk8/tl/langtools: 8012929: Trees.getElement should work not only for declaration trees, but also for use-trees

2013-05-13 Thread jonathan . gibbons
Changeset: 8dd528992c15 Author:jlahoda Date: 2013-05-10 15:15 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/8dd528992c15 8012929: Trees.getElement should work not only for declaration trees, but also for use-trees Reviewed-by: jjg Contributed-by: Dusan Balek

hg: jdk8/tl/langtools: 8014363: javac test class ToolTester handles classpath incorrectly

2013-05-12 Thread jonathan . gibbons
Changeset: e39669aea0bd Author:jjg Date: 2013-05-12 18:18 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/e39669aea0bd 8014363: javac test class ToolTester handles classpath incorrectly Reviewed-by: ksrini ! test/tools/javac/api/6406133/T6406133.java !

  1   2   3   4   5   >