Hi Jaroslav,
Looks good. Not a reviewer however.
Olivier.
On 22/12/2015 17:50, Jaroslav Bachorik wrote:
Please, review this trivial test change
Issue : https://bugs.openjdk.java.net/browse/JDK-8145982
Webrev: http://cr.openjdk.java.net/~jbachorik/8145982/webrev.00
The test calls System.exit(
Hi,
Please review the following changes for task "JDK-8058865 : JMX Test
Refactoring"
Issue: https://bugs.openjdk.java.net/browse/JDK-8058865
Webrev: http://cr.openjdk.java.net/~olagneau/8058865/webrev.06/
Issue Description:
" The majority of the JMX related tests are in JTreg. There is a sma
ebrev:
http://cr.openjdk.java.net/~akulyakh/8143121_04/test/javax/management/remote/mandatory/loading/MethodResultTest.java.udiff.html
Best regards,
Alexander
- Original Message -
From: olivier.lagn...@oracle.com
To: shanliang.ji...@oracle.com, daniel.fu...@oracle.com
Cc: serviceabilit
Hi Jaroslav,
Thats looks good to me.
Unfortunately not a reviewer anyway...
Olivier.
On 07/10/2015 10:28, Jaroslav Bachorik wrote:
On 2.10.2015 18:54, Jaroslav Bachorik wrote:
Please, review the following change
Issue : https://bugs.openjdk.java.net/browse/JDK-8138748
Webrev: http://cr.open
Looks good to me.
Not a reviewer however.
Olivier.
On 03/08/2015 17:31, Jaroslav Bachorik wrote:
Please, review the following test change
Issue : https://bugs.openjdk.java.net/browse/JDK-8085919
Webrev: http://cr.openjdk.java.net/~jbachorik/8085919/webrev.00
The test fails on embedded machin
Thanks Jaroslav and Serguey for the comments for first pass of review.
I have fixed the patch following your comments.
Please find the 2nd version here :
webrev: http://cr.openjdk.java.net/~olagneau/8131784/webrev.01/
Thanks,
Olivier.
On 30/07/2015 18:55, olivier.lagn...@oracle.com wrote:
Hi
eflect.Method.invoke(Method.java:504)
at
com.sun.javatest.regtest.agent.MainWrapper$MainThread.run(MainWrapper.java:92)
at java.lang.Thread.run(Thread.java:746)
"
Which I find more readable.
Otherwise, it looks good.
Thanks,
Serguei
On 7/30/15 9:55 AM, olivier.lagn...@oracle.c
Hi Jaroslav,
Thanks for reviewing this fix. Comments inlined.
Olivier.
On 30/07/2015 19:13, Jaroslav Bachorik wrote:
Hi Olivier,
On 30.7.2015 18:55, olivier.lagn...@oracle.com wrote:
Hi,
Could you please review this fix:
bug: https://bugs.openjdk.java.net/browse/JDK-8131784
webrev: http
Hi,
Could you please review this fix:
bug: https://bugs.openjdk.java.net/browse/JDK-8131784
webrev: http://cr.openjdk.java.net/~olagneau/8131784/webrev.00/
We add tracing information to help diagnosing master bug problem
(https://bugs.openjdk.java.net/browse/JDK-8130339),
and we will monitor th
Hi,
Could you please review this very light fix:
bug: https://bugs.openjdk.java.net/browse/JDK-8131783
webrev: http://cr.openjdk.java.net/~olagneau/8131783/webrev.00/
We first quarantine the test.
We will then add tracing information to help diagnosing the problem
(https://bugs.openjdk.java.n
Hi Katja,
Looks ok to me too.
It has been a relatively manual process and I'm not aware of a
mechanism how to sync test-key-bug. What I can do is to mark bugs I
went through with for example 'key-intermittent' label to distinguish
them form the new ones.
That's another additional label, and
On 17/07/2015 14:59, Alexander Kulyakhtin wrote:
Jaroslav,
Ok, I'm going to create a new low-severity issue to replace /../.. with
external.lib.roots property throughout the hotspot repo.
The original issue, as the development team pointed out in the comments, is
likely to be caused by the
Hi Alexander,
Looks ok to me with same remark as Jaroslav.
Last failure was 10th of July in Comp baseline. Let's hope it fixes it.
Olivier.
On 17/07/2015 13:13, Alexander Kulyakhtin wrote:
Hi,
Can the changes below be approven?
Although they are not strictly necessary, it is better to use
Hi Dmitry,
On 11/12/2014 15:43, Dmitry Samersoff wrote:
Jaroslav,
You can set SO_LINGER to zero, in this case socket will be closed
immediately without waiting in TIME_WAIT
SO-LINGER did not help either in my case (see my previous mail to Jaroslav).
That ended-up in using another hard-coded (s
Hi Jaroslav,
On 11/12/2014 15:06, Jaroslav Bachorik wrote:
Further investigation shows that the problem was rather the client
connecting to a socket being shut down.
I remember I met this situation for an RMI fix a while ago and IIRC no
flag setting could help (SO_REUSEADDR as well),
the port
the bug used to do the quarantine.
Dan
On 11/12/14 11:19 AM, olivier.lagn...@oracle.com wrote:
Please review this addition to ProblemList.txt
Issue: https://bugs.openjdk.java.net/browse/JDK-8062037
Initial Failure: https://bugs.openjdk.java.net/browse/JDK-8061177
Webrev: http
Please review this addition to ProblemList.txt
Issue: https://bugs.openjdk.java.net/browse/JDK-8062037
Initial Failure: https://bugs.openjdk.java.net/browse/JDK-8061177
Webrev: http://cr.openjdk.java.net/~olagneau/8062037/webrev.00/
Retransform/RedefineBigClass.sh have been showing again random
Looks good,
Hope you will get enough information to see what happens.
Olivier.
On 17/10/2014 12:26, Jaroslav Bachorik wrote:
Please, review the following addition to the test debug output
Issue : https://bugs.openjdk.java.net/browse/JDK-8061312
Test Issue : https://bugs.openjdk.java.net/
Hi Christian,
Looks good !
Olivier.
On 15/08/2014 16:55, Christian Tornqvist wrote:
Hi,
This is a small update to NMTHelper.java to make it work with recent
changes in the NMT implementation that changed the output format a bit.
I’ve tested the change locally using
java\lang\instrument\Re
Hi Jaroslav,
Thats looks good to me.
Olivier.
On 07/07/2014 12:15, Jaroslav Bachorik wrote:
Please, review the following test change
Issue : https://bugs.openjdk.java.net/browse/JDK-8049194
Webrev: http://cr.openjdk.java.net/~jbachorik/8049194/webrev.00
jdk.testlibrary.ProcessThread was erro
20 matches
Mail list logo
