On Wed, 22 Dec 2021 09:07:24 GMT, Sergey Bylokhov wrote:
> This bug is similar to https://bugs.openjdk.java.net/browse/JDK-8244094
>
> Currently, some of the files in the OpenJDK repo have Amazon copyright
> notices which are all slightly different and do not conform to Amazons
> preferred
On Mon, 1 Nov 2021 20:51:39 GMT, Evgeny Astigeevich
wrote:
> This PR changes nmethods names in `METHOD NAMES for CodeHeap` section to be
> qualified.
> Testing:
> - `make test TEST="gtest"`: Passed
> - `make run-test TEST="tier1"`: Passed
> - `make run-test TEST="tier2"`: Passed
> - `make
On Sat, 5 Dec 2020 00:35:27 GMT, Lin Zang wrote:
>> when use SA JMap dump commands, such as "jhsdb jmap --binaryheap" or "dump
>> heap" with "jhsdb clhsdb", it keep printing "dumpStack: not java Thread.".
>> Skip non-java thread stack dump to avoid printing the message.
>
> Lin Zang has
On Thu, 3 Dec 2020 12:06:23 GMT, Lin Zang wrote:
> when use SA JMap dump commands, such as "jhsdb jmap --binaryheap" or "dump
> heap" with "jhsdb clhsdb", it keep printing "dumpStack: not java Thread.".
> Skip non-java thread stack dump to avoid printing the message.
Marked as reviewed by phh
On Fri, 20 Nov 2020 01:17:18 GMT, Lin Zang wrote:
>> This PR add "gz" option to jmap -dump command to support generate gzipped
>> heap dump.
>>
>> example:
>> jmap -dump:live,gz=1,file=dump.gz
>
> Lin Zang has updated the pull request incrementally with one additional
> commit since
On Wed, 14 Oct 2020 15:27:26 GMT, Aleksey Shipilev wrote:
> There is no definition of `ClassFieldMap::compute_field_count` in current tip
> or any history after the initial load.
> Can be removed.
> Testing:
> - [x] Linux x86_64 build
> - [x] Text searches for `compute_field_count` in
Changeset: 4a24c4f648bd
Author:phh
Date: 2012-02-16 13:50 -0500
URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/4a24c4f648bd
7142113: Add Ivy Bridge to the known Intel x86 cpu families
Summary: In vm_version_x86.hpp, add and use CPU_MODEL_IVYBRIDGE_EP, and
restrict
Imo we should at least try to make non-osx bsd builds work, since
the original code did work for non-osx builds. This change doesn't
do that.
In globalDefinitions_gcc.hpp, if you keep the lines
#undef ELF_AC
#undef EFL_ID
then you don't have to change vm_version_x86.hpp.
Paul
On 2/15/12
in os_bsd.hpp, though you'd still need it
in os_bsd.cpp. I'm assuming there's no mach_thread_self() on non-osx
bsd platforms.
Thanks,
Paul
On 2/15/12 1:33 PM, Paul Hohensee wrote:
Imo we should at least try to make non-osx bsd builds work, since
the original code did work for non-osx builds
On 2/15/12 1:58 PM, Staffan Larsen wrote:
On 15 feb 2012, at 19:49, Paul Hohensee wrote:
Also,
You can move the #include of mach.h into globalDefinitions_gcc.hpp,
in the #ifdef __APPLE__ section. That way, it won't cause a compile-
time error on non-osx platforms that don't have it.
I
Right. If you move the #include of mach.h from os_bsd.inline.hpp into
globalDefinitions_gcc.hpp and #undef EFL_AC and EFL_ID in
globalDefinitions_gcc.hpp, then the problem goes away.
Paul
On 2/15/12 1:56 PM, Staffan Larsen wrote:
On 15 feb 2012, at 19:33, Paul Hohensee wrote:
Imo we should
Thanks!
Paul
On 2/15/12 2:25 PM, Staffan Larsen wrote:
On 15 feb 2012, at 20:03, Paul Hohensee wrote:
On 2/15/12 1:58 PM, Staffan Larsen wrote:
On 15 feb 2012, at 19:49, Paul Hohensee wrote:
Also,
You can move the #include of mach.h into globalDefinitions_gcc.hpp,
in the #ifdef __APPLE__
Looks good.
Paul
On 2/14/12 4:20 PM, keith mcguigan wrote:
Well, ok, I guess it's not the smallest code change -- I think I've
matched this before -- but I guarantee you won't see one smaller than
this!
It's a one-liner (a one-character-er) to accept 0 as a successful
return from an
Looks good, again with Dan's recommendations.
Paul
On 2/10/12 9:37 AM, Daniel D. Daugherty wrote:
On 2/10/12 5:14 AM, Dmitry Samersoff wrote:
Hi Everybody,
Assert incorrectly triggered by _invokedynamic opcode.
Fixed assert.
webrev is:
Changeset: 869be5c8882e
Author:phh
Date: 2012-02-03 17:21 -0500
URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/869be5c8882e
7142586: Cannot build on Solaris 11 due to use of ia_nice
Summary: Delete the single use of ia_nice in os_solaris.cpp
Reviewed-by: kamg, kvn
!
linux-sparc used to build and run fine (I did the port way back when),
so it should be relatively easy to resurrect. The original port was on
a T1.
Paul
On 1/31/12 10:23 AM, Deepak Bhole wrote:
* David Holmesdavid.hol...@oracle.com [2012-01-30 21:50]:
On 31/01/2012 12:36 PM, Deepak Bhole
On, and it's not supported by Oracle, of course. One of the Linux
distro companies might be interested though.
On 2/1/12 7:12 AM, Paul Hohensee wrote:
linux-sparc used to build and run fine (I did the port way back when),
so it should be relatively easy to resurrect. The original port
Changeset: 481a9443f721
Author:phh
Date: 2012-02-01 15:01 -0500
URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/481a9443f721
7123386: RFE: Preserve universal builds of HotSpot on Mac OS X
Summary: Add support for packaging HotSpot JVM builds in universal binaries
Will this fix the jdk7u-dev build problem?
Thanks,
paul
On 1/26/12 4:44 AM, Rickard Bäckman wrote:
Hi,
We have a problem with some versions of jar reporting errors when
trying to run jar cf some.jar com/test com/test/foo
This fix removes the redundant subdirectories from the command.
Apparently yes. Thanks,
paul
On 1/26/12 9:14 AM, Paul Hohensee wrote:
Will this fix the jdk7u-dev build problem?
Thanks,
paul
On 1/26/12 4:44 AM, Rickard Bäckman wrote:
Hi,
We have a problem with some versions of jar reporting errors when
trying to run jar cf some.jar com/test com/test
Looks good.
Paul
On 1/26/12 8:17 AM, Rickard Bäckman wrote:
Hi,
can I have some reviews for this change?
I decided to go with unused typedefs (thanks Keith) for the usages in
the class definition and a do { } while (0) in the method definition.
The webrev:
Changeset: d6660fedbab5
Author:phh
Date: 2012-01-24 14:07 -0500
URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/d6660fedbab5
7126732: MAC: Require Mac OS X builds/tests for JPRT integrate jobs for HotSpot
Summary: Modify jprt.properties to run OSX builds and tests.
Changeset: 94ec88ca68e2
Author:phh
Date: 2012-01-11 17:34 -0500
URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/94ec88ca68e2
7115199: Add event tracing hooks and Java Flight Recorder infrastructure
Summary: Added a nop tracing infrastructure, JFR makefile changes and
Looks good.
Tiny things:
In globals.hpp, you might take this opportunity to get rid of the
default value for the withComments argument to printFlags.
In diagnosticCommand.hpp, there's a few places with blanks
between parens where the blanks should go away, vis.
static const char* name( ) {
Changeset: b16494a69d3d
Author:phh
Date: 2012-01-03 15:11 -0500
URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/b16494a69d3d
7126185: Clean up lasterror handling, add os::get_last_error()
Summary: Add os::get_last_error(), replace getLastErrorString() by
os::lasterror()
Looks good.
Thanks,
Paul
On 12/21/11 3:35 PM, Thomas Wuerthinger wrote:
Thanks for the review. I've corrected the comments and created a new
webrev at: http://cr.openjdk.java.net/~thomaswue/7064927/webrev.00/
- thomas
On 20.12.2011 23:09, Paul Hohensee wrote:
Looks good, except
Changeset: 11c26bfcf8c7
Author:phh
Date: 2011-12-21 15:48 -0500
URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/11c26bfcf8c7
7091417: recvfrom's 6th input should be of type socklen_t
Summary: Revamp class os's socket method formal args to match socket.h, insert
casts in
Changeset: 6c995c08526c
Author:phh
Date: 2011-12-19 15:50 -0500
URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/6c995c08526c
7122880: Extend vendor-specific command interface to include manageable switches
Summary: Add Flag::external_ext()/writable_ext(), both return
Looks good, except that the LocalVariableTable attribute comments in
write_code_attribute() and write_local_variable_table_attribute() don't
match. The comment in the latter says LineNumberTable instead
of LocalVariableTable and the descriptor is for the line number table
rather than the local
The framework implemented for
7117389: Add a framework for vendor-specific command line switch
extensions to Hotspot
did not include support for vendor-specific manageable-by-JMX switches.
This change adds new methods Flag::is_external_ext() and
Flag::is_writeable_ext() that
return false,
Thank you for the review.
Paul
On 12/19/11 6:55 PM, David Holmes wrote:
Looks fine to me.
David
On 20/12/2011 3:24 AM, Paul Hohensee wrote:
The framework implemented for
7117389: Add a framework for vendor-specific command line switch
extensions to Hotspot
did not include support
good practice to
explicitly include
globals.hpp directly.
Paul
Regards,
Kris Mok
On Tue, Dec 20, 2011 at 1:24 AM, Paul Hohensee
paul.hohen...@oracle.com mailto:paul.hohen...@oracle.com wrote:
The framework implemented for
7117389: Add a framework for vendor-specific command line
the refactoring
in diagnosticCommandFramework.cpp (too few lines can be really
factored out without passing many arguments).
New webrev is here:
http://cr.openjdk.java.net/~fparain/7104647/webrev.hotspot.03/
Regards,
Fred
On 12/ 8/11 07:26 PM, Paul Hohensee wrote:
For the hotspot part at
http
For the hotspot part at
http://cr.openjdk.java.net/~fparain/7104647/webrev.hotspot.00/
Most of my comments are style-related. Nice job on the implementation
architecture.
In attachListener.cpp:
You might want to delete the first return JNI_OK; line, since the code
under
For the hotspot part:
In attachListener.cpp, you might want to delete the first return JNI_OK;
line, since the code under HAS_PENDING_EXCEPTION just falls through.
In jmm.h, minor formatting nit: be nice to indent (JNIEnv on lines 318,
319 and 325 the same as the existing declarations. Add a
Changeset: 358eca91be48
Author:phh
Date: 2011-11-30 12:48 -0500
URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/358eca91be48
7116730: Revert 7116481: Commercial features in Hotspot must be gated by a
switch
Summary: Revert 7116481 to current hsx/hotspot-main
Changeset: 242b4e0e6f73
Author:phh
Date: 2011-11-29 09:21 -0500
URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/242b4e0e6f73
7116189: Export JVM_SetNativeThreadName from Hotspot
Summary: Added JVM_SetNativeThreadName to linker mapfiles on Solaris and Linux.
Reviewed-by:
Changeset: 763f01599ff4
Author:phh
Date: 2011-11-29 17:00 -0500
URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/763f01599ff4
7116481: Commercial features in Hotspot must be gated by a switch
Summary: Add -XX:+UnlockCommercialVMOptions to gate use of commercial feature
This was my fault. See
http://hg.openjdk.java.net/jdk7/hotspot-rt/hotspot/rev/b1a2afa37ec4
I simply forgot to update the jdk (though I did remember to update jmm.h,
of course, because I added . The changes isn't functional, just a
formal parameter name change to match the jni call.
If we can
Changeset: 3d5a546351ef
Author:phh
Date: 2011-03-11 16:09 -0500
URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/hotspot/rev/3d5a546351ef
7023931: PcDescCache::find_pc_desc should not write _last_pc_desc
Summary: Remove _last_pc_desc and use pcdescs[0] instead.
Reviewed-by: dcubed,
Changeset: c73c178159d8
Author:phh
Date: 2011-01-20 19:34 -0500
URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/c73c178159d8
6173675: MM: approximate memory allocation rate/amount per thread
Summary: Subclass com.sun.management.ThreadMXBean from
java.lang.management.ThreadMXBean,
I filed 7011788 for this.
Paul
On 1/10/11 2:29 AM, Paul Hohensee wrote:
I'll file a CR.
Thanks for your review!
Pul
On 1/10/11 2:01 AM, David Holmes wrote:
Paul Hohensee said the following on 01/10/11 16:42:
My bad on the 7003271 webrev. It's already pushed. The only one to
review
Changeset: 5577848f5923
Author:phh
Date: 2011-01-11 17:33 -0500
URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/hotspot/rev/5577848f5923
7011463: Sparc MacroAssembler::incr_allocated_bytes() needs a
RegisterOrConstant argument
Summary: Replaced incr_allocated_bytes() formals
Thanks!
Paul
On 1/10/11 10:59 AM, Mandy Chung wrote:
On 1/9/11 5:10 PM, Paul Hohensee wrote:
Thanks to all who reviewed the previous webrev. Revised versions are
here
http://cr.openjdk.java.net/~phh/6173675/webrev.02/
Looks good. Thanks for updating it and adding the tests
Christian Thalinger wrote:
On Jan 4, 2011, at 10:00 PM, Paul Hohensee wrote:
These two rfes implement per-thread approximate memory allocation tracking.
6173675 also adds multi-thread-id versions of getThreadCpuTime and getThreadUserTime.
6173675 MM: approximate memory allocation
These two rfes implement per-thread approximate memory allocation tracking.
6173675 also adds multi-thread-id versions of getThreadCpuTime and
getThreadUserTime.
*6173675 MM: approximate memory allocation rate/amount per thread
http://monaco.sfbay.sun.com/detail.jsf?cr=6173675
**7003271
Looks good.
Paul
On 12/16/10 1:23 PM, Kevin Walls wrote:
Hi again -- Just a minor nit I'd like to fix for the x64 linux tools.
Thanks
Kevin
On 30/11/2010 16:52, Kevin Walls wrote:
Hi,
An oversight whereby although jstack and the Serviceability Agent's
jstackproc.sh work on x64, the
fwiw, the HSX model specifically doesn't support dropping old versions
of Hotspot
into newer JDKs.
Paul
On 12/16/10 6:01 PM, Alan Bateman wrote:
Keith McGuigan wrote:
:
I like the flexibility of being able to swap in/out different JVMs --
be it earlier versions of Hotspot or something else
Changeset: 167c2986d91b
Author:phh
Date: 2009-12-16 12:54 -0500
URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/hotspot/rev/167c2986d91b
6843629: Make current hotspot build part of jdk5 control build
Summary: Source changes for older compilers plus makefile changes.
Reviewed-by:
Changeset: 84cb6f20afb3
Author:phh
Date: 2009-11-20 16:22 -0500
URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/hotspot/rev/84cb6f20afb3
6900899: vm fails to start when -Xmx value is less than OldSize + NewSize
Summary: Set minimum heap size to min(OldSize + NewSize, MaxHeapSize)
6898160: Need serviceability support for new vm argument type 'uint64_t'.
Webrev here
http://cr.openjdk.java.net/~phh/6898160/webrev.01/
A new vm argument type, 'uint64_t', was added as part of 6887571. The
jdk library
code in jdk/share/native/sun/management/Flag.c that fetches all the vm
Thanks for the quick review.
I changed it to flag value must be an unsigned 64-bit integer.
Paul
Mandy Chung wrote:
Looks okay to me. Minor nit:
attachListener.cpp line 267: unsigned integer in the error message
should be unsigned 64-bit value or something like that.
Mandy
Paul
Thanks, :)
Paul
Daniel D. Daugherty wrote:
Paul Hohensee wrote:
6898160: Need serviceability support for new vm argument type
'uint64_t'.
Webrev here
http://cr.openjdk.java.net/~phh/6898160/webrev.01/
src/share/vm/runtime/globals.cpp
No comments.
src/share/vm/services
Changeset: ba7ea42fc66e
Author:phh
Date: 2009-11-04 16:49 -0500
URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/hotspot/rev/ba7ea42fc66e
6898160: Need serviceability support for new vm argument type 'uint64_t'
Summary: Add serviceability support for uint64_t. Flags of unknown type
Forwarding to serviceability-dev.
Alan Bateman here at Sun suggests that BCI might be the best way to do this.
It's the way Netbeans handles it, e.g. You might be interested in
btrace too. See
https://btrace.dev.java.net/
Paul
---BeginMessage---
Hi all --
we are using JVMTI for
55 matches
Mail list logo
