Re: RFR: 8244669: convert clhsdb "mem" command from javascript to java [v4]

On Tue, 21 Dec 2021 23:12:45 GMT, Chris Plummer wrote: >> clhsdb lost support for the "mem" command when javascript support was >> removed from SA. This PR is re-adding it by implementing it in Java. The >> description of the CR contains all the details. >> >> Regarding the clhsdb.html changes

Re: RFR: 8254001: [Metrics] Enhance parsing of cgroup interface files for version detection

On Mon, 23 Nov 2020 15:50:18 GMT, Severin Gehwolf wrote: >> This is an enhancement which solves two issues: >> >> 1. Multiple reads of relevant cgroup interface files. Now interface files >> are only read once per file (just like Hotspot). >> 2. Proxies creation of the impl specific subsystem v

RFR: JDK-8165493: SA: Add method in GrowableArray.java to be able to access the 'data' field

Hello, Please review this small change that adds an accessor method to GrowableArray class for its 'data' field. Bug: https://bugs.openjdk.java.net/browse/JDK-8165493 Webrev: http://cr.openjdk.java.net/~poonam/8165493/webrev/ This change is required for closed flight recorder related changes

Re: RFR(8u) JDK-8153252: SA: Hotspot build on Windows fails if make/closed folder does not exist

Hello, As per Erik's suggestion not to remove the existing check for HS_ALT_MAKE, here is the updated webrev: http://cr.openjdk.java.net/~poonam/8153252/webrev.01/ Thanks, Poonam On 4/11/2016 12:15 PM, Poonam Bajaj Parhar wrote: Hello, Please review this simple fix. Bug JDK-8153252 &

RFR(8u) JDK-8153252: SA: Hotspot build on Windows fails if make/closed folder does not exist

Hello, Please review this simple fix. Bug JDK-8153252 : SA: Hotspot build on Windows fails if make/closed folder does not exist Problem: The problem is that the SA build on windows fails while building non-openjdk commercial sources that don'

RFR: JDK-8140031: SA: Searching for a value in Threads does not work

Hello, Please review the changes for the following fix: Bug: JDK-8140031: SA: Searching for a value in Threads does not work Fix: These changes improve the threads related commands in clhsdb 1. 'threads' command now prints the detailed information about threads. 2. 'thread' command now prints t

Re: Review request: Backport of JDK-8046282 to 8u

re and live process Thanks, Poonam On 2/12/2015 11:51 PM, Staffan Larsen wrote: Hi Poonam, Did the changes apply cleanly? What tests have you run? /Staffan On 29 jan 2015, at 20:42, Poonam Bajaj Parhar mailto:poonam.ba...@oracle.com>> wrote: Hello, Review request for the backport of 8

Re: Review request: Backport of JDK-8046282 to 8u

Hello, Could I have reviews for these backported changes, please. Thanks, Poonam On 1/29/2015 11:42 AM, Poonam Bajaj Parhar wrote: Hello, Review request for the backport of 8046282 to 8u: Bug: JDK-8046282 <https://bugs.openjdk.java.net/browse/JDK-8046282> SA update Webrev

Review request: Backport of JDK-8046282 to 8u

Hello, Review request for the backport of 8046282 to 8u: Bug: JDK-8046282 SA update Webrev: http://cr.openjdk.java.net/~poonam/8046282/webrev.00/ Thanks, Poonam

RFR(S): JDK-8065220: Include alternate sa.make file for MacOSX

Hello, Could I request reviews for this simple change to include alternate sa.make file in make/bsd/makefiles/sa.make: Bug:JDK-8065220: Include alternate sa.make file for MacOSX Webrev: http://cr.openjdk.java.net/~poonam/8065220/webrev.00/ T

Re: RFR 8060169: Update the Crash Reporting URL in the Java crash log

Hi David, On 10/31/2014 8:58 AM, david buck wrote: Hi! Please approve this very simple update to the URL written in the crash log (hs_err_pid.log) file. BUGURL: https://bugs.openjdk.java.net/browse/JDK-8060169 WEBREV: http://cr.openjdk.java.net/~dbuck/8060169/webrev.000/ The changes look g

Re: Review request: 8049303: Transient network problems cause JMX thread to fail silenty

Hi Jaroslav, On 8/26/2014 4:06 PM, Jaroslav Bachorik wrote: Hi Poonam, On 08/26/2014 12:27 PM, Poonam Bajaj wrote: Sending the review request to serviceability-dev list as well... --- Could I have reviews for this change: Bug: https://bugs.openjdk.java.net/browse/JDK-8049303 Webrev

Review request: 8049303: Transient network problems cause JMX thread to fail silenty

Sending the review request to serviceability-dev list as well... --- Could I have reviews for this change: Bug: https://bugs.openjdk.java.net/browse/JDK-8049303 Webrev: http://cr.openjdk.java.net/~poonam/8049303/webrev.00/ Problem and fix: By default the JMX client side notification fet

Re: Review Request: JDK-8049881: jstack not working on core files

Hi David, On 7/21/2014 5:52 PM, David Holmes wrote: Hi Poonam, On 21/07/2014 7:29 PM, Poonam Bajaj wrote: The changes for "8046282: SA update" introduced this bug. The following changes fix the failure. Bug: JDK-8049881 <https://bugs.openjdk.java.net/browse/JDK-8049881>: js

Review Request: JDK-8049881: jstack not working on core files

The changes for "8046282: SA update" introduced this bug. The following changes fix the failure. Bug: JDK-8049881 : jstack not working on core files Webrev: http://cr.openjdk.java.net/~poonam/8049881/webrev.00/ With these changes jstack works

Re: "8046282: SA update" seems to break the SA/jstack in OpenJDK

Hi Volker, Thanks. There is a bug filed for this issue: https://bugs.openjdk.java.net/browse/JDK-8049881 I am working on this bug. Thanks, Poonam On 7/10/2014 4:00 PM, Volker Simonis wrote: Hi, the change "8046282: SA update" introduced the following new code in agent/src/share/classes/sun

Re: RFR JDK-8046282: SA update

Thanks for the review, Sundar. regards, Poonam On 6/16/2014 3:54 PM, A. Sundararajan wrote: Hi Poonam, Looks good to me. -Sundar On Monday 16 June 2014 02:45 PM, Poonam Bajaj wrote: Hi Sundar, I have updated the enum classes. The updated webrev is available here: http

Re: RFR JDK-8046282: SA update

Hi Sundar, I have updated the enum classes. The updated webrev is available here: http://cr.openjdk.java.net/~poonam/8046282/webrev.01/ Please review the changes and let me know your feedback. Thanks, Poonam On 6/12/2014 1:25 PM, Poonam Bajaj wrote: Hi Sundar, Is it okay with you if I keep

Re: RFR JDK-8046282: SA update

2014 02:40 PM, Poonam Bajaj wrote: Hi Sundar, Yes, it is possible to do that. e.g. G1YCType can be defined like this. public enum G1YCType { Normal ("Normal"), InitialMark ("Initial Mark"), DuringMark ("During Mark"), Mixed ("Mixed"), G1YCType

Re: RFR JDK-8046282: SA update

Thanks Markus! regards, Poonam On 6/9/2014 1:40 PM, Markus Grönlund wrote: Hi Poonam, I think this looks good (not a Reviewer). Thanks for giving SA some much needed attention. /Markus -Original Message- From: Poonam Bajaj Sent: den 7 juni 2014 11:18 To: serviceability-dev Subject

Re: RFR JDK-8046282: SA update

e that itself - no need for "Unknown" in such cases. It'd nice to simplify that class-within-enum pattern... -Sundar On Saturday 07 June 2014 02:48 PM, Poonam Bajaj wrote: Hi, Please review these changes for the bug 8046282 for JDK 9. These changes add some definitions on the S

RFR JDK-8046282: SA update

Hi, Please review these changes for the bug 8046282 for JDK 9. These changes add some definitions on the SA side and the supporting code on the hotspot side. Webrev: http://cr.openjdk.java.net/~poonam/8046282/webrev.00/ Bug: https://bugs.openjdk.java.net/browse/JDK-8046282 Thanks, Poonam

hg: hsx/hotspot-rt/hotspot: 3 new changesets

Changeset: a70566600baf Author:poonam Date: 2013-08-21 22:12 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/a70566600baf 8020530: Non heap memory size calculated incorrectly Reviewed-by: coleenp, sla Contributed-by: vladimir.kem...@oracle.com ! src/share/vm/servic

Re: RFR(S): 8021444: SA: ClassDump.run() should not ignore existing ClassFilter.

Hi Kevin, The changes look good. Thanks, Poonam On 7/31/2013 4:00 PM, Kevin Walls wrote: Thanks Yumin - Any further review out there, then I'll get this cleared up... Thanks Kevin On 26/07/13 16:47, Yumin Qi wrote: Looks good! Thanks for fixing it. Yumin On 7/26/2013 3:06 AM, Kevin Wal

Re: RFR: 8015576: CMS: svc agent throws java.lang.RuntimeException: No type named "FreeList" in database

Hi Vladimir, The changes look good. Thanks, Poonam On 7/15/2013 6:59 PM, Vladimir Kempik wrote: Can I have a couple of reviewers for this please ? This is urgent now, as ZBB for 7u40 is nearing. Thanks On 04.07.2013 18:50, Vladimir Kempik wrote: Hi all, this change fixes an issue where we c

Re: RR 6313816: SA: jstack -m fails on Win32 : UnalignedAddressException

Hi Kevin, The changes look good. Thanks, Poonam On 5/7/2013 5:36 PM, Kevin Walls wrote: Hi - I'd like to get another review from an openjdk user/reviewer/... Thanks Kevin On 03/05/13 09:3

Re: RFR: 8008917 CMS: Concurrent mode failure tracing event

Hi Kevin, Changes look good to me. Thanks, Poonam On 3/1/2013 11:04 PM, Kevin Walls wrote: Hi, I'd like some reviews on this CMS Concurrent Mode Failure event: http://cr.openjdk.java.net/~kevinw/8008917/hotspot/ The event doesn't actually carry any new information, but it is a warning we n

Re: RR(S): 8008807: SA: jstack crash when target has mismatched bitness (Linux)

Hi Kevin, The fix looks good. Thanks, Poonam On 2/25/2013 11:51 PM, Kevin Walls wrote: Hi, This is a crash I stumbled upon: jstack -m will crash when it doesn't match the bitness of its target. On Solaris we check and give an exception message, Linux should do similarly. http://cr.openj

Re: RFR (S) 7178741: SA: jstack -m produce UnalignedAddressException in output (Linux)

Hi Kevin, The changes look good. Thanks, Poonam On 2/21/2013 8:55 PM, Kevin Walls wrote: Hi, I'd like to get reviews on this small SA fix: http://cr.openjdk.java.net/~kevinw/7178741/webrev_8.00/ jstack -m follows native frames, and gets confused if it can't follow from frame pointer to sav

hg: hsx/hotspot-rt/hotspot: 2 new changesets

Changeset: b87e5a681416 Author:poonam Date: 2012-06-14 02:12 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/b87e5a681416 6310967: SA: jstack -m produce failures in output Summary: While looking for the sender frame check that the frame pointer should not be less t

Re: Request for review: 6310967: SA: jstack -m produce failures in output

th the fix. Thanks, /Staffan On 14 jun 2012, at 06:10, Poonam Bajaj wrote: Could I get one more review for this fix, please. Thanks, Poonam On 6/13/2012 7:57 AM, David Holmes wrote: On 13/06/2012 12:25 PM, Poonam Bajaj wrote: Hi David, On 6/13/2012 7:35 AM, David Holmes wrote: Hi Poonam, I

Re: Request for review: 6310967: SA: jstack -m produce failures in output

Could I get one more review for this fix, please. Thanks, Poonam On 6/13/2012 7:57 AM, David Holmes wrote: On 13/06/2012 12:25 PM, Poonam Bajaj wrote: Hi David, On 6/13/2012 7:35 AM, David Holmes wrote: Hi Poonam, It seems to me that rather than passing the ThreadProxy through to f.sender

Re: Request for review: 6310967: SA: jstack -m produce failures in output

On 12/06/2012 11:05 PM, Poonam Bajaj wrote: Hi, Please review this fix for bug 6310967 <http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=6310967>. 6310967 <http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=6310967>: SA: jstack -m produce failures in output http://cr.openjdk.ja

Request for review: 6310967: SA: jstack -m produce failures in output

Hi, Please review this fix for bug 6310967 . 6310967 : SA: jstack -m produce failures in output http://cr.openjdk.java.net/~poonam/6310967/webrev.00/ Problem: jstack -m f

Re: Clarification on SA support for Windows & JDK6

Hi Martin, That page talks only about 'SA-Plugin for VisualVM' and the JDK versions it is supported on. The page is not up-to-date. With the fix for 6755621 : Include SA binaries into Windows JDK, integrated into jdk6u30, SA binaries a

Re: SA frontends

Hi Kris, SA-Plugin for VisualVM uses HotspotAgent - SA interface provided by class sun.jvm.hotspot.HotSpotAgent. SA-Plugin uses the attach/detach functionality provided by this class and it uses other SA classes (e.g. sun.jvm.hotspot.runtime.*, sun.jvm.hotspot.ui.*) to extract and display dat

hg: hsx/hotspot-rt/hotspot: 7145358: SA throws ClassCastException for partially loaded ConstantPool

Changeset: 38fd165da001 Author:poonam Date: 2012-02-20 21:27 -0800 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/38fd165da001 7145358: SA throws ClassCastException for partially loaded ConstantPool Summary: In printValueOn() in ConstantPool.java check if the poolHolder

Request for review: 7145358: SA throws ClassCastException for partially loaded ConstantPool

Request for review: CR 7145358 : SA throws ClassCastException for partially loaded ConstantPool webrev: http://cr.openjdk.java.net/~poonam/7145358/webrev.00/ Contributed by: Krystal Mok mailto:sa...@taobao.com>> If the poolHolder fiel

hg: hsx/hotspot-rt/hotspot: 7009098: SA cannot open core files larger than 2GB on Linux 32-bit

Changeset: 54d3535a6dd3 Author:poonam Date: 2012-02-12 19:33 -0800 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/54d3535a6dd3 7009098: SA cannot open core files larger than 2GB on Linux 32-bit Summary: Added Large File Support by compiling libsaproc.so with -D_FILE_OFF

Re: Review Request: 7009098: SA cannot open core files larger than 2GB on Linux 32-bit

webrev.00/ <http://cr.openjdk.java.net/%7Epoonam/7009098/webrev.00/> Thanks, Poonam On 2/9/2012 12:29 PM, Poonam Bajaj wrote: On 2/9/2012 12:21 PM, David Holmes wrote: Hi Poonam, On 9/02/2012 4:42 PM, Poonam Bajaj wrote: There is one more change with which SA should first load librar

Re: Review Request: 7009098: SA cannot open core file larger than 2GB

On 2/9/2012 12:21 PM, David Holmes wrote: Hi Poonam, On 9/02/2012 4:42 PM, Poonam Bajaj wrote: There is one more change with which SA should first load libraries from the path specified with SA_ALTROOT rather than loading from the host system. Where does this come from? It is not related to

Re: Review Request: 7009098: SA cannot open core file larger than 2GB

Hi David, On 2/9/2012 11:36 AM, David Holmes wrote: On 9/02/2012 2:41 PM, Poonam Bajaj wrote: Could I have code reviews for the following fix: 7009098: SA cannot open core file larger than 2GB http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7009098 Webrev: http://cr.openjdk.java.net

Re: Review Request: 7009098: SA cannot open core file larger than 2GB

, because I've been using SA to open core files around 4GB~5GB on Linux/x64 routinely, and it worked. Regards, Kris Mok On Thu, Feb 9, 2012 at 12:41 PM, Poonam Bajaj <mailto:poonam.ba...@oracle.com>> wrote: Could I have code reviews for the following fix: 7009098: SA ca

Review Request: 7009098: SA cannot open core file larger than 2GB

Could I have code reviews for the following fix: 7009098: SA cannot open core file larger than 2GB http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7009098 Webrev: http://cr.openjdk.java.net/~poonam/7009098/webrev.00/ Serviceability Agent on Linux is not able to open core files larger than 2GB

Re: code review request for Redefine and Retransform Classes memory leak (7121600, 7122253)

Hi Dan, On 12/22/2011 8:52 AM, Daniel D. Daugherty wrote: On 12/21/11 8:05 PM, Poonam Bajaj wrote: Hi Dan, In the following block (in JPLISAgent.c): /1278 if (!errorOccurred) { 1279 jvmtiError errorCode = JVMTI_ERROR_NONE; 1280

Re: code review request for Redefine and Retransform Classes memory leak (7121600, 7122253)

. so JDK only or both JDK and HSX? Dan On 12/21/11 8:22 PM, Daniel D. Daugherty wrote: On 12/21/11 8:05 PM, Poonam Bajaj wrote: Hi Dan, In the following block (in JPLISAgent.c): /1278 if (!errorOccurred) { 1279 jvmtiError error

Re: code review request for Redefine and Retransform Classes memory leak (7121600, 7122253)

- WinXP JDK8/HSX-23-B08 (not yet started) Thanks, in advance, for any feedback... Dan -- Best regards, Poonam

Re: SECOND CALL: code review for jvmstat/jps fix (6954420)

Looks good. One minor suggestion - you may consider changing the following warning message to something like "Could not get status information on file ". 1357 struct stat statbuf; 1358 int ret_code = ::stat(filename, &statbuf); 1359 if (ret_code == OS_ERR) { 1360 if (PrintMisc

Re: code review for very small jstat fix (7005984)

Looks good to me. Thanks, Poonam On 12/24/2010 4:55 AM, Daniel D. Daugherty wrote: Greetings, I need a code review for a very small jstat fix: http://cr.openjdk.java.net/~dcubed/7005984-webrev/0/ It's going to take me longer to remember how to run the associated tests in JPRT than it is

Re: SECOND CALL: serviceability agent (SA) fix for VS2010 (6987812)

Hi Dan, I looked at the changes. It looks good. Thanks for fixing the search logic for dbg*.dll files in WindbgDebuggerLocal.java. Thanks, Poonam On 12/23/2010 4:45 AM, Daniel D. Daugherty wrote: Added original reviewer list back in since this is an open review... Thanks for the review! Da

hg: jdk7/hotspot-rt/hotspot: 6837842: JNI_CreateJavaVM crashes under impersonation

Changeset: 0b33f0736406 Author:poonam Date: 2010-11-19 03:41 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/hotspot/rev/0b33f0736406 6837842: JNI_CreateJavaVM crashes under impersonation Reviewed-by: acorn, dholmes ! src/os/windows/vm/perfMemory_windows.cpp

hg: jdk7/hotspot-rt/hotspot: 6745217: jmap assertion failure

Changeset: 9d4dd91c4a0a Author:poonam Date: 2010-05-15 18:24 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/hotspot/rev/9d4dd91c4a0a 6745217: jmap assertion failure Summary: SA shows exception with core files > 2GB. These changes fix that by correcting the size of CMSBitmap

hg: jdk7/hotspot-rt/hotspot: 6858208: jvm crash when specifying TypeProfileWidth=0 on jdk 6.0

Changeset: 6918603297f7 Author:poonam Date: 2009-09-01 23:34 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/hotspot/rev/6918603297f7 6858208: jvm crash when specifying TypeProfileWidth=0 on jdk 6.0 Summary: Add an explicit check for TypeProfileWidth == 0 in record_klass_in_p

hg: jdk7/tl/jdk: 6814140: deadlock due to synchronized demandLogger() code that locks ServerLogManager

Changeset: dba7dc47b78e Author:poonam Date: 2009-07-22 07:49 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/dba7dc47b78e 6814140: deadlock due to synchronized demandLogger() code that locks ServerLogManager Summary: Making demandLogger() non-synchronized resolves the deadloc

hg: jdk7/hotspot-rt/hotspot: 6840305: Discrepancy in system memory details (when 4G or greater) reported by JVM and Windows OS

Changeset: 8c79517a9300 Author:poonam Date: 2009-07-16 18:21 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/hotspot/rev/8c79517a9300 6840305: Discrepancy in system memory details (when 4G or greater) reported by JVM and Windows OS Summary: GlobalMemoryStatus() does not repor

hg: jdk7/hotspot-rt/hotspot: 6829234: Refix 6822407 and 6812971

Changeset: 81a249214991 Author:poonam Date: 2009-05-04 17:58 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/hotspot/rev/81a249214991 6829234: Refix 6822407 and 6812971 Summary: Fixes two SA issues 6822407 and 6812971 Reviewed-by: swamyv, acorn, kvn, coleenp ! agent/src/share

hg: jdk7/hotspot-rt/hotspot: 6822407: heapOopSize lookup is incorrect in Serviceability Agent.

Changeset: f30ba3b36599 Author:poonam Date: 2009-03-27 10:29 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/hotspot/rev/f30ba3b36599 6822407: heapOopSize lookup is incorrect in Serviceability Agent. Summary: heapOopSize symbol should be declared as constant in vmStructs and

hg: jdk7/hotspot-rt/hotspot: 6812971: SA: re-attaching to process fails

Changeset: 54782a4cd321 Author:poonam Date: 2009-03-15 18:11 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/hotspot/rev/54782a4cd321 6812971: SA: re-attaching to process fails Summary: After attaching, de-attaching SA from a process, the second time attach() call fails. This

hg: jdk7/tl/jdk: 6755621: Include SA binaries into Windows JDK

Changeset: 40ce81649cd6 Author:poonam Date: 2009-02-10 03:26 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/40ce81649cd6 6755621: Include SA binaries into Windows JDK Summary: These changes will enable inclusion of sa-jdi.jar and sawindbg.dll into Windows JDK bundle. Reviewe

hg: jdk7/hotspot-svc/hotspot: 6743339: Enable building sa-jdi.jar and sawindbg.dll on Windows with hotspot build

Changeset: b6272ef4a18f Author:poonam Date: 2008-11-27 18:19 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-svc/hotspot/rev/b6272ef4a18f 6743339: Enable building sa-jdi.jar and sawindbg.dll on Windows with hotspot build Summary: These changes enable the SA binaries build with h

hg: jdk7/hotspot-svc/hotspot: 2 new changesets

Changeset: 25c3145237c6 Author:poonam Date: 2008-08-27 22:45 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-svc/hotspot/rev/25c3145237c6 6731958: Include all the SA classes into sa-jdi.jar Summary: sa-jdi.jar bundled with JDK should include all the SA classes. Reviewed-by: swamy