Re: RFR: 8268286: ProblemList serviceability/sa/TestJmapCore.java on linux-aarch64 with ZGC

On Sat, 5 Jun 2021 15:12:50 GMT, Daniel D. Daugherty wrote: > A trivial fix to ProblemList serviceability/sa/TestJmapCore.java on > linux-aarch64 with ZGC. Marked as reviewed by rriggs (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/4374

Re: RFR: 8268698: Use Objects.check{Index, FromToIndex, FromIndexSize} for java.base [v11]

On Thu, 8 Jul 2021 03:12:24 GMT, Yi Yang wrote: >> After JDK-8265518(#3615), it's possible to replace all variants of >> checkIndex by >> Objects.checkIndex/Objects.checkFromToIndex/Objects.checkFromIndexSize in >> the whole JDK codebase. > > Yi Yang has refreshed the contents of this pull req

Re: Integrated: 8274294: ProblemList sun/tools/jmap/BasicJMapTest.java

On Fri, 24 Sep 2021 15:34:18 GMT, Daniel D. Daugherty wrote: > A trivial fix to ProblemList sun/tools/jmap/BasicJMapTest.java. Marked as reviewed by rriggs (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/5685

Re: RFR: JDK-8276447 Deprecate finalization-related methods for removal

On Thu, 18 Nov 2021 21:51:30 GMT, Brent Christian wrote: > Here are the code changes for the "Deprecate finalizers in the standard Java > API" portion of JEP 421 ("Deprecate Finalization for Removal") for code > review. > > This change makes the indicated deprecations, and updates the API spec

Re: RFR: 8272317: jstatd has dependency on Security Manager which needs to be removed

On Wed, 22 Dec 2021 21:41:13 GMT, Mandy Chung wrote: >> Remove the use of Security Manager from jstatd. >> Add use of an ObjectInputFilter to restrict RMI. >> >> Also we can undo the property-setting Launcher.gmk change from: 8279007: >> jstatd fails to start because SecurityManager is disabled

Re: RFR: 8278597: Remove outdated comments regarding RMISecurityManager in HotSpotAgent.java

On Wed, 12 Jan 2022 15:04:04 GMT, Kevin Walls wrote: > The HotSpotAgent.java setupDebugger method has a commmented out section > relating to possibly using RMISecurityManager. > The comment is from pre-jdk7. As RMISecurityManager has been deprecated for > a while the comments should be removed

Re: RFR: 8272317: jstatd has dependency on Security Manager which needs to be removed [v2]

On Mon, 10 Jan 2022 11:17:12 GMT, Kevin Walls wrote: >> Remove the use of Security Manager from jstatd. >> Add use of an ObjectInputFilter to restrict RMI. >> >> Also we can undo the property-setting Launcher.gmk change from: 8279007: >> jstatd fails to start because SecurityManager is disabled

Re: RFR: 8272777: Clean up remaining AccessController warnings in test library

On Wed, 2 Feb 2022 21:35:59 GMT, Kevin Walls wrote: > Reduce noise in test output by adding the @SuppressWarnings("removal") > annotation (which has already been widely applied). Marked as reviewed by rriggs (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/7328

Re: RFR: 8282657: Code cleanup: removing double semicolons at the end of lines

On Fri, 28 Jan 2022 14:39:31 GMT, Matteo Baccan wrote: > Hi > > I have reviewed the code for removing double semicolons at the end of lines > > all the best > matteo We usually request that these be be broken up by area to attract the appropriate reviewers and avoid eye-strain. The client mo

Re: RFR: 8282657: Code cleanup: removing double semicolons at the end of lines

On Fri, 28 Jan 2022 14:39:31 GMT, Matteo Baccan wrote: > Hi > > I have reviewed the code for removing double semicolons at the end of lines > > all the best > matteo Marked as reviewed by rriggs (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/7268

Re: RFR: 8276799: Implementation of JEP 422: Linux/RISC-V Port [v3]

On Tue, 22 Mar 2022 11:50:13 GMT, Fei Yang wrote: >> This PR implements JEP 422: Linux/RISC-V Port [1]. >> The PR starts as a squashed merge of the >> https://openjdk.java.net/projects/riscv-port branch. >> >> This has been tested with jtreg tier{1,2,3,4} and jcstress on HiFive >> Unmatched bo

Re: RFR: 8282819: Deprecate Locale class constructors

On Thu, 24 Mar 2022 22:01:30 GMT, Naoto Sato wrote: > Proposing to deprecate the constructors in the `java.util.Locale` class. > There is already a factory method and a builder to return singletons, so > there is no need to have constructors anymore unless one purposefully wants > to create `i

Re: RFR: 8282819: Deprecate Locale class constructors

On Thu, 24 Mar 2022 22:01:30 GMT, Naoto Sato wrote: > Proposing to deprecate the constructors in the `java.util.Locale` class. > There is already a factory method and a builder to return singletons, so > there is no need to have constructors anymore unless one purposefully wants > to create `i

Re: RFR: 8244681: Add a warning for possibly lossy conversion in compound assignments [v3]

On Wed, 11 May 2022 13:27:38 GMT, Adam Sotona wrote: >> That's good to know. I think the tricky part is mostly about keeping track >> of all these disabled warnings, so they are not kept around longer than >> necessary. And that needs coordination with all the subtasks of the umbrella >> issue

Re: RFR: 8280035: Use Class.isInstance instead of Class.isAssignableFrom where applicable [v2]

On Thu, 31 Mar 2022 08:03:23 GMT, Andrey Turbanov wrote: >> Method `Class.isAssignableFrom` is often used in form of: >> >> if (clazz.isAssignableFrom(obj.getClass())) { >> Such condition could be simplified to more shorter and performarnt code >> >> if (clazz.isInstance(obj)) { >>

hg: jdk8/tl/jdk: 2 new changesets

Changeset: 53819fd0ab61 Author:rriggs Date: 2013-08-16 11:28 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/53819fd0ab61 8022770: java/time/tck/java/time/chrono/TCKChronology.java start failing 8022766: java/time/test/java/time/chrono/TestUmmAlQuraChronology.java failed. Summ

hg: jdk8/tl/jdk: 8019185: Inconsistency between JapaneseEra start dates and java.util.JapaneseImperialDate

Changeset: acaa256e3f7c Author:rriggs Date: 2013-08-16 13:58 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/acaa256e3f7c 8019185: Inconsistency between JapaneseEra start dates and java.util.JapaneseImperialDate Summary: align Meiji start date with lib/calendar.properties to

hg: jdk8/tl/jdk: 8011944: Sort fails with ArrayIndexOutOfBoundsException

Changeset: 07585a2483fa Author:rriggs Date: 2013-08-26 11:46 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/07585a2483fa 8011944: Sort fails with ArrayIndexOutOfBoundsException Summary: Increase the size of pending stack and add test cases Reviewed-by: alanb ! src/share/clas

hg: jdk8/tl/jdk: 2 new changesets

Changeset: 292d93f32aa1 Author:rriggs Date: 2013-09-11 10:16 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/292d93f32aa1 8024164: JSR310 serialization should be described in details Summary: The serialized-form.html should specify the stream format for interoperability Revie

hg: jdk8/tl/jdk: 8024618: Issues with French locale on compact1, 2: expected: but was:

Changeset: 672f349fbad7 Author:rriggs Date: 2013-09-12 10:58 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/672f349fbad7 8024618: Issues with French locale on compact1,2: expected: but was: Summary: Tests against the data of the French locale are not valid as conformance te

hg: jdk8/tl/jdk: 2 new changesets

Changeset: 3255a4e348a1 Author:rriggs Date: 2013-09-14 13:55 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/3255a4e348a1 8023639: Difference between LocalTime.now(Clock.systemDefaultZone()) and LocalTime.now() executed successively is more than 100 000 000 nanoseconds for s

hg: jdk8/tl/jdk: 2 new changesets

Changeset: 01b8604e8268 Author:rriggs Date: 2013-08-22 10:01 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/01b8604e8268 8024896: Refactor java.time serialization tests into separate subpackage Summary: Move serialization tests to .serial subpackage Reviewed-by: sherman Contr

hg: jdk8/tl/jdk: 7 new changesets

Changeset: 1de0fac9b962 Author:rriggs Date: 2013-08-29 20:38 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/1de0fac9b962 8023764: Optimize Period addition Summary: Optimise plus/minus for common cases Reviewed-by: sherman Contributed-by: scolebou...@joda.org ! src/share/clas

hg: jdk8/tl/jdk: 2 new changesets

Changeset: e3b70e601c1c Author:rriggs Date: 2013-10-09 11:02 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/e3b70e601c1c 8024612: java/time/tck/java/time/format/TCKDateTimeFormatters.java failed Summary: The test should be using the Locale.Category.FORMAT to verify the test

hg: jdk8/tl/jdk: 8024076: Incorrect 2 -> 4 year parsing and resolution in DateTimeFormatter

Changeset: d42fe440bda8 Author:rriggs Date: 2013-10-09 13:34 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/d42fe440bda8 8024076: Incorrect 2 -> 4 year parsing and resolution in DateTimeFormatter Summary: Add appendValueReduced method based on a ChronoLocalDate to provide co

hg: jdk8/tl/jdk: 3 new changesets

Changeset: ea422834f880 Author:rriggs Date: 2013-09-26 23:05 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/ea422834f880 8025720: Separate temporal interface layer Summary: Remove ZoneId and Chronology from TemporalField interface Reviewed-by: sherman Contributed-by: scolebou

hg: jdk8/tl/jdk: 8026516: javadoc errors in java.time

Changeset: 36fe6a9bd43e Author:rriggs Date: 2013-10-17 10:37 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/36fe6a9bd43e 8026516: javadoc errors in java.time Summary: Corrected links to TemporalQuery and TemporalField.resolve Reviewed-by: mduigou, darcy, lancea ! src/share/c

hg: jdk8/tl/jdk: 8026183: minor documentation problems in java.lang.invoke; ...

Changeset: 456a9b199208 Author:rriggs Date: 2013-10-17 13:43 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/456a9b199208 8026183: minor documentation problems in java.lang.invoke 8015808: Typo in MethodHandle javadoc Summary: Fix typos and javadoc markup and extraneous paragr

hg: jdk8/tl/jdk: 8025828: Late binding of Chronology to appendValueReduced

Changeset: 7a947daa8f51 Author:rriggs Date: 2013-10-18 16:37 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/7a947daa8f51 8025828: Late binding of Chronology to appendValueReduced Summary: Add a listener to the parseContext called when the Chronology changes Reviewed-by: sherm

hg: jdk8/tl/jdk: 3 new changesets

Changeset: e2b814e68956 Author:rriggs Date: 2013-10-22 15:03 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/e2b814e68956 8024686: Cleanup of java.time serialization source Summary: optimize serialized form of OffsetTime, OffsetDateTime; correct order of modifiers Reviewed-by

hg: jdk8/tl/jdk: 8026982: javadoc errors in core libs

Changeset: 4bb758a77fd7 Author:rriggs Date: 2013-10-22 17:02 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/4bb758a77fd7 8026982: javadoc errors in core libs Summary: Cleanup of javadoc -Xlint errors Reviewed-by: lancea, mduigou, darcy, mullan, mchung ! src/share/classes/jav

Re: JDK 14 RFR of JDK-8232442: Suppress warnings on non-serializable non-transient instance fields in java.management.*

Hi Joe, These look ok. A few of them might be handled by making them transient, but SuppressWarnings calls more attention to them as fields that are being serialized, even indirectly. The presence of a writeReplace method weakens the coupling of the fields to the serialized values. Roger

RFR 8232622: Technical debt in BadAttributeValueExpException

Please review a minor cleanup to remove code long since unnecessary. The type of the BadAttributeValueExpException argument is String and if it is not a string in the serialized stream, a suitable replacement is created. Issue: https://bugs.openjdk.java.net/browse/JDK-8232622 Patch: diff --gi

Re: RFR 8232622: Technical debt in BadAttributeValueExpException

ger On 2/13/20 12:38 PM, Daniel Fuchs wrote: Hi Roger, I think you will need to preserve these cases: On 13/02/2020 15:52, Roger Riggs wrote: -    || valObj instanceof Long -    || valObj instanceof Integer -    || valObj instanceof Float -   

Re: RFR: 8241080: Consolidate signature parsing code in serviceability tools

Hi Daniil, In the grand scheme of things, could servicability use the signature parsing support in HotSpot? Thanks, Roger On 5/9/20 12:29 PM, Daniil Titov wrote: Please review a change[1] that centralizes the signature processing in serviceability tools to make it capable of being easily e

Re: RFR 8197387: jcmd started by "root" must be allowed to access all VM processes

Hi, - The incantations for identifying valid accesses occur enough times that it    might be worth introducing a function to do the access check. - With respect to "all processes" keep in mind that in containers like Ddocker, all may not really be all.   Though I'm not sure that is worth a c

Re: Ping!! Re: RFR: 8203357 Container Metrics

Hi, Just a thought on the timeslice units,  would nanoseconds be more future proof? In a variety of cases, milliseconds are starting to seem too coarse. $.02, Roger On 6/11/18 10:12 AM, Bob Vandette wrote: On Jun 11, 2018, at 4:32 AM, David Holmes > wrote:

Re: hprof format question

Hi Simon, I can file a bug on BufferInputStream with a bit more information about how you are using it or a failing test case. I was not able to reproduce it with a simple read of 1Mb buffers. Thanks, Roger On 11/01/2018 06:08 PM, Simon Roberts wrote: Oh, while on the topic of what I lea

Re: RFR: JDK-8213916: no copyright in signature.html

Looks fine,  Roger On 11/15/2018 09:41 AM, JC Beyler wrote: Hi Gary, Looks good to me (not a reviewer though), Jc On Thu, Nov 15, 2018 at 5:45 AM Gary Adams > wrote: Here's a quick fix to add a missing copyright to signature.html. diff --git a/src/

Re: Proposal: Always-on Statistical History

Hi, This looks like it has significant overlap with JFR. I don't think we want to start building in multiple mechanisms to keep tabs on a running VM. $.02, Roger On 11/14/2018 04:27 PM, Thomas Stüfe wrote: Hi Bernd, On Wed, Nov 14, 2018 at 10:07 PM Bernd Eckenfels wrote: Looks good Thoma

Re: RFR: 8220355: Improve assertion texts and exception messages in eventHandlerVMInit

Hi, InvocationAdapter.c: 581, remove the space after "(".  As long as that line is being changed. $.02, Roger On 03/18/2019 06:00 AM, Baesken, Matthias wrote: Hi Alan, thanks for the review . >I think this looks okay except I think "emergency" should be dropped from the message (and the

Re: RFR: JDK-8203026: java.rmi.NoSuchObjectException: no such object in table

Hi Gary, Holding a static reference to the implementation solves the problem. But I noticed that the object that is bound in the registry is the RemoteHostImpl and it should be the RemoteHost stub. Line 145: should be: bind(name.toString(), stub); That is likely to solve the problem

Re: [preview] Adding java.lang.Runtime.getVMArguments() method

Hi Jaroslav, Is this just to accommodate the test library? I found no other references in java.base. If so, then perhaps it can be placed in another package that the tests routinely need access to. Does this fit the scope of the WhiteBox? Thanks, Roger On 12/07/2015 06:23 AM, Jaroslav B

Re: RFR: 8141211: Convert TraceExceptions to Unified Logging

Hi, Are the aliases listed in the -XX usage help? +TraceExceptions is so much easier to understand and use than the new flag. Thanks, Roger On 12/08/2015 10:42 AM, Rachel Protacio wrote: Hello, Please review my conversion of -XX:+TraceExceptions to -Xlog:exceptions=info. The existing (produ

Re: RFR[9u-dev] 8130425: libjvm crash due to stack overflow in executables with 32k tbss/tdata

Hi, If just doubling the size of the Reaper stack would suffice, I would start there. If a mechanism (property) is needed to make an adjustment to the stack size, then I'd prefer something that applied to all Threads, not just the reaper. It can be done in the Java code in Thread and would be

Re: RFR[9u-dev] 8130425: libjvm crash due to stack overflow in executables with 32k tbss/tdata

Hi David, On 1/18/16 2:48 AM, David Holmes wrote: Hi Roger, On 16/01/2016 3:43 AM, Roger Riggs wrote: Hi, If just doubling the size of the Reaper stack would suffice, I would start there. That's too specific. It might be fix this problem case today, but break again tomorrow.

Re: RFR(S, TESTONLY): JDK-8148315 Create a basic reproducer for JDI issues

As an alternative to a specific child application would it be possible / reasonable to use jshell as the child? Or use the jshell API to manage the child? Then you can feed it any java expressions/functions that are interesting and get back any data needed. $.02, Roger On 1/27/2016 9:09 A

Re: RFR(S, TESTONLY): JDK-8148315 Create a basic reproducer for JDI issues

-Dmitry On 2016-01-27 17:29, Roger Riggs wrote: As an alternative to a specific child application would it be possible / reasonable to use jshell as the child? Or use the jshell API to manage the child? Then you can feed it any java expressions/functions that are interesting and get back any data

Re: JDK 9 RFR of JDK-8149616: Problem list RmiSslBootstrapTest.sh

Hi Joe, Seems correct to put it on the problem list. Roger On 2/11/2016 12:38 AM, joe darcy wrote: Hello, The test sun/management/jmxremote/bootstrap/RmiSslBootstrapTest.sh has recently been seen to fail frequently on various platforms. Until the root cause is addressed (JDK-8145919),

Re: RFR[9u-dev] 8130425: libjvm crash due to stack overflow in executables with 32k tbss/tdata

Hi, ok. A release note will be needed to document the new property. Please add the label 'release-note' and a separate comment with the proposed release note text. Thanks, Roger On 2/17/2016 10:17 AM, cheleswer sahu wrote: Hi, I have made changes in the property name (jdk.lang.processReape

Re: JDK 9 RFR of JDK-8169949: Remove java/lang/instrument/BootClassPath/BootClassPathTest.sh from ProblemList.txt

Looks fine. Roger On 11/18/2016 1:57 AM, Amy Lu wrote: Please review the patch to bring back test: java/lang/instrument/BootClassPath/BootClassPathTest.sh fails on Mac OSX As mentioned in JDK-8072130, failure is not reproducible. I also tested it with different version of macOS, test all pass

Re: RFR - 8169575: com/sun/management/DiagnosticCommandMBean/DcmdMBeanPermissionsTest.java failing with jtreg tip

Hi Harsha, The addition of the permission for "getProperty.jdk.jar.disabledAlgorithms" is fine. But the addition of a permission for exitVM.95 to satisfy the need of the test harness to exit cleanly should instead be fixed by changing the "exitVM.97" to "exitVM.*" to avoid future maintenance

Re: RFR - 8169575: com/sun/management/DiagnosticCommandMBean/DcmdMBeanPermissionsTest.java failing with jtreg tip

8 November 2016 08:58 PM, Roger Riggs wrote: Hi Harsha, The addition of the permission for "getProperty.jdk.jar.disabledAlgorithms" is fine. But the addition of a permission for exitVM.95 to satisfy the need of the test harness to exit cleanly should instead be fixed by changing the &qu

Re: RFR: JDK-8165765: javax/management/remote/mandatory/connection/RMIConnectionIdTest.java: failed when looking at RMI connection IDs:

Hi, RMIConnectionIdTest.java: - The method NetworkInterface.getByInetAddress(addr) may be a better choice without all the looping and repetitive checks of localAddr == null. Roger p.s. This would have been a good use of streams with NetworkInterface.networkInterfaces and NetworkInt

Re: RFR: JDK-8165765: javax/management/remote/mandatory/connection/RMIConnectionIdTest.java: failed when looking at RMI connection IDs:

, please find the new webrev incorporating the review comments. webrev :http://cr.openjdk.java.net/~hb/sponsorship/8165765/webrev.01/ -Ujwal On 11/23/2016 10:10 PM, Roger Riggs wrote: Hi, RMIConnectionIdTest.java: - The method NetworkInterface.getByInetAddress(addr) may be a better choice

Re: RFR: JDK-8165765: javax/management/remote/mandatory/connection/RMIConnectionIdTest.java: failed when looking at RMI connection IDs:

erent from which it is picking by default to String clientAddr and executed the test . Thanks, Ujwal On 11/29/2016 3:12 AM, Roger Riggs wrote: Hi Ujwal, looks fine. Have you been able to verify the test on a system similar to where it failed originally? Thanks, Roger On 11/27/2016

Re: RFR : JDK-8167337 - When jmxremote.port=0, JDP broadcasts "0" instead of assigned port

Hi Harsha, On 1/16/2017 1:21 AM, Harsha Wardhana B wrote: Hi Amit, In JdpJmxRemoteDynamicPortTestCase:48 needs null/empty check for jmx url. JdpJmxRemoteDynamicPortTestCase:49, array length needs to checked before accessing index at token[6]. It is possible that port number need not always

Re: RFR : JDK-8167337 - When jmxremote.port=0, JDP broadcasts "0" instead of assigned port

Your approach is more elegant. However checking for ":0/" may not work as we can have non-zero port number that can end in 0. Regards Harsha On Tuesday 17 January 2017 09:39 PM, Roger Riggs wrote: Hi Harsha, On 1/16/2017 1:21 AM, Harsha Wardhana B wrote: Hi Amit, In JdpJmxRemot

Re: RFR : JDK-8167337 - When jmxremote.port=0, JDP broadcasts "0" instead of assigned port

- From: Amit Sapre Sent: Wednesday, January 18, 2017 2:09 PM To: Roger Riggs; serviceability-dev@openjdk.java.net; Harsha Wardhana B Subject: RE: RFR : JDK-8167337 - When jmxremote.port=0, JDP broadcasts "0" instead of assigned port Hello, Looks like basic check on Jdp packet includ

Re: RFE Review : JDK-5016517 - Replace plaintext passwords by hashed passwords for out-of-the-box JMX Agent

Hi Harsha, Thanks for this important improvement. Comments: * jmxremote.password.template: "Passwords will be hashed by server if they are in clear." Perhaps should be more explicit: "The jmxremote.passwords file will be re-written by the server to replace all plain text passwords with

Re: RFR: JDK-8173180 VirtualMachine.startLocalManagementAgent() returns URI with unreliable IP address

Hi, I would expect to see a mix of versions in many operational cases. For example, in a large deployment there will be a mix of versions active and the folks monitoring it should not have to change their management tools unnecessarily. The usual rule for interoperability between versions is

Re: RFR : 8182485 - JMX connections should have configurable ObjectInputFilter

+1 Roger On 6/20/2017 1:24 PM, Daniel Fuchs wrote: The fix looks good to me Harsha. best regards, -- daniel On 20/06/2017 07:10, Harsha Wardhana B wrote: Hi, Please review the below RFE, JDK-8182485 : JMX connections should have configurable ObjectInputFilter having webrev at http://cr

Re: Proposal:JdpController.getProcessId() VM compatibility improvement

; } Andrew Leonard Java Runtimes Development IBM Hursley IBM United Kingdom Ltd Phone internal: 245913, external: 01962 815913 internet email: andrew_m_leon...@uk.ibm.com From: Roger Riggs To: Andrew Leonard Cc: core-libs-...@openjdk.java.net Date: 23

Re: RFR: JDK-8181895 javax management docs contain links to technotes

Hi Ujwal, As Alan noted earlier, it would be helpful in the package javadoc of javax.management.remote.rmi if there was some mention of the class or package within the javadoc that supported the mentioned dynamic classloading. As is, the feature is mentioned but with no suggestion about where

Re: RFR: JDK-8181895 javax management docs contain links to technotes

Hi Ujwal, The updated links look fine. Thanks, Roger On 7/24/2017 1:48 PM, Ujwal Vangapally wrote: Thanks for the review Roger. please see the webrev incorporating review comments. http://cr.openjdk.java.net/~uvangapally/webrev/2017/8181895/webrev.01/ -Ujwal. On 7/20/2017 2:16 AM, Roger

Re: RFR: JDK-8185003 JMX: Add a version of ThreadMXBean.dumpAllThreads with a maxDepth argument

Hi Ujwal, (Reviewer, but not specifically servicability). Comments, java/lang/management/ThreadMXBean.java: 809: It may be useful to state that the behavior is the same as {@link #dumpAllThreads} except that the depth is limited. 828: Do not duplicate specification of the meaning of maxDep

Re: RFR: JDK-8185003 JMX: Add a version of ThreadMXBean.dumpAllThreads with a maxDepth argument

Hi Ujwal, On 8/3/2017 12:44 PM, Ujwal Vangapally wrote: Thanks for the review Roger, please see my comments inline. On 8/3/2017 8:23 PM, Roger Riggs wrote: Hi Ujwal, (Reviewer, but not specifically servicability). Comments, java/lang/management/ThreadMXBean.java: 809: It may be useful

Re: RFE Review : JDK-5016517 - Replace plaintext passwords by hashed passwords for out-of-the-box JMX Agent

Thanks for the detailed review. Below is the webrev addressing all the review comments. http://cr.openjdk.java.net/~hb/5016517/webrev.01/ -Harsha On Tuesday 25 April 2017 10:56 PM, Roger Riggs wrote: Hi Harsha, Thanks for this important improvement. Comments: * jmxremote.password.templa

Re: RFR : JDK-8044122 MBean access to the PID

Hi Ujwal, In the implementation RuntimeMXBean.java: 72:  Include a message "getProcessId" in the throw new Unsupported... In the text and @return change "PID" to "process ID" as Alan suggested. 66: the @implSpec should be on its own line so the text starts on a new line to make the source more

Re: RFE Review : JDK-5016517 - Replace plaintext passwords by hashed passwords for out-of-the-box JMX Agent

ted by you. http://cr.openjdk.java.net/~hb/5016517/webrev.02/ -Harsha On Wednesday 04 October 2017 12:54 AM, Roger Riggs wrote: Hi Harsha, FileLoginModule.java:  104:  Add a period at the end of the the sentence. JMXPluggableAuthenticator.java: line 306:  Is the difference between

Re: RFR : JDK-8044122 MBean access to the PID

/webrev/2017/8044122/webrev.01/ Thanks, Ujwal. On 10/11/2017 3:50 PM, Ujwal Vangapally wrote: Thanks for the review and suggestions Mandy, Roger. kindly see my comments inline. On 10/10/2017 11:25 PM, Roger Riggs wrote: Hi Ujwal, In the implementation RuntimeMXBean.java: 72:  Include a

Re: RFR : JDK-8044122 MBean access to the PID

) Gruss Bernd -- http://bernd.eckenfels.net *From:* serviceability-dev on behalf of mandy chung *Sent:* Friday, October 20, 2017 4:42:00 PM *To:* Ujwal Vangapally; Roger Riggs *Cc:* serviceability-dev *Subject:* Re: RFR

Re: RFR : JDK-8044122 MBean access to the PID

://cr.openjdk.java.net/~uvangapally/webrev/2017/8044122/webrev.03/ Thanks, Ujwal. On 10/26/2017 6:54 PM, Roger Riggs wrote: Hi Ujwal, In RuntimeMXBean: Please add @throws UnsupportedOperationException if the process id is not available Otherwise, looks fine. Thanks, Roger On 10/26/2017 4:29 AM

Re: RFE Review : JDK-5016517 - Replace plaintext passwords by hashed passwords for out-of-the-box JMX Agent

Hi Harsha, Sorry for the late editorial recommendations: In jmxremote.password.template: 41: "Clear text" -> "A clear text" 43: 'below format" -> "format below" 53: "in clear" -> "in the clear" 63: "in clear" -> "in the clear" 77: "by ONLY the owner" -> "ONLY by the owner" 80-81: Is not consist

Re: RFR : JDK-8024352 - MBeanOperationInfo accepts any int value as "impact"

Hi Ujwal, MBeanOperationInfo:163: Since the values are fixed, you could more concisely just compare impact >=0 and impact <= UNKNOWN. 257/263:  I don't see a reason to change the toString in the default case for getImpact(). A suggestion would be to introduce an Enum for the action values

Re: RFR : JDK-8024352 - MBeanOperationInfo accepts any int value as "impact"

+1 Looks good, Thanks, Roger On 11/9/17 6:34 AM, Daniel Fuchs wrote: On 09/11/2017 10:40, Ujwal Vangapally wrote: Thanks for the Review Daniel, made changes as suggested. webrev : http://cr.openjdk.java.net/~uvangapally/webrev/2017/8024352/webrev.03/ Looks good to me. -- daniel Ujwal

Re: RFR : JDK-8024352 - MBeanOperationInfo accepts any int value as "impact"

+1 On 11/15/2017 10:09 AM, Daniel Fuchs wrote: Hi Ujwal, Still looks good to me. best regards, -- daniel On 15/11/2017 13:18, Ujwal Vangapally wrote: kindly review the updated webrev including changes to MBeanInfoHashCodeNPETest.java webrev : http://cr.openjdk.java.net/~uvangapally/webre

Re: RFR : JDK-8191313 - deprecate RMIConnectorServer.CREDENTIAL_TYPES

Hi Ujwal, Looks fine. (There may be a bit of confusion because in the webrev it looks like the value is being added and deprecated. The field is present in JDK 9 and this is formalizing the intention to remove it after JDK 1). (I cleaned up the csr a bit to remove extraneous information in t

Re: RFR(XXS): 8182307 - Error during JRMP connection establishment

+1 On 12/7/2017 12:00 PM, Gerald Thornbrugh wrote: Hi Dan, Your fix looks good. Jerry Adding core-libs-dev@... since this is RMI code. Thanks Alan! Folks, this review spans three OpenJDK aliases so Thunderbird's reply-to-list feature won't get it right. This is one of the few times that rep

Re: RFR: JDK-8167253: com.sun.jdi invokeMethod has duplicated @throws for InvalidTypeException

Hi Gary, Looks fine, Roger On 1/22/2018 12:43 PM, Gary Adams wrote: Here's a small fix to remove a duplicate InvalidTypeException. The other reported locations appear to have already been fixed.    Issue: https://bugs.openjdk.java.net/browse/JDK-8167253    Webrev: http://cr.openjdk.java.net/

Re: RFR: 8041626: [Event Request] Shutdown reason

Hi Robin, It looks like the status argument to BeforeHalt is discarded in JVM_BeforeHalt and is not inserted into the event. That suggests it should be removed all the way back to Shutdown.beforeHalt. Roger On 2/13/2018 9:59 AM, Robin Westberg wrote: Hi Alan, On 12 Feb 2018, at 09:02, Al

Re: RFR: 8041626: [Event Request] Shutdown reason

On 13 Feb 2018, at 16:17, Roger Riggs <mailto:roger.ri...@oracle.com>> wrote: Hi Robin, It looks like the status argument to BeforeHalt is discarded in JVM_BeforeHalt and is not inserted into the event. That suggests it should be removed all the way back to Shutdown.beforeHalt. You a

Re: RFR: JDK-8187498: Add a -Xmanagement flag as syntactic sugar for -Dcom.sun.management.jmxremote.* properties

Hi, I'm a bit leary of command line arguments being special cased and the corresponding custom mappings to system properties.   The convenience is fine but we need to keep the handling out of native code so it is easier to maintain.  We don't have a Java API for processing (VM) command line a

RFR 8199467 Compilation Errors in libinstrument Reentrancy.c with VS2017

Please review a small change to avoid sign extension in libinstrument/ Reentrancy.c to correct an compilation warning with vs2017. diff --git a/src/java.instrument/share/native/libinstrument/Reentrancy.c b/src/java.instrument/share/native/libinstrument/Reentrancy.c --- a/src/java.instrument/sh

Re: RFR 8199467 Compilation Errors in libinstrument Reentrancy.c with VS2017

Hi Martin, Good recommendation; pushed. Thanks, Roger On 3/21/2018 3:31 PM, Martin Buchholz wrote: On Wed, Mar 21, 2018 at 12:13 PM, Roger Riggs <mailto:roger.ri...@oracle.com>> wrote: -    void *  test = (void *) 0x; +    void *  test = (void *) 0x9

hg: jdk8/tl/jdk: 8024458: DataInput.readDouble refers to "readlong" instead of "readLong"

Changeset: 04f071a95c29 Author:rriggs Date: 2013-11-07 20:56 -0500 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/04f071a95c29 8024458: DataInput.readDouble refers to "readlong" instead of "readLong" Summary: fix the typo Reviewed-by: lancea, chegar, dxu ! src/share/classes/java/i

hg: jdk8/tl/jdk: 8028041: Serialized Form description of j.l.String is not consistent with the implementation

Changeset: df2f7f288353 Author:rriggs Date: 2013-11-08 17:50 -0500 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/df2f7f288353 8028041: Serialized Form description of j.l.String is not consistent with the implementation Summary: Replaced incorrect description with reference to the

hg: jdk8/tl/jdk: 8028092: Lint cleanup of java.time.format

Changeset: 3add16c86970 Author:rriggs Date: 2013-11-09 14:30 -0500 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/3add16c86970 8028092: Lint cleanup of java.time.format Summary: correct declarations and add @SuppressWarnings Reviewed-by: darcy, lancea ! src/share/classes/java/time

hg: jdk8/tl/jdk: 8028014: Doclint warning/error cleanup in javax.management

Changeset: ebe27e1a2e2d Author:rriggs Date: 2013-11-12 14:03 -0500 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/ebe27e1a2e2d 8028014: Doclint warning/error cleanup in javax.management Summary: Improve generated html by fixing doclint warnings Reviewed-by: sla, jbachorik ! src/sh

RFR 8028141 intermittent test failure of LocalManagementTest

Please review this fix to improve the reliability of the jmxRemote/LocalManagementTest and CustomLauncherTest. The solution may apply to other tests that fail with ClassNotFound. The tests did not include the jdk.testlibrary in the classpath when it spawns a new process. The failure mode is de

Re: RFR 8028141 intermittent test failure of LocalManagementTest

, but that's out of scope for the particular issue. Thanks, Roger On 11/18/2013 5:25 PM, Chris Hegarty wrote: On 18 Nov 2013, at 21:59, roger riggs wrote: Please review this fix to improve the reliability of the jmxRemote/LocalManagementTest and CustomLauncherTest. The solution may a

Re: RFR 8028141 intermittent test failure of LocalManagementTest

ools utils) because it is the frequent pattern. On 19.11.2013 1:59, roger riggs wrote: Please review this fix to improve the reliability of the jmxRemote/LocalManagementTest and CustomLauncherTest. The solution may apply to other tests that fail with ClassNotFound. The tests did not i

hg: jdk8/tl/jdk: 8028141: test/sun/management/jmxremote/bootstrap/LocalManagementTest|CustomLauncherTest.java failing again

Changeset: 3f47e393e1dd Author:rriggs Date: 2013-11-19 13:20 -0500 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/3f47e393e1dd 8028141: test/sun/management/jmxremote/bootstrap/LocalManagementTest|CustomLauncherTest.java failing again Summary: Correct to use the test.class.path in

Re: Review request for 7195249: Some jtreg tests use hard coded ports

Hi, fyi, The jdk.testlibrary.Utils.getFreePort() method will Open an free Socket, close it and return the port number. And as Alan recommended, use (0) when possible to have the system assign the port #. Roger On 11/20/2013 8:04 AM, Dmitry Samersoff wrote: Taras, *The only* correct way

hg: jdk8/tl/jdk: 8028019: AWT Doclint warning/error cleanup

Changeset: 3e95aadb479f Author:rriggs Date: 2013-12-03 16:20 -0500 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/3e95aadb479f 8028019: AWT Doclint warning/error cleanup Summary: Fix numerious javadoc and html errors and warnings Reviewed-by: yan ! src/share/classes/java/applet/Ap

hg: jdk8/tl/jdk: 8029551: Add value-type notice to java.time classes

Changeset: fe3383582427 Author:rriggs Date: 2013-12-11 16:52 -0500 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/fe3383582427 8029551: Add value-type notice to java.time classes Summary: Add warning about identity of value types and reference to ValueBased.html Reviewed-by: brian

hg: jdk8/tl/jdk: 2 new changesets

Changeset: 7186275e6ef1 Author:rriggs Date: 2013-12-20 13:06 -0500 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/7186275e6ef1 8030002: Enhance deserialization using readObject Reviewed-by: sherman, chegar, scolebourne ! src/share/classes/java/time/Duration.java ! src/share/classe

hg: jdk8/tl/jdk: 8031103: java.time.Duration has wrong Javadoc Comments in toDays() and toHours()

Changeset: 1b503dd54b95 Author:rriggs Date: 2014-01-07 11:50 -0500 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/1b503dd54b95 8031103: java.time.Duration has wrong Javadoc Comments in toDays() and toHours() Summary: Correct specification for Duration.toDays, toHours Reviewed-by: l

Re: RFR 9: 8035889: jdk testlibrary - add printing of values of failed assertions

framework. It would be necessary to compile/run against TestNG.jar but it might not need the entire mechanism. Thanks, Roger On 2/26/2014 10:17 PM, Mandy Chung wrote: On 2/26/2014 7:09 PM, Roger Riggs wrote: Hi Mandy, Yes, it might be more productive to switch the tests to TestNG. But it did

RFR 80044461: Cleanup new Boolean and single character strings

A quick sanity check please for these cleanup changes to remove uses of new Boolean and using chars instead of single character strings contributed by Otávio Gonçalves de Santana. These changes update multiple classes in the jdk9-dev repo (except client packages). webrev: http://cr.openjdk.ja

  1   2   >