On Fri, 16 Apr 2021 01:08:57 GMT, Vicente Romero wrote:
> Please review this PR that intents to make sealed classes a final feature in
> Java. This PR contains compiler and VM changes. In line with similar PRs,
> which has made preview features final, this one is mostly removin
ases. Please also review the
> related [CSR](https://bugs.openjdk.java.net/browse/JDK-8265090)
>
> Thanks
>
> note: this PR is related to
> [PR-3528](https://github.com/openjdk/jdk/pull/3528) and must be integrated
> after it.
Vicente Romero has updated the pull reques
ases. Please also review the
> related [CSR](https://bugs.openjdk.java.net/browse/JDK-8265090)
>
> Thanks
>
> note: this PR is related to
> [PR-3528](https://github.com/openjdk/jdk/pull/3528) and must be integrated
> after it.
Vicente Romero has updated the pull reques
ases. Please also review the
> related [CSR](https://bugs.openjdk.java.net/browse/JDK-8265090)
>
> Thanks
>
> note: this PR is related to
> [PR-3528](https://github.com/openjdk/jdk/pull/3528) and must be integrated
> after it.
Vicente Romero has updated the pull request
ases. Please also review the
> related [CSR](https://bugs.openjdk.java.net/browse/JDK-8265090)
>
> Thanks
>
> note: this PR is related to
> [PR-3528](https://github.com/openjdk/jdk/pull/3528) and must be integrated
> after it.
Vicente Romero has updated the pull reques
ases. Please also review the
> related [CSR](https://bugs.openjdk.java.net/browse/JDK-8265090)
>
> Thanks
>
> note: this PR is related to
> [PR-3528](https://github.com/openjdk/jdk/pull/3528) and must be integrated
> after it.
Vicente Romero has updated the pull reques
On Wed, 21 Apr 2021 14:42:39 GMT, Maurizio Cimadamore
wrote:
> Compiler changes look good (I have not checked SymbolGenerator).
>
> Why were some tests removed?
thanks for the review. The removed tests were already covered in langtools
regression tests, so I only removed duplicated tests
---
ases. Please also review the
> related [CSR](https://bugs.openjdk.java.net/browse/JDK-8265090)
>
> Thanks
>
> note: this PR is related to
> [PR-3528](https://github.com/openjdk/jdk/pull/3528) and must be integrated
> after it.
Vicente Romero has updated the pull request
On Fri, 16 Apr 2021 02:10:05 GMT, David Holmes wrote:
> Hi Vicente,
>
> Hotspot and hotspot tests all look fine. One query: why was this test removed?
>
> test/hotspot/jtreg/runtime/sealedClasses/AbstractSealedTest.java
>
> is that functionality tested elsewhere? (The other deleted test seemed
ases. Please also review the
> related [CSR](https://bugs.openjdk.java.net/browse/JDK-8265090)
>
> Thanks
>
> note: this PR is related to
> [PR-3528](https://github.com/openjdk/jdk/pull/3528) and must be integrated
> after it.
Vicente Romero has updated the pull request
Please review this PR that intents to make sealed classes a final feature in
Java. This PR contains compiler and VM changes. In line with similar PRs, which
has made preview features final, this one is mostly removing preview related
comments from APIs plus options in test cases.
Thanks
--
On Thu, 22 Oct 2020 01:24:20 GMT, Yasumasa Suenaga wrote:
>>>
>>> Because it seems that for the short jobs, we would like to just do "perf
>>> record java -XX:+WhatEver", followed by "perf report", without requiring
>>> user to invoke the diagnostic command while JVM is still running?
>>
>> Y
On Mon, 21 Sep 2020 21:30:51 GMT, Vicente Romero wrote:
> 8246774: implement Record Classes as a standard feature in Java
This pull request has now been integrated.
Changeset: c17d5851
Author: Vicente Romero
URL: https://git.openjdk.java.net/jdk/commit/c17d5851
Stats: 856 li
> 8246774: implement Record Classes as a standard feature in Java
Vicente Romero has updated the pull request incrementally with one additional
commit since the last revision:
removing reference to unused jcod file from test
-
Changes:
- all: https://git.openjdk.java.net/
> 8246774: implement Record Classes as a standard feature in Java
Vicente Romero has updated the pull request with a new target base due to a
merge or a rebase. The pull request now
contains 10 commits:
- Merge branch 'master' into JDK-8246774
- Merge branch 'master
> 8246774: implementing Record Classes as a standard feature in Java
Vicente Romero has updated the pull request with a new target base due to a
merge or a rebase. The pull request now
contains ten commits:
- Merge branch 'master' into JDK-8246774
- removing unused jcod f
> 8246774: implementing Record Classes as a standard feature in Java
Vicente Romero has updated the pull request incrementally with one additional
commit since the last revision:
removing unused jcod file
-
Changes:
- all: https://git.openjdk.java.net/jdk/pull/290/fi
On Wed, 30 Sep 2020 08:54:14 GMT, Chris Hegarty wrote:
>> test/langtools/tools/javac/records/LocalStaticDeclarations.java line 33:
>>
>>> 31: * jdk.compiler/com.sun.tools.javac.util
>>> 32: * @build combo.ComboTestHelper
>>> 33: * @compile LocalStaticDeclarations.java
>>
>> This, an
> Co-authored-by: Vicente Romero
> Co-authored-by: Harold Seigel
> Co-authored-by: Jonathan Gibbons
> Co-authored-by: Brian Goetz
> Co-authored-by: Maurizio Cimadamore
> Co-authored-by: Joe Darcy
> Co-authored-by: Chris Hegarty
> Co-authored-by: Jan Lahoda
Vicent
On Wed, 30 Sep 2020 08:54:14 GMT, Chris Hegarty wrote:
>> test/langtools/tools/javac/records/LocalStaticDeclarations.java line 33:
>>
>>> 31: * jdk.compiler/com.sun.tools.javac.util
>>> 32: * @build combo.ComboTestHelper
>>> 33: * @compile LocalStaticDeclarations.java
>>
>> This, an
On Wed, 30 Sep 2020 00:18:17 GMT, Vicente Romero wrote:
>> The instrument tests update looks good to me.
>
> @sspitsyn thanks for the review. Please add yourself as a reviewer
@plevart interesting, but I think that I prefer to update those benchmarks in a
follow-up patch in order
On Wed, 30 Sep 2020 00:06:19 GMT, Serguei Spitsyn wrote:
>> Marked as reviewed by jlahoda (Reviewer).
>
> The instrument tests update looks good to me.
@sspitsyn thanks for the review. Please add yourself as a reviewer
-
PR: https://git.openjdk.java.net/jdk/pull/290
> Co-authored-by: Vicente Romero
> Co-authored-by: Harold Seigel
> Co-authored-by: Jonathan Gibbons
> Co-authored-by: Brian Goetz
> Co-authored-by: Maurizio Cimadamore
> Co-authored-by: Joe Darcy
> Co-authored-by: Chris Hegarty
> Co-authored-by: Jan Lahoda
Vicente
> Co-authored-by: Vicente Romero
> Co-authored-by: Harold Seigel
> Co-authored-by: Jonathan Gibbons
> Co-authored-by: Brian Goetz
> Co-authored-by: Maurizio Cimadamore
> Co-authored-by: Joe Darcy
> Co-authored-by: Chris Hegarty
> Co-authored-by: Jan Lahoda
Vicent
On Thu, 24 Sep 2020 15:45:22 GMT, Vicente Romero wrote:
>> The classfile parser changes look good to me.
>
> I have modified the `@since`: 14 -> 16
[CSR: Record Classes](https://bugs.openjdk.java.net/browse/JDK-8253605)
-
PR: https://git.openjdk.java.net/jdk/pull/290
> Co-authored-by: Vicente Romero
> Co-authored-by: Harold Seigel
> Co-authored-by: Jonathan Gibbons
> Co-authored-by: Brian Goetz
> Co-authored-by: Maurizio Cimadamore
> Co-authored-by: Joe Darcy
> Co-authored-by: Chris Hegarty
> Co-authored-by: Jan Lahoda
Vicent
> Co-authored-by: Vicente Romero
> Co-authored-by: Harold Seigel
> Co-authored-by: Jonathan Gibbons
> Co-authored-by: Brian Goetz
> Co-authored-by: Maurizio Cimadamore
> Co-authored-by: Joe Darcy
> Co-authored-by: Chris Hegarty
> Co-authored-by: Jan Lahoda
Vicent
> Co-authored-by: Vicente Romero
> Co-authored-by: Harold Seigel
> Co-authored-by: Jonathan Gibbons
> Co-authored-by: Brian Goetz
> Co-authored-by: Maurizio Cimadamore
> Co-authored-by: Joe Darcy
> Co-authored-by: Chris Hegarty
> Co-authored-by: Jan Lahoda
Vicent
On Thu, 24 Sep 2020 12:23:13 GMT, Coleen Phillimore wrote:
>> Vicente Romero has updated the pull request incrementally with three
>> additional commits since the last revision:
>>
>> - Merge pull request #1 from ChrisHegarty/record-serial-tests
>>
>>
> Co-authored-by: Vicente Romero
> Co-authored-by: Harold Seigel
> Co-authored-by: Jonathan Gibbons
> Co-authored-by: Brian Goetz
> Co-authored-by: Maurizio Cimadamore
> Co-authored-by: Joe Darcy
> Co-authored-by: Chris Hegarty
> Co-authored-by: Jan Lahoda
Vicent
good catch Chris, thanks for the patch,
Vicente
On 9/22/20 5:51 AM, Chris Hegarty wrote:
On Mon, 21 Sep 2020 23:21:18 GMT, Vicente Romero wrote:
Hi Vicente,
Please file a separate subtask for the javax.lang.model changes. This helps
with the JSR 269 MR paperwork.
Thanks,
-Joe
note: I have
> Co-authored-by: Vicente Romero
> Co-authored-by: Harold Seigel
> Co-authored-by: Jonathan Gibbons
> Co-authored-by: Brian Goetz
> Co-authored-by: Maurizio Cimadamore
> Co-authored-by: Joe Darcy
> Co-authored-by: Chris Hegarty
> Co-authored-by: Jan Lahoda
Vicent
On Mon, 21 Sep 2020 21:53:05 GMT, Joe Darcy wrote:
>> Please review the fix for [1]. The intention of this patch is to make
>> records final removing the need to
>> use --enable-preview in order to be able to include a record declaration in
>> a source or for the VM to execute code
>> compiled
Co-authored-by: Vicente Romero
Co-authored-by: Harold Seigel
Co-authored-by: Jonathan Gibbons
Co-authored-by: Brian Goetz
Co-authored-by: Maurizio Cimadamore
Co-authored-by: Joe Darcy
Co-authored-by: Chris Hegarty
Co-authored-by: Jan Lahoda
-
Commit messages:
- 8246774
On Mon, 21 Sep 2020 21:30:51 GMT, Vicente Romero wrote:
> Co-authored-by: Vicente Romero
> Co-authored-by: Harold Seigel
> Co-authored-by: Jonathan Gibbons
> Co-authored-by: Brian Goetz
> Co-authored-by: Maurizio Cimadamore
> Co-authored-by: Joe Darcy
> Co-authored-by
Hi David,
src/java.base/share/classes/java/lang/Class.java
There needs to be a CSR request for these changes.
yes there is one already: https://bugs.openjdk.java.net/browse/JDK-8244556
+ * Returns an array containing {@code ClassDesc} objects
representing all the
+ * permitted su
d. Any help would be appreciated.
thanks
Mandy
Vicente
On 3/27/20 2:15 PM, Vicente Romero wrote:
Hi Mandy,
The patch for nestmates [1] could be used as a reference. There a new
method was added to class `com.sun.tools.javac.jvm.Target`, named:
`hasNestmateAccess` which checks if a t
Hi Mandy,
The patch for nestmates [1] could be used as a reference. There a new
method was added to class `com.sun.tools.javac.jvm.Target`, named:
`hasNestmateAccess` which checks if a target is ready for nestmates or
not. I think that you can follow a similar approach here.
Thanks,
Vicente
Thanks David,
Vicente
On 10/22/19 7:01 PM, David Holmes wrote:
Hi Vicente,
I plan to look at this ASAP.
Cheers,
David
On 19/10/2019 4:44 am, Vicente Romero wrote:
Hi,
Please review the hotspot runtime and serviceability code for JEP 359
(Records).
Thanks in advance for the feedback
Hi Lois,
Thanks for the review,
Vicente
On 10/21/19 2:40 PM, Lois Foltan wrote:
On 10/18/2019 2:44 PM, Vicente Romero wrote:
Hi,
Please review the hotspot runtime and serviceability code for JEP 359
(Records).
Thanks in advance for the feedback,
Vicente
PS, Thanks to Harold for the
Hi,
Please review the hotspot runtime and serviceability code for JEP 359
(Records).
Thanks in advance for the feedback,
Vicente
PS, Thanks to Harold for the development
[1]
http://cr.openjdk.java.net/~vromero/records.review/hotspot_runtime/webrev.00/
Changeset: 8832b6048e65
Author:vromero
Date: 2013-12-13 14:13 +
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/8832b6048e65
8029721: javac crash for annotated parameter type of lambda in a field
Reviewed-by: rfield, jfranck
! src/share/classes/com/sun/tools/javac/comp/At
Changeset: 5bf0af735c61
Author:vromero
Date: 2013-12-09 19:29 +
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/5bf0af735c61
8029569: internal javac cast exception when resolving varargs ambiguity
Reviewed-by: jjg
! src/share/classes/com/sun/tools/javac/comp/Resolve.java
Changeset: fb8c59cf26c8
Author:vromero
Date: 2013-12-03 18:13 +
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/fb8c59cf26c8
8029179: javac produces a compile error for valid boolean expressions
Reviewed-by: jjg, jlahoda
! src/share/classes/com/sun/tools/javac/parser/Java
Changeset: 66bcd5d4b3d1
Author:vromero
Date: 2013-11-19 23:35 +
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/66bcd5d4b3d1
8028504: javac generates LocalVariableTable even with -g:none
Reviewed-by: jjg, jlahoda
! src/share/classes/com/sun/tools/javac/jvm/ClassWriter.jav
Changeset: d4cbb671de1c
Author:vromero
Date: 2013-11-15 11:08 +
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/d4cbb671de1c
8026231: Look at 'static' flag when checking method references
Reviewed-by: jjg, dlsmith
! src/share/classes/com/sun/tools/javac/code/Kinds.java
!
Changeset: e79d6425f1c4
Author:vromero
Date: 2013-11-14 19:28 +
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/e79d6425f1c4
8026963: type annotations code crashes for code with erroneous trees
Reviewed-by: jjg, jlahoda
! src/share/classes/com/sun/tools/javac/comp/Attr.ja
Changeset: cc80c03c41e4
Author:vromero
Date: 2013-11-01 19:08 +
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/cc80c03c41e4
8027660: javac crash while creating LVT entry for a local variable defined in
an inner block
Reviewed-by: jjg
Contributed-by: vicente.rom...@oracle
Changeset: 537fa895fd74
Author:vromero
Date: 2013-10-30 18:09 +
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/537fa895fd74
8027327: jar files related to test test/tools/javac/ExtDirs/ExtDirTest.java
should be removed from the repo
Reviewed-by: ksrini
! test/tools/javac
Changeset: 963c57175e40
Author:vromero
Date: 2013-10-22 13:54 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/963c57175e40
8025290: javac implicit versus explicit lambda compilation error
Reviewed-by: jjg, dlsmith
! src/share/classes/com/sun/tools/javac/comp/Attr.java
!
Changeset: 9f876bd43f55
Author:vromero
Date: 2013-10-21 15:55 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/9f876bd43f55
8026956: test tools/javac/lambda/TargetType58.java is failing after a libs
change
Reviewed-by: jfranck
! test/tools/javac/lambda/TargetType58.java
Changeset: c4292590fc70
Author:vromero
Date: 2013-10-19 17:43 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/c4292590fc70
8024809: javac, some lambda programs are rejected by flow analysis
Reviewed-by: jjg, dlsmith
! src/share/classes/com/sun/tools/javac/comp/Attr.java
Changeset: fbb7510f788d
Author:vromero
Date: 2013-10-19 17:53 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/fbb7510f788d
8026854: java.time.temporal.TemporalQueries doesn't compile after javac
modification to lambda flow analysis
Reviewed-by: psandoz
! src/share/classes/ja
Changeset: d8d6b58f1ebf
Author:vromero
Date: 2013-10-15 21:02 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/d8d6b58f1ebf
8024947: javac should issue the potentially ambiguous overload warning only
where the problem appears
Reviewed-by: jjg
! src/share/classes/com/sun
Changeset: 70a301b35e71
Author:vromero
Date: 2013-10-15 19:36 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/70a301b35e71
8025816: javac crash with method reference with a type variable as the site
Reviewed-by: jjg
! src/share/classes/com/sun/tools/javac/comp/Resolve.j
Changeset: 1e6088da1740
Author:vromero
Date: 2013-10-02 17:04 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/1e6088da1740
8023679: Improve error message for '_' used as a lambda parameter name
Reviewed-by: jjg, dlsmith
! src/share/classes/com/sun/tools/javac/parser/Jav
Changeset: 16194509e483
Author:vromero
Date: 2013-09-27 10:24 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/16194509e483
8024497: crash returning this-referencing lambda from default method
Reviewed-by: jjg, rfield
! src/share/classes/com/sun/tools/javac/code/Symbol.j
Changeset: 13eba2e322e6
Author:vromero
Date: 2013-09-26 19:06 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/13eba2e322e6
8025139: javac patch for using bootstrap compiler for debugging is not working
properly
Reviewed-by: jjg
! make/netbeans/langtools/build.xml
! mak
Changeset: 571f8ebc2d51
Author:vromero
Date: 2013-09-22 12:53 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/571f8ebc2d51
8024696: Missing null check in bound method reference capture
Reviewed-by: jjg, briangoetz
! src/share/classes/com/sun/tools/javac/comp/LambdaToMet
Changeset: 2375ce96e80d
Author:vromero
Date: 2013-09-19 20:57 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/2375ce96e80d
8024437: Inferring the exception thrown: sometimes fails to compile
Reviewed-by: jjg
! src/share/classes/com/sun/tools/javac/code/Flags.java
! src/
Changeset: 4ce8148ffc4f
Author:jlahoda
Date: 2013-09-16 14:13 +0200
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/4ce8148ffc4f
8021112: Spurious unchecked warning reported by javac
6480588: No way to suppress deprecation warnings when implementing deprecated
interface
Summa
Changeset: 4932bb04c4b8
Author:vromero
Date: 2013-09-14 19:04 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/4932bb04c4b8
7047734: javac, the LVT is not generated correctly in several scenarios
Reviewed-by: jjg, mcimadamore
! src/share/classes/com/sun/tools/javac/code/
Changeset: 03c26c60499c
Author:vromero
Date: 2013-09-14 15:23 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/03c26c60499c
8024207: javac crash in Flow.AssignAnalyzer.visitIdent
Reviewed-by: jjg
! src/share/classes/com/sun/tools/javac/comp/Resolve.java
+ test/tools/java
Changeset: 3ae1814f7c59
Author:vromero
Date: 2013-09-12 22:40 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/3ae1814f7c59
8023558: Javac creates invalid bootstrap methods for complex lambda/methodref
case
Reviewed-by: jjg
Contributed-by: maurizio.cimadam...@oracle.com,
Changeset: d87f017ec217
Author:mcimadamore
Date: 2013-09-10 16:47 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/d87f017ec217
8024414: javac, should facilitate the use of the bootstrap compiler for
debugging
Reviewed-by: jjg
! make/netbeans/langtools/build.xml
! make/
Changeset: a4b9a8859e58
Author:vromero
Date: 2013-09-09 16:32 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/a4b9a8859e58
8024154: Fix for 8016177: structural most specific and stuckness breaks 6
langtools tests
Reviewed-by: jjg, jfranck
! test/tools/javac/lambda/Meth
Changeset: 2de3750d65a5
Author:vromero
Date: 2013-09-08 11:54 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/2de3750d65a5
8024398: javac, compiler crashes with try with empty body
Reviewed-by: jjg
! src/share/classes/com/sun/tools/javac/comp/Lower.java
+ test/tools/jav
Changeset: 7c7b4aea6d50
Author:vromero
Date: 2013-09-06 09:53 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/7c7b4aea6d50
8024039: javac, previous solution for JDK-8022186 was incorrect
Reviewed-by: jjg
! src/share/classes/com/sun/tools/javac/comp/Lower.java
! src/shar
Changeset: b94824ddcbb6
Author:vromero
Date: 2013-09-04 11:53 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/b94824ddcbb6
8008275: javac.Main should be @Supported
Reviewed-by: jjg
! src/share/classes/com/sun/tools/javac/Main.java
Changeset: 9be0afbdf244
Author:vromero
Date: 2013-09-03 23:41 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/9be0afbdf244
8023545: Misleading error message when using diamond operator with private
constructor
Reviewed-by: jjg
! src/share/classes/com/sun/tools/javac/co
Changeset: fb5a846c4a49
Author:vromero
Date: 2013-09-03 23:31 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/fb5a846c4a49
8023389: Javac fails to infer type for lambda used with intersection type and
wildcards
Reviewed-by: jjg, vromero
Contributed-by: maurizio.cimadam.
Changeset: 438547d895dc
Author:vromero
Date: 2013-09-04 00:01 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/438547d895dc
8023549: Compiler emitting spurious errors when constructor reference type is
inferred and explicit type arguments are supplied
Reviewed-by: jjg, v
Changeset: 4a6acc42c3a1
Author:vromero
Date: 2013-09-02 22:38 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/4a6acc42c3a1
8016177: structural most specific and stuckness
Reviewed-by: jjg, vromero
Contributed-by: maurizio.cimadam...@oracle.com
! src/share/classes/com/su
Changeset: 2bf4c132bf90
Author:vromero
Date: 2013-09-02 22:44 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/2bf4c132bf90
8022162: Incorrect signature determination for certain inner class generics
Reviewed-by: jjg
! src/share/classes/com/sun/tools/javac/jvm/ClassReade
Changeset: 25aaff78d754
Author:vromero
Date: 2013-08-22 13:12 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/25aaff78d754
8023112: javac should not use lazy constant evaluation approach for method
references
Reviewed-by: jjg, mcimadamore
! src/share/classes/com/sun/to
Changeset: 7a4717f3ea7b
Author:vromero
Date: 2013-08-22 10:22 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/7a4717f3ea7b
8022316: Generic throws, overriding and method reference
Reviewed-by: jjg, mcimadamore
! src/share/classes/com/sun/tools/javac/code/Types.java
+ te
Changeset: a6378c19836b
Author:vromero
Date: 2013-08-16 10:32 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/a6378c19836b
8022053: javac generates unverifiable initializer for nested subclass of local
class
Reviewed-by: jjg, mcimadamore
! src/share/classes/com/sun/too
Changeset: 0ad781399706
Author:vromero
Date: 2013-08-14 10:53 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/0ad781399706
8013394: compile of iterator use fails with error \"defined in an inaccessible
class or interface\"
Reviewed-by: mcimadamore
! src/share/classes/c
Changeset: 70c8f4a4b8d6
Author:vromero
Date: 2013-08-12 17:40 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/70c8f4a4b8d6
8015780: java/lang/reflect/Method/GenericStringTest.java failing
Reviewed-by: darcy, jfranck
! test/ProblemList.txt
! test/java/lang/reflect/Method/Gener
Changeset: aa6c6f8b5622
Author:vromero
Date: 2013-08-10 16:29 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/aa6c6f8b5622
6983297: methods missing from NewArrayTree
Reviewed-by: jjg
! src/share/classes/com/sun/source/tree/NewArrayTree.java
! src/share/classes/com/sun/s
Changeset: 8f282dc58dfc
Author:vromero
Date: 2013-08-10 16:26 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/8f282dc58dfc
8022622: javac, two tests are failing with compile time error after class
Collector was modified
Reviewed-by: mcimadamore
! test/tools/javac/lambd
Changeset: 0d9bc764cac7
Author:vromero
Date: 2013-08-10 13:27 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/0d9bc764cac7
8009640: -profile does not work when -bootclasspath specified
Reviewed-by: jjg
! src/share/classes/com/sun/tools/javac/main/Main.java
! src/share/
Changeset: b8610a65fbf9
Author:vromero
Date: 2013-08-08 11:49 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/b8610a65fbf9
8019486: javac, generates erroneous LVT for a test case with lambda code
Reviewed-by: mcimadamore
! src/share/classes/com/sun/tools/javac/comp/Lamb
Changeset: c7dcf899
Author:vromero
Date: 2013-08-07 11:04 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/c7dcf899
8008274: javac should not reference/use sample code
Reviewed-by: jjg
! src/share/classes/com/sun/tools/javac/Main.java
Changeset: f3deeccbf4cf
Author:vromero
Date: 2013-08-07 10:41 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/f3deeccbf4cf
8020997: TreeMaker.AnnotationBuilder creates broken element literals with
repeating annotations
Reviewed-by: jjg, jfranck
! src/share/classes/com/
Changeset: 99b60bcf3862
Author:vromero
Date: 2013-08-06 15:08 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/99b60bcf3862
8022186: javac generates dead code if a try with an empty body has a finalizer
Reviewed-by: jjg
! src/share/classes/com/sun/tools/javac/jvm/Gen.jav
Changeset: 7696282873f6
Author:vromero
Date: 2013-07-31 10:52 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/7696282873f6
8013179: assertion failure in javac when compiling with -source 1.6 -target 1.6
Reviewed-by: jjg
! src/share/classes/com/sun/tools/javac/comp/Trans
Changeset: 79c3146e417b
Author:vromero
Date: 2013-07-04 10:41 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/79c3146e417b
6356530: -Xlint:serial does not flag abstract classes with concrete
methods/members
Reviewed-by: mcimadamore
! src/share/classes/com/sun/tools/jav
Changeset: d6158f8d7235
Author:vromero
Date: 2013-07-04 10:35 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/d6158f8d7235
8009924: some langtools tools do not accept -cp as an alias for -classpath
Reviewed-by: jjg
! src/share/classes/com/sun/tools/doclets/internal/tool
Changeset: 3b4f92a3797f
Author:vromero
Date: 2013-07-02 22:49 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/3b4f92a3797f
6326693: variable x might already have been assigned, when assignment is in
catch block
Reviewed-by: mcimadamore
! src/share/classes/com/sun/tools
Changeset: 27a2e8c78bd0
Author:vromero
Date: 2013-07-02 10:21 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/27a2e8c78bd0
8019397: javap does not show SourceDebugExtension properly
Reviewed-by: jjg
Contributed-by: dmytro_she...@hotmail.com
! src/share/classes/com/sun/t
Changeset: 891c5ecb8306
Author:vromero
Date: 2013-06-29 20:12 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/891c5ecb8306
6983646: javap should identify why a DefaultAttribute is being used
Reviewed-by: jjg
! src/share/classes/com/sun/tools/classfile/Attribute.java
! s
Changeset: bdd699d7378d
Author:vromero
Date: 2013-06-28 14:36 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/bdd699d7378d
8005552: c.s.t.javap.AttributeWriter.visitLocalVariableTable() uses incorrect
format string
Reviewed-by: mcimadamore
! src/share/classes/com/sun/t
Changeset: bb06c412d079
Author:vromero
Date: 2013-06-28 13:20 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/bb06c412d079
6473148: TreePath.iterator() should document the iteration order
Reviewed-by: mcimadamore
! src/share/classes/com/sun/source/util/TreePath.java
Changeset: d137ce373c4c
Author:vromero
Date: 2013-06-27 16:06 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/d137ce373c4c
7008643: inlined finally clauses confuse debuggers
Reviewed-by: jjg
! src/share/classes/com/sun/tools/javac/jvm/Gen.java
+ test/tools/javac/T700864
Changeset: e42c27026290
Author:vromero
Date: 2013-06-27 16:04 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/e42c27026290
8016099: Some @SuppressWarnings annotations ignored ( unchecked, rawtypes )
Reviewed-by: jjg
! src/share/classes/com/sun/tools/javac/comp/Attr.java
Changeset: 8e3d391c88c6
Author:vromero
Date: 2013-06-27 09:54 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/8e3d391c88c6
8017609: javac, ClassFile.read(Path) should be ClassFile.read(Path,
Attribute.Factory)
Reviewed-by: jjg
! src/share/classes/com/sun/tools/classfil
Changeset: a47e28759666
Author:vromero
Date: 2013-06-27 09:51 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/a47e28759666
7066788: javah again accepts -old option (ineffectively) which was removed in
1.5.
Reviewed-by: jjg
! src/share/classes/com/sun/tools/javah/JavahT
Changeset: 831467c4c6a7
Author:vromero
Date: 2013-06-25 16:12 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/831467c4c6a7
8017104: javac should have a class for primitive types that inherits from Type
Reviewed-by: jjg
! src/share/classes/com/sun/tools/javac/api/JavacTr
Changeset: 6debfa63a4a1
Author:vromero
Date: 2013-06-20 08:45 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/6debfa63a4a1
8016613: javac should avoid source 8 only analysis when compiling for source 7
Reviewed-by: jjg
Contributed-by: maurizio.cimadam...@oracle.com
! sr
1 - 100 of 142 matches
Mail list logo
