Hi Siba,
The change looks fine to me. I would like Serviceability review this
change as well.
Thanks,
Xuelei
On 6/28/2018 8:46 AM, Daniel Fuchs wrote:
[ccing serviceability-dev@openjdk.java.net]
Hi Siba,
This looks good to me - but I'm not a SSL expert.
It would be good to get someone fro
Looks fine to me.
Thanks,
Xuelei
> On Jun 26, 2018, at 2:20 AM, Amy Lu wrote:
>
> sun/management/jmxremote/bootstrap/RmiSslBootstrapTest.sh
> sun/management/jmxremote/bootstrap/RmiRegistrySslTest.java
>
> Above two tests have been failing on all platforms (JDK-8205653) since
> JDK-8196584.
>
> - security
>
http://cr.openjdk.java.net/~psandoz/jdk9/sb/JDK-8041679-buffer-to-builder-security/webrev/
Looks fine to me. Thanks for making this update.
Xuelei
On 5/12/2014 6:03 PM, Paul Sandoz wrote:
> Hi,
>
> This is a request for review of Otavio's patch replacing StringBuffer
> with Stri
Changeset: 8d35f0985dd7
Author:xuelei
Date: 2013-12-18 16:46 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/8d35f0985dd7
7093640: Enable client-side TLS 1.2 by default
Reviewed-by: weijun, mullan, wetmore
! src/share/classes/sun/security/ssl/ProtocolVersion.java
! src/share/
Changeset: 40d0ccd00f87
Author:xuelei
Date: 2013-11-14 16:08 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/40d0ccd00f87
8014266: regression test AsyncSSLSocketClose.java time out.
Reviewed-by: xuelei
Contributed-by: Rajan Halade
!
test/sun/security/ssl/com/sun/net/ssl/int
Changeset: 1158d504e39e
Author:xuelei
Date: 2013-11-13 01:14 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/1158d504e39e
8023147: Test DisabledShortRSAKeys.java intermittent failed
Reviewed-by: mullan
! test/sun/security/ssl/javax/net/ssl/TLSv12/DisabledShortRSAKeys.java
Changeset: fb202a8e83c9
Author:xuelei
Date: 2013-10-13 21:10 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/fb202a8e83c9
8026119: Regression test DHEKeySizing.java failing intermittently
Reviewed-by: weijun
!
test/sun/security/ssl/com/sun/net/ssl/internal/ssl/DHKeyExchange/
Changeset: 0d5f4f1782e8
Author:xuelei
Date: 2013-10-07 18:46 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/0d5f4f1782e8
6956398: make ephemeral DH key match the length of the certificate key
Reviewed-by: weijun
! src/share/classes/sun/security/ssl/ServerHandshaker.java
+
t
Changeset: 3fca37c636be
Author:xuelei
Date: 2013-10-01 20:25 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/3fca37c636be
8025123: SNI support in Kerberos cipher suites
Reviewed-by: weijun, xuelei
Contributed-by: Artem Smotrakov
! src/share/classes/sun/security/ssl/ClientHan
Changeset: c9083205e6eb
Author:xuelei
Date: 2013-09-10 21:31 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/c9083205e6eb
8024501: sun.security.mscapi.Key has no definition of serialVersionUID
Reviewed-by: weijun
! src/windows/classes/sun/security/mscapi/Key.java
Changeset: f80b8af9c218
Author:xuelei
Date: 2013-09-09 19:07 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/f80b8af9c218
802: Change to use othervm mode of tests in SSLEngineImpl
Reviewed-by: mullan
!
test/sun/security/ssl/com/sun/net/ssl/internal/ssl/SSLEngineImpl/Clos
Changeset: 0f47f9f622d9
Author:xuelei
Date: 2013-09-07 17:05 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/0f47f9f622d9
7188657: There should be a way to reorder the JSSE ciphers
Reviewed-by: weijun, wetmore
! src/share/classes/javax/net/ssl/SSLParameters.java
! src/share/c
Changeset: ead6babac5a9
Author:xuelei
Date: 2013-09-01 20:00 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/ead6babac5a9
8024068: sun/security/ssl/javax/net/ssl/ServerName/IllegalSNIName.java fails
Reviewed-by: weijun
! test/sun/security/ssl/javax/net/ssl/ServerName/IllegalS
Changeset: cdf68747b0fb
Author:xuelei
Date: 2013-08-29 18:58 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/cdf68747b0fb
8023881: IDN.USE_STD3_ASCII_RULES option is too strict to use Unicode in
IDN.toASCII
Reviewed-by: michaelm
! src/share/classes/java/net/IDN.java
+ test/j
Changeset: ec827a62070a
Author:xuelei
Date: 2013-08-21 19:44 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/ec827a62070a
808: Intermittent test failures in sun/security/ssl/javax/net/ssl/NewAPIs
Reviewed-by: weijun
! test/sun/security/ssl/javax/net/ssl/NewAPIs/SessionCac
Changeset: 21a25911f7f7
Author:xuelei
Date: 2013-08-19 18:49 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/21a25911f7f7
8023230: The impl of KerberosClientKeyExchange maybe not exist
Reviewed-by: weijun
! src/share/classes/sun/security/ssl/KerberosClientKeyExchange.java
Changeset: 096e7c665857
Author:xuelei
Date: 2013-08-19 17:42 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/096e7c665857
8020842: IDN do not throw IAE when hostname ends with a trailing dot
Reviewed-by: weijun, michaelm
! src/share/classes/java/net/IDN.java
+ test/java/net/I
Changeset: ea4f4164422e
Author:xuelei
Date: 2013-08-11 18:21 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/ea4f4164422e
8022487: DEREncodedKeyValue.supportedKeyTypes should be private
Reviewed-by: mullan
!
src/share/classes/com/sun/org/apache/xml/internal/security/keys/con
Changeset: 8c7cf4926157
Author:xuelei
Date: 2013-08-07 06:42 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/8c7cf4926157
8013809: deadlock in SSLSocketImpl between between write and close
Reviewed-by: wetmore
! src/share/classes/sun/security/ssl/SSLSocketImpl.java
Changeset: d6de149b9f20
Author:xuelei
Date: 2013-08-01 07:34 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/d6de149b9f20
7127524: P11TlsPrfGenerator has anonymous inner class with serialVersionUID
Reviewed-by: vinnie
! src/share/classes/sun/security/pkcs11/P11TlsPrfGenerator
Changeset: 613cc7beba64
Author:xuelei
Date: 2013-07-29 19:36 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/613cc7beba64
8021841: Remove SSLEngineDeadlock.java from problem list
Reviewed-by: wetmore
! test/ProblemList.txt
Changeset: 60d1994f63f7
Author:xuelei
Date: 2013-06-27 19:22 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/60d1994f63f7
8019359: To comment why not use no_renegotiation to reject client initiated
renegotiation
Reviewed-by: wetmore
! src/share/classes/sun/security/ssl/Serve
Changeset: 0822bcddbd4f
Author:xuelei
Date: 2013-06-26 06:32 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/0822bcddbd4f
8017049: rename property jdk.tls.rejectClientInitializedRenego
Reviewed-by: vinnie, wetmore, mullan
! src/share/classes/sun/security/ssl/Handshaker.java
!
Changeset: a44bd993ce93
Author:xuelei
Date: 2013-06-20 07:48 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/a44bd993ce93
8017157: catch more exception in test RejectClientRenego
Reviewed-by: vinnie
!
test/sun/security/ssl/com/sun/net/ssl/internal/ssl/SSLSocketImpl/RejectCli
Changeset: a76858faad59
Author:xuelei
Date: 2013-06-19 02:33 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/a76858faad59
7188658: Add possibility to disable client initiated renegotiation
Reviewed-by: weijun, wetmore
! src/share/classes/sun/security/ssl/Handshaker.java
! src
Changeset: 2d9da733014f
Author:xuelei
Date: 2013-06-18 18:50 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/2d9da733014f
8000456: Add programmatic deadlock detection in SSLEngineDeadlock
Reviewed-by: wetmore
!
test/sun/security/ssl/com/sun/net/ssl/internal/ssl/SSLEngineImpl
Changeset: 918d9ac17740
Author:ascarpino
Date: 2013-05-30 14:11 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/918d9ac17740
6750584: Cipher.wrap/unwrap methods should define UnsupportedOperationException
Reviewed-by: mullan
! src/share/classes/javax/crypto/Cipher.java
! src/
Changeset: 6cb09d3cd309
Author:valeriep
Date: 2013-05-29 20:54 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/6cb09d3cd309
8013069: javax.crypto tests fail with new PBE algorithm names
Summary: Shouldn't auto-generate default parameters for MAC objects.
Reviewed-by: vinnie
!
Changeset: 8402ef8fabde
Author:ascarpino
Date: 2013-05-30 22:19 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/8402ef8fabde
7160837: DigestOutputStream does not turn off digest calculation when "close()"
is called
Reviewed-by: mullan, xuelei
! src/share/classes/java/securit
Changeset: 6407106f1b1c
Author:xuelei
Date: 2013-05-30 22:02 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/6407106f1b1c
8014618: Need to strip leading zeros in TlsPremasterSecret of DHKeyAgreement
Reviewed-by: xuelei
Contributed-by: Pasi Eronen
! src/share/classes/com/sun/
Changeset: 46db0e633240
Author:xuelei
Date: 2013-05-13 06:05 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/46db0e633240
8005598: (reopened) Need to clone array of input/output parameters
Reviewed-by: weijun
! src/share/classes/com/sun/jndi/dns/DnsContext.java
! src/share/cl
Changeset: 76998d11a643
Author:xuelei
Date: 2013-05-13 05:41 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/76998d11a643
8005535: SSLSessionImpl should have protected finalize()
Reviewed-by: weijun, wetmore
! src/share/classes/sun/security/ssl/SSLSessionImpl.java
Changeset: 7bdb3e186497
Author:xuelei
Date: 2013-04-18 22:23 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/7bdb3e186497
8006935: Need to take care of long secret keys in HMAC/PRF compuation
Reviewed-by: valeriep
! src/share/classes/com/sun/crypto/provider/TlsPrfGenerator.ja
Changeset: def2e05299b7
Author:xuelei
Date: 2013-03-01 02:34 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/def2e05299b7
7030966: Support AEAD CipherSuites
Reviewed-by: weijun, wetmore, valeriep
! src/share/classes/com/sun/crypto/provider/TlsKeyMaterialGenerator.java
! src/s
Changeset: edb7e34a0531
Author:xuelei
Date: 2013-01-14 18:31 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/edb7e34a0531
8006265: Add test SSLEngineDeadlock.java to ProblemList
Reviewed-by: weijun
! test/ProblemList.txt
Changeset: 4472a641b4dc
Author:xuelei
Date: 2012-12-28 03:50 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/4472a641b4dc
8003265: Need to clone array of input/output parameters
Reviewed-by: mullan
! src/share/classes/com/sun/jndi/dns/DnsContext.java
! src/share/classes/com/s
Changeset: 645d774b683a
Author:xuelei
Date: 2012-12-28 00:48 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/645d774b683a
7109274: Restrict the use of certificates with RSA keys less than 1024 bits
Summary: This restriction is applied via the Java Security property,
"jdk.cert
Changeset: ead651efb271
Author:xuelei
Date: 2012-12-03 06:00 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/ead651efb271
8004184: security tests leave JSSEServer running
Summary: Use othervm mode to release resources, and correct the system
properties issues in JSSE
Reviewe
Changeset: 46c627801490
Author:xuelei
Date: 2012-11-28 05:18 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/46c627801490
8004019: Removes unused method HandshakeHash.setCertificateVerifyAlg()
Summary: certification verification in HandshakeHash was abandoned during TLS
1.2 i
Changeset: d30c13172254
Author:xuelei
Date: 2012-11-24 04:27 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/d30c13172254
8003951: Removes unused variables in sun.security.ssl
Reviewed-by: xuelei
Contributed-by: Florian Weimer
! src/share/classes/sun/security/ssl/HandshakeMe
Changeset: f7d45462b225
Author:xuelei
Date: 2012-11-24 04:09 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/f7d45462b225
8003950: Adds missing Override annotations and removes unnecessary imports in
sun.security.ssl
Reviewed-by: xuelei
Contributed-by: Florian Weimer
! src/
Changeset: 25e5df117021
Author:xuelei
Date: 2012-11-18 01:31 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/25e5df117021
8003587: Warning cleanup in package javax.net.ssl
Summary: Removes unnecessary imports and adds missing Override annotations
Reviewed-by: xuelei
Contribute
Changeset: 9edfa0e761b9
Author:xuelei
Date: 2012-11-09 01:15 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/9edfa0e761b9
8001569: Regression test GetPeerHost uses static port number
Reviewed-by: weijun
!
test/sun/security/ssl/com/sun/net/ssl/internal/ssl/ServerHandshaker/Ge
Changeset: e782f3c383fe
Author:xuelei
Date: 2012-10-24 08:25 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/e782f3c383fe
8001466: Nightly regression test failure of SSLSocketSNISensitive.java
Reviewed-by: weijun
! test/sun/security/ssl/javax/net/ssl/ServerName/SSLSocketSNISe
Changeset: 21f1b88e68ce
Author:xuelei
Date: 2012-10-19 20:36 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/21f1b88e68ce
8000954: Add final keyword to new method in SSLParameters
Reviewed-by: wetmore
! src/share/classes/javax/net/ssl/SSLParameters.java
Changeset: 3f62cfc4e83d
Author:xuelei
Date: 2012-10-18 01:14 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/3f62cfc4e83d
7068321: Support TLS Server Name Indication (SNI) Extension in JSSE Server
Reviewed-by: mullan, weijun, wetmore
! src/share/classes/javax/net/ssl/Extended
Changeset: a58585051c4b
Author:xuelei
Date: 2012-09-26 21:05 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/a58585051c4b
7200295: CertificateRequest message is wrapping when using large numbers of
Certs
Reviewed-by: wetmore
! src/share/classes/sun/security/ssl/HandshakeMess
Changeset: 88a4f699d233
Author:xuelei
Date: 2012-09-18 06:51 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/88a4f699d233
7199066: Typo in method name
Reviewed-by: mullan
! src/share/classes/sun/security/ssl/SSLContextImpl.java
! src/share/classes/sun/security/ssl/SSLEngineIm
Changeset: b7b33a3c9df0
Author:xuelei
Date: 2012-09-04 02:24 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/b7b33a3c9df0
7195733: TEST_BUG:
sun/security/ssl/sun/net/www/protocol/https/HttpsURLConnection/B6216082.java
failing
Reviewed-by: chegar, alanb, xuelei
Contributed-by
Changeset: e0e7cc711bda
Author:xuelei
Date: 2012-07-24 03:31 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/e0e7cc711bda
7185576: Need to consider the connection timeout at
test/com/sun/jndi/ldap/InvalidLdapFilters.java
Reviewed-by: vinnie
! test/com/sun/jndi/ldap/InvalidLd
Changeset: 3ae91286f313
Author:xuelei
Date: 2012-07-03 20:29 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/3ae91286f313
7180038: regression test failure, SSLEngineBadBufferArrayAccess.java
Reviewed-by: weijun
!
test/sun/security/ssl/com/sun/net/ssl/internal/ssl/SSLEngineIm
Changeset: cdcbd22cfb9d
Author:xuelei
Date: 2012-06-19 17:28 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/cdcbd22cfb9d
7166487: checkSequenceNumber method never called within readRecord of
SSLEngineImpl
Reviewed-by: weijun
! src/share/classes/sun/security/ssl/SSLEngineImp
Changeset: 713b10821c3d
Author:xuelei
Date: 2012-06-06 18:39 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/713b10821c3d
7172149: ArrayIndexOutOfBoundsException from Signature.verify
Summary: take care of integer addition overflow
Reviewed-by: xuelei, wetmore
Contributed-by:
Changeset: f8e72d7ff37d
Author:xuelei
Date: 2012-06-06 18:18 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/f8e72d7ff37d
7174244: NPE in Krb5ProxyImpl.getServerKeys()
Reviewed-by: weijun
! src/share/classes/sun/security/ssl/SSLContextImpl.java
! src/share/classes/sun/securit
Changeset: 9fe6ebbe5895
Author:xuelei
Date: 2012-05-17 21:59 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/9fe6ebbe5895
7145960: sun/security/mscapi/ShortRSAKey1024.sh failing on windows
Reviewed-by: vinnie, wetmore
! test/sun/security/mscapi/ShortRSAKey1024.sh
! test/sun/s
Changeset: df3152beef2f
Author:xuelei
Date: 2012-05-14 07:26 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/df3152beef2f
7167988: PKIX CertPathBuilder in reverse mode doesn't work if more than one
trust anchor is specified
Reviewed-by: mullan
! src/share/classes/sun/securit
Changeset: 0f63f3390ac9
Author:xuelei
Date: 2012-05-08 18:08 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/0f63f3390ac9
7166570: JSSE certificate validation has started to fail for certificate chains
Reviewed-by: wetmore
! src/share/classes/sun/security/validator/SimpleVali
Changeset: fbf98cbd2e6b
Author:xuelei
Date: 2012-05-08 17:56 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/fbf98cbd2e6b
7167092: Need to put the return clause in the synchronized block
Summary: a regression fix for bug 7153184
Reviewed-by: wetmore
! src/share/classes/sun/se
Changeset: 41d3f7509e00
Author:xuelei
Date: 2012-05-04 17:28 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/41d3f7509e00
7153184: NullPointerException when calling
SSLEngineImpl.getSupportedCipherSuites
Reviewed-by: weijun
! src/share/classes/sun/security/ssl/SSLContextImpl
Changeset: 71fdf32fdc65
Author:xuelei
Date: 2012-05-01 03:48 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/71fdf32fdc65
7158688: Typo in SSLContext Spec
Reviewed-by: weijun, wetmore
! src/share/classes/javax/net/ssl/SSLContext.java
Changeset: f0842ed897c3
Author:xuelei
Date: 2012-04-27 04:25 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/f0842ed897c3
6996372: synchronizing handshaking hash
Summary: remove the unnecessary synchronization. Also reviewed by David
Schlosnagle (schlo...@gmail.com)
Reviewed-
Changeset: e700286746c9
Author:xuelei
Date: 2012-03-26 21:21 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/e700286746c9
7155051: DNS provider may return incorrect results
Reviewed-by: weijun, chegar
! src/share/classes/com/sun/jndi/dns/DnsClient.java
Changeset: a4e3dde9a8a7
Author:xuelei
Date: 2012-02-21 05:44 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/a4e3dde9a8a7
7147407: remove never used debug code in DnsClient.java
Reviewed-by: vinnie
! src/share/classes/com/sun/jndi/dns/DnsClient.java
Changeset: 45804d661008
Author:xuelei
Date: 2012-02-15 23:45 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/45804d661008
7145837: a little performance improvement on the usage of SecureRandom
Reviewed-by: chegar, wetmore
! src/share/classes/sun/security/ssl/CipherSuite.java
Changeset: da8b8ee281f9
Author:xuelei
Date: 2012-02-10 22:17 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/da8b8ee281f9
7144781: incorrect URLs in JSSE java doc
Reviewed-by: wetmore, skannan
! src/share/classes/javax/net/ssl/ExtendedSSLSession.java
! src/share/classes/javax
Changeset: d383b5d128e3
Author:xuelei
Date: 2012-01-23 04:44 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/d383b5d128e3
7132248:
sun/security/ssl/sun/net/www/protocol/https/HttpsURLConnection/CookieHttpsClientTest.java
failing
Reviewed-by: alanb
!
test/sun/security/ssl/s
Webrev: http://cr.openjdk.java.net/~xuelei/7132248/webrev.00/
In JDK 8, the regression tests of JSSE (HTTP/TLS) run in agentvm mode.
In agentvm mode, multiple threads may share the thread pool. SunJSSE
implementation initialize the SSL/TLS context at the first time the
context get loaded, a
Changeset: 11e52d5ba64e
Author:xuelei
Date: 2012-01-12 03:39 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/11e52d5ba64e
7106773: 512 bits RSA key cannot work with SHA384 and SHA512
Reviewed-by: weijun
! src/share/classes/sun/security/pkcs11/P11Cipher.java
! src/share/classe
Changeset: d1928ae4e0a2
Author:xuelei
Date: 2011-11-28 02:35 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/d1928ae4e0a2
7115524: sun.security.provider.certpath.ssl.SSLServerCertStore no longer works
Reviewed-by: weijun
! src/share/classes/sun/security/provider/certpath/ssl/
Changeset: 82151e860a64
Author:xuelei
Date: 2011-11-23 03:40 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/82151e860a64
7113275: compatibility issue with MD2 trust anchor and old X509TrustManager
Summary: also reviewed by dennis...@oracle.com
Reviewed-by: mullan
! src/share
Changeset: 5c7c83a6ee24
Author:xuelei
Date: 2011-11-14 01:21 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/5c7c83a6ee24
7111548: unexpected debug log message
Reviewed-by: wetmore
! src/share/classes/sun/security/ssl/SSLSocketImpl.java
Changeset: 30900a1a9cfc
Author:xuelei
Date: 2011-10-30 20:07 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/30900a1a9cfc
7106277: Brokenness in the seqNumberOverflow of MAC
Reviewed-by: wetmore
! src/share/classes/sun/security/ssl/MAC.java
Changeset: 6e59c482e9b8
Author:xuelei
Date: 2011-10-28 07:18 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/6e59c482e9b8
7105940: Test regression: KeyStore must be from provider SunPKCS11-NSSKeyStore
Reviewed-by: weijun
! test/sun/security/pkcs11/fips/CipherTest.java
! test/
Changeset: ffa762153af4
Author:xuelei
Date: 2011-09-28 15:10 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/ffa762153af4
7092375: Security Libraries don't build with javac -Werror
Summary: Changes to security related java and make files to remove warnings
Reviewed-by: xuelei
Changeset: 02c2d38f4271
Author:xuelei
Date: 2011-08-29 05:55 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/02c2d38f4271
7059542: JNDI name operations should be locale independent
Reviewed-by: weijun
! src/share/classes/com/sun/jndi/ldap/ClientId.java
! src/share/classes/com
Sorry that there is a typo of the email address of the contributor. The mail
address should be sebastian.sickelm...@gmx.de. My apologies for my mistake.
Xuelei
On Aug 27, 2011, at 5:18 PM, xuelei@oracle.com wrote:
> Changeset: e4729ad0d7b5
> Author:xuelei
> Date: 2011-08-27 02:17 -
Changeset: e4729ad0d7b5
Author:xuelei
Date: 2011-08-27 02:17 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/e4729ad0d7b5
7084040: Clearup warning in HttpsURLConnection
Reviewed-by: xuelei
Contributed-by: nsebastian.sickelm...@gmx.de
! src/share/classes/javax/net/ssl/HttpsURL
Changeset: 21f4d2d96191
Author:xuelei
Date: 2011-08-22 18:21 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/21f4d2d96191
7081817:
test/sun/security/provider/certpath/X509CertPath/IllegalCertiticates.java
failing
Reviewed-by: alanb, weijun
! src/share/classes/sun/security/p
Changeset: b07cf6cbb62a
Author:xuelei
Date: 2011-08-15 00:30 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/b07cf6cbb62a
7063647: To use synchronized map in key manager
Reviewed-by: wetmore, weijun
! src/share/classes/sun/security/ssl/SunX509KeyManagerImpl.java
Changeset: cea7c749f805
Author:xuelei
Date: 2011-07-29 02:50 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/cea7c749f805
7068662: Reserve and restore the default locale
Reviewed-by: alanb, weijun
! test/com/sun/org/apache/xml/internal/security/exceptions/LocaleTest.java
! te
Changeset: 99dc852080e1
Author:xuelei
Date: 2011-07-19 21:47 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/99dc852080e1
7065972: Some race condition may happen in SSLSocketImpl class
Reviewed-by: wetmore, weijun, dgu
! src/share/classes/sun/security/ssl/SSLSocketImpl.java
Changeset: 5355b9ccd19d
Author:xuelei
Date: 2011-07-19 08:21 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/5355b9ccd19d
7059709: close the IO in a final block
Reviewed-by: smarks, mullan, wetmore
! src/share/classes/sun/security/ssl/SSLContextImpl.java
! src/share/classes/s
Changeset: cd7adb545f71
Author:xuelei
Date: 2011-06-23 04:23 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/cd7adb545f71
7057022: test/sun/security/pkcs11/fips/ClientJSSEServerJSSE.java has invalid
jtreg tags
Reviewed-by: weijun
! test/sun/security/pkcs11/fips/ClientJSSESer
Changeset: 57265bf4b36b
Author:xuelei
Date: 2011-06-22 21:21 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/57265bf4b36b
7058271: Remove InterruptedIO.java record from ProblemList.txt
Reviewed-by: weijun
! test/ProblemList.txt
Changeset: 3b7193ab0d87
Author:xuelei
Date: 2011-06-22 19:37 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/3b7193ab0d87
6952814:
sun/security/ssl/com/sun/net/ssl/internal/ssl/InputRecord/InterruptedIO.java
failing in PIT
Reviewed-by: alanb
-
test/sun/security/ssl/com/sun
Changeset: 99156e4f26ea
Author:xuelei
Date: 2011-05-11 20:39 -0700
URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/99156e4f26ea
7043514: NPE in sun.security.ssl.JsseJce.isEcAvailable
Reviewed-by: weijun, vinnie, wetmore
! src/share/classes/sun/security/ssl/JsseJce.java
Changeset: 8b7f0a3a0b2e
Author:xuelei
Date: 2011-03-15 23:08 -0700
URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/8b7f0a3a0b2e
7025073: Stricter check on trust anchor makes VerifyCACerts.java test fail
Summary: loosen the check for version 1 and 2 X.509 certificate
Reviewed-by: mul
Changeset: 6e306c3aa17b
Author:xuelei
Date: 2011-04-12 08:27 -0700
URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/6e306c3aa17b
6882437: CertPath/X509CertPathDiscovery/Test fails on jdk7/pit/b62
Summary: Pass trust anchors to CRL certification path building, support CRLs
without AK
Changeset: 9c29dd06e138
Author:xuelei
Date: 2011-04-08 02:00 -0700
URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/9c29dd06e138
6976117: SSLContext.getInstance("TLSv1.1") returns SSLEngines/SSLSockets
without TLSv1.1 enabled
Summary: Reorg the SSLContext implementation
Reviewed-by:
Changeset: b921112e39d3
Author:xuelei
Date: 2011-03-23 20:25 -0700
URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/b921112e39d3
7030523: regression: imporper checking of paramater
Reviewed-by: weijun
! src/share/classes/javax/net/ssl/KeyStoreBuilderParameters.java
Changeset: 3fee1c67bd10
Author:xuelei
Date: 2011-03-23 20:07 -0700
URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/3fee1c67bd10
7029848: KeyStoreBuilderParameters((Builder)null) does not throw
NullPointerException
Summary: throws NPE for null Builder
Reviewed-by: weijun
! src/shar
Changeset: ef5bbbe0dd75
Author:xuelei
Date: 2011-03-21 22:02 -0700
URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/ef5bbbe0dd75
7027797: take care of ECDH_anon/DH_anon server key exchange for TLS 1.2
Summary: the signature of server key exanage message could be null
Reviewed-by: vin
Changeset: 320bdab4cb2a
Author:xuelei
Date: 2011-03-17 08:55 -0700
URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/320bdab4cb2a
7028422: regression: SKID miss-matching
Summary: Do not override the previous setting for initial selection.
Reviewed-by: mullan
!
src/share/classes/sun/
Changeset: e3efbb250c0c
Author:xuelei
Date: 2011-03-15 23:13 -0700
URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/e3efbb250c0c
7022855: Export "PKIX" as the standard algorithm name of KeyManagerFactory
Summary: export the existing "NewSunX509" algorithm implementation using the
st
Changeset: fa9d7e241517
Author:xuelei
Date: 2011-03-14 09:05 -0700
URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/fa9d7e241517
7009794: misleading text in SSLHandshakeException exception message
Summary: update the warning message
Reviewed-by: weijun
! src/share/classes/sun/securi
Changeset: 44c99f30f9df
Author:xuelei
Date: 2011-02-14 13:31 -0800
URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/44c99f30f9df
7018897: CertPath validation cannot handle self-signed cert with bad KeyUsage
Summary: Remove KeyUsage checking for trust anchors
Reviewed-by: mullan
! sr
Changeset: d4bc38aa7594
Author:xuelei
Date: 2011-02-01 04:45 -0800
URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/d4bc38aa7594
7011497: new CertPathValidatorException.BasicReason enum constant for
constrained algorithm
Summary: add new BasicReason and improve trust anchor searchin
Changeset: 0d826185a92e
Author:xuelei
Date: 2010-12-22 06:28 -0800
URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/0d826185a92e
6996365: Evaluate the priorities of cipher suites
Reviewed-by: wetmore
! src/share/classes/sun/security/ssl/CipherSuite.java
Changeset: e6ed7c95d94f
Author:xuelei
Date: 2010-12-15 22:42 -0800
URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/e6ed7c95d94f
7006265: Javadoc warnings
Reviewed-by: weijun
! src/share/classes/javax/net/ssl/X509ExtendedTrustManager.java
Changeset: 0e0bdcd9c101
Author:xuelei
Date: 2010-12-02 23:44 -0800
URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/0e0bdcd9c101
6979376: to have ldap filters tolerate underscore character in object identifier
Reviewed-by: weijun
! src/share/classes/com/sun/jndi/ldap/Filter.java
! t
1 - 100 of 133 matches
Mail list logo