Re: (S) RFR: 8159461: bigapps/Kitchensink/stressExitCode hits assert: Must be VMThread or JavaThread

2016-08-11 Thread David Holmes
On 12/08/2016 11:25 AM, Daniel D. Daugherty wrote: David, Sorry I forgot to respond before I left for Santa Fe, NM... More below... No problem. On 8/8/16 5:57 PM, David Holmes wrote: Hi Dan, Thanks for the review. On 9/08/2016 2:07 AM, Daniel D. Daugherty wrote: On 8/4/16 8:28 PM, David

Re: (S) RFR: 8159461: bigapps/Kitchensink/stressExitCode hits assert: Must be VMThread or JavaThread

2016-08-11 Thread Daniel D. Daugherty
David, Sorry I forgot to respond before I left for Santa Fe, NM... More below... On 8/8/16 5:57 PM, David Holmes wrote: Hi Dan, Thanks for the review. On 9/08/2016 2:07 AM, Daniel D. Daugherty wrote: On 8/4/16 8:28 PM, David Holmes wrote: Hi Volker, Thanks for looking at this. On 5/08/20

Re: (S) RFR: 8159461: bigapps/Kitchensink/stressExitCode hits assert: Must be VMThread or JavaThread

2016-08-08 Thread David Holmes
Thanks Volker! David On 8/08/2016 11:35 PM, Volker Simonis wrote: Hi David, looks good now. Thanks, Volker On Fri, Aug 5, 2016 at 4:28 AM, David Holmes wrote: Hi Volker, Thanks for looking at this. On 5/08/2016 1:48 AM, Volker Simonis wrote: Hi David, thanks for doing this change on

Re: (S) RFR: 8159461: bigapps/Kitchensink/stressExitCode hits assert: Must be VMThread or JavaThread

2016-08-08 Thread David Holmes
Hi Dan, Thanks for the review. On 9/08/2016 2:07 AM, Daniel D. Daugherty wrote: On 8/4/16 8:28 PM, David Holmes wrote: Hi Volker, Thanks for looking at this. On 5/08/2016 1:48 AM, Volker Simonis wrote: Hi David, thanks for doing this change on all platforms. The fix looks good. Maybe you c

Re: (S) RFR: 8159461: bigapps/Kitchensink/stressExitCode hits assert: Must be VMThread or JavaThread

2016-08-08 Thread Daniel D. Daugherty
On 8/4/16 8:28 PM, David Holmes wrote: Hi Volker, Thanks for looking at this. On 5/08/2016 1:48 AM, Volker Simonis wrote: Hi David, thanks for doing this change on all platforms. The fix looks good. Maybe you can just extend the following comment with something like: // Note that the SR_lo

Re: (S) RFR: 8159461: bigapps/Kitchensink/stressExitCode hits assert: Must be VMThread or JavaThread

2016-08-08 Thread Volker Simonis
Hi David, looks good now. Thanks, Volker On Fri, Aug 5, 2016 at 4:28 AM, David Holmes wrote: > Hi Volker, > > Thanks for looking at this. > > On 5/08/2016 1:48 AM, Volker Simonis wrote: >> >> Hi David, >> >> thanks for doing this change on all platforms. >> The fix looks good. Maybe you can ju

Re: (S) RFR: 8159461: bigapps/Kitchensink/stressExitCode hits assert: Must be VMThread or JavaThread

2016-08-04 Thread David Holmes
Hi Volker, Thanks for looking at this. On 5/08/2016 1:48 AM, Volker Simonis wrote: Hi David, thanks for doing this change on all platforms. The fix looks good. Maybe you can just extend the following comment with something like: // Note that the SR_lock plays no role in this suspend/resume

Re: (S) RFR: 8159461: bigapps/Kitchensink/stressExitCode hits assert: Must be VMThread or JavaThread

2016-08-04 Thread Volker Simonis
Hi David, thanks for doing this change on all platforms. The fix looks good. Maybe you can just extend the following comment with something like: // Note that the SR_lock plays no role in this suspend/resume protocol. // It is only used in SR_handler as a thread termination indicator if NULL.

Re: (S) RFR: 8159461: bigapps/Kitchensink/stressExitCode hits assert: Must be VMThread or JavaThread

2016-08-03 Thread David Holmes
On 4/08/2016 12:07 AM, Frederic Parain wrote: David, Interesting twist about JavaThreads returning to their plain Thread nature before dying. Yes that was quite baffling for a while :) Fix looks good to me. Thanks for the review Fred! David Fred On 08/02/2016 09:13 PM, David Holmes wro

Re: (S) RFR: 8159461: bigapps/Kitchensink/stressExitCode hits assert: Must be VMThread or JavaThread

2016-08-03 Thread Frederic Parain
David, Interesting twist about JavaThreads returning to their plain Thread nature before dying. Fix looks good to me. Fred On 08/02/2016 09:13 PM, David Holmes wrote: webrev: http://cr.openjdk.java.net/~dholmes/8159461/webrev/ bug: https://bugs.openjdk.java.net/browse/JDK-8159461 The suspen

(S) RFR: 8159461: bigapps/Kitchensink/stressExitCode hits assert: Must be VMThread or JavaThread

2016-08-02 Thread David Holmes
webrev: http://cr.openjdk.java.net/~dholmes/8159461/webrev/ bug: https://bugs.openjdk.java.net/browse/JDK-8159461 The suspend/resume signal (SR_signum) is never sent to a thread once it has started to terminate. On one platform (SuSE 12) we have seen what appears to be a "stuck" signal, which