Summary: Modify SA code to not use SymbolTable and remove it.
This is to support the concurrent hashtable for SymbolTable.
open webrev at http://cr.openjdk.java.net/~coleenp/8205534.01/webrev
bug link https://bugs.openjdk.java.net/browse/JDK-8205534
Tested with hs-tier1-5.
Thanks,
Coleen
hi Coleen,
Looks good, just need to update the copyright years here (don’t need to see the
webrev):
src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/classfile/ClassLoaderDataGraph.java
src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/oops/Field.java
src/jdk.hotspot.agent/share/classes/sun/
Thank you for reviewing, Gerard!
Coleen
On 6/26/18 3:31 PM, Gerard Ziemski wrote:
hi Coleen,
Looks good, just need to update the copyright years here (don’t need to see the
webrev):
src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/classfile/ClassLoaderDataGraph.java
src/jdk.hotspot.agent
Hello Coleen,
The changes look good to me. One minor thing that I noticed though:
At Line 94 in file
src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/classfile/ClassLoaderData.java
The comment above the function find() is removed. Is that intentional?
Thanks,
Poonam
On 6/22/18 2:40 PM, c
On 6/26/18 5:18 PM, Poonam Parhar wrote:
Hello Coleen,
The changes look good to me. One minor thing that I noticed though:
At Line 94 in file
src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/classfile/ClassLoaderData.java
The comment above the function find() is removed. Is that intent
Hi Coleen,
Apologize for the delay. Your changes look good to me overall. A few
comments:
It might make sense to also remove the corresponding lines in the
vmStructs files. Like:
File Line
vmStructs.cpp 170 typedef RehashableHashtable
RehashableSymbolHashtable;
vmStructs.cpp 47
Hi Jini, Thank you for reviewing this.
On 6/29/18 12:02 PM, Jini George wrote:
Hi Coleen,
Apologize for the delay. Your changes look good to me overall. A few
comments:
It might make sense to also remove the corresponding lines in the
vmStructs files. Like:
File Line
vmStruct
