Looks ok to me.
/Erik
On 2018-11-15 06:57, Severin Gehwolf wrote:
Hi,
Could I please get reviews for this 8u backport of JDK-8210647. Since
the build system is different in 8, the patch looks different. For the
Windows build changes I've refactored the make file a bit so as to
facilitate passi
Hi JC,
On Thu, 2018-11-15 at 08:37 -0800, JC Beyler wrote:
> Hi Severin,
>
> That does look different (
> http://hg.openjdk.java.net/jdk/jdk/rev/c608b2190460) :)
>
> It looks good to me :),
Thanks for the review!
Cheers,
Severin
> Jc
>
> On Thu, Nov 15, 2018 at 6:58 AM Severin Gehwolf
> wro
Hi Severin,
That does look different (
http://hg.openjdk.java.net/jdk/jdk/rev/c608b2190460) :)
It looks good to me :),
Jc
On Thu, Nov 15, 2018 at 6:58 AM Severin Gehwolf wrote:
> Hi,
>
> Could I please get reviews for this 8u backport of JDK-8210647. Since
> the build system is different in 8,
Hi,
Could I please get reviews for this 8u backport of JDK-8210647. Since
the build system is different in 8, the patch looks different. For the
Windows build changes I've refactored the make file a bit so as to
facilitate passing opt flags to the compiler.
Bug: https://bugs.openjdk.java.net/brow
