Re: [PING] RFR(s) 8153711: [REDO] JDWP: Memory Leak: GlobalRefs never deleted when processing invokeMethod command

2016-09-15 Thread Severin Gehwolf
Hi Serguei, On Wed, 2016-09-14 at 11:44 -0700, serguei.spit...@oracle.com wrote: > Hi Severin, > > The fix looks good. > Thank you for persistence in fixing the issue! Thanks for the review! > The only suggestion is to refactor the lines 800-815 into a method call. > Something like deletePoenti

Re: [PING] RFR(s) 8153711: [REDO] JDWP: Memory Leak: GlobalRefs never deleted when processing invokeMethod command

2016-09-14 Thread serguei.spit...@oracle.com
Hi Severin, The fix looks good. Thank you for persistence in fixing the issue! The only suggestion is to refactor the lines 800-815 into a method call. Something like deletePoentiallySavedGlobalRefs, similar to deleteGlobalArgumetRefs. Thanks, Serguei On 9/14/16 09:34, Severin Gehwolf wrot

Re: [PING] RFR(s) 8153711: [REDO] JDWP: Memory Leak: GlobalRefs never deleted when processing invokeMethod command

2016-09-14 Thread Severin Gehwolf
Anyone? On Fri, 2016-09-09 at 18:27 +0200, Severin Gehwolf wrote: > Hi, > > Could I please get a review of the this 4th version of this fix: > > Bug: https://bugs.openjdk.java.net/browse/JDK-8153711 > webrev: http://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-8153711/webrev.03/ > > It fixes a mem