[ping] Re: RFR 8077327: ThreadStackTrace.java throws exception: BlockedThread expected to have BLOCKED but got RUNNABLE

2015-04-13 Thread Jaroslav Bachorik
On 9.4.2015 20:11, Jaroslav Bachorik wrote: Please, review the following test change Issue : https://bugs.openjdk.java.net/browse/JDK-8077327 Webrev: http://cr.openjdk.java.net/~jbachorik/8077327/webrev.00 This fix is for an intermittent failure due to timing issues. The test is using an arbitr

Re: [ping] Re: RFR 8077327: ThreadStackTrace.java throws exception: BlockedThread expected to have BLOCKED but got RUNNABLE

2015-04-14 Thread Daniel Fuchs
Hi Jaroslav, Shouldn't you also wait for the blockedThread to be blocked on lockA at around line 252? (I mean - using Utils.waitForThreadState(blockedThread, State.BLOCKED)) best regards, -- daniel On 4/13/15 10:07 AM, Jaroslav Bachorik wrote: On 9.4.2015 20:11, Jaroslav Bachorik wrote: Plea

Re: [ping] Re: RFR 8077327: ThreadStackTrace.java throws exception: BlockedThread expected to have BLOCKED but got RUNNABLE

2015-04-14 Thread Jaroslav Bachorik
Hi Daniel, On 14.4.2015 09:38, Daniel Fuchs wrote: Hi Jaroslav, Shouldn't you also wait for the blockedThread to be blocked on lockA at around line 252? (I mean - using Utils.waitForThreadState(blockedThread, State.BLOCKED)) Yes, nice catch. Thanks! http://cr.openjdk.java.net/~jbachorik/8077

Re: [ping] Re: RFR 8077327: ThreadStackTrace.java throws exception: BlockedThread expected to have BLOCKED but got RUNNABLE

2015-04-14 Thread Daniel Fuchs
On 14/04/15 11:28, Jaroslav Bachorik wrote: Hi Daniel, On 14.4.2015 09:38, Daniel Fuchs wrote: Hi Jaroslav, Shouldn't you also wait for the blockedThread to be blocked on lockA at around line 252? (I mean - using Utils.waitForThreadState(blockedThread, State.BLOCKED)) Yes, nice catch. Thanks

Re: [ping] Re: RFR 8077327: ThreadStackTrace.java throws exception: BlockedThread expected to have BLOCKED but got RUNNABLE

2015-04-14 Thread serguei.spit...@oracle.com
On 4/14/15 12:38 AM, Daniel Fuchs wrote: Hi Jaroslav, Shouldn't you also wait for the blockedThread to be blocked on lockA at around line 252? (I mean - using Utils.waitForThreadState(blockedThread, State.BLOCKED)) I guess, it is about these lines: 255 Utils.checkThreadSta

Re: [ping] Re: RFR 8077327: ThreadStackTrace.java throws exception: BlockedThread expected to have BLOCKED but got RUNNABLE

2015-04-14 Thread Jaroslav Bachorik
On 14.4.2015 14:37, serguei.spit...@oracle.com wrote: On 4/14/15 12:38 AM, Daniel Fuchs wrote: Hi Jaroslav, Shouldn't you also wait for the blockedThread to be blocked on lockA at around line 252? (I mean - using Utils.waitForThreadState(blockedThread, State.BLOCKED)) I guess, it is about thes

Re: [ping] Re: RFR 8077327: ThreadStackTrace.java throws exception: BlockedThread expected to have BLOCKED but got RUNNABLE

2015-04-14 Thread serguei.spit...@oracle.com
On 4/14/15 7:44 AM, Jaroslav Bachorik wrote: On 14.4.2015 14:37, serguei.spit...@oracle.com wrote: On 4/14/15 12:38 AM, Daniel Fuchs wrote: Hi Jaroslav, Shouldn't you also wait for the blockedThread to be blocked on lockA at around line 252? (I mean - using Utils.waitForThreadState(blockedThre