Hi David and Serguei,
Thank you for reviewing this fix!
Best regards,
Daniil
On 10/2/19, 4:24 PM, "serguei.spit...@oracle.com"
wrote:
Hi Daniil,
+1
I also prefer (agree with) a new VM option to opt-out from the new behavior.
Sorry for some latency in the review and
Thumbs up!
Dan
On 10/1/19 4:57 PM, Daniil Titov wrote:
Hello,
Please review a new version of the change [1] that fixes the problem with the
debugger not stopping in the low memory notification code. The fix moves the
send notifications task from
not visible ServiceThread to a new visible
Hi David and Serguei,
Thank you, for reviewing this change!
Best regards,
Daniil
On 10/2/19, 4:24 PM, "serguei.spit...@oracle.com"
wrote:
Hi Daniil,
+1
I also prefer (agree with) a new VM option to opt-out from the new behavior.
Sorry for some latency in the review
Hi Daniil,
+1
I also prefer (agree with) a new VM option to opt-out from the new behavior.
Sorry for some latency in the review and discussion process.
Thanks,
Serguei
On 10/1/19 20:20, David Holmes wrote:
Hi Daniil,
Thanks again for your perseverance with this one.
This looks fine to me.
Hi Daniil,
Thanks again for your perseverance with this one.
This looks fine to me.
Thanks,
David
-
On 2/10/2019 6:57 am, Daniil Titov wrote:
Hello,
Please review a new version of the change [1] that fixes the problem with the
debugger not stopping in the low memory notification
Hello,
Please review a new version of the change [1] that fixes the problem with the
debugger not stopping in the low memory notification code. The fix moves the
send notifications task from
not visible ServiceThread to a new visible NotificationThread. This version of
the change also
Hi Chris,
On 3/08/2019 4:12 am, Chris Plummer wrote:
On 7/31/19 11:50 PM, David Holmes wrote:
Hi Daniil,
On 25/07/2019 3:34 am, Daniil Titov wrote:
Hi David,
Hope you had a great vacation!
I did thank you. Apologies again for taking so long to get back to
this work.
Please find below
On 7/31/19 11:50 PM, David Holmes wrote:
Hi Daniil,
On 25/07/2019 3:34 am, Daniil Titov wrote:
Hi David,
Hope you had a great vacation!
I did thank you. Apologies again for taking so long to get back to
this work.
Please find below the latest version of the change . The only
difference
Hi Daniil,
On 25/07/2019 3:34 am, Daniil Titov wrote:
Hi David,
Hope you had a great vacation!
I did thank you. Apologies again for taking so long to get back to this
work.
Please find below the latest version of the change . The only difference from
the version 01 is
the corrected
Hi David,
Hope you had a great vacation!
Please find below the latest version of the change . The only difference from
the version 01 is
the corrected ordering of include statements as Serguei suggested.
Webrev: https://cr.openjdk.java.net/~dtitov/8170299/webrev.02/
Bug:
"hotspot-runtime-...@openjdk.java.net"
,
"jmx-...@openjdk.java.net"
, David Holmes
Subject: Re: RFR: 8170299: Debugger does not stop
inside the low memory notifications code
, OpenJDK Serviceability
, "hotspot-runtime-...@openjdk.java.net"
, "jmx-...@openjdk.java.net"
, David Holmes
Subject: Re: RFR: 8170299: Debugger does not stop inside the low memory
notifications code
Hi Daniil,
Did you see a message from David Holmes?
I do not see your rep
Hi David,
Sure, I will put it on hold till you are back from the vacations.
Webrev: https://cr.openjdk.java.net/~dtitov/8170299/webrev.02/
Bug: https://bugs.openjdk.java.net/browse/JDK-8170299
Have a nice vacations!
Best regards,
Daniil
On 7/3/19, 11:47 PM, "David Holmes" wrote:
Hi
Hi Daniil,
Did you see a message from David Holmes?
I do not see your reply.
Specifically, David asked to hold on with this while he is on
vacation for two weeks:
> But introducing a new thread in the VM also has the same set
of
Hi Serguei,
Please review the new version of the fix that corrects the order of include
statements in src/hotspot/share/runtime/notificationThread.cpp.
The list of Include statements doesn't contain "#include
"runtime/mutexLocker.hpp" since this include file is already included by
Hi Daniil,
On 4/07/2019 1:04 pm, Daniil Titov wrote:
Please review the change the fixes the problem with the debugger not stopping
in the low memory notification code.
The problem here is that the ServiceThread that calls these MXBean listeners is
hidden from the external view that prevents
Hi Daniil,
I've not finished my review but it looks good in general.
A couple of quick comments.
https://cr.openjdk.java.net/~dtitov/8170299/webrev.01/src/hotspot/share/runtime/notificationThread.hpp.html
I wonder if this function is also needed:
static bool
Please review the change the fixes the problem with the debugger not stopping
in the low memory notification code.
The problem here is that the ServiceThread that calls these MXBean listeners is
hidden from the external view that prevents the debugger from stopping in it.
The fix introduces
18 matches
Mail list logo
