Re: 8033758: gcc warnings compiling jdk/src/share/back

2014-02-06 Thread Daniel D. Daugherty
Looks good to me. Nice to see you back in Serviceability code...:-) Dan On 2/6/14 3:04 AM, Alan Bateman wrote: This is a drive-by fix to the JDWP agent to fix 50+ warnings that have been annoying me, see: https://bugs.openjdk.java.net/browse/JDK-8033758 The bulk of the warnings stem fr

Re: 8033758: gcc warnings compiling jdk/src/share/back

2014-02-06 Thread Alan Bateman
On 06/02/2014 10:22, David Holmes wrote: Ok - not the nicest but this isn't worth any additional effort. Right, it's not worth it. Thanks for the quick review (Staffan too). I've just run the JDI tests on all platforms (as that exercises JDWP) and the tests are passing so I think we are good

Re: 8033758: gcc warnings compiling jdk/src/share/back

2014-02-06 Thread serguei.spit...@oracle.com
Looks good. Thanks, Alan! Serguei On 2/6/14 2:04 AM, Alan Bateman wrote: This is a drive-by fix to the JDWP agent to fix 50+ warnings that have been annoying me, see: https://bugs.openjdk.java.net/browse/JDK-8033758 The bulk of the warnings stem from using a switch statement to switch

Re: 8033758: gcc warnings compiling jdk/src/share/back

2014-02-06 Thread Staffan Larsen
Looks good! Thanks, /Staffan On 6 feb 2014, at 11:04, Alan Bateman wrote: > > This is a drive-by fix to the JDWP agent to fix 50+ warnings that have been > annoying me, see: >https://bugs.openjdk.java.net/browse/JDK-8033758 > > The bulk of the warnings stem from using a switch statement

Re: 8033758: gcc warnings compiling jdk/src/share/back

2014-02-06 Thread David Holmes
Hi Alan, On 6/02/2014 8:04 PM, Alan Bateman wrote: This is a drive-by fix to the JDWP agent to fix 50+ warnings that have been annoying me, see: https://bugs.openjdk.java.net/browse/JDK-8033758 The bulk of the warnings stem from using a switch statement to switch on JVMTI and JDWP interna

8033758: gcc warnings compiling jdk/src/share/back

2014-02-06 Thread Alan Bateman
This is a drive-by fix to the JDWP agent to fix 50+ warnings that have been annoying me, see: https://bugs.openjdk.java.net/browse/JDK-8033758 The bulk of the warnings stem from using a switch statement to switch on JVMTI and JDWP internal "agent" errors. The agent errors are arranged (i