Please review the change that fixes the failing tests when running with Graal.
The issue originally
included several vmTestbase/nsk/jdi tests but only 2 of them still fail:
-
vmTestbase/nsk/jdi/VirtualMachine/instanceCounts/instancecounts003/instancecounts003.java
-
vmTestbase/nsk/jdi/ObjectRef
Hi Dean and Chris,
Just wanted to check with you would it be OK now to add this issue to
Graal-specific problem list, as Dean suggested in one of the previous emails,
while the proposal about introducing new options for @requires is being
discussed?
-Thanks!
--Daniil
On 8/9/19, 3:37 PM, "
I'm not sure. You could problem list it, but then the question is which
bug to problem list it under, JDK-8195600 or JDK-8207267 (in which case
JDK-8195600 would be closed). I'd hate to see a separate CR for every
test that fails due to graal unexpectedly executing java code. But then
JDK-82072
I don't have a strong opinion either way. It's too bad we don't have
resource management features that would allow setting a memory limit on
the test or app while allowing the rest of the JVM to use memory
unrestricted. That might solve a lot of these OOM problems. Even after
we move to libgr
Hi Daniil,
Looks good to me,
Jc
On Wed, Aug 7, 2019 at 3:39 PM Daniil Titov
wrote:
> Please review the change that fixes the failing tests when running with
> Graal. The issue originally
> included several vmTestbase/nsk/jdi tests but only 2 of them still fail:
> -
> vmTestbase/nsk/jdi/VirtualM
Hi Daniil,
My only objection is at some point it seems we need to be able to run
these tests with graal (and other tests that have been disabled due to
graal) because graal might be the only compiler, and we'll lose test
coverage without these tests. Currently we have 260 jtreg tests disabled
This is the kind of failure that is expected to go away with libgraal.
You can add the tests to the Graal-specific problem list (see
JDK-8196611) and they should be re-enabled with libgraal (see
JDK-JDK-8207267).
dl
On 8/8/19 10:21 AM, Chris Plummer wrote:
Hi Daniil,
My only objection is a
That sounds like a better approach to me.
thanks,
Chris
On 8/8/19 4:33 PM, dean.l...@oracle.com wrote:
This is the kind of failure that is expected to go away with libgraal.
You can add the tests to the Graal-specific problem list (see
JDK-8196611) and they should be re-enabled with libgraal
Actually looking at JDK-8207267 a little closer, it looks like it's job
is to re-enable tests that have been disabled with @requires
!vm.graal.enabled, so it looks like we have two different approaches
going in here. Which is preferred? If the preference is to problem list,
do we want to undo J
Good question When we have libgraal, there will still be an option (at
least for debugging) to turn it off and use Graal the same way we do
now, so it seems like the @requires would need to take that into account
once we have libgraal. Maybe we will need a new "vm.libgraal.enabled"
or make "v
10 matches
Mail list logo
