Re: 8217348: assert(thread->is_Java_thread()) failed: just checking

Thank you, David, Serguei and Alex, for reviewing this change! Best regards, --Daniil On 6/16/19, 6:15 AM, "David Holmes" wrote: On 15/06/2019 10:06 am, Daniil Titov wrote: > Hi Serguei, > > The discovery was made by David Holmes. Thank you, David, a lot! :) Wish I'd

Re: 8217348: assert(thread->is_Java_thread()) failed: just checking

On 15/06/2019 10:06 am, Daniil Titov wrote: Hi Serguei, The discovery was made by David Holmes. Thank you, David, a lot! :) Wish I'd spotted it the first time round. Fix looks good. Thanks, David Best regards, Daniil On 6/14/19, 5:01 PM, "serguei.spit...@oracle.com" wrote: H

Re: RFR: 8217348: assert(thread->is_Java_thread()) failed: just checking

On 6/14/19 5:44 PM, Jean Christophe Beyler wrote: Hi Daniil, Looks good to me to :-) FWIW, it seems like: opto/library_call.cpp:    if (!C->too_many_traps(trap_method, trap_bci, Deoptimization::Reason_intrinsic) &           !C->too_many_traps(trap_method, trap_bci, Deoptimization::Reason_nu

Re: 8217348: assert(thread->is_Java_thread()) failed: just checking

On 6/14/19 5:06 PM, Daniil Titov wrote: Hi Serguei, The discovery was made by David Holmes. Thank you, David, a lot! Sharp eyes! Thanks, Serguei Best regards, Daniil On 6/14/19, 5:01 PM, "serguei.spit...@oracle.com" wrote: Hi Daniil, Great discovery! The f

Re: RFR: 8217348: assert(thread->is_Java_thread()) failed: just checking

+1 --alex On 06/14/2019 17:01, serguei.spit...@oracle.com wrote: Hi Daniil, Great discovery! The fix looks good to me. Thanks, Serguei On 6/14/19 4:56 PM, Daniil Titov wrote: Please review the change that fixes an intermittent issue. The problem here is that a bitwise-AND (&) operator was

Re: 8217348: assert(thread->is_Java_thread()) failed: just checking

Hi Serguei, The discovery was made by David Holmes. Thank you, David, a lot! Best regards, Daniil On 6/14/19, 5:01 PM, "serguei.spit...@oracle.com" wrote: Hi Daniil, Great discovery! The fix looks good to me. Thanks, Serguei On 6/14/19 4:56 PM,

Re: RFR: 8217348: assert(thread->is_Java_thread()) failed: just checking

Hi Daniil, Great discovery! The fix looks good to me. Thanks, Serguei On 6/14/19 4:56 PM, Daniil Titov wrote: Please review the change that fixes an intermittent issue. The problem here is that a bitwise-AND (&) operator was used in the condition instead of a logical AND operator (&&). As a

RFR: 8217348: assert(thread->is_Java_thread()) failed: just checking

Please review the change that fixes an intermittent issue. The problem here is that a bitwise-AND (&) operator was used in the condition instead of a logical AND operator (&&). As a result pending_thread->is_thread_fully_suspended() is always evaluated regardless of the value of at_safepoint va