Re: 8222224: vmTestbase/nsk/jvmti/SingleStep/singlestep001/TestDescription.java fails

2019-04-10 Thread Daniil Titov
Thank you, Serguei, JC, and Alex, for reviewing this change. Best regards, Daniil On 4/10/19, 9:58 AM, "serviceability-dev on behalf of Alex Menkov" wrote: +1 --alex On 04/09/2019 19:38, Jean Christophe Beyler wrote: > Hi Daniil, > > Looks good to me too

Re: RFR: 8222224: vmTestbase/nsk/jvmti/SingleStep/singlestep001/TestDescription.java fails

2019-04-10 Thread Alex Menkov
+1 --alex On 04/09/2019 19:38, Jean Christophe Beyler wrote: Hi Daniil, Looks good to me too :-) Jc On Tue, Apr 9, 2019 at 7:01 PM > wrote: Hi Daniil, It looks good. Thanks, Serguei On 4/9/19 4:37 PM, Daniil Titov wrote: >

Re: RFR: 8222224: vmTestbase/nsk/jvmti/SingleStep/singlestep001/TestDescription.java fails

2019-04-09 Thread serguei . spitsyn
Hi Daniil, It looks good. Thanks, Serguei On 4/9/19 4:37 PM, Daniil Titov wrote: Please review the change that fixes intermittent failure of the test when running with Graal on. The problem here is the similar to the one fixed in JDK-8218401, the callbacks this test enables keep

RFR: 8222224: vmTestbase/nsk/jvmti/SingleStep/singlestep001/TestDescription.java fails

2019-04-09 Thread Daniil Titov
Please review the change that fixes intermittent failure of the test when running with Graal on. The problem here is the similar to the one fixed in JDK-8218401, the callbacks this test enables keep processing events and perform JVMTI calls after VM is terminated. The fix ensures that the test