Re: RFR: 8248362: JVMTI frame operations should use Thread-Local Handshake

2020-07-24 Thread Yasumasa Suenaga
Thanks Dan! Yasumasa On 2020/07/25 3:24, Daniel D. Daugherty wrote: On 7/22/20 11:12 PM, Yasumasa Suenaga wrote: Hi Dan, Thanks for your comment! I uploaded new webrev:   http://cr.openjdk.java.net/~ysuenaga/JDK-8248362/webrev.01/   Diff from previous webrev: http://hg.openjdk.java.net/jdk

Re: RFR: 8248362: JVMTI frame operations should use Thread-Local Handshake

2020-07-24 Thread Daniel D. Daugherty
On 7/22/20 11:12 PM, Yasumasa Suenaga wrote: Hi Dan, Thanks for your comment! I uploaded new webrev:   http://cr.openjdk.java.net/~ysuenaga/JDK-8248362/webrev.01/   Diff from previous webrev: http://hg.openjdk.java.net/jdk/submit/rev/df75038b5449 Thumbs up. Reviewed by comparing the previous

Re: RFR: 8248362: JVMTI frame operations should use Thread-Local Handshake

2020-07-23 Thread Yasumasa Suenaga
Thanks Serguei! Yasumasa On 2020/07/24 4:31, serguei.spit...@oracle.com wrote: Hi Yasumasa, The update looks good. Thanks, Serguei On 7/22/20 20:03, Yasumasa Suenaga wrote: Hi Serguei, Thanks for your comment! I fixed it in new webrev:   http://cr.openjdk.java.net/~ysuenaga/JDK-8248362/

Re: RFR: 8248362: JVMTI frame operations should use Thread-Local Handshake

2020-07-23 Thread serguei.spit...@oracle.com
Hi Yasumasa, The update looks good. Thanks, Serguei On 7/22/20 20:03, Yasumasa Suenaga wrote: Hi Serguei, Thanks for your comment! I fixed it in new webrev:   http://cr.openjdk.java.net/~ysuenaga/JDK-8248362/webrev.01/   Diff from previous webrev: http://hg.openjdk.java.net/jdk/submit/rev/

Re: RFR: 8248362: JVMTI frame operations should use Thread-Local Handshake

2020-07-23 Thread Daniel D. Daugherty
On 7/22/20 9:25 PM, David Holmes wrote: Hi Dan, I just want to respond to one aspect of your response ... On 23/07/2020 11:04 am, Daniel D. Daugherty wrote: On 7/22/20 10:38 AM, Yasumasa Suenaga wrote: Hi all, Please review this change:   JBS: https://bugs.openjdk.java.net/browse/JDK-824836

Re: RFR: 8248362: JVMTI frame operations should use Thread-Local Handshake

2020-07-22 Thread David Holmes
On 23/07/2020 1:13 pm, Yasumasa Suenaga wrote: Hi David, Thanks for your comment! On 2020/07/23 11:01, David Holmes wrote: Hi Yasumasa, On 23/07/2020 12:38 am, Yasumasa Suenaga wrote: Hi all, Please review this change:    JBS: https://bugs.openjdk.java.net/browse/JDK-8248362    webrev: htt

Re: RFR: 8248362: JVMTI frame operations should use Thread-Local Handshake

2020-07-22 Thread Yasumasa Suenaga
Hi Dan, Thanks for your comment! I uploaded new webrev: http://cr.openjdk.java.net/~ysuenaga/JDK-8248362/webrev.01/ Diff from previous webrev: http://hg.openjdk.java.net/jdk/submit/rev/df75038b5449 On 2020/07/23 10:04, Daniel D. Daugherty wrote: On 7/22/20 10:38 AM, Yasumasa Suenaga wrote

Re: RFR: 8248362: JVMTI frame operations should use Thread-Local Handshake

2020-07-22 Thread Yasumasa Suenaga
Hi David, Thanks for your comment! On 2020/07/23 11:01, David Holmes wrote: Hi Yasumasa, On 23/07/2020 12:38 am, Yasumasa Suenaga wrote: Hi all, Please review this change:    JBS: https://bugs.openjdk.java.net/browse/JDK-8248362    webrev: http://cr.openjdk.java.net/~ysuenaga/JDK-8248362/we

Re: RFR: 8248362: JVMTI frame operations should use Thread-Local Handshake

2020-07-22 Thread Yasumasa Suenaga
Hi Serguei, Thanks for your comment! I fixed it in new webrev: http://cr.openjdk.java.net/~ysuenaga/JDK-8248362/webrev.01/ Diff from previous webrev: http://hg.openjdk.java.net/jdk/submit/rev/df75038b5449 Yasumasa On 2020/07/23 9:31, serguei.spit...@oracle.com wrote: Hi Yasumasa, Look

Re: RFR: 8248362: JVMTI frame operations should use Thread-Local Handshake

2020-07-22 Thread David Holmes
Hi Yasumasa, On 23/07/2020 12:38 am, Yasumasa Suenaga wrote: Hi all, Please review this change:   JBS: https://bugs.openjdk.java.net/browse/JDK-8248362   webrev: http://cr.openjdk.java.net/~ysuenaga/JDK-8248362/webrev.00/ Migrate JVMTI frame operations to Thread-Local Handshakes from VM Op

Re: RFR: 8248362: JVMTI frame operations should use Thread-Local Handshake

2020-07-22 Thread David Holmes
Hi Dan, I just want to respond to one aspect of your response ... On 23/07/2020 11:04 am, Daniel D. Daugherty wrote: On 7/22/20 10:38 AM, Yasumasa Suenaga wrote: Hi all, Please review this change:   JBS: https://bugs.openjdk.java.net/browse/JDK-8248362   webrev: http://cr.openjdk.java.net/~y

Re: RFR: 8248362: JVMTI frame operations should use Thread-Local Handshake

2020-07-22 Thread Daniel D. Daugherty
On 7/22/20 10:38 AM, Yasumasa Suenaga wrote: Hi all, Please review this change:   JBS: https://bugs.openjdk.java.net/browse/JDK-8248362   webrev: http://cr.openjdk.java.net/~ysuenaga/JDK-8248362/webrev.00/ src/hotspot/share/prims/jvmtiEnv.cpp     L1755 // JVMTI get java stack frame locati

Re: RFR: 8248362: JVMTI frame operations should use Thread-Local Handshake

2020-07-22 Thread serguei.spit...@oracle.com
Hi Yasumasa, Looks good. Just one minor comment. http://cr.openjdk.java.net/~ysuenaga/JDK-8248362/webrev.00/src/hotspot/share/prims/jvmtiEnv.cpp.udiff.html // JVMTI get java stack frame location at safepoint. Replace: "at safepoint" => "with han

Re: 8248362: JVMTI frame operations should use Thread-Local Handshake

2020-07-22 Thread Yasumasa Suenaga
Thanks David! Your suggestion seems to work fine on submit repo. I will send review request. Yasumasa On 2020/07/22 21:29, David Holmes wrote: On 22/07/2020 6:19 pm, Yasumasa Suenaga wrote: On 2020/07/22 16:57, David Holmes wrote: Hi Yasumasa, On 22/07/2020 5:39 pm, Yasumasa Suenaga wrote:

RFR: 8248362: JVMTI frame operations should use Thread-Local Handshake

2020-07-22 Thread Yasumasa Suenaga
Hi all, Please review this change: JBS: https://bugs.openjdk.java.net/browse/JDK-8248362 webrev: http://cr.openjdk.java.net/~ysuenaga/JDK-8248362/webrev.00/ Migrate JVMTI frame operations to Thread-Local Handshakes from VM Operations. - VM_GetFrameCount - VM_GetFrameLocation They

Re: 8248362: JVMTI frame operations should use Thread-Local Handshake

2020-07-22 Thread David Holmes
On 22/07/2020 6:19 pm, Yasumasa Suenaga wrote: On 2020/07/22 16:57, David Holmes wrote: Hi Yasumasa, On 22/07/2020 5:39 pm, Yasumasa Suenaga wrote: Hi all, I'm working for fixing JDK-8248362, but I saw some errors on submit repo. Someone can share the details of mach5-one-ysuenaga-JDK-82483

Re: 8248362: JVMTI frame operations should use Thread-Local Handshake

2020-07-22 Thread Yasumasa Suenaga
On 2020/07/22 16:57, David Holmes wrote: Hi Yasumasa, On 22/07/2020 5:39 pm, Yasumasa Suenaga wrote: Hi all, I'm working for fixing JDK-8248362, but I saw some errors on submit repo. Someone can share the details of mach5-one-ysuenaga-JDK-8248362-20200722-0550-12850261 ? I wonder why build t

Re: 8248362: JVMTI frame operations should use Thread-Local Handshake

2020-07-22 Thread David Holmes
Hi Yasumasa, On 22/07/2020 5:39 pm, Yasumasa Suenaga wrote: Hi all, I'm working for fixing JDK-8248362, but I saw some errors on submit repo. Someone can share the details of mach5-one-ysuenaga-JDK-8248362-20200722-0550-12850261 ? I wonder why build task of linux-x64 was failed because I can

8248362: JVMTI frame operations should use Thread-Local Handshake

2020-07-22 Thread Yasumasa Suenaga
Hi all, I'm working for fixing JDK-8248362, but I saw some errors on submit repo. Someone can share the details of mach5-one-ysuenaga-JDK-8248362-20200722-0550-12850261 ? I wonder why build task of linux-x64 was failed because I can do it on my Fedora 32 box. Thanks, Yasumasa